[jira] [Commented] (HIVE-13884) Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-28 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353289#comment-15353289 ] Mohit Sabharwal commented on HIVE-13884: LGTM. A unit test would be great in

[jira] [Commented] (HIVE-13884) Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-28 Thread JIRA
[ https://issues.apache.org/jira/browse/HIVE-13884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353057#comment-15353057 ] Sergio Peña commented on HIVE-13884: [~mohitsabharwal] [~szehon] The patch is ready, could you let me

[jira] [Commented] (HIVE-13884) Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-27 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352278#comment-15352278 ] Hive QA commented on HIVE-13884: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-13884) Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-21 Thread JIRA
[ https://issues.apache.org/jira/browse/HIVE-13884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342416#comment-15342416 ] Sergio Peña commented on HIVE-13884: Thanks [~sershe]. [~mohitsabharwal] [~brocknoland] I run a test

[jira] [Commented] (HIVE-13884) Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-20 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15340603#comment-15340603 ] Sergey Shelukhin commented on HIVE-13884: - It would fall back to ORM in this case. Assuming there

[jira] [Commented] (HIVE-13884) Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-20 Thread JIRA
[ https://issues.apache.org/jira/browse/HIVE-13884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15340594#comment-15340594 ] Sergio Peña commented on HIVE-13884: If {{MetastoreDirectSql.getNumPartitionsViaSqlFilter()}} returns

[jira] [Commented] (HIVE-13884) Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-20 Thread JIRA
[ https://issues.apache.org/jira/browse/HIVE-13884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15340585#comment-15340585 ] Sergio Peña commented on HIVE-13884: Sometimes, the

[jira] [Commented] (HIVE-13884) Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-18 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338103#comment-15338103 ] Hive QA commented on HIVE-13884: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-13884) Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-17 Thread Szehon Ho (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15337115#comment-15337115 ] Szehon Ho commented on HIVE-13884: -- +1 from my side, pending one last comment on RB, and also the other

[jira] [Commented] (HIVE-13884) Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-17 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335558#comment-15335558 ] Hive QA commented on HIVE-13884: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-13884) Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-15 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15332774#comment-15332774 ] Hive QA commented on HIVE-13884: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-13884) Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-13 Thread Mohit Sabharwal (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15328764#comment-15328764 ] Mohit Sabharwal commented on HIVE-13884: Since we are moving the functionality from driver to HMS,

[jira] [Commented] (HIVE-13884) Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-13 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15328370#comment-15328370 ] Hive QA commented on HIVE-13884: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-13884) Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-13 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327997#comment-15327997 ] Hive QA commented on HIVE-13884: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-13884) Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-13 Thread JIRA
[ https://issues.apache.org/jira/browse/HIVE-13884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327768#comment-15327768 ] Sergio Peña commented on HIVE-13884: [~brocknoland] What type of query would you prefer to test? This

[jira] [Commented] (HIVE-13884) Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-09 Thread Brock Noland (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323525#comment-15323525 ] Brock Noland commented on HIVE-13884: - Can you test on a MySQL MS with a table with 100K partitions

[jira] [Commented] (HIVE-13884) Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-09 Thread Reuben Kuhnert (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15322686#comment-15322686 ] Reuben Kuhnert commented on HIVE-13884: --- This looks fine to me. A few minor nitpicks about code

[jira] [Commented] (HIVE-13884) Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-09 Thread JIRA
[ https://issues.apache.org/jira/browse/HIVE-13884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15322622#comment-15322622 ] Sergio Peña commented on HIVE-13884: [~szehon] Do you know about metastore? Could you help me review

[jira] [Commented] (HIVE-13884) Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-07 Thread JIRA
[ https://issues.apache.org/jira/browse/HIVE-13884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319592#comment-15319592 ] Sergio Peña commented on HIVE-13884: [~hagleitn] [~selinazh] I saw you added the partition limit on

[jira] [Commented] (HIVE-13884) Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-05 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15316165#comment-15316165 ] Hive QA commented on HIVE-13884: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-13884) Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-02 Thread JIRA
[ https://issues.apache.org/jira/browse/HIVE-13884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15312960#comment-15312960 ] Sergio Peña commented on HIVE-13884: Agree with [~sershe]. We should validate this limit in the

[jira] [Commented] (HIVE-13884) Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-05-31 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308319#comment-15308319 ] Sergey Shelukhin commented on HIVE-13884: - Should the limit rather be passed to metastore to avoid