[
https://issues.apache.org/jira/browse/HIVE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386593#comment-16386593
]
Kryvenko Igor commented on HIVE-18746:
--
[~vgarg] Thanks for review
> add_months should validate the
[
https://issues.apache.org/jira/browse/HIVE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386172#comment-16386172
]
Kryvenko Igor commented on HIVE-18746:
--
[~vgarg] Do i need to push it to master branch myself?
>
[
https://issues.apache.org/jira/browse/HIVE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385457#comment-16385457
]
Vineet Garg commented on HIVE-18746:
Look good to me. +1
> add_months should validate the date first
[
https://issues.apache.org/jira/browse/HIVE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384261#comment-16384261
]
Kryvenko Igor commented on HIVE-18746:
--
[~vgarg] Please, could you review?
> add_months should
[
https://issues.apache.org/jira/browse/HIVE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384181#comment-16384181
]
Hive QA commented on HIVE-18746:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384142#comment-16384142
]
Hive QA commented on HIVE-18746:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381400#comment-16381400
]
Hive QA commented on HIVE-18746:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381379#comment-16381379
]
Hive QA commented on HIVE-18746:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380887#comment-16380887
]
Hive QA commented on HIVE-18746:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380830#comment-16380830
]
Hive QA commented on HIVE-18746:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379576#comment-16379576
]
Hive QA commented on HIVE-18746:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379531#comment-16379531
]
Hive QA commented on HIVE-18746:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376267#comment-16376267
]
Hive QA commented on HIVE-18746:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376247#comment-16376247
]
Hive QA commented on HIVE-18746:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371841#comment-16371841
]
Hive QA commented on HIVE-18746:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371880#comment-16371880
]
Kryvenko Igor commented on HIVE-18746:
--
[~szehon], please take a look at second patch. Fix failed
[
https://issues.apache.org/jira/browse/HIVE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371737#comment-16371737
]
Hive QA commented on HIVE-18746:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371541#comment-16371541
]
Hive QA commented on HIVE-18746:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370730#comment-16370730
]
Szehon Ho commented on HIVE-18746:
--
Patch looks good but the related test seems to be failing, can you
[
https://issues.apache.org/jira/browse/HIVE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370624#comment-16370624
]
Kryvenko Igor commented on HIVE-18746:
--
[~lskuff], [~jxiang], [~szehon], guys please take a look at
[
https://issues.apache.org/jira/browse/HIVE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370609#comment-16370609
]
Hive QA commented on HIVE-18746:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370571#comment-16370571
]
Hive QA commented on HIVE-18746:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
22 matches
Mail list logo
