[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16665069#comment-16665069
]
Mass Dosage commented on HIVE-18767:
Ah sorry, yes, I got confused (I've been away on holiday!).
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16665066#comment-16665066
]
Peter Vary commented on HIVE-18767:
---
[~massdos...@gmail.com]: It is in
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16665056#comment-16665056
]
Mass Dosage commented on HIVE-18767:
So [~pvary] should it show up in
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661845#comment-16661845
]
Peter Vary commented on HIVE-18767:
---
So it is pushed to branch-3 too.
After fixing the Fix versions we
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661841#comment-16661841
]
Peter Vary commented on HIVE-18767:
---
[~daijy]: I assume you meant 2.3.4, and 3.1.1 :). If you take a
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661288#comment-16661288
]
Daniel Dai commented on HIVE-18767:
---
Unlink from 3.1.1/2.4.4 as they are about to release.
> Some
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657757#comment-16657757
]
Hive QA commented on HIVE-18767:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657741#comment-16657741
]
Hive QA commented on HIVE-18767:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657088#comment-16657088
]
Peter Vary commented on HIVE-18767:
---
[~massdos...@gmail.com]: We waited enough. Just show me the last
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656736#comment-16656736
]
Mass Dosage commented on HIVE-18767:
[~pvary] Excellent, thank you! Should I start on the last one
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656718#comment-16656718
]
Peter Vary commented on HIVE-18767:
---
[~massdos...@gmail.com]: Committed to 3.1! One more to go :D
>
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656698#comment-16656698
]
Mass Dosage commented on HIVE-18767:
[~dvoros] as an aside you should probably add some tests where
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656696#comment-16656696
]
Daniel Voros commented on HIVE-18767:
-
No worries, I didn't know that it's a different path, that's
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656692#comment-16656692
]
Peter Vary commented on HIVE-18767:
---
[~dvoros]: Hmmm Sorry. I should have checked myself :(.
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656673#comment-16656673
]
Daniel Voros commented on HIVE-18767:
-
[~pvary] HIVE-20191 only changed how the ptest runner figures
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656611#comment-16656611
]
Peter Vary commented on HIVE-18767:
---
[~dvoros]: What do you think should be a good patch name instead
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656450#comment-16656450
]
Mass Dosage commented on HIVE-18767:
[~pvary] that seems to have behaved the same way even with the
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656249#comment-16656249
]
Hive QA commented on HIVE-18767:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656206#comment-16656206
]
Hive QA commented on HIVE-18767:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654854#comment-16654854
]
Peter Vary commented on HIVE-18767:
---
[~massdos...@gmail.com]: I think HIVE-20191 changed the patch file
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653360#comment-16653360
]
Mass Dosage commented on HIVE-18767:
[~pvary] any idea what is going on above? The first error
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652537#comment-16652537
]
Hive QA commented on HIVE-18767:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652425#comment-16652425
]
Hive QA commented on HIVE-18767:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623289#comment-16623289
]
Mass Dosage commented on HIVE-18767:
OK, so the first complain above about the patch not applying
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622236#comment-16622236
]
Hive QA commented on HIVE-18767:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622137#comment-16622137
]
Hive QA commented on HIVE-18767:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619538#comment-16619538
]
Peter Vary commented on HIVE-18767:
---
[~massdos...@gmail.com]: This sounds like a never ending story :(
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617397#comment-16617397
]
Mass Dosage commented on HIVE-18767:
[~pvary] the saga continues ;) Looks like the above error has
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616307#comment-16616307
]
Hive QA commented on HIVE-18767:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614593#comment-16614593
]
Mass Dosage commented on HIVE-18767:
OK, so the above tests look like they were caused by a massive
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611670#comment-16611670
]
Hive QA commented on HIVE-18767:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611616#comment-16611616
]
Hive QA commented on HIVE-18767:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610529#comment-16610529
]
Peter Vary commented on HIVE-18767:
---
[~massdos...@gmail.com]: Commited the change to branch-2
Thanks!
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608406#comment-16608406
]
Peter Vary commented on HIVE-18767:
---
+1 for HIVE-18767.2-branch-2.patch
> Some alterPartitions
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604380#comment-16604380
]
Mass Dosage commented on HIVE-18767:
[~pvary] can you please confirm whether those are the usual
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603392#comment-16603392
]
Hive QA commented on HIVE-18767:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603124#comment-16603124
]
Mass Dosage commented on HIVE-18767:
Added HIVE-18767.2-branch-2.patch to apply changes to "branch-2"
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603117#comment-16603117
]
Mass Dosage commented on HIVE-18767:
OK, so it makes sense that the above patch failed since the code
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598373#comment-16598373
]
Hive QA commented on HIVE-18767:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598104#comment-16598104
]
Mass Dosage commented on HIVE-18767:
[~pvary] I put the ticket back into "in progress", added the
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595841#comment-16595841
]
Mass Dosage commented on HIVE-18767:
No problem, OK, here we go one by one with the first one up
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594712#comment-16594712
]
Peter Vary commented on HIVE-18767:
---
[~massdos...@gmail.com]: Yes, I think that should work. Resubmit
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594412#comment-16594412
]
Mass Dosage commented on HIVE-18767:
Thanks [~pvary] - changes in master look good. For doing the
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591295#comment-16591295
]
Peter Vary commented on HIVE-18767:
---
Pushed the fix to master - for that we had green runs.
For the
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590786#comment-16590786
]
Hive QA commented on HIVE-18767:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590782#comment-16590782
]
Hive QA commented on HIVE-18767:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590740#comment-16590740
]
Hive QA commented on HIVE-18767:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590094#comment-16590094
]
Mass Dosage commented on HIVE-18767:
Woops, sorry I should have spotted that. I have just added
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590083#comment-16590083
]
Peter Vary commented on HIVE-18767:
---
Thanks [~massdos...@gmail.com]!
After just a cursory check
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590075#comment-16590075
]
Mass Dosage commented on HIVE-18767:
[~pvary] I have added patches as follows:
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577990#comment-16577990
]
Peter Vary commented on HIVE-18767:
---
[~massdos...@gmail.com]: I think for Hive, the most important is
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577969#comment-16577969
]
Mass Dosage commented on HIVE-18767:
[~pvary] OK, so do you want me to submit two new patches for a
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563324#comment-16563324
]
Peter Vary commented on HIVE-18767:
---
[~massdos...@gmail.com]: Sorry for the delay. The patch is only in
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16560001#comment-16560001
]
Hive QA commented on HIVE-18767:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559854#comment-16559854
]
Mass Dosage commented on HIVE-18767:
[~vgarg] let me know if you need me to do anything to get this
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525435#comment-16525435
]
Vineet Garg commented on HIVE-18767:
Deferring this to 3.1.0 since the branch for 3.0.0 has been cut
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483674#comment-16483674
]
Peter Vary commented on HIVE-18767:
---
[~massdos...@gmail.com]: Will do. Thanks!
> Some alterPartitions
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482307#comment-16482307
]
Mass Dosage commented on HIVE-18767:
[~pvary] I saw on the mailing list there was basically a "merge"
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468703#comment-16468703
]
Hive QA commented on HIVE-18767:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468653#comment-16468653
]
Hive QA commented on HIVE-18767:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467160#comment-16467160
]
Mass Dosage commented on HIVE-18767:
[~pvary] I have recreated the same patch for master. I had some
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460673#comment-16460673
]
Peter Vary commented on HIVE-18767:
---
[~massdos...@gmail.com]: That's OK. Sadly we have some flaky tests.
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459569#comment-16459569
]
Mass Dosage commented on HIVE-18767:
[~pvary] I have run all the unit tests locally after doing a "mvn
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457469#comment-16457469
]
Hive QA commented on HIVE-18767:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456235#comment-16456235
]
Mass Dosage commented on HIVE-18767:
OK, I have renamed patch to "HIVE-18767-branch-2.3.patch". The
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456213#comment-16456213
]
Mass Dosage commented on HIVE-18767:
Ah, OK, I missed the bit about including the branch name in the
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456211#comment-16456211
]
Peter Vary commented on HIVE-18767:
---
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456108#comment-16456108
]
Adrian Woodhead commented on HIVE-18767:
[~pvary] thanks for kicking that off, it ran but the
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454274#comment-16454274
]
Hive QA commented on HIVE-18767:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453711#comment-16453711
]
Peter Vary commented on HIVE-18767:
---
Tried to start the pre-commit again
> Some alterPartitions
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453706#comment-16453706
]
Mass Dosage commented on HIVE-18767:
[~pvary] - looks like the tests aren't running. Is there anything
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428417#comment-16428417
]
Peter Vary commented on HIVE-18767:
---
If a contributor notices this, he can resubmit the same patch with
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428206#comment-16428206
]
Elliot West commented on HIVE-18767:
I notice that the tests have not run on this patch. Does the
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418751#comment-16418751
]
Mass Dosage commented on HIVE-18767:
Yes, the behaviour of the method is definitely counter-intuitive
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418699#comment-16418699
]
Peter Vary commented on HIVE-18767:
---
[~massdos...@gmail.com]: LGTM pending tests. If possible would you
[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417475#comment-16417475
]
Peter Vary commented on HIVE-18767:
---
[~massdos...@gmail.com]: Yeah, it should be assigned to you.
76 matches
Mail list logo