[jira] [Commented] (HIVE-20607) TxnHandler should use PreparedStatement to execute direct SQL queries.

2022-06-17 Thread GuangMing Lu (Jira)
[ https://issues.apache.org/jira/browse/HIVE-20607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1745#comment-1745 ] GuangMing Lu commented on HIVE-20607: - Hi [~sankarh]  [~kgyrtkirk],  Do you know Hive's EOL schedule?

[jira] [Commented] (HIVE-20607) TxnHandler should use PreparedStatement to execute direct SQL queries.

2022-06-16 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/HIVE-20607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555030#comment-17555030 ] Zoltan Haindrich commented on HIVE-20607: - if it would have been on 3.1 - then it would have been

[jira] [Commented] (HIVE-20607) TxnHandler should use PreparedStatement to execute direct SQL queries.

2022-06-16 Thread Colm O hEigeartaigh (Jira)
[ https://issues.apache.org/jira/browse/HIVE-20607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555000#comment-17555000 ] Colm O hEigeartaigh commented on HIVE-20607: Thanks [~kgyrtkirk] , but as it's a security

[jira] [Commented] (HIVE-20607) TxnHandler should use PreparedStatement to execute direct SQL queries.

2022-06-16 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/HIVE-20607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554996#comment-17554996 ] Zoltan Haindrich commented on HIVE-20607: - This patch is on branch-3 via [this

[jira] [Commented] (HIVE-20607) TxnHandler should use PreparedStatement to execute direct SQL queries.

2022-06-15 Thread Colm O hEigeartaigh (Jira)
[ https://issues.apache.org/jira/browse/HIVE-20607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554433#comment-17554433 ] Colm O hEigeartaigh commented on HIVE-20607: Was this fix ever backported to branch-3? I

[jira] [Commented] (HIVE-20607) TxnHandler should use PreparedStatement to execute direct SQL queries.

2018-10-24 Thread Sankar Hariappan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16663240#comment-16663240 ] Sankar Hariappan commented on HIVE-20607: - Test failures are irrelevant to the patch and is

[jira] [Commented] (HIVE-20607) TxnHandler should use PreparedStatement to execute direct SQL queries.

2018-10-24 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662935#comment-16662935 ] Hive QA commented on HIVE-20607: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-20607) TxnHandler should use PreparedStatement to execute direct SQL queries.

2018-10-24 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662858#comment-16662858 ] Hive QA commented on HIVE-20607: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-20607) TxnHandler should use PreparedStatement to execute direct SQL queries.

2018-10-23 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661476#comment-16661476 ] Daniel Dai commented on HIVE-20607: --- [~sankarh], can you commit it to branch-3 as well? > TxnHandler

[jira] [Commented] (HIVE-20607) TxnHandler should use PreparedStatement to execute direct SQL queries.

2018-09-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628701#comment-16628701 ] ASF GitHub Bot commented on HIVE-20607: --- Github user sankarh closed the pull request at:

[jira] [Commented] (HIVE-20607) TxnHandler should use PreparedStatement to execute direct SQL queries.

2018-09-25 Thread Sankar Hariappan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627775#comment-16627775 ] Sankar Hariappan commented on HIVE-20607: - 01.patch committed to master. Thanks [~daijy]! >

[jira] [Commented] (HIVE-20607) TxnHandler should use PreparedStatement to execute direct SQL queries.

2018-09-25 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627660#comment-16627660 ] Daniel Dai commented on HIVE-20607: --- +1, LGTM. > TxnHandler should use PreparedStatement to execute

[jira] [Commented] (HIVE-20607) TxnHandler should use PreparedStatement to execute direct SQL queries.

2018-09-25 Thread Sankar Hariappan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627524#comment-16627524 ] Sankar Hariappan commented on HIVE-20607: - [~daijy], Can you please take a look at the patch? >

[jira] [Commented] (HIVE-20607) TxnHandler should use PreparedStatement to execute direct SQL queries.

2018-09-23 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625373#comment-16625373 ] Hive QA commented on HIVE-20607: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-20607) TxnHandler should use PreparedStatement to execute direct SQL queries.

2018-09-23 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625358#comment-16625358 ] Hive QA commented on HIVE-20607: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-20607) TxnHandler should use PreparedStatement to execute direct SQL queries.

2018-09-23 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625043#comment-16625043 ] Hive QA commented on HIVE-20607: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-20607) TxnHandler should use PreparedStatement to execute direct SQL queries.

2018-09-23 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625029#comment-16625029 ] Hive QA commented on HIVE-20607: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-20607) TxnHandler should use PreparedStatement to execute direct SQL queries.

2018-09-22 Thread Sankar Hariappan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624565#comment-16624565 ] Sankar Hariappan commented on HIVE-20607: - [~daijy], [~ekoifman], [~sershe],  Can you please

[jira] [Commented] (HIVE-20607) TxnHandler should use PreparedStatement to execute direct SQL queries.

2018-09-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624564#comment-16624564 ] ASF GitHub Bot commented on HIVE-20607: --- GitHub user sankarh opened a pull request:

[jira] [Commented] (HIVE-20607) TxnHandler should use PreparedStatement to execute direct SQL queries.

2018-09-21 Thread Sankar Hariappan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623183#comment-16623183 ] Sankar Hariappan commented on HIVE-20607: - [~ekoifman], [~sershe] Yes, this patch is for

[jira] [Commented] (HIVE-20607) TxnHandler should use PreparedStatement to execute direct SQL queries.

2018-09-20 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622534#comment-16622534 ] Sergey Shelukhin commented on HIVE-20607: - I think it does the sanitizing. At least, some

[jira] [Commented] (HIVE-20607) TxnHandler should use PreparedStatement to execute direct SQL queries.

2018-09-20 Thread Eugene Koifman (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622511#comment-16622511 ] Eugene Koifman commented on HIVE-20607: --- How does a PreparedStatement solve this? If you are doing

[jira] [Commented] (HIVE-20607) TxnHandler should use PreparedStatement to execute direct SQL queries.

2018-09-20 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622504#comment-16622504 ] Sergey Shelukhin commented on HIVE-20607: - [~ekoifman] SQL injection via APIs. [~sankarh] is it

[jira] [Commented] (HIVE-20607) TxnHandler should use PreparedStatement to execute direct SQL queries.

2018-09-20 Thread Eugene Koifman (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622328#comment-16622328 ] Eugene Koifman commented on HIVE-20607: --- Most of the statements are executed once per DB txn. What