[jira] [Commented] (HIVE-22640) Decimal64ColumnVector: ClassCastException when partition column type is Decimal
[
https://issues.apache.org/jira/browse/HIVE-22640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995437#comment-16995437
]
Hive QA commented on HIVE-22640:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12988710/HIVE-22640.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 17772 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19911/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19911/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19911/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12988710 - PreCommit-HIVE-Build
> Decimal64ColumnVector: ClassCastException when partition column type is
> Decimal
> ---
>
> Key: HIVE-22640
> URL: https://issues.apache.org/jira/browse/HIVE-22640
> Project: Hive
> Issue Type: Bug
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22640.1.patch
>
>
> Problem statement:
> {code}
> CREATE EXTERNAL TABLE output (id DECIMAL(4,0), foo VARCHAR(10))
> PARTITIONED BY (nr_bank *decimal*(4,0))
> STORED AS ORC TBLPROPERTIES ('orc.compress'='ZLIB')
> insert into output PARTITION (nr_bank=88) values (1,'test');
> insert into output PARTITION (nr_bank=8801) values (1,'8801');
> select count(*), nr_bank from sdlint.output group by nr_bank;
> {code}
> The above query fails with:
> {code}
> Caused by: java.lang.ClassCastException:
> org.apache.hadoop.hive.ql.exec.vector.DecimalColumnVector cannot be cast to
> org.apache.hadoop.hive.ql.exec.vector.LongColumnVector
> at
> org.apache.hadoop.hive.ql.exec.vector.expressions.FuncLongToDecimal.evaluate(FuncLongToDecimal.java:58)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22557) Break up DDLSemanticAnalyzer - extract Table constraints analyzers
[ https://issues.apache.org/jira/browse/HIVE-22557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995436#comment-16995436 ] Miklos Gergely commented on HIVE-22557: --- Fixed the type, thanks! > Break up DDLSemanticAnalyzer - extract Table constraints analyzers > -- > > Key: HIVE-22557 > URL: https://issues.apache.org/jira/browse/HIVE-22557 > Project: Hive > Issue Type: Sub-task >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Labels: pull-request-available, refactor-ddl > Attachments: HIVE-22557.01.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > > DDLSemanticAnalyzer is a huge class, more than 4000 lines long. The goal is > to refactor it in order to have everything cut into more handleable classes > under the package org.apache.hadoop.hive.ql.exec.ddl: > * have a separate class for each analyzers > * have a package for each operation, containing an analyzer, a description, > and an operation, so the amount of classes under a package is more manageable > Step #10: extract the table constraints related analyzers from > DDLSemanticAnalyzer, and move them under the new package. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-22557) Break up DDLSemanticAnalyzer - extract Table constraints analyzers
[ https://issues.apache.org/jira/browse/HIVE-22557?focusedWorklogId=359248=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-359248 ] ASF GitHub Bot logged work on HIVE-22557: - Author: ASF GitHub Bot Created on: 13/Dec/19 07:53 Start Date: 13/Dec/19 07:53 Worklog Time Spent: 10m Work Description: miklosgergely commented on pull request #859: HIVE-22557 Break up DDLSemanticAnalyzer - extract Table constraints analyzers URL: https://github.com/apache/hive/pull/859 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 359248) Time Spent: 0.5h (was: 20m) > Break up DDLSemanticAnalyzer - extract Table constraints analyzers > -- > > Key: HIVE-22557 > URL: https://issues.apache.org/jira/browse/HIVE-22557 > Project: Hive > Issue Type: Sub-task >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Labels: pull-request-available, refactor-ddl > Attachments: HIVE-22557.01.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > > DDLSemanticAnalyzer is a huge class, more than 4000 lines long. The goal is > to refactor it in order to have everything cut into more handleable classes > under the package org.apache.hadoop.hive.ql.exec.ddl: > * have a separate class for each analyzers > * have a package for each operation, containing an analyzer, a description, > and an operation, so the amount of classes under a package is more manageable > Step #10: extract the table constraints related analyzers from > DDLSemanticAnalyzer, and move them under the new package. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22557) Break up DDLSemanticAnalyzer - extract Table constraints analyzers
[ https://issues.apache.org/jira/browse/HIVE-22557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Miklos Gergely updated HIVE-22557: -- Resolution: Fixed Status: Resolved (was: Patch Available) > Break up DDLSemanticAnalyzer - extract Table constraints analyzers > -- > > Key: HIVE-22557 > URL: https://issues.apache.org/jira/browse/HIVE-22557 > Project: Hive > Issue Type: Sub-task >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Labels: pull-request-available, refactor-ddl > Attachments: HIVE-22557.01.patch > > Time Spent: 20m > Remaining Estimate: 0h > > DDLSemanticAnalyzer is a huge class, more than 4000 lines long. The goal is > to refactor it in order to have everything cut into more handleable classes > under the package org.apache.hadoop.hive.ql.exec.ddl: > * have a separate class for each analyzers > * have a package for each operation, containing an analyzer, a description, > and an operation, so the amount of classes under a package is more manageable > Step #10: extract the table constraints related analyzers from > DDLSemanticAnalyzer, and move them under the new package. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22632) Improve estimateRowSizeFromSchema
[ https://issues.apache.org/jira/browse/HIVE-22632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995431#comment-16995431 ] Zoltan Haindrich commented on HIVE-22632: - +1 > Improve estimateRowSizeFromSchema > - > > Key: HIVE-22632 > URL: https://issues.apache.org/jira/browse/HIVE-22632 > Project: Hive > Issue Type: Improvement > Components: Statistics >Reporter: Vineet Garg >Assignee: Vineet Garg >Priority: Major > Attachments: HIVE-22632.1.patch > > > estimateRowSizeFromSchema un-necessarily iterate and do look-up. This could > be avoided. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22638) Fix insert statement issue with return path
[ https://issues.apache.org/jira/browse/HIVE-22638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HIVE-22638: -- Labels: pull-request-available (was: ) > Fix insert statement issue with return path > --- > > Key: HIVE-22638 > URL: https://issues.apache.org/jira/browse/HIVE-22638 > Project: Hive > Issue Type: Sub-task > Components: Hive >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22638.01.patch > > > Insert statements were not handled properly with return path. It was revealed > during examining why TestUpgradeTool is not working with return path. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-22638) Fix insert statement issue with return path
[ https://issues.apache.org/jira/browse/HIVE-22638?focusedWorklogId=359240=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-359240 ] ASF GitHub Bot logged work on HIVE-22638: - Author: ASF GitHub Bot Created on: 13/Dec/19 07:40 Start Date: 13/Dec/19 07:40 Worklog Time Spent: 10m Work Description: miklosgergely commented on pull request #868: HIVE-22638 Fix insert statement issue with return path URL: https://github.com/apache/hive/pull/868 Insert statements were not handled properly with return path. It was revealed during examining why TestUpgradeTool is not working with return path. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 359240) Remaining Estimate: 0h Time Spent: 10m > Fix insert statement issue with return path > --- > > Key: HIVE-22638 > URL: https://issues.apache.org/jira/browse/HIVE-22638 > Project: Hive > Issue Type: Sub-task > Components: Hive >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22638.01.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Insert statements were not handled properly with return path. It was revealed > during examining why TestUpgradeTool is not working with return path. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22638) Fix insert statement issue with return path
[ https://issues.apache.org/jira/browse/HIVE-22638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Miklos Gergely updated HIVE-22638: -- Attachment: HIVE-22638.01.patch > Fix insert statement issue with return path > --- > > Key: HIVE-22638 > URL: https://issues.apache.org/jira/browse/HIVE-22638 > Project: Hive > Issue Type: Sub-task > Components: Hive >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Attachments: HIVE-22638.01.patch > > > Insert statements were not handled properly with return path. It was revealed > during examining why TestUpgradeTool is not working with return path. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22638) Fix insert statement issue with return path
[ https://issues.apache.org/jira/browse/HIVE-22638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Miklos Gergely updated HIVE-22638: -- Attachment: (was: HIVE-22638.01.patch) > Fix insert statement issue with return path > --- > > Key: HIVE-22638 > URL: https://issues.apache.org/jira/browse/HIVE-22638 > Project: Hive > Issue Type: Sub-task > Components: Hive >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > > Insert statements were not handled properly with return path. It was revealed > during examining why TestUpgradeTool is not working with return path. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HIVE-22643) Unable to execute method public java.lang.String udf.IpCityName.evaluate(java.lang.String) on object udf.IpCityName@2edadd75 of class udf.IpCityName with arguments {113
[
https://issues.apache.org/jira/browse/HIVE-22643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
FengWu reassigned HIVE-22643:
-
Assignee: zhangbutao (was: FengWu)
> Unable to execute method public java.lang.String
> udf.IpCityName.evaluate(java.lang.String) on object udf.IpCityName@2edadd75
> of class udf.IpCityName with arguments {113.***..151:java.lang.String} of
> size 1
> --
>
> Key: HIVE-22643
> URL: https://issues.apache.org/jira/browse/HIVE-22643
> Project: Hive
> Issue Type: Task
> Components: UDF
>Affects Versions: 2.1.1
>Reporter: FengWu
>Assignee: zhangbutao
>Priority: Major
> Attachments: IpProvinceCode.java
>
>
> hello,i want to use udf to Resolve IP address，a local file is need.i want to
> create a new static object,but its error when run the sql.
> if you cant understand,please check the javafilethanks
>
> //我想用udf函数来解析ip地址，需要引用一个本体文件来创建一个实例对象City，但是定义成全局变量会出错，请问该怎么写。
> create temporary function IpCityName as 'udf.IpCityName' 可以成功，但是运行时候会报错。
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (HIVE-22643) Unable to execute method public java.lang.String udf.IpCityName.evaluate(java.lang.String) on object udf.IpCityName@2edadd75 of class udf.IpCityName with arguments {113
[
https://issues.apache.org/jira/browse/HIVE-22643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
FengWu reassigned HIVE-22643:
-
Assignee: FengWu
> Unable to execute method public java.lang.String
> udf.IpCityName.evaluate(java.lang.String) on object udf.IpCityName@2edadd75
> of class udf.IpCityName with arguments {113.***..151:java.lang.String} of
> size 1
> --
>
> Key: HIVE-22643
> URL: https://issues.apache.org/jira/browse/HIVE-22643
> Project: Hive
> Issue Type: Task
> Components: UDF
>Affects Versions: 2.1.1
>Reporter: FengWu
>Assignee: FengWu
>Priority: Major
> Attachments: IpProvinceCode.java
>
>
> hello,i want to use udf to Resolve IP address，a local file is need.i want to
> create a new static object,but its error when run the sql.
> if you cant understand,please check the javafilethanks
>
> //我想用udf函数来解析ip地址，需要引用一个本体文件来创建一个实例对象City，但是定义成全局变量会出错，请问该怎么写。
> create temporary function IpCityName as 'udf.IpCityName' 可以成功，但是运行时候会报错。
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22599) Query results cache: 733 permissions check is not necessary
[
https://issues.apache.org/jira/browse/HIVE-22599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995423#comment-16995423
]
Gopal Vijayaraghavan commented on HIVE-22599:
-
LGTM - +1
> Query results cache: 733 permissions check is not necessary
> ---
>
> Key: HIVE-22599
> URL: https://issues.apache.org/jira/browse/HIVE-22599
> Project: Hive
> Issue Type: Bug
>Reporter: Jason Dere
>Assignee: Jason Dere
>Priority: Major
> Attachments: HIVE-22599.1.patch
>
>
> The query results cache initialization makes a call to
> Utilties.ensurePathIsWritable(), which checks the results cache directory for
> 733 permissions (default cache dir is
> {{/tmp/hive/_resultscache_).}}
> The 733 permissions (at least the 033 part) are not actually necessary - we
> actually don't really want the results cache directory to be world-writable,
> and the subdirectories we create within this one are actually done with 700
> perms. So I think the call to Utilties.ensurePathIsWritable() can be removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-22536) Improve return path enabling/disabling
[ https://issues.apache.org/jira/browse/HIVE-22536?focusedWorklogId=359235=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-359235 ] ASF GitHub Bot logged work on HIVE-22536: - Author: ASF GitHub Bot Created on: 13/Dec/19 07:10 Start Date: 13/Dec/19 07:10 Worklog Time Spent: 10m Work Description: jcamachor commented on pull request #866: HIVE-22536 Improve return path enabling/disabling URL: https://github.com/apache/hive/pull/866#discussion_r357510056 ## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java ## @@ -3025,8 +3025,7 @@ private RelNode genTableLogicalPlan(String tableAlias, QB qb) throws SemanticExc db, tabNameToTabObject, partitionCache, colStatsCache, noColsMissingStats); final TableScan scan = new HiveTableScan(cluster, cluster.traitSetOf(HiveRelNode.CONVENTION), optTable, null == tableAlias ? tabMetaData.getTableName() : tableAlias, -getAliasId(tableAlias, qb), HiveConf.getBoolVar(conf, -HiveConf.ConfVars.HIVE_CBO_RETPATH_HIVEOP), qb.isInsideView() +getAliasId(tableAlias, qb), ReturnPathManager.shouldUse(), qb.isInsideView() Review comment: It may not be necessary to pass that boolean when we create HiveTableScan operators anymore, since there was some follow-up work that included the alias with the table name in the digest. If that is the case, we can remove it. Otherwise, it seems it is OK that we pass true even if finally we end up bailing out from return path when we check the operators/expressions in the plan. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 359235) Time Spent: 1h (was: 50m) > Improve return path enabling/disabling > -- > > Key: HIVE-22536 > URL: https://issues.apache.org/jira/browse/HIVE-22536 > Project: Hive > Issue Type: Sub-task > Components: Hive >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22536.01.patch, HIVE-22536.02.patch, > HIVE-22536.03.patch > > Time Spent: 1h > Remaining Estimate: 0h > > Instead of having a boolean for hive.cbo.returnpath.hiveop it should be > on/off/supported. In case of "supported" it should be used for a subset of > commands which are already verified to be able to work with return path. This > is a temporary solution for the time while we are developing return path, > before making it the only way to handle commands. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-22536) Improve return path enabling/disabling
[
https://issues.apache.org/jira/browse/HIVE-22536?focusedWorklogId=359232=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-359232
]
ASF GitHub Bot logged work on HIVE-22536:
-
Author: ASF GitHub Bot
Created on: 13/Dec/19 07:08
Start Date: 13/Dec/19 07:08
Worklog Time Spent: 10m
Work Description: jcamachor commented on pull request #866: HIVE-22536
Improve return path enabling/disabling
URL: https://github.com/apache/hive/pull/866#discussion_r357501690
##
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/ReturnPathManager.java
##
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.parse;
+
+import org.apache.hadoop.hive.conf.HiveConf;
+
+/**
+ * This is a temporary class for the time while we are in transition to use
return path only.
+ * It's purpose is to decide if Hive should use return path.
+ */
+public final class ReturnPathManager {
+ private ReturnPathManager() {
+throw new UnsupportedOperationException("ReturnPathManager should not be
instantiated");
+ }
+
+ private static ThreadLocal useReturnPath = new ThreadLocal<>();
+
+ public static void init(HiveConf conf, ASTNode root) {
+boolean use = shouldUseReturnPath(conf, root);
+useReturnPath.set(use);
+ }
+
+ public static boolean shouldUse() {
+return useReturnPath.get();
+ }
+
+ private static boolean shouldUseReturnPath(HiveConf conf, ASTNode root) {
Review comment:
I believe it is better to make this decision in terms of `RelNode` plan
rather than `ASTNode` since the optimizer may introduce some arbitrary complex
operators and expressions. You can implement a custom `RelVisitorImpl` that
traverses the tree and returns whether any operator/expression is supported or
not. The visitor would be executed before the block that applies the rules to
aid in translation from Calcite tree to Hive tree.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 359232)
Time Spent: 50m (was: 40m)
> Improve return path enabling/disabling
> --
>
> Key: HIVE-22536
> URL: https://issues.apache.org/jira/browse/HIVE-22536
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22536.01.patch, HIVE-22536.02.patch,
> HIVE-22536.03.patch
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Instead of having a boolean for hive.cbo.returnpath.hiveop it should be
> on/off/supported. In case of "supported" it should be used for a subset of
> commands which are already verified to be able to work with return path. This
> is a temporary solution for the time while we are developing return path,
> before making it the only way to handle commands.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22640) Decimal64ColumnVector: ClassCastException when partition column type is Decimal
[
https://issues.apache.org/jira/browse/HIVE-22640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995412#comment-16995412
]
Hive QA commented on HIVE-22640:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
43s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
29s{color} | {color:blue} ql in master has 1531 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
6s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
41s{color} | {color:red} ql: The patch generated 1 new + 39 unchanged - 0 fixed
= 40 total (was 39) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
9s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
16s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 28m 6s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19911/dev-support/hive-personality.sh
|
| git revision | master / 78a4dd7 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-19911/yetus/diff-checkstyle-ql.txt
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-19911/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Decimal64ColumnVector: ClassCastException when partition column type is
> Decimal
> ---
>
> Key: HIVE-22640
> URL: https://issues.apache.org/jira/browse/HIVE-22640
> Project: Hive
> Issue Type: Bug
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22640.1.patch
>
>
> Problem statement:
> {code}
> CREATE EXTERNAL TABLE output (id DECIMAL(4,0), foo VARCHAR(10))
> PARTITIONED BY (nr_bank *decimal*(4,0))
> STORED AS ORC TBLPROPERTIES ('orc.compress'='ZLIB')
> insert into output PARTITION (nr_bank=88) values (1,'test');
> insert into output PARTITION (nr_bank=8801) values (1,'8801');
> select count(*), nr_bank from sdlint.output group by nr_bank;
> {code}
> The above query fails with:
> {code}
> Caused by: java.lang.ClassCastException:
> org.apache.hadoop.hive.ql.exec.vector.DecimalColumnVector cannot be cast to
> org.apache.hadoop.hive.ql.exec.vector.LongColumnVector
> at
> org.apache.hadoop.hive.ql.exec.vector.expressions.FuncLongToDecimal.evaluate(FuncLongToDecimal.java:58)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-22536) Improve return path enabling/disabling
[
https://issues.apache.org/jira/browse/HIVE-22536?focusedWorklogId=359230=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-359230
]
ASF GitHub Bot logged work on HIVE-22536:
-
Author: ASF GitHub Bot
Created on: 13/Dec/19 06:59
Start Date: 13/Dec/19 06:59
Worklog Time Spent: 10m
Work Description: jcamachor commented on pull request #866: HIVE-22536
Improve return path enabling/disabling
URL: https://github.com/apache/hive/pull/866#discussion_r357501690
##
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/ReturnPathManager.java
##
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.parse;
+
+import org.apache.hadoop.hive.conf.HiveConf;
+
+/**
+ * This is a temporary class for the time while we are in transition to use
return path only.
+ * It's purpose is to decide if Hive should use return path.
+ */
+public final class ReturnPathManager {
+ private ReturnPathManager() {
+throw new UnsupportedOperationException("ReturnPathManager should not be
instantiated");
+ }
+
+ private static ThreadLocal useReturnPath = new ThreadLocal<>();
+
+ public static void init(HiveConf conf, ASTNode root) {
+boolean use = shouldUseReturnPath(conf, root);
+useReturnPath.set(use);
+ }
+
+ public static boolean shouldUse() {
+return useReturnPath.get();
+ }
+
+ private static boolean shouldUseReturnPath(HiveConf conf, ASTNode root) {
Review comment:
I believe it is better to make this decision in terms of `RelNode` plan
rather than `ASTNode` since the optimizer may introduce some arbitrary complex
operators and expressions. You can implement a custom `RelVisitorImpl` that
traverses the tree and returns whether any operator/expression is supported or
not. The visitor would be executed before the block that applies the rules to
aid in translation from Calcite tree to Hive tree. I also think we can
potentially revisit the decision on checking that return path boolean when we
create the HiveTableScan operator.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 359230)
Time Spent: 0.5h (was: 20m)
> Improve return path enabling/disabling
> --
>
> Key: HIVE-22536
> URL: https://issues.apache.org/jira/browse/HIVE-22536
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22536.01.patch, HIVE-22536.02.patch,
> HIVE-22536.03.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Instead of having a boolean for hive.cbo.returnpath.hiveop it should be
> on/off/supported. In case of "supported" it should be used for a subset of
> commands which are already verified to be able to work with return path. This
> is a temporary solution for the time while we are developing return path,
> before making it the only way to handle commands.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-22536) Improve return path enabling/disabling
[
https://issues.apache.org/jira/browse/HIVE-22536?focusedWorklogId=359229=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-359229
]
ASF GitHub Bot logged work on HIVE-22536:
-
Author: ASF GitHub Bot
Created on: 13/Dec/19 06:59
Start Date: 13/Dec/19 06:59
Worklog Time Spent: 10m
Work Description: jcamachor commented on pull request #866: HIVE-22536
Improve return path enabling/disabling
URL: https://github.com/apache/hive/pull/866#discussion_r357499269
##
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##
@@ -1663,7 +1663,8 @@ private static void
populateLlapDaemonVarsSet(Set llapDaemonVarsSetLocal
HIVE_CBO_CNF_NODES_LIMIT("hive.cbo.cnf.maxnodes", -1, "When converting to
conjunctive normal form (CNF), fail if" +
"the expression exceeds this threshold; the threshold is expressed in
terms of number of nodes (leaves and" +
"interior nodes). -1 to not set up a threshold."),
-HIVE_CBO_RETPATH_HIVEOP("hive.cbo.returnpath.hiveop", false, "Flag to
control calcite plan to hive operator conversion"),
+HIVE_CBO_RETPATH_HIVEOP("hive.cbo.returnpath.hiveop", "supported",
Review comment:
You can provide a `StringSet` validator as parameter for the allowed values,
e.g., check `HIVEFETCHTASKCONVERSION` below.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 359229)
Time Spent: 20m (was: 10m)
> Improve return path enabling/disabling
> --
>
> Key: HIVE-22536
> URL: https://issues.apache.org/jira/browse/HIVE-22536
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22536.01.patch, HIVE-22536.02.patch,
> HIVE-22536.03.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Instead of having a boolean for hive.cbo.returnpath.hiveop it should be
> on/off/supported. In case of "supported" it should be used for a subset of
> commands which are already verified to be able to work with return path. This
> is a temporary solution for the time while we are developing return path,
> before making it the only way to handle commands.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-22536) Improve return path enabling/disabling
[
https://issues.apache.org/jira/browse/HIVE-22536?focusedWorklogId=359231=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-359231
]
ASF GitHub Bot logged work on HIVE-22536:
-
Author: ASF GitHub Bot
Created on: 13/Dec/19 06:59
Start Date: 13/Dec/19 06:59
Worklog Time Spent: 10m
Work Description: jcamachor commented on pull request #866: HIVE-22536
Improve return path enabling/disabling
URL: https://github.com/apache/hive/pull/866#discussion_r357506813
##
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
##
@@ -464,7 +464,7 @@ Operator genOPTree(ASTNode ast, PlannerContext plannerCtx)
throws SemanticExcept
// 0. Gen Optimized Plan
RelNode newPlan = logicalPlan();
- if (this.conf.getBoolVar(HiveConf.ConfVars.HIVE_CBO_RETPATH_HIVEOP))
{
+ if (ReturnPathManager.shouldUse()) {
if (cboCtx.type == PreCboCtx.Type.VIEW && !materializedView) {
Review comment:
We should only fail if return path is `true` rather than `supported`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 359231)
Time Spent: 40m (was: 0.5h)
> Improve return path enabling/disabling
> --
>
> Key: HIVE-22536
> URL: https://issues.apache.org/jira/browse/HIVE-22536
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22536.01.patch, HIVE-22536.02.patch,
> HIVE-22536.03.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Instead of having a boolean for hive.cbo.returnpath.hiveop it should be
> on/off/supported. In case of "supported" it should be used for a subset of
> commands which are already verified to be able to work with return path. This
> is a temporary solution for the time while we are developing return path,
> before making it the only way to handle commands.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-20150) TopNKey pushdown
[ https://issues.apache.org/jira/browse/HIVE-20150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krisztian Kasa updated HIVE-20150: -- Status: Patch Available (was: Open) > TopNKey pushdown > > > Key: HIVE-20150 > URL: https://issues.apache.org/jira/browse/HIVE-20150 > Project: Hive > Issue Type: Improvement > Components: Physical Optimizer >Affects Versions: 4.0.0 >Reporter: Teddy Choi >Assignee: Krisztian Kasa >Priority: Major > Labels: pull-request-available > Attachments: HIVE-20150.1.patch, HIVE-20150.10.patch, > HIVE-20150.11.patch, HIVE-20150.11.patch, HIVE-20150.14.patch, > HIVE-20150.15.patch, HIVE-20150.16.patch, HIVE-20150.17.patch, > HIVE-20150.17.patch, HIVE-20150.18.patch, HIVE-20150.18.patch, > HIVE-20150.19.patch, HIVE-20150.2.patch, HIVE-20150.20.patch, > HIVE-20150.21.patch, HIVE-20150.22.patch, HIVE-20150.23.patch, > HIVE-20150.24.patch, HIVE-20150.25.patch, HIVE-20150.25.patch, > HIVE-20150.26.patch, HIVE-20150.27.patch, HIVE-20150.4.patch, > HIVE-20150.5.patch, HIVE-20150.6.patch, HIVE-20150.7.patch, > HIVE-20150.8.patch, HIVE-20150.9.patch > > > TopNKey operator is implemented in HIVE-17896, but it needs more work in > pushdown implementation. So this issue covers TopNKey pushdown implementation > with proper tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-20150) TopNKey pushdown
[ https://issues.apache.org/jira/browse/HIVE-20150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krisztian Kasa updated HIVE-20150: -- Attachment: HIVE-20150.27.patch > TopNKey pushdown > > > Key: HIVE-20150 > URL: https://issues.apache.org/jira/browse/HIVE-20150 > Project: Hive > Issue Type: Improvement > Components: Physical Optimizer >Affects Versions: 4.0.0 >Reporter: Teddy Choi >Assignee: Krisztian Kasa >Priority: Major > Labels: pull-request-available > Attachments: HIVE-20150.1.patch, HIVE-20150.10.patch, > HIVE-20150.11.patch, HIVE-20150.11.patch, HIVE-20150.14.patch, > HIVE-20150.15.patch, HIVE-20150.16.patch, HIVE-20150.17.patch, > HIVE-20150.17.patch, HIVE-20150.18.patch, HIVE-20150.18.patch, > HIVE-20150.19.patch, HIVE-20150.2.patch, HIVE-20150.20.patch, > HIVE-20150.21.patch, HIVE-20150.22.patch, HIVE-20150.23.patch, > HIVE-20150.24.patch, HIVE-20150.25.patch, HIVE-20150.25.patch, > HIVE-20150.26.patch, HIVE-20150.27.patch, HIVE-20150.4.patch, > HIVE-20150.5.patch, HIVE-20150.6.patch, HIVE-20150.7.patch, > HIVE-20150.8.patch, HIVE-20150.9.patch > > > TopNKey operator is implemented in HIVE-17896, but it needs more work in > pushdown implementation. So this issue covers TopNKey pushdown implementation > with proper tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22489) Reduce Sink operator should order nulls by parameter
[
https://issues.apache.org/jira/browse/HIVE-22489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995389#comment-16995389
]
Hive QA commented on HIVE-22489:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12988702/HIVE-22489.4.patch
{color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 515 failed/errored test(s), 17773 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_stats5] (batchId=23)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[allcolref_in_udf]
(batchId=59)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ambiguous_col]
(batchId=54)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[annotate_stats_groupby2]
(batchId=53)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[annotate_stats_groupby]
(batchId=55)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[annotate_stats_join]
(batchId=60)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[annotate_stats_join_pkfk]
(batchId=16)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[autoColumnStats_5]
(batchId=46)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[autoColumnStats_5a]
(batchId=59)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[autoColumnStats_6]
(batchId=73)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[autoColumnStats_7]
(batchId=71)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[autoColumnStats_9]
(batchId=40)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join18] (batchId=14)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join18_multi_distinct]
(batchId=29)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join20] (batchId=99)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join21] (batchId=91)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join26] (batchId=15)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join27]
(batchId=100)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join28] (batchId=80)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join29] (batchId=61)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join32] (batchId=96)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join6] (batchId=96)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join7] (batchId=29)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join_stats]
(batchId=54)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join_without_localtask]
(batchId=1)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[binarysortable_1]
(batchId=83)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[bucketsortoptimize_insert_1]
(batchId=67)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[bucketsortoptimize_insert_3]
(batchId=87)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[bucketsortoptimize_insert_4]
(batchId=28)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[bucketsortoptimize_insert_5]
(batchId=65)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[bucketsortoptimize_insert_8]
(batchId=5)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cbo_SortUnionTransposeRule]
(batchId=18)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cbo_const] (batchId=20)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cbo_rp_annotate_stats_groupby]
(batchId=95)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cbo_rp_auto_join1]
(batchId=4)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cbo_rp_cross_product_check_2]
(batchId=22)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cbo_rp_gby2_map_multi_distinct]
(batchId=92)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cbo_rp_groupby3_noskew_multi_distinct]
(batchId=44)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cbo_rp_join0]
(batchId=55)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[column_pruner_multiple_children]
(batchId=24)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[columnstats_partlvl]
(batchId=40)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[columnstats_partlvl_dp]
(batchId=57)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[combine2] (batchId=7)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[complex_alias]
(batchId=19)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[constGby] (batchId=10)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[constant_prop_1]
(batchId=45)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[constant_prop_2]
(batchId=32)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[constant_prop_3]
(batchId=49)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[constprog_dp]
(batchId=21)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[constprog_partitioner]
(batchId=80)
[jira] [Work logged] (HIVE-22557) Break up DDLSemanticAnalyzer - extract Table constraints analyzers
[
https://issues.apache.org/jira/browse/HIVE-22557?focusedWorklogId=359220=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-359220
]
ASF GitHub Bot logged work on HIVE-22557:
-
Author: ASF GitHub Bot
Created on: 13/Dec/19 06:16
Start Date: 13/Dec/19 06:16
Worklog Time Spent: 10m
Work Description: jcamachor commented on pull request #859: HIVE-22557
Break up DDLSemanticAnalyzer - extract Table constraints analyzers
URL: https://github.com/apache/hive/pull/859#discussion_r357498230
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/DDLSemanticAnalyzerFactory.java
##
@@ -51,8 +52,17 @@ private DDLSemanticAnalyzerFactory() {
int type();
}
+ /**
+ * Reveals the actual type of an ASTTree that has a category as main element.
+ */
+ public interface DDLSematnicAnalyzerCategory {
Review comment:
typo
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 359220)
Time Spent: 20m (was: 10m)
> Break up DDLSemanticAnalyzer - extract Table constraints analyzers
> --
>
> Key: HIVE-22557
> URL: https://issues.apache.org/jira/browse/HIVE-22557
> Project: Hive
> Issue Type: Sub-task
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
> Labels: pull-request-available, refactor-ddl
> Attachments: HIVE-22557.01.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> DDLSemanticAnalyzer is a huge class, more than 4000 lines long. The goal is
> to refactor it in order to have everything cut into more handleable classes
> under the package org.apache.hadoop.hive.ql.exec.ddl:
> * have a separate class for each analyzers
> * have a package for each operation, containing an analyzer, a description,
> and an operation, so the amount of classes under a package is more manageable
> Step #10: extract the table constraints related analyzers from
> DDLSemanticAnalyzer, and move them under the new package.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22557) Break up DDLSemanticAnalyzer - extract Table constraints analyzers
[ https://issues.apache.org/jira/browse/HIVE-22557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995385#comment-16995385 ] Jesus Camacho Rodriguez commented on HIVE-22557: Left a minor comment. Other than that, LGTM. +1 > Break up DDLSemanticAnalyzer - extract Table constraints analyzers > -- > > Key: HIVE-22557 > URL: https://issues.apache.org/jira/browse/HIVE-22557 > Project: Hive > Issue Type: Sub-task >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Labels: pull-request-available, refactor-ddl > Attachments: HIVE-22557.01.patch > > Time Spent: 20m > Remaining Estimate: 0h > > DDLSemanticAnalyzer is a huge class, more than 4000 lines long. The goal is > to refactor it in order to have everything cut into more handleable classes > under the package org.apache.hadoop.hive.ql.exec.ddl: > * have a separate class for each analyzers > * have a package for each operation, containing an analyzer, a description, > and an operation, so the amount of classes under a package is more manageable > Step #10: extract the table constraints related analyzers from > DDLSemanticAnalyzer, and move them under the new package. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-20150) TopNKey pushdown
[ https://issues.apache.org/jira/browse/HIVE-20150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krisztian Kasa updated HIVE-20150: -- Status: Open (was: Patch Available) > TopNKey pushdown > > > Key: HIVE-20150 > URL: https://issues.apache.org/jira/browse/HIVE-20150 > Project: Hive > Issue Type: Improvement > Components: Physical Optimizer >Affects Versions: 4.0.0 >Reporter: Teddy Choi >Assignee: Krisztian Kasa >Priority: Major > Labels: pull-request-available > Attachments: HIVE-20150.1.patch, HIVE-20150.10.patch, > HIVE-20150.11.patch, HIVE-20150.11.patch, HIVE-20150.14.patch, > HIVE-20150.15.patch, HIVE-20150.16.patch, HIVE-20150.17.patch, > HIVE-20150.17.patch, HIVE-20150.18.patch, HIVE-20150.18.patch, > HIVE-20150.19.patch, HIVE-20150.2.patch, HIVE-20150.20.patch, > HIVE-20150.21.patch, HIVE-20150.22.patch, HIVE-20150.23.patch, > HIVE-20150.24.patch, HIVE-20150.25.patch, HIVE-20150.25.patch, > HIVE-20150.26.patch, HIVE-20150.4.patch, HIVE-20150.5.patch, > HIVE-20150.6.patch, HIVE-20150.7.patch, HIVE-20150.8.patch, HIVE-20150.9.patch > > > TopNKey operator is implemented in HIVE-17896, but it needs more work in > pushdown implementation. So this issue covers TopNKey pushdown implementation > with proper tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22408) The fix for CALCITE-2991 creates wrong results on edge case
[ https://issues.apache.org/jira/browse/HIVE-22408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vineet Garg updated HIVE-22408: --- Fix Version/s: 4.0.0 Resolution: Fixed Status: Resolved (was: Patch Available) > The fix for CALCITE-2991 creates wrong results on edge case > --- > > Key: HIVE-22408 > URL: https://issues.apache.org/jira/browse/HIVE-22408 > Project: Hive > Issue Type: Bug > Components: CBO >Affects Versions: 3.1.2 >Reporter: Steve Carlin >Assignee: Vineet Garg >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22408.1.patch, HIVE-22408.2.patch, > HIVE-22408.3.patch, HIVE-22408.4.patch, HIVE-22408.5.patch, HIVE-22408.6.patch > > Time Spent: 1h > Remaining Estimate: 0h > > The Calcite upgrade from 1.19 to 1.21 includes a fix for CALCITE-2991. This > patch causes a failure in subquery_ALL.q > In order to proceed with the upgrade, the patch was bypassed by creating the > HiveRelMdMaxRowCount class which overrides the behavior in Calcite. > In order to recreate the regression, remove this file and the references to > the class in HiveDefaultRelMetadataProvider. > This Jira is being created before the HIVE-22274 PR has been pushed, so > please wait until that is pushed before working on this. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22408) The fix for CALCITE-2991 creates wrong results on edge case
[ https://issues.apache.org/jira/browse/HIVE-22408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995383#comment-16995383 ] Vineet Garg commented on HIVE-22408: Thanks [~kgyrtkirk]. I have pushed this to master. > The fix for CALCITE-2991 creates wrong results on edge case > --- > > Key: HIVE-22408 > URL: https://issues.apache.org/jira/browse/HIVE-22408 > Project: Hive > Issue Type: Bug > Components: CBO >Affects Versions: 3.1.2 >Reporter: Steve Carlin >Assignee: Vineet Garg >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22408.1.patch, HIVE-22408.2.patch, > HIVE-22408.3.patch, HIVE-22408.4.patch, HIVE-22408.5.patch, HIVE-22408.6.patch > > Time Spent: 1h > Remaining Estimate: 0h > > The Calcite upgrade from 1.19 to 1.21 includes a fix for CALCITE-2991. This > patch causes a failure in subquery_ALL.q > In order to proceed with the upgrade, the patch was bypassed by creating the > HiveRelMdMaxRowCount class which overrides the behavior in Calcite. > In order to recreate the regression, remove this file and the references to > the class in HiveDefaultRelMetadataProvider. > This Jira is being created before the HIVE-22274 PR has been pushed, so > please wait until that is pushed before working on this. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22632) Improve estimateRowSizeFromSchema
[ https://issues.apache.org/jira/browse/HIVE-22632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995380#comment-16995380 ] Vineet Garg commented on HIVE-22632: [~jcamachorodriguez] [~kgyrtkirk] Can you take a look please? > Improve estimateRowSizeFromSchema > - > > Key: HIVE-22632 > URL: https://issues.apache.org/jira/browse/HIVE-22632 > Project: Hive > Issue Type: Improvement > Components: Statistics >Reporter: Vineet Garg >Assignee: Vineet Garg >Priority: Major > Attachments: HIVE-22632.1.patch > > > estimateRowSizeFromSchema un-necessarily iterate and do look-up. This could > be avoided. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22637) Avoid cost based rules during generating expressions from AST
[ https://issues.apache.org/jira/browse/HIVE-22637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995381#comment-16995381 ] Vineet Garg commented on HIVE-22637: [~jcamachorodriguez] Can you take a look please? > Avoid cost based rules during generating expressions from AST > - > > Key: HIVE-22637 > URL: https://issues.apache.org/jira/browse/HIVE-22637 > Project: Hive > Issue Type: Improvement > Components: Query Planning >Reporter: Vineet Garg >Assignee: Vineet Garg >Priority: Major > Attachments: HIVE-22637.1.patch, HIVE-22637.2.patch > > > genExprNode uses default dispatcher which fire rules based on cost, > computation of cost is expensive and is likely un-necessary. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22637) Avoid cost based rules during generating expressions from AST
[ https://issues.apache.org/jira/browse/HIVE-22637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vineet Garg updated HIVE-22637: --- Attachment: HIVE-22637.2.patch > Avoid cost based rules during generating expressions from AST > - > > Key: HIVE-22637 > URL: https://issues.apache.org/jira/browse/HIVE-22637 > Project: Hive > Issue Type: Improvement > Components: Query Planning >Reporter: Vineet Garg >Assignee: Vineet Garg >Priority: Major > Attachments: HIVE-22637.1.patch, HIVE-22637.2.patch > > > genExprNode uses default dispatcher which fire rules based on cost, > computation of cost is expensive and is likely un-necessary. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22489) Reduce Sink operator should order nulls by parameter
[
https://issues.apache.org/jira/browse/HIVE-22489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995379#comment-16995379
]
Hive QA commented on HIVE-22489:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
41s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
28s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
51s{color} | {color:blue} serde in master has 198 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
36s{color} | {color:blue} ql in master has 1531 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
34s{color} | {color:blue} accumulo-handler in master has 21 extant Findbugs
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
27s{color} | {color:blue} contrib in master has 11 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
37s{color} | {color:blue} hbase-handler in master has 15 extant Findbugs
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
26s{color} | {color:blue} kudu-handler in master has 1 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
42s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
43s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m
31s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
24s{color} | {color:red} serde: The patch generated 3 new + 346 unchanged - 2
fixed = 349 total (was 348) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
58s{color} | {color:red} ql: The patch generated 2 new + 593 unchanged - 0
fixed = 595 total (was 593) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 7m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
37s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 58m 46s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19910/dev-support/hive-personality.sh
|
| git revision | master / 41b51fc |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-19910/yetus/diff-checkstyle-serde.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-19910/yetus/diff-checkstyle-ql.txt
|
| modules | C: serde ql accumulo-handler contrib hbase-handler kudu-handler
itests/hive-blobstore U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-19910/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Reduce Sink operator should order nulls by parameter
>
[jira] [Updated] (HIVE-22637) Avoid cost based rules during generating expressions from AST
[ https://issues.apache.org/jira/browse/HIVE-22637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vineet Garg updated HIVE-22637: --- Status: Patch Available (was: Open) > Avoid cost based rules during generating expressions from AST > - > > Key: HIVE-22637 > URL: https://issues.apache.org/jira/browse/HIVE-22637 > Project: Hive > Issue Type: Improvement > Components: Query Planning >Reporter: Vineet Garg >Assignee: Vineet Garg >Priority: Major > Attachments: HIVE-22637.1.patch, HIVE-22637.2.patch > > > genExprNode uses default dispatcher which fire rules based on cost, > computation of cost is expensive and is likely un-necessary. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22637) Avoid cost based rules during generating expressions from AST
[ https://issues.apache.org/jira/browse/HIVE-22637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vineet Garg updated HIVE-22637: --- Status: Open (was: Patch Available) > Avoid cost based rules during generating expressions from AST > - > > Key: HIVE-22637 > URL: https://issues.apache.org/jira/browse/HIVE-22637 > Project: Hive > Issue Type: Improvement > Components: Query Planning >Reporter: Vineet Garg >Assignee: Vineet Garg >Priority: Major > Attachments: HIVE-22637.1.patch, HIVE-22637.2.patch > > > genExprNode uses default dispatcher which fire rules based on cost, > computation of cost is expensive and is likely un-necessary. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22625) Syntax Error in findPotentialCompactions SQL query for MySql/Postgres
[
https://issues.apache.org/jira/browse/HIVE-22625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995358#comment-16995358
]
Hive QA commented on HIVE-22625:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12988518/HIVE-22625.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 17772 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19909/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19909/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19909/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12988518 - PreCommit-HIVE-Build
> Syntax Error in findPotentialCompactions SQL query for MySql/Postgres
> -
>
> Key: HIVE-22625
> URL: https://issues.apache.org/jira/browse/HIVE-22625
> Project: Hive
> Issue Type: Bug
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22625.1.patch
>
>
> {code}
> ERROR 1064 (42000): You have an error in your SQL syntax; check the manual
> that corresponds to your MySQL server version for the right syntax to use
> near '=> current_timestamp - interval '254' second'
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22625) Syntax Error in findPotentialCompactions SQL query for MySql/Postgres
[
https://issues.apache.org/jira/browse/HIVE-22625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995335#comment-16995335
]
Hive QA commented on HIVE-22625:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
27s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m
25s{color} | {color:blue} standalone-metastore/metastore-server in master has
182 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
24s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
27s{color} | {color:red} standalone-metastore/metastore-server: The patch
generated 2 new + 562 unchanged - 2 fixed = 564 total (was 564) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
16s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 16m 41s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19909/dev-support/hive-personality.sh
|
| git revision | master / 41b51fc |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-19909/yetus/diff-checkstyle-standalone-metastore_metastore-server.txt
|
| modules | C: standalone-metastore/metastore-server U:
standalone-metastore/metastore-server |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-19909/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Syntax Error in findPotentialCompactions SQL query for MySql/Postgres
> -
>
> Key: HIVE-22625
> URL: https://issues.apache.org/jira/browse/HIVE-22625
> Project: Hive
> Issue Type: Bug
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22625.1.patch
>
>
> {code}
> ERROR 1064 (42000): You have an error in your SQL syntax; check the manual
> that corresponds to your MySQL server version for the right syntax to use
> near '=> current_timestamp - interval '254' second'
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22638) Fix insert statement issue with return path
[
https://issues.apache.org/jira/browse/HIVE-22638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995328#comment-16995328
]
Hive QA commented on HIVE-22638:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12988701/HIVE-22638.01.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17774 tests
executed
*Failed tests:*
{noformat}
org.apache.hive.service.server.TestHS2HttpServerPamConfiguration.testPamCorrectConfiguration
(batchId=241)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19908/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19908/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19908/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12988701 - PreCommit-HIVE-Build
> Fix insert statement issue with return path
> ---
>
> Key: HIVE-22638
> URL: https://issues.apache.org/jira/browse/HIVE-22638
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
> Attachments: HIVE-22638.01.patch
>
>
> Insert statements were not handled properly with return path. It was revealed
> during examining why TestUpgradeTool is not working with return path.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22638) Fix insert statement issue with return path
[
https://issues.apache.org/jira/browse/HIVE-22638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995297#comment-16995297
]
Hive QA commented on HIVE-22638:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
48s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
27s{color} | {color:blue} ql in master has 1531 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
6s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
49s{color} | {color:green} ql: The patch generated 0 new + 487 unchanged - 2
fixed = 487 total (was 489) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 28m 26s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19908/dev-support/hive-personality.sh
|
| git revision | master / 41b51fc |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-19908/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Fix insert statement issue with return path
> ---
>
> Key: HIVE-22638
> URL: https://issues.apache.org/jira/browse/HIVE-22638
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
> Attachments: HIVE-22638.01.patch
>
>
> Insert statements were not handled properly with return path. It was revealed
> during examining why TestUpgradeTool is not working with return path.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-20150) TopNKey pushdown
[
https://issues.apache.org/jira/browse/HIVE-20150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995279#comment-16995279
]
Hive QA commented on HIVE-20150:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12988694/HIVE-20150.26.patch
{color:green}SUCCESS:{color} +1 due to 3 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 111 failed/errored test(s), 17778 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestKuduCliDriver.testCliDriver[kudu_complex_queries]
(batchId=292)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[explainuser_2]
(batchId=160)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[insert_into1]
(batchId=156)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[insert_into2]
(batchId=161)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_struct_type_vectorization]
(batchId=160)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[parquet_complex_types_vectorization]
(batchId=160)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[parquet_map_type_vectorization]
(batchId=160)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[parquet_struct_type_vectorization]
(batchId=156)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[check_constraint]
(batchId=166)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[constraints_optimization]
(batchId=176)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[ctas]
(batchId=163)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[dynpart_sort_opt_vectorization]
(batchId=176)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[enforce_constraint_notnull]
(batchId=166)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[external_jdbc_table_perf]
(batchId=187)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[filter_union]
(batchId=166)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[groupby_groupingset_bug]
(batchId=187)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[insert1_overwrite_partitions]
(batchId=181)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[lateral_view]
(batchId=185)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[limit_pushdown3]
(batchId=170)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[limit_pushdown]
(batchId=182)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_decimal64_reader]
(batchId=175)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[materialized_view_rewrite_8]
(batchId=178)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[q93_with_constraints]
(batchId=175)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_scalar]
(batchId=174)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_select]
(batchId=174)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[temp_table]
(batchId=188)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[tez_fixed_bucket_pruning]
(batchId=185)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_case_when_2]
(batchId=178)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_case_when_conversion]
(batchId=162)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_cast_constant]
(batchId=164)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_char_2]
(batchId=182)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_char_simple]
(batchId=175)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_coalesce]
(batchId=164)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_data_types]
(batchId=184)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_groupby_grouping_sets_limit]
(batchId=173)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_groupby_reduce]
(batchId=178)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_identity_reuse]
(batchId=182)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_llap_text_1]
(batchId=166)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_partitioned_date_time]
(batchId=185)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_reduce_groupby_decimal]
(batchId=171)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_string_concat]
(batchId=171)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_varchar_simple]
(batchId=184)
[jira] [Commented] (HIVE-20150) TopNKey pushdown
[
https://issues.apache.org/jira/browse/HIVE-20150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995259#comment-16995259
]
Hive QA commented on HIVE-20150:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m
1s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
3s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
32s{color} | {color:blue} ql in master has 1531 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
26s{color} | {color:blue} kudu-handler in master has 1 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
20s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
30s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
34s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
49s{color} | {color:red} ql: The patch generated 2 new + 440 unchanged - 2
fixed = 442 total (was 442) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
45s{color} | {color:red} ql generated 1 new + 1531 unchanged - 0 fixed = 1532
total (was 1531) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
23s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 33m 3s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | Dead store to standardObjInspector in
org.apache.hadoop.hive.ql.exec.TopNKeyOperator.initializeOp(Configuration) At
TopNKeyOperator.java:org.apache.hadoop.hive.ql.exec.TopNKeyOperator.initializeOp(Configuration)
At TopNKeyOperator.java:[line 62] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19907/dev-support/hive-personality.sh
|
| git revision | master / 41b51fc |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-19907/yetus/diff-checkstyle-ql.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-19907/yetus/new-findbugs-ql.html
|
| modules | C: ql kudu-handler U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-19907/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> TopNKey pushdown
>
>
> Key: HIVE-20150
> URL: https://issues.apache.org/jira/browse/HIVE-20150
> Project: Hive
> Issue Type: Improvement
> Components: Physical Optimizer
>Affects Versions: 4.0.0
>Reporter: Teddy Choi
>Assignee: Krisztian Kasa
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-20150.1.patch, HIVE-20150.10.patch,
> HIVE-20150.11.patch, HIVE-20150.11.patch, HIVE-20150.14.patch,
> HIVE-20150.15.patch, HIVE-20150.16.patch, HIVE-20150.17.patch,
>
[jira] [Commented] (HIVE-22584) Flakyness in TestTaskExecutorService.testSetCapacity
[
https://issues.apache.org/jira/browse/HIVE-22584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995245#comment-16995245
]
Hive QA commented on HIVE-22584:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12988688/HIVE-22584.4.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 10 failed/errored test(s), 17772 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query22]
(batchId=301)
org.apache.hive.minikdc.TestJdbcWithDBTokenStoreNoDoAs.testCancelRenewTokenFlow
(batchId=302)
org.apache.hive.minikdc.TestJdbcWithDBTokenStoreNoDoAs.testConnection
(batchId=302)
org.apache.hive.minikdc.TestJdbcWithDBTokenStoreNoDoAs.testIsValid (batchId=302)
org.apache.hive.minikdc.TestJdbcWithDBTokenStoreNoDoAs.testIsValidNeg
(batchId=302)
org.apache.hive.minikdc.TestJdbcWithDBTokenStoreNoDoAs.testNegativeProxyAuth
(batchId=302)
org.apache.hive.minikdc.TestJdbcWithDBTokenStoreNoDoAs.testNegativeTokenAuth
(batchId=302)
org.apache.hive.minikdc.TestJdbcWithDBTokenStoreNoDoAs.testProxyAuth
(batchId=302)
org.apache.hive.minikdc.TestJdbcWithDBTokenStoreNoDoAs.testRenewDelegationToken
(batchId=302)
org.apache.hive.minikdc.TestJdbcWithDBTokenStoreNoDoAs.testTokenAuth
(batchId=302)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19906/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19906/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19906/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 10 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12988688 - PreCommit-HIVE-Build
> Flakyness in TestTaskExecutorService.testSetCapacity
>
>
> Key: HIVE-22584
> URL: https://issues.apache.org/jira/browse/HIVE-22584
> Project: Hive
> Issue Type: Test
>Reporter: Peter Vary
>Assignee: Peter Vary
>Priority: Major
> Attachments: HIVE-22584.2.patch, HIVE-22584.3.patch,
> HIVE-22584.4.patch, HIVE-22584.patch
>
>
> Very rarely the test fails:
> {code}
> java.lang.AssertionError: expected:<0> but was:<1>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:743)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:555)
> at org.junit.Assert.assertEquals(Assert.java:542)
> at
> org.apache.hadoop.hive.llap.daemon.impl.TestTaskExecutorService.testSetCapacity(TestTaskExecutorService.java:515)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)
> {code}
> See:
> https://builds.apache.org/job/PreCommit-HIVE-Build/19739/testReport/org.apache.hadoop.hive.llap.daemon.impl/TestTaskExecutorService/testSetCapacity/
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-9736) StorageBasedAuthProvider should batch namenode-calls where possible.
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995221#comment-16995221
]
Mithun Radhakrishnan commented on HIVE-9736:
[~zshao], sorry I missed your comment. You're right about this not being faster
today, since the DFSClient currently just loops on the client-side. The
intention was for the file-list to be pushed down to the name-node, so as to
avoid the loop. We intended to request for the {{DFSClient}} to implement this.
:/
> StorageBasedAuthProvider should batch namenode-calls where possible.
>
>
> Key: HIVE-9736
> URL: https://issues.apache.org/jira/browse/HIVE-9736
> Project: Hive
> Issue Type: Bug
> Components: Metastore, Security
>Affects Versions: 1.2.1
>Reporter: Mithun Radhakrishnan
>Assignee: Mithun Radhakrishnan
>Priority: Major
> Labels: TODOC1.2
> Attachments: HIVE-9736.1.patch, HIVE-9736.2.patch, HIVE-9736.3.patch,
> HIVE-9736.4.patch, HIVE-9736.5.patch, HIVE-9736.6.patch, HIVE-9736.7.patch,
> HIVE-9736.8.patch
>
>
> Consider a table partitioned by 2 keys (dt, region). Say a dt partition could
> have 1 associated regions. Consider that the user does:
> {code:sql}
> ALTER TABLE my_table DROP PARTITION (dt='20150101');
> {code}
> As things stand now, {{StorageBasedAuthProvider}} will make individual
> {{DistributedFileSystem.listStatus()}} calls for each partition-directory,
> and authorize each one separately. It'd be faster to batch the calls, and
> examine multiple FileStatus objects at once.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (HIVE-22590) Revert HIVE-17218 Canonical-ize hostnames for Hive metastore, and HS2 servers as it causes issues with SSL and LB
[
https://issues.apache.org/jira/browse/HIVE-22590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995216#comment-16995216
]
Mithun Radhakrishnan edited comment on HIVE-22590 at 12/13/19 12:01 AM:
My apologies for not responding to this sooner. This sort of failure was
unintended. I'm supportive of reverting HIVE-17218, if required.
[~pvary], would you happen to know if HIVE-21899 sorts this out?
Edit: I'm not sure it will. With a load-balancer, it wouldn't be enough to
check if an IP address is returned instead of the hostname. The load-balancer
would have its own hostname and IP-address.
was (Author: mithun):
My apologies for not responding to this sooner. This sort of failure was
unintended. I'm supportive of reverting HIVE-17218, if required.
[~pvary], would you happen to know if HIVE-21899 sorts this out?
> Revert HIVE-17218 Canonical-ize hostnames for Hive metastore, and HS2 servers
> as it causes issues with SSL and LB
> -
>
> Key: HIVE-22590
> URL: https://issues.apache.org/jira/browse/HIVE-22590
> Project: Hive
> Issue Type: Bug
>Reporter: Peter Vary
>Assignee: Peter Vary
>Priority: Major
>
> HIVE-17218 causes issues with Load balanced + SSL environments, like this:
> {code}
> java.net.SocketException: Socket is closed
> at sun.security.ssl.SSLSocketImpl.checkEOF(SSLSocketImpl.java:1532)
> at sun.security.ssl.SSLSocketImpl.checkWrite(SSLSocketImpl.java:1553)
> at sun.security.ssl.AppOutputStream.write(AppOutputStream.java:71)
> at java.io.BufferedOutputStream.flushBuffer(BufferedOutputStream.java:82)
> at java.io.BufferedOutputStream.flush(BufferedOutputStream.java:140)
> at java.io.FilterOutputStream.close(FilterOutputStream.java:158)
> at
> org.apache.thrift.transport.TIOStreamTransport.close(TIOStreamTransport.java:110)
>
> at org.apache.thrift.transport.TSocket.close(TSocket.java:235)
> at org.apache.thrift.transport.TSaslTransport.open(TSaslTransport.java:318)
> at
> org.apache.thrift.transport.TSaslClientTransport.open(TSaslClientTransport.java:37)
>
> at
> org.apache.hadoop.hive.thrift.client.TUGIAssumingTransport$1.run(TUGIAssumingTransport.java:52)
>
> at
> org.apache.hadoop.hive.thrift.client.TUGIAssumingTransport$1.run(TUGIAssumingTransport.java:49)
>
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1917)
>
> at
> org.apache.hadoop.hive.thrift.client.TUGIAssumingTransport.open(TUGIAssumingTransport.java:49)
>
> at org.apache.hive.jdbc.HiveConnection.openTransport(HiveConnection.java:204)
> at org.apache.hive.jdbc.HiveConnection.(HiveConnection.java:169)
> at org.apache.hive.jdbc.HiveDriver.connect(HiveDriver.java:105)
> at java.sql.DriverManager.getConnection(DriverManager.java:664)
> at java.sql.DriverManager.getConnection(DriverManager.java:208)
> at
> org.apache.hive.beeline.DatabaseConnection.connect(DatabaseConnection.java:146)
>
> at
> org.apache.hive.beeline.DatabaseConnection.getConnection(DatabaseConnection.java:211)
>
> at org.apache.hive.beeline.Commands.connect(Commands.java:1496)
> at org.apache.hive.beeline.Commands.connect(Commands.java:1391)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.hive.beeline.ReflectiveCommandHandler.execute(ReflectiveCommandHandler.java:52)
>
> at org.apache.hive.beeline.BeeLine.execCommandWithPrefix(BeeLine.java:1135)
> at org.apache.hive.beeline.BeeLine.dispatch(BeeLine.java:1174)
> at org.apache.hive.beeline.BeeLine.execute(BeeLine.java:1010)
> at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:922)
> at org.apache.hive.beeline.BeeLine.mainWithInputRedirection(BeeLine.java:518)
> at org.apache.hive.beeline.BeeLine.main(BeeLine.java:501)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.apache.hadoop.util.RunJar.run(RunJar.java:221)
> at org.apache.hadoop.util.RunJar.main(RunJar.java:136)
> Unknown HS2 problem when communicating with Thrift server.
> Error: Could not open client transport with JDBC Uri: jdbc:hive2:// For privacy> GSS initiate failed
> Also, could not send response:
[jira] [Commented] (HIVE-22590) Revert HIVE-17218 Canonical-ize hostnames for Hive metastore, and HS2 servers as it causes issues with SSL and LB
[
https://issues.apache.org/jira/browse/HIVE-22590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995216#comment-16995216
]
Mithun Radhakrishnan commented on HIVE-22590:
-
My apologies for not responding to this sooner. This sort of failure was
unintended. I'm supportive of reverting HIVE-17218, if required.
[~pvary], would you happen to know if HIVE-21899 sorts this out?
> Revert HIVE-17218 Canonical-ize hostnames for Hive metastore, and HS2 servers
> as it causes issues with SSL and LB
> -
>
> Key: HIVE-22590
> URL: https://issues.apache.org/jira/browse/HIVE-22590
> Project: Hive
> Issue Type: Bug
>Reporter: Peter Vary
>Assignee: Peter Vary
>Priority: Major
>
> HIVE-17218 causes issues with Load balanced + SSL environments, like this:
> {code}
> java.net.SocketException: Socket is closed
> at sun.security.ssl.SSLSocketImpl.checkEOF(SSLSocketImpl.java:1532)
> at sun.security.ssl.SSLSocketImpl.checkWrite(SSLSocketImpl.java:1553)
> at sun.security.ssl.AppOutputStream.write(AppOutputStream.java:71)
> at java.io.BufferedOutputStream.flushBuffer(BufferedOutputStream.java:82)
> at java.io.BufferedOutputStream.flush(BufferedOutputStream.java:140)
> at java.io.FilterOutputStream.close(FilterOutputStream.java:158)
> at
> org.apache.thrift.transport.TIOStreamTransport.close(TIOStreamTransport.java:110)
>
> at org.apache.thrift.transport.TSocket.close(TSocket.java:235)
> at org.apache.thrift.transport.TSaslTransport.open(TSaslTransport.java:318)
> at
> org.apache.thrift.transport.TSaslClientTransport.open(TSaslClientTransport.java:37)
>
> at
> org.apache.hadoop.hive.thrift.client.TUGIAssumingTransport$1.run(TUGIAssumingTransport.java:52)
>
> at
> org.apache.hadoop.hive.thrift.client.TUGIAssumingTransport$1.run(TUGIAssumingTransport.java:49)
>
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1917)
>
> at
> org.apache.hadoop.hive.thrift.client.TUGIAssumingTransport.open(TUGIAssumingTransport.java:49)
>
> at org.apache.hive.jdbc.HiveConnection.openTransport(HiveConnection.java:204)
> at org.apache.hive.jdbc.HiveConnection.(HiveConnection.java:169)
> at org.apache.hive.jdbc.HiveDriver.connect(HiveDriver.java:105)
> at java.sql.DriverManager.getConnection(DriverManager.java:664)
> at java.sql.DriverManager.getConnection(DriverManager.java:208)
> at
> org.apache.hive.beeline.DatabaseConnection.connect(DatabaseConnection.java:146)
>
> at
> org.apache.hive.beeline.DatabaseConnection.getConnection(DatabaseConnection.java:211)
>
> at org.apache.hive.beeline.Commands.connect(Commands.java:1496)
> at org.apache.hive.beeline.Commands.connect(Commands.java:1391)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.hive.beeline.ReflectiveCommandHandler.execute(ReflectiveCommandHandler.java:52)
>
> at org.apache.hive.beeline.BeeLine.execCommandWithPrefix(BeeLine.java:1135)
> at org.apache.hive.beeline.BeeLine.dispatch(BeeLine.java:1174)
> at org.apache.hive.beeline.BeeLine.execute(BeeLine.java:1010)
> at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:922)
> at org.apache.hive.beeline.BeeLine.mainWithInputRedirection(BeeLine.java:518)
> at org.apache.hive.beeline.BeeLine.main(BeeLine.java:501)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.apache.hadoop.util.RunJar.run(RunJar.java:221)
> at org.apache.hadoop.util.RunJar.main(RunJar.java:136)
> Unknown HS2 problem when communicating with Thrift server.
> Error: Could not open client transport with JDBC Uri: jdbc:hive2:// For privacy> GSS initiate failed
> Also, could not send response:
> org.apache.thrift.transport.TTransportException:
> javax.net.ssl.SSLHandshakeException: java.security.cert.CertificateException:
> No subject alternative names matching IP address 52
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-22515) Support cast to decimal64 in Vectorization
[ https://issues.apache.org/jira/browse/HIVE-22515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ramesh Kumar Thangarajan updated HIVE-22515: Attachment: HIVE-22515.5.patch Status: Patch Available (was: Open) > Support cast to decimal64 in Vectorization > -- > > Key: HIVE-22515 > URL: https://issues.apache.org/jira/browse/HIVE-22515 > Project: Hive > Issue Type: Bug >Reporter: Ramesh Kumar Thangarajan >Assignee: Ramesh Kumar Thangarajan >Priority: Major > Attachments: HIVE-22515.5.patch > > > Support cast to decimal64 in Vectorization -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22584) Flakyness in TestTaskExecutorService.testSetCapacity
[
https://issues.apache.org/jira/browse/HIVE-22584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995209#comment-16995209
]
Hive QA commented on HIVE-22584:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
14s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
49s{color} | {color:blue} llap-server in master has 90 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
17s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
16s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 14m 50s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19906/dev-support/hive-personality.sh
|
| git revision | master / 41b51fc |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| modules | C: llap-server U: llap-server |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-19906/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Flakyness in TestTaskExecutorService.testSetCapacity
>
>
> Key: HIVE-22584
> URL: https://issues.apache.org/jira/browse/HIVE-22584
> Project: Hive
> Issue Type: Test
>Reporter: Peter Vary
>Assignee: Peter Vary
>Priority: Major
> Attachments: HIVE-22584.2.patch, HIVE-22584.3.patch,
> HIVE-22584.4.patch, HIVE-22584.patch
>
>
> Very rarely the test fails:
> {code}
> java.lang.AssertionError: expected:<0> but was:<1>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:743)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:555)
> at org.junit.Assert.assertEquals(Assert.java:542)
> at
> org.apache.hadoop.hive.llap.daemon.impl.TestTaskExecutorService.testSetCapacity(TestTaskExecutorService.java:515)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>
[jira] [Updated] (HIVE-22510) Support decimal64 operations for column operands with different scales
[ https://issues.apache.org/jira/browse/HIVE-22510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ramesh Kumar Thangarajan updated HIVE-22510: Attachment: HIVE-22510.15.patch Status: Patch Available (was: Open) > Support decimal64 operations for column operands with different scales > -- > > Key: HIVE-22510 > URL: https://issues.apache.org/jira/browse/HIVE-22510 > Project: Hive > Issue Type: Bug >Reporter: Ramesh Kumar Thangarajan >Assignee: Ramesh Kumar Thangarajan >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22510.11.patch, HIVE-22510.13.patch, > HIVE-22510.14.patch, HIVE-22510.15.patch, HIVE-22510.2.patch, > HIVE-22510.3.patch, HIVE-22510.4.patch, HIVE-22510.5.patch, > HIVE-22510.7.patch, HIVE-22510.9.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Right now, if the operands on the decimal64 operations are columns with > different scales, then we do not use the decimal64 vectorized version and > fall back to HiveDecimal vectorized version of the operator. In this Jira, we > will check if we can use decimal64 vectorized version, even if the scales are > different. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22510) Support decimal64 operations for column operands with different scales
[ https://issues.apache.org/jira/browse/HIVE-22510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ramesh Kumar Thangarajan updated HIVE-22510: Status: Open (was: Patch Available) > Support decimal64 operations for column operands with different scales > -- > > Key: HIVE-22510 > URL: https://issues.apache.org/jira/browse/HIVE-22510 > Project: Hive > Issue Type: Bug >Reporter: Ramesh Kumar Thangarajan >Assignee: Ramesh Kumar Thangarajan >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22510.11.patch, HIVE-22510.13.patch, > HIVE-22510.14.patch, HIVE-22510.2.patch, HIVE-22510.3.patch, > HIVE-22510.4.patch, HIVE-22510.5.patch, HIVE-22510.7.patch, HIVE-22510.9.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Right now, if the operands on the decimal64 operations are columns with > different scales, then we do not use the decimal64 vectorized version and > fall back to HiveDecimal vectorized version of the operator. In this Jira, we > will check if we can use decimal64 vectorized version, even if the scales are > different. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-21050) Upgrade Parquet to 1.11.0 and use LogicalTypes
[
https://issues.apache.org/jira/browse/HIVE-21050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995181#comment-16995181
]
Hive QA commented on HIVE-21050:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12988687/HIVE-21050.9.patch
{color:green}SUCCESS:{color} +1 due to 6 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 40 failed/errored test(s), 17822 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_stats]
(batchId=49)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorization_parquet_projection]
(batchId=48)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[mm_all]
(batchId=160)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[parquet_complex_types_vectorization]
(batchId=160)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[parquet_map_type_vectorization]
(batchId=160)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[parquet_struct_type_vectorization]
(batchId=156)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[parquet_types_vectorization]
(batchId=156)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_partitioned_date_time]
(batchId=185)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorization_input_format_excludes]
(batchId=175)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorized_parquet]
(batchId=177)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorized_parquet_types]
(batchId=181)
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_dynamic_partition_pruning]
(batchId=195)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_join]
(batchId=123)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_0]
(batchId=121)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_10]
(batchId=124)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_11]
(batchId=131)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_12]
(batchId=125)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_13]
(batchId=138)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_14]
(batchId=131)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_15]
(batchId=154)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_16]
(batchId=152)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_17]
(batchId=127)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_1]
(batchId=118)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_2]
(batchId=115)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_3]
(batchId=150)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_4]
(batchId=134)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_5]
(batchId=146)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_6]
(batchId=133)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_7]
(batchId=153)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_8]
(batchId=120)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_9]
(batchId=128)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_decimal_date]
(batchId=128)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_div0]
(batchId=150)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_limit]
(batchId=125)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_offset_limit]
(batchId=129)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_part_project]
(batchId=130)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_pushdown]
(batchId=129)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorization_input_format_excludes]
(batchId=135)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorization_parquet_projection]
(batchId=134)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query20]
(batchId=301)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19905/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19905/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19905/
Messages:
{noformat}
Executing
[jira] [Commented] (HIVE-21050) Upgrade Parquet to 1.11.0 and use LogicalTypes
[
https://issues.apache.org/jira/browse/HIVE-21050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995178#comment-16995178
]
Hive QA commented on HIVE-21050:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m
5s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
58s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
26s{color} | {color:blue} ql in master has 1531 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 8m
38s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
28s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 8m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
45s{color} | {color:green} ql: The patch generated 0 new + 145 unchanged - 4
fixed = 145 total (was 149) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
7s{color} | {color:green} root: The patch generated 0 new + 145 unchanged - 4
fixed = 145 total (was 149) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 8m
24s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
16s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 70m 45s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc xml compile findbugs
checkstyle |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19905/dev-support/hive-personality.sh
|
| git revision | master / 41b51fc |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| modules | C: ql . U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-19905/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Upgrade Parquet to 1.11.0 and use LogicalTypes
> --
>
> Key: HIVE-21050
> URL: https://issues.apache.org/jira/browse/HIVE-21050
> Project: Hive
> Issue Type: Improvement
> Components: File Formats
>Reporter: Karen Coppage
>Assignee: Karen Coppage
>Priority: Major
> Labels: Parquet, parquet
> Attachments: HIVE-21050.1.patch, HIVE-21050.1.patch,
> HIVE-21050.1.patch, HIVE-21050.2.patch, HIVE-21050.3.patch,
> HIVE-21050.4.patch, HIVE-21050.4.patch, HIVE-21050.4.patch,
> HIVE-21050.5.patch, HIVE-21050.5.patch, HIVE-21050.5.patch,
> HIVE-21050.6.patch, HIVE-21050.6.patch, HIVE-21050.6.patch,
> HIVE-21050.6.patch.txt, HIVE-21050.7.patch, HIVE-21050.7.patch,
> HIVE-21050.8.patch, HIVE-21050.9.patch
>
>
> [WIP until Parquet community releases version 1.11.0]
> The new Parquet version (1.11.0) uses
>
[jira] [Commented] (HIVE-22510) Support decimal64 operations for column operands with different scales
[ https://issues.apache.org/jira/browse/HIVE-22510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995168#comment-16995168 ] Ramesh Kumar Thangarajan commented on HIVE-22510: - Hi [~gopalv], I did the change you suggested for the template and I have the new PR at [https://github.com/apache/hive/pull/867], since I had to generate a new patch to submit upstream. Can you please review this? > Support decimal64 operations for column operands with different scales > -- > > Key: HIVE-22510 > URL: https://issues.apache.org/jira/browse/HIVE-22510 > Project: Hive > Issue Type: Bug >Reporter: Ramesh Kumar Thangarajan >Assignee: Ramesh Kumar Thangarajan >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22510.11.patch, HIVE-22510.13.patch, > HIVE-22510.14.patch, HIVE-22510.2.patch, HIVE-22510.3.patch, > HIVE-22510.4.patch, HIVE-22510.5.patch, HIVE-22510.7.patch, HIVE-22510.9.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Right now, if the operands on the decimal64 operations are columns with > different scales, then we do not use the decimal64 vectorized version and > fall back to HiveDecimal vectorized version of the operator. In this Jira, we > will check if we can use decimal64 vectorized version, even if the scales are > different. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22510) Support decimal64 operations for column operands with different scales
[ https://issues.apache.org/jira/browse/HIVE-22510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HIVE-22510: -- Labels: pull-request-available (was: ) > Support decimal64 operations for column operands with different scales > -- > > Key: HIVE-22510 > URL: https://issues.apache.org/jira/browse/HIVE-22510 > Project: Hive > Issue Type: Bug >Reporter: Ramesh Kumar Thangarajan >Assignee: Ramesh Kumar Thangarajan >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22510.11.patch, HIVE-22510.13.patch, > HIVE-22510.14.patch, HIVE-22510.2.patch, HIVE-22510.3.patch, > HIVE-22510.4.patch, HIVE-22510.5.patch, HIVE-22510.7.patch, HIVE-22510.9.patch > > > Right now, if the operands on the decimal64 operations are columns with > different scales, then we do not use the decimal64 vectorized version and > fall back to HiveDecimal vectorized version of the operator. In this Jira, we > will check if we can use decimal64 vectorized version, even if the scales are > different. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-22510) Support decimal64 operations for column operands with different scales
[ https://issues.apache.org/jira/browse/HIVE-22510?focusedWorklogId=358989=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-358989 ] ASF GitHub Bot logged work on HIVE-22510: - Author: ASF GitHub Bot Created on: 12/Dec/19 22:38 Start Date: 12/Dec/19 22:38 Worklog Time Spent: 10m Work Description: ramesh0201 commented on pull request #867: HIVE-22510 Support decimal64 arithmetic and comparison operations on … URL: https://github.com/apache/hive/pull/867 …different scale This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 358989) Remaining Estimate: 0h Time Spent: 10m > Support decimal64 operations for column operands with different scales > -- > > Key: HIVE-22510 > URL: https://issues.apache.org/jira/browse/HIVE-22510 > Project: Hive > Issue Type: Bug >Reporter: Ramesh Kumar Thangarajan >Assignee: Ramesh Kumar Thangarajan >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22510.11.patch, HIVE-22510.13.patch, > HIVE-22510.14.patch, HIVE-22510.2.patch, HIVE-22510.3.patch, > HIVE-22510.4.patch, HIVE-22510.5.patch, HIVE-22510.7.patch, HIVE-22510.9.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Right now, if the operands on the decimal64 operations are columns with > different scales, then we do not use the decimal64 vectorized version and > fall back to HiveDecimal vectorized version of the operator. In this Jira, we > will check if we can use decimal64 vectorized version, even if the scales are > different. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22510) Support decimal64 operations for column operands with different scales
[ https://issues.apache.org/jira/browse/HIVE-22510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ramesh Kumar Thangarajan updated HIVE-22510: Attachment: HIVE-22510.14.patch Status: Patch Available (was: Open) > Support decimal64 operations for column operands with different scales > -- > > Key: HIVE-22510 > URL: https://issues.apache.org/jira/browse/HIVE-22510 > Project: Hive > Issue Type: Bug >Reporter: Ramesh Kumar Thangarajan >Assignee: Ramesh Kumar Thangarajan >Priority: Major > Attachments: HIVE-22510.11.patch, HIVE-22510.13.patch, > HIVE-22510.14.patch, HIVE-22510.2.patch, HIVE-22510.3.patch, > HIVE-22510.4.patch, HIVE-22510.5.patch, HIVE-22510.7.patch, HIVE-22510.9.patch > > > Right now, if the operands on the decimal64 operations are columns with > different scales, then we do not use the decimal64 vectorized version and > fall back to HiveDecimal vectorized version of the operator. In this Jira, we > will check if we can use decimal64 vectorized version, even if the scales are > different. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22510) Support decimal64 operations for column operands with different scales
[ https://issues.apache.org/jira/browse/HIVE-22510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ramesh Kumar Thangarajan updated HIVE-22510: Status: Open (was: Patch Available) > Support decimal64 operations for column operands with different scales > -- > > Key: HIVE-22510 > URL: https://issues.apache.org/jira/browse/HIVE-22510 > Project: Hive > Issue Type: Bug >Reporter: Ramesh Kumar Thangarajan >Assignee: Ramesh Kumar Thangarajan >Priority: Major > Attachments: HIVE-22510.11.patch, HIVE-22510.13.patch, > HIVE-22510.14.patch, HIVE-22510.2.patch, HIVE-22510.3.patch, > HIVE-22510.4.patch, HIVE-22510.5.patch, HIVE-22510.7.patch, HIVE-22510.9.patch > > > Right now, if the operands on the decimal64 operations are columns with > different scales, then we do not use the decimal64 vectorized version and > fall back to HiveDecimal vectorized version of the operator. In this Jira, we > will check if we can use decimal64 vectorized version, even if the scales are > different. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22637) Avoid cost based rules during generating expressions from AST
[
https://issues.apache.org/jira/browse/HIVE-22637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995135#comment-16995135
]
Hive QA commented on HIVE-22637:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12988686/HIVE-22637.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 17772 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19904/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19904/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19904/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12988686 - PreCommit-HIVE-Build
> Avoid cost based rules during generating expressions from AST
> -
>
> Key: HIVE-22637
> URL: https://issues.apache.org/jira/browse/HIVE-22637
> Project: Hive
> Issue Type: Improvement
> Components: Query Planning
>Reporter: Vineet Garg
>Assignee: Vineet Garg
>Priority: Major
> Attachments: HIVE-22637.1.patch
>
>
> genExprNode uses default dispatcher which fire rules based on cost,
> computation of cost is expensive and is likely un-necessary.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-22577) StringIndexOutOfBoundsException when getting sessionId from worker node name
[
https://issues.apache.org/jira/browse/HIVE-22577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Attila Magyar updated HIVE-22577:
-
Status: Patch Available (was: Open)
> StringIndexOutOfBoundsException when getting sessionId from worker node name
>
>
> Key: HIVE-22577
> URL: https://issues.apache.org/jira/browse/HIVE-22577
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Reporter: Attila Magyar
>Assignee: Attila Magyar
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-22577.1.patch, HIVE-22577.2.patch,
> HIVE-22577.3.patch
>
>
> When the node name is "worker-" the following exception is thrown
>
> {code:java}
> Caused by: java.lang.StringIndexOutOfBoundsException: String index out of
> range: -1Caused by: java.lang.StringIndexOutOfBoundsException: String index
> out of range: -1 at java.lang.String.substring(String.java:1931) at
> org.apache.hadoop.hive.registry.impl.ZkRegistryBase.extractSeqNum(ZkRegistryBase.java:781)
> at
> org.apache.hadoop.hive.registry.impl.ZkRegistryBase.populateCache(ZkRegistryBase.java:507)
> at
> org.apache.hadoop.hive.llap.registry.impl.LlapZookeeperRegistryImpl.access$000(LlapZookeeperRegistryImpl.java:65)
> at
> org.apache.hadoop.hive.llap.registry.impl.LlapZookeeperRegistryImpl$DynamicServiceInstanceSet.(LlapZookeeperRegistryImpl.java:313)
> at
> org.apache.hadoop.hive.llap.registry.impl.LlapZookeeperRegistryImpl.getInstances(LlapZookeeperRegistryImpl.java:462)
> at
> org.apache.hadoop.hive.llap.registry.impl.LlapZookeeperRegistryImpl.getApplicationId(LlapZookeeperRegistryImpl.java:469)
> at
> org.apache.hadoop.hive.llap.registry.impl.LlapRegistryService.getApplicationId(LlapRegistryService.java:212)
> at
> org.apache.hadoop.hive.ql.exec.tez.Utils.getCustomSplitLocationProvider(Utils.java:77)
> at
> org.apache.hadoop.hive.ql.exec.tez.Utils.getSplitLocationProvider(Utils.java:53)
> at
> org.apache.hadoop.hive.ql.exec.tez.HiveSplitGenerator.(HiveSplitGenerator.java:140)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-22577) StringIndexOutOfBoundsException when getting sessionId from worker node name
[
https://issues.apache.org/jira/browse/HIVE-22577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Attila Magyar updated HIVE-22577:
-
Status: Open (was: Patch Available)
> StringIndexOutOfBoundsException when getting sessionId from worker node name
>
>
> Key: HIVE-22577
> URL: https://issues.apache.org/jira/browse/HIVE-22577
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Reporter: Attila Magyar
>Assignee: Attila Magyar
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-22577.1.patch, HIVE-22577.2.patch,
> HIVE-22577.3.patch
>
>
> When the node name is "worker-" the following exception is thrown
>
> {code:java}
> Caused by: java.lang.StringIndexOutOfBoundsException: String index out of
> range: -1Caused by: java.lang.StringIndexOutOfBoundsException: String index
> out of range: -1 at java.lang.String.substring(String.java:1931) at
> org.apache.hadoop.hive.registry.impl.ZkRegistryBase.extractSeqNum(ZkRegistryBase.java:781)
> at
> org.apache.hadoop.hive.registry.impl.ZkRegistryBase.populateCache(ZkRegistryBase.java:507)
> at
> org.apache.hadoop.hive.llap.registry.impl.LlapZookeeperRegistryImpl.access$000(LlapZookeeperRegistryImpl.java:65)
> at
> org.apache.hadoop.hive.llap.registry.impl.LlapZookeeperRegistryImpl$DynamicServiceInstanceSet.(LlapZookeeperRegistryImpl.java:313)
> at
> org.apache.hadoop.hive.llap.registry.impl.LlapZookeeperRegistryImpl.getInstances(LlapZookeeperRegistryImpl.java:462)
> at
> org.apache.hadoop.hive.llap.registry.impl.LlapZookeeperRegistryImpl.getApplicationId(LlapZookeeperRegistryImpl.java:469)
> at
> org.apache.hadoop.hive.llap.registry.impl.LlapRegistryService.getApplicationId(LlapRegistryService.java:212)
> at
> org.apache.hadoop.hive.ql.exec.tez.Utils.getCustomSplitLocationProvider(Utils.java:77)
> at
> org.apache.hadoop.hive.ql.exec.tez.Utils.getSplitLocationProvider(Utils.java:53)
> at
> org.apache.hadoop.hive.ql.exec.tez.HiveSplitGenerator.(HiveSplitGenerator.java:140)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-22641) Columns returned in sorted order when show columns query is run with no search pattern.
[
https://issues.apache.org/jira/browse/HIVE-22641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chiran Ravani updated HIVE-22641:
-
Priority: Major (was: Minor)
> Columns returned in sorted order when show columns query is run with no
> search pattern.
> ---
>
> Key: HIVE-22641
> URL: https://issues.apache.org/jira/browse/HIVE-22641
> Project: Hive
> Issue Type: Improvement
> Components: Hive, HiveServer2
>Affects Versions: 3.1.0
>Reporter: Chiran Ravani
>Priority: Major
> Attachments: HIVE-22641.patch
>
>
> In Hive 1.2.1 and 2.0 while displaying columns for a table, it used to return
> in same order as it was created. for example
> {code}
> create table col_order_test(server_name string, task_name string,
> partition_name string, start_time string, end_time string, table_owner
> string, table_name string) stored as orc;
> show columns in col_order_test;
> +-+--+
> | field |
> +-+--+
> | server_name |
> | task_name |
> | partition_name |
> | start_time |
> | end_time|
> | table_owner |
> | table_name |
> +-+--+
> {code}
> For Hive 3 columns are returned in sorted order for the same query, below is
> output.
> {code}
> create table col_order_test(server_name string, task_name string,
> partition_name string, start_time string, end_time string, table_owner
> string, table_name string) stored as orc;
> show columns in col_order_test;
> +-+
> | field |
> +-+
> | end_time|
> | partition_name |
> | server_name |
> | start_time |
> | table_name |
> | table_owner |
> | task_name |
> +-+
> {code}
> Above behavior looks to be changed with the introduction of search column
> feature as part of Jira [HIVE-18373
> |https://issues.apache.org/jira/browse/HIVE-18373]
> This behavior change can cause existing process to fail setup in a few
> environments, for example: code to generate the INSERT OVERWRITE in a
> different manner, which may result in query failure.
> I would like to request a community if we can improve the Jira [HIVE-18373
> |https://issues.apache.org/jira/browse/HIVE-18373] by returning column order
> same as it was created if the search pattern provided by the user is null.
> Attaching patch with the change.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22637) Avoid cost based rules during generating expressions from AST
[
https://issues.apache.org/jira/browse/HIVE-22637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995072#comment-16995072
]
Hive QA commented on HIVE-22637:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
42s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
30s{color} | {color:blue} ql in master has 1531 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
7s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
13s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
42s{color} | {color:red} ql: The patch generated 5 new + 88 unchanged - 0 fixed
= 93 total (was 88) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 27m 37s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19904/dev-support/hive-personality.sh
|
| git revision | master / 41b51fc |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-19904/yetus/diff-checkstyle-ql.txt
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-19904/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Avoid cost based rules during generating expressions from AST
> -
>
> Key: HIVE-22637
> URL: https://issues.apache.org/jira/browse/HIVE-22637
> Project: Hive
> Issue Type: Improvement
> Components: Query Planning
>Reporter: Vineet Garg
>Assignee: Vineet Garg
>Priority: Major
> Attachments: HIVE-22637.1.patch
>
>
> genExprNode uses default dispatcher which fire rules based on cost,
> computation of cost is expensive and is likely un-necessary.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-22568) Process compaction candidates in parallel by the Initiator
[ https://issues.apache.org/jira/browse/HIVE-22568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Denys Kuzmenko updated HIVE-22568: -- Attachment: HIVE-22568.7.patch > Process compaction candidates in parallel by the Initiator > -- > > Key: HIVE-22568 > URL: https://issues.apache.org/jira/browse/HIVE-22568 > Project: Hive > Issue Type: Improvement >Reporter: Denys Kuzmenko >Assignee: Denys Kuzmenko >Priority: Major > Attachments: HIVE-22568.1.patch, HIVE-22568.2.patch, > HIVE-22568.3.patch, HIVE-22568.4.patch, HIVE-22568.5.patch, > HIVE-22568.6.patch, HIVE-22568.7.patch > > > `checkForCompaction` includes many file metadata checks and may be expensive. > Therefore, make sense using a thread pool here and running > `checkForCompactions` in parallel. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22327) Repl: Ignore read-only transactions in notification log
[ https://issues.apache.org/jira/browse/HIVE-22327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Denys Kuzmenko updated HIVE-22327: -- Attachment: HIVE-22327.21.patch > Repl: Ignore read-only transactions in notification log > --- > > Key: HIVE-22327 > URL: https://issues.apache.org/jira/browse/HIVE-22327 > Project: Hive > Issue Type: Improvement > Components: repl >Reporter: Gopal Vijayaraghavan >Assignee: Denys Kuzmenko >Priority: Major > Attachments: HIVE-22327.1.patch, HIVE-22327.10.patch, > HIVE-22327.11.patch, HIVE-22327.12.patch, HIVE-22327.13.patch, > HIVE-22327.14.patch, HIVE-22327.15.patch, HIVE-22327.16.patch, > HIVE-22327.17.patch, HIVE-22327.18.patch, HIVE-22327.19.patch, > HIVE-22327.2.patch, HIVE-22327.20.patch, HIVE-22327.21.patch, > HIVE-22327.3.patch, HIVE-22327.4.patch, HIVE-22327.5.patch, > HIVE-22327.6.patch, HIVE-22327.7.patch, HIVE-22327.8.patch, HIVE-22327.9.patch > > > Read txns need not be replicated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22577) StringIndexOutOfBoundsException when getting sessionId from worker node name
[
https://issues.apache.org/jira/browse/HIVE-22577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995043#comment-16995043
]
Hive QA commented on HIVE-22577:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12988685/HIVE-22577.3.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17772 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[hybridgrace_hashjoin_2]
(batchId=112)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19903/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19903/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19903/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12988685 - PreCommit-HIVE-Build
> StringIndexOutOfBoundsException when getting sessionId from worker node name
>
>
> Key: HIVE-22577
> URL: https://issues.apache.org/jira/browse/HIVE-22577
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Reporter: Attila Magyar
>Assignee: Attila Magyar
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-22577.1.patch, HIVE-22577.2.patch,
> HIVE-22577.3.patch
>
>
> When the node name is "worker-" the following exception is thrown
>
> {code:java}
> Caused by: java.lang.StringIndexOutOfBoundsException: String index out of
> range: -1Caused by: java.lang.StringIndexOutOfBoundsException: String index
> out of range: -1 at java.lang.String.substring(String.java:1931) at
> org.apache.hadoop.hive.registry.impl.ZkRegistryBase.extractSeqNum(ZkRegistryBase.java:781)
> at
> org.apache.hadoop.hive.registry.impl.ZkRegistryBase.populateCache(ZkRegistryBase.java:507)
> at
> org.apache.hadoop.hive.llap.registry.impl.LlapZookeeperRegistryImpl.access$000(LlapZookeeperRegistryImpl.java:65)
> at
> org.apache.hadoop.hive.llap.registry.impl.LlapZookeeperRegistryImpl$DynamicServiceInstanceSet.(LlapZookeeperRegistryImpl.java:313)
> at
> org.apache.hadoop.hive.llap.registry.impl.LlapZookeeperRegistryImpl.getInstances(LlapZookeeperRegistryImpl.java:462)
> at
> org.apache.hadoop.hive.llap.registry.impl.LlapZookeeperRegistryImpl.getApplicationId(LlapZookeeperRegistryImpl.java:469)
> at
> org.apache.hadoop.hive.llap.registry.impl.LlapRegistryService.getApplicationId(LlapRegistryService.java:212)
> at
> org.apache.hadoop.hive.ql.exec.tez.Utils.getCustomSplitLocationProvider(Utils.java:77)
> at
> org.apache.hadoop.hive.ql.exec.tez.Utils.getSplitLocationProvider(Utils.java:53)
> at
> org.apache.hadoop.hive.ql.exec.tez.HiveSplitGenerator.(HiveSplitGenerator.java:140)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-22641) Columns returned in sorted order when show columns query is run with no search pattern.
[
https://issues.apache.org/jira/browse/HIVE-22641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chiran Ravani updated HIVE-22641:
-
Description:
In Hive 1.2.1 and 2.0 while displaying columns for a table, it used to return
in same order as it was created. for example
{code}
create table col_order_test(server_name string, task_name string,
partition_name string, start_time string, end_time string, table_owner string,
table_name string) stored as orc;
show columns in col_order_test;
+-+--+
| field |
+-+--+
| server_name |
| task_name |
| partition_name |
| start_time |
| end_time|
| table_owner |
| table_name |
+-+--+
{code}
For Hive 3 columns are returned in sorted order for the same query, below is
output.
{code}
create table col_order_test(server_name string, task_name string,
partition_name string, start_time string, end_time string, table_owner string,
table_name string) stored as orc;
show columns in col_order_test;
+-+
| field |
+-+
| end_time|
| partition_name |
| server_name |
| start_time |
| table_name |
| table_owner |
| task_name |
+-+
{code}
Above behavior looks to be changed with the introduction of search column
feature as part of Jira [HIVE-18373
|https://issues.apache.org/jira/browse/HIVE-18373]
This behavior change can cause existing process to fail setup in a few
environments, for example: code to generate the INSERT OVERWRITE in a different
manner, which may result in query failure.
I would like to request a community if we can improve the Jira [HIVE-18373
|https://issues.apache.org/jira/browse/HIVE-18373] by returning column order
same as it was created if the search pattern provided by the user is null.
Attaching patch with the change.
was:
In Hive 1.2.1 and 2.0 while displaying columns for a table, it used to return
in same order as it was created. for example
{code}
create table col_order_test(server_name string, task_name string,
partition_name string, start_time string, end_time string, table_owner string,
table_name string) stored as orc;
show columns in col_order_test;
+-+--+
| field |
+-+--+
| server_name |
| task_name |
| partition_name |
| start_time |
| end_time|
| table_owner |
| table_name |
+-+--+
{code}
For Hive 3 columns are returned in sorted order for the same query, below is
output.
{code}
create table col_order_test(server_name string, task_name string,
partition_name string, start_time string, end_time string, table_owner string,
table_name string) stored as orc;
show columns in col_order_test;
+-+
| field |
+-+
| end_time|
| partition_name |
| server_name |
| start_time |
| table_name |
| table_owner |
| task_name |
+-+
{code}
Above behavior looks to be changed with the introduction of search column
feature as part of Jira [HIVE-18373
|https://issues.apache.org/jira/browse/HIVE-18373]
This behavior change can cause code to generate the INSERT OVERWRITE in a
different manner, which may result in query failure.
I would like to request a community if we can improve the Jira [HIVE-18373
|https://issues.apache.org/jira/browse/HIVE-18373] by returning column order
same as it was created, if the search pattern provided by the user is null.
Attaching patch with the change.
> Columns returned in sorted order when show columns query is run with no
> search pattern.
> ---
>
> Key: HIVE-22641
> URL: https://issues.apache.org/jira/browse/HIVE-22641
> Project: Hive
> Issue Type: Improvement
> Components: Hive, HiveServer2
>Affects Versions: 3.1.0
>Reporter: Chiran Ravani
>Priority: Minor
> Attachments: HIVE-22641.patch
>
>
> In Hive 1.2.1 and 2.0 while displaying columns for a table, it used to return
> in same order as it was created. for example
> {code}
> create table col_order_test(server_name string, task_name string,
> partition_name string, start_time string, end_time string, table_owner
> string, table_name string) stored as orc;
> show columns in col_order_test;
> +-+--+
> | field |
> +-+--+
> | server_name |
> | task_name |
> | partition_name |
> | start_time |
> | end_time|
> | table_owner |
> | table_name |
> +-+--+
> {code}
> For Hive 3 columns are returned in sorted order for the same query, below is
> output.
> {code}
> create table col_order_test(server_name string, task_name string,
> partition_name string,
[jira] [Updated] (HIVE-22641) Columns returned in sorted order when show columns query is run with no search pattern.
[
https://issues.apache.org/jira/browse/HIVE-22641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chiran Ravani updated HIVE-22641:
-
Affects Version/s: 3.1.0
> Columns returned in sorted order when show columns query is run with no
> search pattern.
> ---
>
> Key: HIVE-22641
> URL: https://issues.apache.org/jira/browse/HIVE-22641
> Project: Hive
> Issue Type: Improvement
> Components: Hive, HiveServer2
>Affects Versions: 3.0.0, 3.1.0
>Reporter: Chiran Ravani
>Priority: Minor
> Attachments: HIVE-22641.patch
>
>
> In Hive 1.2.1 and 2.0 while displaying columns for a table, it used to return
> in same order as it was created. for example
> {code}
> create table col_order_test(server_name string, task_name string,
> partition_name string, start_time string, end_time string, table_owner
> string, table_name string) stored as orc;
> show columns in col_order_test;
> +-+--+
> | field |
> +-+--+
> | server_name |
> | task_name |
> | partition_name |
> | start_time |
> | end_time|
> | table_owner |
> | table_name |
> +-+--+
> {code}
> For Hive 3 columns are returned in sorted order for the same query, below is
> output.
> {code}
> create table col_order_test(server_name string, task_name string,
> partition_name string, start_time string, end_time string, table_owner
> string, table_name string) stored as orc;
> show columns in col_order_test;
> +-+
> | field |
> +-+
> | end_time|
> | partition_name |
> | server_name |
> | start_time |
> | table_name |
> | table_owner |
> | task_name |
> +-+
> {code}
> Above behavior looks to be changed with the introduction of search column
> feature as part of Jira [HIVE-18373
> |https://issues.apache.org/jira/browse/HIVE-18373]
> This behavior change can cause code to generate the INSERT OVERWRITE in a
> different manner, which may result in query failure.
> I would like to request a community if we can improve the Jira [HIVE-18373
> |https://issues.apache.org/jira/browse/HIVE-18373] by returning column order
> same as it was created, if the search pattern provided by the user is null.
> Attaching patch with the change.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-22641) Columns returned in sorted order when show columns query is run with no search pattern.
[
https://issues.apache.org/jira/browse/HIVE-22641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chiran Ravani updated HIVE-22641:
-
Affects Version/s: (was: 3.0.0)
> Columns returned in sorted order when show columns query is run with no
> search pattern.
> ---
>
> Key: HIVE-22641
> URL: https://issues.apache.org/jira/browse/HIVE-22641
> Project: Hive
> Issue Type: Improvement
> Components: Hive, HiveServer2
>Affects Versions: 3.1.0
>Reporter: Chiran Ravani
>Priority: Minor
> Attachments: HIVE-22641.patch
>
>
> In Hive 1.2.1 and 2.0 while displaying columns for a table, it used to return
> in same order as it was created. for example
> {code}
> create table col_order_test(server_name string, task_name string,
> partition_name string, start_time string, end_time string, table_owner
> string, table_name string) stored as orc;
> show columns in col_order_test;
> +-+--+
> | field |
> +-+--+
> | server_name |
> | task_name |
> | partition_name |
> | start_time |
> | end_time|
> | table_owner |
> | table_name |
> +-+--+
> {code}
> For Hive 3 columns are returned in sorted order for the same query, below is
> output.
> {code}
> create table col_order_test(server_name string, task_name string,
> partition_name string, start_time string, end_time string, table_owner
> string, table_name string) stored as orc;
> show columns in col_order_test;
> +-+
> | field |
> +-+
> | end_time|
> | partition_name |
> | server_name |
> | start_time |
> | table_name |
> | table_owner |
> | task_name |
> +-+
> {code}
> Above behavior looks to be changed with the introduction of search column
> feature as part of Jira [HIVE-18373
> |https://issues.apache.org/jira/browse/HIVE-18373]
> This behavior change can cause code to generate the INSERT OVERWRITE in a
> different manner, which may result in query failure.
> I would like to request a community if we can improve the Jira [HIVE-18373
> |https://issues.apache.org/jira/browse/HIVE-18373] by returning column order
> same as it was created, if the search pattern provided by the user is null.
> Attaching patch with the change.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-22641) Columns returned in sorted order when show columns query is run with no search pattern.
[
https://issues.apache.org/jira/browse/HIVE-22641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chiran Ravani updated HIVE-22641:
-
Description:
In Hive 1.2.1 and 2.0 while displaying columns for a table, it used to return
in same order as it was created. for example
{code}
create table col_order_test(server_name string, task_name string,
partition_name string, start_time string, end_time string, table_owner string,
table_name string) stored as orc;
show columns in col_order_test;
+-+--+
| field |
+-+--+
| server_name |
| task_name |
| partition_name |
| start_time |
| end_time|
| table_owner |
| table_name |
+-+--+
{code}
For Hive 3 columns are returned in sorted order for the same query, below is
output.
{code}
create table col_order_test(server_name string, task_name string,
partition_name string, start_time string, end_time string, table_owner string,
table_name string) stored as orc;
show columns in col_order_test;
+-+
| field |
+-+
| end_time|
| partition_name |
| server_name |
| start_time |
| table_name |
| table_owner |
| task_name |
+-+
{code}
Above behavior looks to be changed with the introduction of search column
feature as part of Jira [HIVE-18373
|https://issues.apache.org/jira/browse/HIVE-18373]
This behavior change can cause code to generate the INSERT OVERWRITE in a
different manner, which may result in query failure.
I would like to request a community if we can improve the Jira [HIVE-18373
|https://issues.apache.org/jira/browse/HIVE-18373] by returning column order
same as it was created, if the search pattern provided by the user is null.
Attaching patch with the change.
was:
In Hive 1.2.1 and 2.0 while displaying columns for a table, it used to return
in same order as it was created. for example
{code}
create table col_order_test(server_name string, task_name string,
partition_name string, start_time string, end_time string, table_owner string,
table_name string) stored as orc;
show columns in col_order_test;
+-+--+
| field |
+-+--+
| server_name |
| task_name |
| partition_name |
| start_time |
| end_time|
| table_owner |
| table_name |
+-+--+
{code}
For Hive 3 columns are returned in sorted order for the same query, below is
output.
{code}
create table col_order_test(server_name string, task_name string,
partition_name string, start_time string, end_time string, table_owner string,
table_name string) stored as orc;
show columns in col_order_test;
+-+
| field |
+-+
| end_time|
| partition_name |
| server_name |
| start_time |
| table_name |
| table_owner |
| task_name |
+-+
{code}
Above behaviour looks to be changed with the introduction of search column
feature as part of Jira [HIVE-18373
|https://issues.apache.org/jira/browse/HIVE-18373]
This behaviour change can cause code to generate the INSERT OVERWRITE in a
different manner, which may result in query failure.
Would like to request community if we can improve the Jira [HIVE-18373
|https://issues.apache.org/jira/browse/HIVE-18373] by returning column order
same as it was created if search pattern provided by the user is null.
> Columns returned in sorted order when show columns query is run with no
> search pattern.
> ---
>
> Key: HIVE-22641
> URL: https://issues.apache.org/jira/browse/HIVE-22641
> Project: Hive
> Issue Type: Improvement
> Components: Hive, HiveServer2
>Affects Versions: 3.0.0
>Reporter: Chiran Ravani
>Priority: Minor
> Attachments: HIVE-22641.patch
>
>
> In Hive 1.2.1 and 2.0 while displaying columns for a table, it used to return
> in same order as it was created. for example
> {code}
> create table col_order_test(server_name string, task_name string,
> partition_name string, start_time string, end_time string, table_owner
> string, table_name string) stored as orc;
> show columns in col_order_test;
> +-+--+
> | field |
> +-+--+
> | server_name |
> | task_name |
> | partition_name |
> | start_time |
> | end_time|
> | table_owner |
> | table_name |
> +-+--+
> {code}
> For Hive 3 columns are returned in sorted order for the same query, below is
> output.
> {code}
> create table col_order_test(server_name string, task_name string,
> partition_name string, start_time string, end_time string, table_owner
> string, table_name string) stored as orc;
> show columns in
[jira] [Updated] (HIVE-22641) Columns returned in sorted order when show columns query is run with no search pattern.
[
https://issues.apache.org/jira/browse/HIVE-22641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chiran Ravani updated HIVE-22641:
-
Attachment: HIVE-22641.patch
> Columns returned in sorted order when show columns query is run with no
> search pattern.
> ---
>
> Key: HIVE-22641
> URL: https://issues.apache.org/jira/browse/HIVE-22641
> Project: Hive
> Issue Type: Improvement
> Components: Hive, HiveServer2
>Affects Versions: 3.0.0
>Reporter: Chiran Ravani
>Priority: Minor
> Attachments: HIVE-22641.patch
>
>
> In Hive 1.2.1 and 2.0 while displaying columns for a table, it used to return
> in same order as it was created. for example
> {code}
> create table col_order_test(server_name string, task_name string,
> partition_name string, start_time string, end_time string, table_owner
> string, table_name string) stored as orc;
> show columns in col_order_test;
> +-+--+
> | field |
> +-+--+
> | server_name |
> | task_name |
> | partition_name |
> | start_time |
> | end_time|
> | table_owner |
> | table_name |
> +-+--+
> {code}
> For Hive 3 columns are returned in sorted order for the same query, below is
> output.
> {code}
> create table col_order_test(server_name string, task_name string,
> partition_name string, start_time string, end_time string, table_owner
> string, table_name string) stored as orc;
> show columns in col_order_test;
> +-+
> | field |
> +-+
> | end_time|
> | partition_name |
> | server_name |
> | start_time |
> | table_name |
> | table_owner |
> | task_name |
> +-+
> {code}
> Above behaviour looks to be changed with the introduction of search column
> feature as part of Jira [HIVE-18373
> |https://issues.apache.org/jira/browse/HIVE-18373]
> This behaviour change can cause code to generate the INSERT OVERWRITE in a
> different manner, which may result in query failure.
> Would like to request community if we can improve the Jira [HIVE-18373
> |https://issues.apache.org/jira/browse/HIVE-18373] by returning column order
> same as it was created if search pattern provided by the user is null.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22577) StringIndexOutOfBoundsException when getting sessionId from worker node name
[
https://issues.apache.org/jira/browse/HIVE-22577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16994976#comment-16994976
]
Hive QA commented on HIVE-22577:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
25s{color} | {color:blue} llap-client in master has 27 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
13s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
13s{color} | {color:red} llap-client: The patch generated 3 new + 40 unchanged
- 3 fixed = 43 total (was 43) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
11s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
16s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 13m 16s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19903/dev-support/hive-personality.sh
|
| git revision | master / 41b51fc |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-19903/yetus/diff-checkstyle-llap-client.txt
|
| modules | C: llap-client U: llap-client |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-19903/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> StringIndexOutOfBoundsException when getting sessionId from worker node name
>
>
> Key: HIVE-22577
> URL: https://issues.apache.org/jira/browse/HIVE-22577
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Reporter: Attila Magyar
>Assignee: Attila Magyar
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-22577.1.patch, HIVE-22577.2.patch,
> HIVE-22577.3.patch
>
>
> When the node name is "worker-" the following exception is thrown
>
> {code:java}
> Caused by: java.lang.StringIndexOutOfBoundsException: String index out of
> range: -1Caused by: java.lang.StringIndexOutOfBoundsException: String index
> out of range: -1 at java.lang.String.substring(String.java:1931) at
> org.apache.hadoop.hive.registry.impl.ZkRegistryBase.extractSeqNum(ZkRegistryBase.java:781)
> at
> org.apache.hadoop.hive.registry.impl.ZkRegistryBase.populateCache(ZkRegistryBase.java:507)
> at
> org.apache.hadoop.hive.llap.registry.impl.LlapZookeeperRegistryImpl.access$000(LlapZookeeperRegistryImpl.java:65)
> at
> org.apache.hadoop.hive.llap.registry.impl.LlapZookeeperRegistryImpl$DynamicServiceInstanceSet.(LlapZookeeperRegistryImpl.java:313)
> at
> org.apache.hadoop.hive.llap.registry.impl.LlapZookeeperRegistryImpl.getInstances(LlapZookeeperRegistryImpl.java:462)
> at
>
[jira] [Commented] (HIVE-22617) Re-Enable PreCommit test org.apache.hadoop.hive.ql.TestMTQueries.testMTQueries1
[
https://issues.apache.org/jira/browse/HIVE-22617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16994955#comment-16994955
]
Hive QA commented on HIVE-22617:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12988661/HIVE-22617.01.patch
{color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 17773 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19901/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19901/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19901/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12988661 - PreCommit-HIVE-Build
> Re-Enable PreCommit test
> org.apache.hadoop.hive.ql.TestMTQueries.testMTQueries1
> ---
>
> Key: HIVE-22617
> URL: https://issues.apache.org/jira/browse/HIVE-22617
> Project: Hive
> Issue Type: Sub-task
>Reporter: Oliver Draese
>Assignee: László Bodor
>Priority: Major
> Attachments: HIVE-22617.01.patch, HIVE-22617.01.patch, hive.log,
> initialize.log
>
>
> The test was disabled via HIVE-22616 because it was flaky. If the test is
> considered valid, it needs to be fixed and re-enabled.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-22536) Improve return path enabling/disabling
[ https://issues.apache.org/jira/browse/HIVE-22536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HIVE-22536: -- Labels: pull-request-available (was: ) > Improve return path enabling/disabling > -- > > Key: HIVE-22536 > URL: https://issues.apache.org/jira/browse/HIVE-22536 > Project: Hive > Issue Type: Sub-task > Components: Hive >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22536.01.patch, HIVE-22536.02.patch, > HIVE-22536.03.patch > > > Instead of having a boolean for hive.cbo.returnpath.hiveop it should be > on/off/supported. In case of "supported" it should be used for a subset of > commands which are already verified to be able to work with return path. This > is a temporary solution for the time while we are developing return path, > before making it the only way to handle commands. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-22536) Improve return path enabling/disabling
[ https://issues.apache.org/jira/browse/HIVE-22536?focusedWorklogId=358848=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-358848 ] ASF GitHub Bot logged work on HIVE-22536: - Author: ASF GitHub Bot Created on: 12/Dec/19 18:46 Start Date: 12/Dec/19 18:46 Worklog Time Spent: 10m Work Description: miklosgergely commented on pull request #866: HIVE-22536 Improve return path enabling/disabling URL: https://github.com/apache/hive/pull/866 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 358848) Remaining Estimate: 0h Time Spent: 10m > Improve return path enabling/disabling > -- > > Key: HIVE-22536 > URL: https://issues.apache.org/jira/browse/HIVE-22536 > Project: Hive > Issue Type: Sub-task > Components: Hive >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22536.01.patch, HIVE-22536.02.patch, > HIVE-22536.03.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Instead of having a boolean for hive.cbo.returnpath.hiveop it should be > on/off/supported. In case of "supported" it should be used for a subset of > commands which are already verified to be able to work with return path. This > is a temporary solution for the time while we are developing return path, > before making it the only way to handle commands. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-17680) TestNegativeCliDriver[merge_negative_5.q]
[
https://issues.apache.org/jira/browse/HIVE-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16994949#comment-16994949
]
Zoltan Haindrich commented on HIVE-17680:
-
\+1
> TestNegativeCliDriver[merge_negative_5.q]
> -
>
> Key: HIVE-17680
> URL: https://issues.apache.org/jira/browse/HIVE-17680
> Project: Hive
> Issue Type: Sub-task
>Reporter: Vihang Karajgaonkar
>Assignee: László Bodor
>Priority: Major
> Attachments: HIVE-17680.01.branch-2.patch
>
>
> Seeing this error stack in the hive.log when I run it locally
> Test failed in
> https://builds.apache.org/job/PreCommit-HIVE-Build/7083/testReport
> {noformat}
> 2017-10-03T10:34:59,335 ERROR [d6419a0a-1fc9-4454-9575-f085c7f2cb55 main]
> metastore.RetryingHMSHandler: MetaException(message:The table must be
> bucketed and stored using an ACID compliant format (such as ORC))
> at
> org.apache.hadoop.hive.metastore.TransactionalValidationListener.handleCreateTableTransactionalProp(TransactionalValidationListener.java:199)
> at
> org.apache.hadoop.hive.metastore.TransactionalValidationListener.handle(TransactionalValidationListener.java:68)
> at
> org.apache.hadoop.hive.metastore.TransactionalValidationListener.onEvent(TransactionalValidationListener.java:53)
> at
> org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.firePreEvent(HiveMetaStore.java:2290)
> at
> org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.create_table_core(HiveMetaStore.java:1413)
> at
> org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.create_table_with_environment_context(HiveMetaStore.java:1511)
> at sun.reflect.GeneratedMethodAccessor56.invoke(Unknown Source)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.hadoop.hive.metastore.RetryingHMSHandler.invokeInternal(RetryingHMSHandler.java:148)
> at
> org.apache.hadoop.hive.metastore.RetryingHMSHandler.invoke(RetryingHMSHandler.java:107)
> at
> com.sun.proxy.$Proxy34.create_table_with_environment_context(Unknown Source)
> at
> org.apache.hadoop.hive.metastore.HiveMetaStoreClient.create_table_with_environment_context(HiveMetaStoreClient.java:2407)
> at
> org.apache.hadoop.hive.ql.metadata.SessionHiveMetaStoreClient.create_table_with_environment_context(SessionHiveMetaStoreClient.java:93)
> at
> org.apache.hadoop.hive.metastore.HiveMetaStoreClient.createTable(HiveMetaStoreClient.java:760)
> at
> org.apache.hadoop.hive.metastore.HiveMetaStoreClient.createTable(HiveMetaStoreClient.java:748)
> at sun.reflect.GeneratedMethodAccessor55.invoke(Unknown Source)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.hadoop.hive.metastore.RetryingMetaStoreClient.invoke(RetryingMetaStoreClient.java:173)
> at com.sun.proxy.$Proxy35.createTable(Unknown Source)
> at org.apache.hadoop.hive.ql.metadata.Hive.createTable(Hive.java:852)
> at org.apache.hadoop.hive.ql.metadata.Hive.createTable(Hive.java:867)
> at
> org.apache.hadoop.hive.ql.exec.DDLTask.createTable(DDLTask.java:4376)
> at org.apache.hadoop.hive.ql.exec.DDLTask.execute(DDLTask.java:354)
> at org.apache.hadoop.hive.ql.exec.Task.executeTask(Task.java:199)
> at
> org.apache.hadoop.hive.ql.exec.TaskRunner.runSequential(TaskRunner.java:100)
> at org.apache.hadoop.hive.ql.Driver.launchTask(Driver.java:2183)
> at org.apache.hadoop.hive.ql.Driver.execute(Driver.java:1839)
> at org.apache.hadoop.hive.ql.Driver.runInternal(Driver.java:1526)
> at org.apache.hadoop.hive.ql.Driver.run(Driver.java:1237)
> at org.apache.hadoop.hive.ql.Driver.run(Driver.java:1227)
> at
> org.apache.hadoop.hive.cli.CliDriver.processLocalCmd(CliDriver.java:233)
> at org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:184)
> at
> org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:403)
> at
> org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:336)
> at
> org.apache.hadoop.hive.ql.QTestUtil.executeClientInternal(QTestUtil.java:1337)
> at
> org.apache.hadoop.hive.ql.QTestUtil.executeClient(QTestUtil.java:1311)
> at
> org.apache.hadoop.hive.cli.control.CoreNegativeCliDriver.runTest(CoreNegativeCliDriver.java:121)
> at
> org.apache.hadoop.hive.cli.control.CliAdapter.runTest(CliAdapter.java:104)
> at
> org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver(TestNegativeCliDriver.java:59)
>
[jira] [Commented] (HIVE-22617) Re-Enable PreCommit test org.apache.hadoop.hive.ql.TestMTQueries.testMTQueries1
[
https://issues.apache.org/jira/browse/HIVE-22617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16994910#comment-16994910
]
Hive QA commented on HIVE-22617:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m
21s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
34s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
55s{color} | {color:blue} itests/util in master has 53 extant Findbugs
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
46s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
40s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 22m 31s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19901/dev-support/hive-personality.sh
|
| git revision | master / 41b51fc |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| modules | C: itests/util itests/hive-unit U: itests |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-19901/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Re-Enable PreCommit test
> org.apache.hadoop.hive.ql.TestMTQueries.testMTQueries1
> ---
>
> Key: HIVE-22617
> URL: https://issues.apache.org/jira/browse/HIVE-22617
> Project: Hive
> Issue Type: Sub-task
>Reporter: Oliver Draese
>Assignee: László Bodor
>Priority: Major
> Attachments: HIVE-22617.01.patch, HIVE-22617.01.patch, hive.log,
> initialize.log
>
>
> The test was disabled via HIVE-22616 because it was flaky. If the test is
> considered valid, it needs to be fixed and re-enabled.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-17680) TestNegativeCliDriver[merge_negative_5.q]
[
https://issues.apache.org/jira/browse/HIVE-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16994900#comment-16994900
]
László Bodor commented on HIVE-17680:
-
[~kgyrtkirk]: could you please take a look?
> TestNegativeCliDriver[merge_negative_5.q]
> -
>
> Key: HIVE-17680
> URL: https://issues.apache.org/jira/browse/HIVE-17680
> Project: Hive
> Issue Type: Sub-task
>Reporter: Vihang Karajgaonkar
>Assignee: László Bodor
>Priority: Major
> Attachments: HIVE-17680.01.branch-2.patch
>
>
> Seeing this error stack in the hive.log when I run it locally
> Test failed in
> https://builds.apache.org/job/PreCommit-HIVE-Build/7083/testReport
> {noformat}
> 2017-10-03T10:34:59,335 ERROR [d6419a0a-1fc9-4454-9575-f085c7f2cb55 main]
> metastore.RetryingHMSHandler: MetaException(message:The table must be
> bucketed and stored using an ACID compliant format (such as ORC))
> at
> org.apache.hadoop.hive.metastore.TransactionalValidationListener.handleCreateTableTransactionalProp(TransactionalValidationListener.java:199)
> at
> org.apache.hadoop.hive.metastore.TransactionalValidationListener.handle(TransactionalValidationListener.java:68)
> at
> org.apache.hadoop.hive.metastore.TransactionalValidationListener.onEvent(TransactionalValidationListener.java:53)
> at
> org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.firePreEvent(HiveMetaStore.java:2290)
> at
> org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.create_table_core(HiveMetaStore.java:1413)
> at
> org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.create_table_with_environment_context(HiveMetaStore.java:1511)
> at sun.reflect.GeneratedMethodAccessor56.invoke(Unknown Source)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.hadoop.hive.metastore.RetryingHMSHandler.invokeInternal(RetryingHMSHandler.java:148)
> at
> org.apache.hadoop.hive.metastore.RetryingHMSHandler.invoke(RetryingHMSHandler.java:107)
> at
> com.sun.proxy.$Proxy34.create_table_with_environment_context(Unknown Source)
> at
> org.apache.hadoop.hive.metastore.HiveMetaStoreClient.create_table_with_environment_context(HiveMetaStoreClient.java:2407)
> at
> org.apache.hadoop.hive.ql.metadata.SessionHiveMetaStoreClient.create_table_with_environment_context(SessionHiveMetaStoreClient.java:93)
> at
> org.apache.hadoop.hive.metastore.HiveMetaStoreClient.createTable(HiveMetaStoreClient.java:760)
> at
> org.apache.hadoop.hive.metastore.HiveMetaStoreClient.createTable(HiveMetaStoreClient.java:748)
> at sun.reflect.GeneratedMethodAccessor55.invoke(Unknown Source)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.hadoop.hive.metastore.RetryingMetaStoreClient.invoke(RetryingMetaStoreClient.java:173)
> at com.sun.proxy.$Proxy35.createTable(Unknown Source)
> at org.apache.hadoop.hive.ql.metadata.Hive.createTable(Hive.java:852)
> at org.apache.hadoop.hive.ql.metadata.Hive.createTable(Hive.java:867)
> at
> org.apache.hadoop.hive.ql.exec.DDLTask.createTable(DDLTask.java:4376)
> at org.apache.hadoop.hive.ql.exec.DDLTask.execute(DDLTask.java:354)
> at org.apache.hadoop.hive.ql.exec.Task.executeTask(Task.java:199)
> at
> org.apache.hadoop.hive.ql.exec.TaskRunner.runSequential(TaskRunner.java:100)
> at org.apache.hadoop.hive.ql.Driver.launchTask(Driver.java:2183)
> at org.apache.hadoop.hive.ql.Driver.execute(Driver.java:1839)
> at org.apache.hadoop.hive.ql.Driver.runInternal(Driver.java:1526)
> at org.apache.hadoop.hive.ql.Driver.run(Driver.java:1237)
> at org.apache.hadoop.hive.ql.Driver.run(Driver.java:1227)
> at
> org.apache.hadoop.hive.cli.CliDriver.processLocalCmd(CliDriver.java:233)
> at org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:184)
> at
> org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:403)
> at
> org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:336)
> at
> org.apache.hadoop.hive.ql.QTestUtil.executeClientInternal(QTestUtil.java:1337)
> at
> org.apache.hadoop.hive.ql.QTestUtil.executeClient(QTestUtil.java:1311)
> at
> org.apache.hadoop.hive.cli.control.CoreNegativeCliDriver.runTest(CoreNegativeCliDriver.java:121)
> at
> org.apache.hadoop.hive.cli.control.CliAdapter.runTest(CliAdapter.java:104)
> at
>
[jira] [Updated] (HIVE-20972) Enable TestMiniLlapLocalCliDriver cbo_limit and cbo_rp_limit
[ https://issues.apache.org/jira/browse/HIVE-20972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich updated HIVE-20972: Attachment: HIVE-20972.03.patch > Enable TestMiniLlapLocalCliDriver cbo_limit and cbo_rp_limit > > > Key: HIVE-20972 > URL: https://issues.apache.org/jira/browse/HIVE-20972 > Project: Hive > Issue Type: Test >Reporter: Vihang Karajgaonkar >Assignee: Zoltan Haindrich >Priority: Major > Attachments: HIVE-20972.01.patch, HIVE-20972.02.patch, > HIVE-20972.02.patch, HIVE-20972.03.patch, HIVE-20972.03.patch, > HIVE-20972.03.patch, HIVE-20972.03.patch, HIVE-20972.03.patch, > HIVE-20972.03.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22640) Decimal64ColumnVector: ClassCastException when partition column type is Decimal
[
https://issues.apache.org/jira/browse/HIVE-22640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16994889#comment-16994889
]
Denys Kuzmenko commented on HIVE-22640:
---
[~prasanth_j] could you please take a look.
> Decimal64ColumnVector: ClassCastException when partition column type is
> Decimal
> ---
>
> Key: HIVE-22640
> URL: https://issues.apache.org/jira/browse/HIVE-22640
> Project: Hive
> Issue Type: Bug
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22640.1.patch
>
>
> Problem statement:
> {code}
> CREATE EXTERNAL TABLE output (id DECIMAL(4,0), foo VARCHAR(10))
> PARTITIONED BY (nr_bank *decimal*(4,0))
> STORED AS ORC TBLPROPERTIES ('orc.compress'='ZLIB')
> insert into output PARTITION (nr_bank=88) values (1,'test');
> insert into output PARTITION (nr_bank=8801) values (1,'8801');
> select count(*), nr_bank from sdlint.output group by nr_bank;
> {code}
> The above query fails with:
> {code}
> Caused by: java.lang.ClassCastException:
> org.apache.hadoop.hive.ql.exec.vector.DecimalColumnVector cannot be cast to
> org.apache.hadoop.hive.ql.exec.vector.LongColumnVector
> at
> org.apache.hadoop.hive.ql.exec.vector.expressions.FuncLongToDecimal.evaluate(FuncLongToDecimal.java:58)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-22640) Decimal64ColumnVector: ClassCastException when partition column type is Decimal
[
https://issues.apache.org/jira/browse/HIVE-22640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Denys Kuzmenko updated HIVE-22640:
--
Attachment: HIVE-22640.1.patch
> Decimal64ColumnVector: ClassCastException when partition column type is
> Decimal
> ---
>
> Key: HIVE-22640
> URL: https://issues.apache.org/jira/browse/HIVE-22640
> Project: Hive
> Issue Type: Bug
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22640.1.patch
>
>
> Problem statement:
> {code}
> CREATE EXTERNAL TABLE output (id DECIMAL(4,0), foo VARCHAR(10))
> PARTITIONED BY (nr_bank *decimal*(4,0))
> STORED AS ORC TBLPROPERTIES ('orc.compress'='ZLIB')
> insert into output PARTITION (nr_bank=88) values (1,'test');
> insert into output PARTITION (nr_bank=8801) values (1,'8801');
> select count(*), nr_bank from sdlint.output group by nr_bank;
> {code}
> The above query fails with:
> {code}
> Caused by: java.lang.ClassCastException:
> org.apache.hadoop.hive.ql.exec.vector.DecimalColumnVector cannot be cast to
> org.apache.hadoop.hive.ql.exec.vector.LongColumnVector
> at
> org.apache.hadoop.hive.ql.exec.vector.expressions.FuncLongToDecimal.evaluate(FuncLongToDecimal.java:58)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-22640) Decimal64ColumnVector: ClassCastException when partition column type is Decimal
[
https://issues.apache.org/jira/browse/HIVE-22640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Denys Kuzmenko updated HIVE-22640:
--
Status: Patch Available (was: Open)
> Decimal64ColumnVector: ClassCastException when partition column type is
> Decimal
> ---
>
> Key: HIVE-22640
> URL: https://issues.apache.org/jira/browse/HIVE-22640
> Project: Hive
> Issue Type: Bug
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22640.1.patch
>
>
> Problem statement:
> {code}
> CREATE EXTERNAL TABLE output (id DECIMAL(4,0), foo VARCHAR(10))
> PARTITIONED BY (nr_bank *decimal*(4,0))
> STORED AS ORC TBLPROPERTIES ('orc.compress'='ZLIB')
> insert into output PARTITION (nr_bank=88) values (1,'test');
> insert into output PARTITION (nr_bank=8801) values (1,'8801');
> select count(*), nr_bank from sdlint.output group by nr_bank;
> {code}
> The above query fails with:
> {code}
> Caused by: java.lang.ClassCastException:
> org.apache.hadoop.hive.ql.exec.vector.DecimalColumnVector cannot be cast to
> org.apache.hadoop.hive.ql.exec.vector.LongColumnVector
> at
> org.apache.hadoop.hive.ql.exec.vector.expressions.FuncLongToDecimal.evaluate(FuncLongToDecimal.java:58)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-20972) Enable TestMiniLlapLocalCliDriver cbo_limit and cbo_rp_limit
[
https://issues.apache.org/jira/browse/HIVE-20972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16994886#comment-16994886
]
Hive QA commented on HIVE-20972:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12988650/HIVE-20972.03.patch
{color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 6 failed/errored test(s), 17774 tests
executed
*Failed tests:*
{noformat}
org.apache.hive.jdbc.TestJdbcWithMiniLlapRow.testComplexQuery (batchId=286)
org.apache.hive.jdbc.TestJdbcWithMiniLlapRow.testDataTypes (batchId=286)
org.apache.hive.jdbc.TestJdbcWithMiniLlapRow.testEscapedStrings (batchId=286)
org.apache.hive.jdbc.TestJdbcWithMiniLlapRow.testKillQuery (batchId=286)
org.apache.hive.jdbc.TestJdbcWithMiniLlapRow.testLlapInputFormatEndToEnd
(batchId=286)
org.apache.hive.jdbc.TestJdbcWithMiniLlapRow.testNonAsciiStrings (batchId=286)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19900/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19900/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19900/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 6 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12988650 - PreCommit-HIVE-Build
> Enable TestMiniLlapLocalCliDriver cbo_limit and cbo_rp_limit
>
>
> Key: HIVE-20972
> URL: https://issues.apache.org/jira/browse/HIVE-20972
> Project: Hive
> Issue Type: Test
>Reporter: Vihang Karajgaonkar
>Assignee: Zoltan Haindrich
>Priority: Major
> Attachments: HIVE-20972.01.patch, HIVE-20972.02.patch,
> HIVE-20972.02.patch, HIVE-20972.03.patch, HIVE-20972.03.patch,
> HIVE-20972.03.patch, HIVE-20972.03.patch, HIVE-20972.03.patch
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-22640) Decimal64ColumnVector: ClassCastException when partition column type is Decimal
[
https://issues.apache.org/jira/browse/HIVE-22640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Denys Kuzmenko updated HIVE-22640:
--
Description:
Problem statement:
{code}
CREATE EXTERNAL TABLE output (id DECIMAL(4,0), foo VARCHAR(10))
PARTITIONED BY (nr_bank *decimal*(4,0))
STORED AS ORC TBLPROPERTIES ('orc.compress'='ZLIB')
insert into output PARTITION (nr_bank=88) values (1,'test');
insert into output PARTITION (nr_bank=8801) values (1,'8801');
select count(*), nr_bank from sdlint.output group by nr_bank;
{code}
The above query fails with:
{code}
Caused by: java.lang.ClassCastException:
org.apache.hadoop.hive.ql.exec.vector.DecimalColumnVector cannot be cast to
org.apache.hadoop.hive.ql.exec.vector.LongColumnVector
at
org.apache.hadoop.hive.ql.exec.vector.expressions.FuncLongToDecimal.evaluate(FuncLongToDecimal.java:58)
{code}
was:
{code}
CREATE EXTERNAL TABLE output (id DECIMAL(4,0), foo VARCHAR(10))
PARTITIONED BY (nr_bank *decimal*(4,0))
STORED AS ORC TBLPROPERTIES ('orc.compress'='ZLIB')
insert into output PARTITION (nr_bank=88) values (1,'test');
insert into output PARTITION (nr_bank=8801) values (1,'8801');
select count(*), nr_bank from sdlint.output group by nr_bank;
{code}
The above query fails with:
{code}
Caused by: java.lang.ClassCastException:
org.apache.hadoop.hive.ql.exec.vector.DecimalColumnVector cannot be cast to
org.apache.hadoop.hive.ql.exec.vector.LongColumnVector
at
org.apache.hadoop.hive.ql.exec.vector.expressions.FuncLongToDecimal.evaluate(FuncLongToDecimal.java:58)
{code}
> Decimal64ColumnVector: ClassCastException when partition column type is
> Decimal
> ---
>
> Key: HIVE-22640
> URL: https://issues.apache.org/jira/browse/HIVE-22640
> Project: Hive
> Issue Type: Bug
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
>
> Problem statement:
> {code}
> CREATE EXTERNAL TABLE output (id DECIMAL(4,0), foo VARCHAR(10))
> PARTITIONED BY (nr_bank *decimal*(4,0))
> STORED AS ORC TBLPROPERTIES ('orc.compress'='ZLIB')
> insert into output PARTITION (nr_bank=88) values (1,'test');
> insert into output PARTITION (nr_bank=8801) values (1,'8801');
> select count(*), nr_bank from sdlint.output group by nr_bank;
> {code}
> The above query fails with:
> {code}
> Caused by: java.lang.ClassCastException:
> org.apache.hadoop.hive.ql.exec.vector.DecimalColumnVector cannot be cast to
> org.apache.hadoop.hive.ql.exec.vector.LongColumnVector
> at
> org.apache.hadoop.hive.ql.exec.vector.expressions.FuncLongToDecimal.evaluate(FuncLongToDecimal.java:58)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-22640) Decimal64ColumnVector: ClassCastException when partition column type is Decimal
[
https://issues.apache.org/jira/browse/HIVE-22640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Denys Kuzmenko updated HIVE-22640:
--
Description:
{code}
CREATE EXTERNAL TABLE output (id DECIMAL(4,0), foo VARCHAR(10))
PARTITIONED BY (nr_bank *decimal*(4,0))
STORED AS ORC TBLPROPERTIES ('orc.compress'='ZLIB')
insert into output PARTITION (nr_bank=88) values (1,'test');
insert into output PARTITION (nr_bank=8801) values (1,'8801');
select count(*), nr_bank from sdlint.output group by nr_bank;
{code}
The above query fails with:
{code}
Caused by: java.lang.ClassCastException:
org.apache.hadoop.hive.ql.exec.vector.DecimalColumnVector cannot be cast to
org.apache.hadoop.hive.ql.exec.vector.LongColumnVector
at
org.apache.hadoop.hive.ql.exec.vector.expressions.FuncLongToDecimal.evaluate(FuncLongToDecimal.java:58)
{code}
> Decimal64ColumnVector: ClassCastException when partition column type is
> Decimal
> ---
>
> Key: HIVE-22640
> URL: https://issues.apache.org/jira/browse/HIVE-22640
> Project: Hive
> Issue Type: Bug
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
>
> {code}
> CREATE EXTERNAL TABLE output (id DECIMAL(4,0), foo VARCHAR(10))
> PARTITIONED BY (nr_bank *decimal*(4,0))
> STORED AS ORC TBLPROPERTIES ('orc.compress'='ZLIB')
> insert into output PARTITION (nr_bank=88) values (1,'test');
> insert into output PARTITION (nr_bank=8801) values (1,'8801');
> select count(*), nr_bank from sdlint.output group by nr_bank;
> {code}
> The above query fails with:
> {code}
> Caused by: java.lang.ClassCastException:
> org.apache.hadoop.hive.ql.exec.vector.DecimalColumnVector cannot be cast to
> org.apache.hadoop.hive.ql.exec.vector.LongColumnVector
> at
> org.apache.hadoop.hive.ql.exec.vector.expressions.FuncLongToDecimal.evaluate(FuncLongToDecimal.java:58)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (HIVE-22640) Decimal64ColumnVector: ClassCastException when partition column type is Decimal
[ https://issues.apache.org/jira/browse/HIVE-22640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Denys Kuzmenko reassigned HIVE-22640: - Assignee: Denys Kuzmenko > Decimal64ColumnVector: ClassCastException when partition column type is > Decimal > --- > > Key: HIVE-22640 > URL: https://issues.apache.org/jira/browse/HIVE-22640 > Project: Hive > Issue Type: Bug >Reporter: Denys Kuzmenko >Assignee: Denys Kuzmenko >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22558) Metastore: Passwords jceks should be read lazily, in case of connection pools
[ https://issues.apache.org/jira/browse/HIVE-22558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16994861#comment-16994861 ] Ashutosh Chauhan commented on HIVE-22558: - +1 > Metastore: Passwords jceks should be read lazily, in case of connection pools > - > > Key: HIVE-22558 > URL: https://issues.apache.org/jira/browse/HIVE-22558 > Project: Hive > Issue Type: Bug > Components: Metastore, Standalone Metastore >Reporter: Gopal Vijayaraghavan >Assignee: Slim Bouguerra >Priority: Major > Attachments: HIVE-22558.1.patch, getDatabase-password-md5-hotpath.png > > > The jceks file is parsed for every instance of the metastore conf to populate > the password in plain-text, which is irrelevant for the scenario where the DB > connection pool is already active. > !getDatabase-password-md5-hotpath.png|width=640! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22577) StringIndexOutOfBoundsException when getting sessionId from worker node name
[
https://issues.apache.org/jira/browse/HIVE-22577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16994857#comment-16994857
]
Ashutosh Chauhan commented on HIVE-22577:
-
+1
> StringIndexOutOfBoundsException when getting sessionId from worker node name
>
>
> Key: HIVE-22577
> URL: https://issues.apache.org/jira/browse/HIVE-22577
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Reporter: Attila Magyar
>Assignee: Attila Magyar
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-22577.1.patch, HIVE-22577.2.patch,
> HIVE-22577.3.patch
>
>
> When the node name is "worker-" the following exception is thrown
>
> {code:java}
> Caused by: java.lang.StringIndexOutOfBoundsException: String index out of
> range: -1Caused by: java.lang.StringIndexOutOfBoundsException: String index
> out of range: -1 at java.lang.String.substring(String.java:1931) at
> org.apache.hadoop.hive.registry.impl.ZkRegistryBase.extractSeqNum(ZkRegistryBase.java:781)
> at
> org.apache.hadoop.hive.registry.impl.ZkRegistryBase.populateCache(ZkRegistryBase.java:507)
> at
> org.apache.hadoop.hive.llap.registry.impl.LlapZookeeperRegistryImpl.access$000(LlapZookeeperRegistryImpl.java:65)
> at
> org.apache.hadoop.hive.llap.registry.impl.LlapZookeeperRegistryImpl$DynamicServiceInstanceSet.(LlapZookeeperRegistryImpl.java:313)
> at
> org.apache.hadoop.hive.llap.registry.impl.LlapZookeeperRegistryImpl.getInstances(LlapZookeeperRegistryImpl.java:462)
> at
> org.apache.hadoop.hive.llap.registry.impl.LlapZookeeperRegistryImpl.getApplicationId(LlapZookeeperRegistryImpl.java:469)
> at
> org.apache.hadoop.hive.llap.registry.impl.LlapRegistryService.getApplicationId(LlapRegistryService.java:212)
> at
> org.apache.hadoop.hive.ql.exec.tez.Utils.getCustomSplitLocationProvider(Utils.java:77)
> at
> org.apache.hadoop.hive.ql.exec.tez.Utils.getSplitLocationProvider(Utils.java:53)
> at
> org.apache.hadoop.hive.ql.exec.tez.HiveSplitGenerator.(HiveSplitGenerator.java:140)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-20972) Enable TestMiniLlapLocalCliDriver cbo_limit and cbo_rp_limit
[
https://issues.apache.org/jira/browse/HIVE-20972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16994850#comment-16994850
]
Hive QA commented on HIVE-20972:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
53s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
56s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
30s{color} | {color:blue} ql in master has 1531 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
56s{color} | {color:blue} itests/util in master has 53 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
31s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
32s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
28s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 33m 26s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19900/dev-support/hive-personality.sh
|
| git revision | master / 41b51fc |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| modules | C: ql itests/util U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-19900/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Enable TestMiniLlapLocalCliDriver cbo_limit and cbo_rp_limit
>
>
> Key: HIVE-20972
> URL: https://issues.apache.org/jira/browse/HIVE-20972
> Project: Hive
> Issue Type: Test
>Reporter: Vihang Karajgaonkar
>Assignee: Zoltan Haindrich
>Priority: Major
> Attachments: HIVE-20972.01.patch, HIVE-20972.02.patch,
> HIVE-20972.02.patch, HIVE-20972.03.patch, HIVE-20972.03.patch,
> HIVE-20972.03.patch, HIVE-20972.03.patch, HIVE-20972.03.patch
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22583) LLAP cache always misses with non-vectorized serde readers such as OpenCSV
[
https://issues.apache.org/jira/browse/HIVE-22583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16994821#comment-16994821
]
Ádám Szita commented on HIVE-22583:
---
Thanks for looking into this, [~bslim].
I was thinking that maybe we could do an {{llap cache -purge}} at the end of
the test case. That would imprint the number bytes that were cached in the q
test result file. I guess it would not interfere with other test cases, as
ptest runs them sequentially within a batch.
What's your opinion?
> LLAP cache always misses with non-vectorized serde readers such as OpenCSV
> --
>
> Key: HIVE-22583
> URL: https://issues.apache.org/jira/browse/HIVE-22583
> Project: Hive
> Issue Type: Bug
> Components: llap
>Reporter: Ádám Szita
>Assignee: Ádám Szita
>Priority: Major
> Attachments: HIVE-22583.0.patch, HIVE-22583.1.patch,
> HIVE-22583.2.patch
>
>
> Although after the first read LLAP cache stores data of tables that are not
> using the LazySimple serde, the stored data is then never used in the future
> subsequent queries, causing a full cache miss and re-read each time.
> Problem is rooted in SerdeEncodedDataReader#cacheFileData is not taking care
> of creating an entry for the root/struct column of the table. The only cases
> this is taken care of are when a vectorized reader is used _(e.g.
> LazySimpleSerde's LazySimpleDeserializeRead)_, where
> SerdeEncodedDataReader#processAsyncCacheData takes care of this.
> This can be reproduced by either using a custom serde, like OpenCSV or using
> LazySimpleSerde, but turning off _hive.llap.io.encode.vector.serde.enabled_.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22632) Improve estimateRowSizeFromSchema
[
https://issues.apache.org/jira/browse/HIVE-22632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16994799#comment-16994799
]
Hive QA commented on HIVE-22632:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12988649/HIVE-22632.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 17772 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19899/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19899/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19899/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12988649 - PreCommit-HIVE-Build
> Improve estimateRowSizeFromSchema
> -
>
> Key: HIVE-22632
> URL: https://issues.apache.org/jira/browse/HIVE-22632
> Project: Hive
> Issue Type: Improvement
> Components: Statistics
>Reporter: Vineet Garg
>Assignee: Vineet Garg
>Priority: Major
> Attachments: HIVE-22632.1.patch
>
>
> estimateRowSizeFromSchema un-necessarily iterate and do look-up. This could
> be avoided.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22632) Improve estimateRowSizeFromSchema
[
https://issues.apache.org/jira/browse/HIVE-22632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16994761#comment-16994761
]
Hive QA commented on HIVE-22632:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
45s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
31s{color} | {color:blue} ql in master has 1531 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
8s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
7s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
16s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 28m 39s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19899/dev-support/hive-personality.sh
|
| git revision | master / 41b51fc |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-19899/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Improve estimateRowSizeFromSchema
> -
>
> Key: HIVE-22632
> URL: https://issues.apache.org/jira/browse/HIVE-22632
> Project: Hive
> Issue Type: Improvement
> Components: Statistics
>Reporter: Vineet Garg
>Assignee: Vineet Garg
>Priority: Major
> Attachments: HIVE-22632.1.patch
>
>
> estimateRowSizeFromSchema un-necessarily iterate and do look-up. This could
> be avoided.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-22489) Reduce Sink operator should order nulls by parameter
[
https://issues.apache.org/jira/browse/HIVE-22489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Krisztian Kasa updated HIVE-22489:
--
Status: Patch Available (was: Open)
> Reduce Sink operator should order nulls by parameter
> -
>
> Key: HIVE-22489
> URL: https://issues.apache.org/jira/browse/HIVE-22489
> Project: Hive
> Issue Type: Bug
> Components: Query Planning
>Reporter: Krisztian Kasa
>Assignee: Krisztian Kasa
>Priority: Major
> Attachments: HIVE-22489.1.patch, HIVE-22489.2.patch,
> HIVE-22489.3.patch, HIVE-22489.3.patch, HIVE-22489.4.patch
>
>
> When the property hive.default.nulls.last is set to true and no null order is
> explicitly specified in the ORDER BY clause of the query null ordering should
> be NULLS LAST.
> But some of the Reduce Sink operators still orders null first.
> {code}
> SET hive.default.nulls.last=true;
> EXPLAIN EXTENDED
> SELECT src1.key, src2.value FROM src src1 JOIN src src2 ON (src1.key =
> src2.key) ORDER BY src1.key LIMIT 5;
> {code}
> {code}
> PREHOOK: query: EXPLAIN EXTENDED
> SELECT src1.key, src2.value FROM src src1 JOIN src src2 ON (src1.key =
> src2.key) ORDER BY src1.key
> PREHOOK: type: QUERY
> PREHOOK: Input: default@src
> A masked pattern was here
> POSTHOOK: query: EXPLAIN EXTENDED
> SELECT src1.key, src2.value FROM src src1 JOIN src src2 ON (src1.key =
> src2.key) ORDER BY src1.key
> POSTHOOK: type: QUERY
> POSTHOOK: Input: default@src
> A masked pattern was here
> OPTIMIZED SQL: SELECT `t0`.`key`, `t2`.`value`
> FROM (SELECT `key`
> FROM `default`.`src`
> WHERE `key` IS NOT NULL) AS `t0`
> INNER JOIN (SELECT `key`, `value`
> FROM `default`.`src`
> WHERE `key` IS NOT NULL) AS `t2` ON `t0`.`key` = `t2`.`key`
> ORDER BY `t0`.`key`
> STAGE DEPENDENCIES:
> Stage-1 is a root stage
> Stage-0 depends on stages: Stage-1
> STAGE PLANS:
> Stage: Stage-1
> Tez
> A masked pattern was here
> Edges:
> Reducer 2 <- Map 1 (SIMPLE_EDGE), Map 4 (SIMPLE_EDGE)
> Reducer 3 <- Reducer 2 (SIMPLE_EDGE)
> A masked pattern was here
> Vertices:
> Map 1
> Map Operator Tree:
> TableScan
> alias: src1
> filterExpr: key is not null (type: boolean)
> Statistics: Num rows: 500 Data size: 43500 Basic stats:
> COMPLETE Column stats: COMPLETE
> GatherStats: false
> Filter Operator
> isSamplingPred: false
> predicate: key is not null (type: boolean)
> Statistics: Num rows: 500 Data size: 43500 Basic stats:
> COMPLETE Column stats: COMPLETE
> Select Operator
> expressions: key (type: string)
> outputColumnNames: _col0
> Statistics: Num rows: 500 Data size: 43500 Basic stats:
> COMPLETE Column stats: COMPLETE
> Reduce Output Operator
> key expressions: _col0 (type: string)
> null sort order: a
> sort order: +
> Map-reduce partition columns: _col0 (type: string)
> Statistics: Num rows: 500 Data size: 43500 Basic
> stats: COMPLETE Column stats: COMPLETE
> tag: 0
> auto parallelism: true
> Execution mode: vectorized, llap
> LLAP IO: no inputs
> Path -> Alias:
> A masked pattern was here
> Path -> Partition:
> A masked pattern was here
> Partition
> base file name: src
> input format: org.apache.hadoop.mapred.TextInputFormat
> output format:
> org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat
> properties:
> COLUMN_STATS_ACCURATE
> {"BASIC_STATS":"true","COLUMN_STATS":{"key":"true","value":"true"}}
> bucket_count -1
> bucketing_version 2
> column.name.delimiter ,
> columns key,value
> columns.comments 'default','default'
> columns.types string:string
> A masked pattern was here
> name default.src
> numFiles 1
> numRows 500
> rawDataSize 5312
> serialization.ddl struct src { string key, string value}
> serialization.format 1
> serialization.lib
> org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe
> totalSize 5812
> A masked pattern was here
>
[jira] [Updated] (HIVE-22489) Reduce Sink operator should order nulls by parameter
[
https://issues.apache.org/jira/browse/HIVE-22489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Krisztian Kasa updated HIVE-22489:
--
Status: Open (was: Patch Available)
> Reduce Sink operator should order nulls by parameter
> -
>
> Key: HIVE-22489
> URL: https://issues.apache.org/jira/browse/HIVE-22489
> Project: Hive
> Issue Type: Bug
> Components: Query Planning
>Reporter: Krisztian Kasa
>Assignee: Krisztian Kasa
>Priority: Major
> Attachments: HIVE-22489.1.patch, HIVE-22489.2.patch,
> HIVE-22489.3.patch, HIVE-22489.3.patch
>
>
> When the property hive.default.nulls.last is set to true and no null order is
> explicitly specified in the ORDER BY clause of the query null ordering should
> be NULLS LAST.
> But some of the Reduce Sink operators still orders null first.
> {code}
> SET hive.default.nulls.last=true;
> EXPLAIN EXTENDED
> SELECT src1.key, src2.value FROM src src1 JOIN src src2 ON (src1.key =
> src2.key) ORDER BY src1.key LIMIT 5;
> {code}
> {code}
> PREHOOK: query: EXPLAIN EXTENDED
> SELECT src1.key, src2.value FROM src src1 JOIN src src2 ON (src1.key =
> src2.key) ORDER BY src1.key
> PREHOOK: type: QUERY
> PREHOOK: Input: default@src
> A masked pattern was here
> POSTHOOK: query: EXPLAIN EXTENDED
> SELECT src1.key, src2.value FROM src src1 JOIN src src2 ON (src1.key =
> src2.key) ORDER BY src1.key
> POSTHOOK: type: QUERY
> POSTHOOK: Input: default@src
> A masked pattern was here
> OPTIMIZED SQL: SELECT `t0`.`key`, `t2`.`value`
> FROM (SELECT `key`
> FROM `default`.`src`
> WHERE `key` IS NOT NULL) AS `t0`
> INNER JOIN (SELECT `key`, `value`
> FROM `default`.`src`
> WHERE `key` IS NOT NULL) AS `t2` ON `t0`.`key` = `t2`.`key`
> ORDER BY `t0`.`key`
> STAGE DEPENDENCIES:
> Stage-1 is a root stage
> Stage-0 depends on stages: Stage-1
> STAGE PLANS:
> Stage: Stage-1
> Tez
> A masked pattern was here
> Edges:
> Reducer 2 <- Map 1 (SIMPLE_EDGE), Map 4 (SIMPLE_EDGE)
> Reducer 3 <- Reducer 2 (SIMPLE_EDGE)
> A masked pattern was here
> Vertices:
> Map 1
> Map Operator Tree:
> TableScan
> alias: src1
> filterExpr: key is not null (type: boolean)
> Statistics: Num rows: 500 Data size: 43500 Basic stats:
> COMPLETE Column stats: COMPLETE
> GatherStats: false
> Filter Operator
> isSamplingPred: false
> predicate: key is not null (type: boolean)
> Statistics: Num rows: 500 Data size: 43500 Basic stats:
> COMPLETE Column stats: COMPLETE
> Select Operator
> expressions: key (type: string)
> outputColumnNames: _col0
> Statistics: Num rows: 500 Data size: 43500 Basic stats:
> COMPLETE Column stats: COMPLETE
> Reduce Output Operator
> key expressions: _col0 (type: string)
> null sort order: a
> sort order: +
> Map-reduce partition columns: _col0 (type: string)
> Statistics: Num rows: 500 Data size: 43500 Basic
> stats: COMPLETE Column stats: COMPLETE
> tag: 0
> auto parallelism: true
> Execution mode: vectorized, llap
> LLAP IO: no inputs
> Path -> Alias:
> A masked pattern was here
> Path -> Partition:
> A masked pattern was here
> Partition
> base file name: src
> input format: org.apache.hadoop.mapred.TextInputFormat
> output format:
> org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat
> properties:
> COLUMN_STATS_ACCURATE
> {"BASIC_STATS":"true","COLUMN_STATS":{"key":"true","value":"true"}}
> bucket_count -1
> bucketing_version 2
> column.name.delimiter ,
> columns key,value
> columns.comments 'default','default'
> columns.types string:string
> A masked pattern was here
> name default.src
> numFiles 1
> numRows 500
> rawDataSize 5312
> serialization.ddl struct src { string key, string value}
> serialization.format 1
> serialization.lib
> org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe
> totalSize 5812
> A masked pattern was here
> serde:
[jira] [Updated] (HIVE-22489) Reduce Sink operator should order nulls by parameter
[
https://issues.apache.org/jira/browse/HIVE-22489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Krisztian Kasa updated HIVE-22489:
--
Attachment: HIVE-22489.4.patch
> Reduce Sink operator should order nulls by parameter
> -
>
> Key: HIVE-22489
> URL: https://issues.apache.org/jira/browse/HIVE-22489
> Project: Hive
> Issue Type: Bug
> Components: Query Planning
>Reporter: Krisztian Kasa
>Assignee: Krisztian Kasa
>Priority: Major
> Attachments: HIVE-22489.1.patch, HIVE-22489.2.patch,
> HIVE-22489.3.patch, HIVE-22489.3.patch, HIVE-22489.4.patch
>
>
> When the property hive.default.nulls.last is set to true and no null order is
> explicitly specified in the ORDER BY clause of the query null ordering should
> be NULLS LAST.
> But some of the Reduce Sink operators still orders null first.
> {code}
> SET hive.default.nulls.last=true;
> EXPLAIN EXTENDED
> SELECT src1.key, src2.value FROM src src1 JOIN src src2 ON (src1.key =
> src2.key) ORDER BY src1.key LIMIT 5;
> {code}
> {code}
> PREHOOK: query: EXPLAIN EXTENDED
> SELECT src1.key, src2.value FROM src src1 JOIN src src2 ON (src1.key =
> src2.key) ORDER BY src1.key
> PREHOOK: type: QUERY
> PREHOOK: Input: default@src
> A masked pattern was here
> POSTHOOK: query: EXPLAIN EXTENDED
> SELECT src1.key, src2.value FROM src src1 JOIN src src2 ON (src1.key =
> src2.key) ORDER BY src1.key
> POSTHOOK: type: QUERY
> POSTHOOK: Input: default@src
> A masked pattern was here
> OPTIMIZED SQL: SELECT `t0`.`key`, `t2`.`value`
> FROM (SELECT `key`
> FROM `default`.`src`
> WHERE `key` IS NOT NULL) AS `t0`
> INNER JOIN (SELECT `key`, `value`
> FROM `default`.`src`
> WHERE `key` IS NOT NULL) AS `t2` ON `t0`.`key` = `t2`.`key`
> ORDER BY `t0`.`key`
> STAGE DEPENDENCIES:
> Stage-1 is a root stage
> Stage-0 depends on stages: Stage-1
> STAGE PLANS:
> Stage: Stage-1
> Tez
> A masked pattern was here
> Edges:
> Reducer 2 <- Map 1 (SIMPLE_EDGE), Map 4 (SIMPLE_EDGE)
> Reducer 3 <- Reducer 2 (SIMPLE_EDGE)
> A masked pattern was here
> Vertices:
> Map 1
> Map Operator Tree:
> TableScan
> alias: src1
> filterExpr: key is not null (type: boolean)
> Statistics: Num rows: 500 Data size: 43500 Basic stats:
> COMPLETE Column stats: COMPLETE
> GatherStats: false
> Filter Operator
> isSamplingPred: false
> predicate: key is not null (type: boolean)
> Statistics: Num rows: 500 Data size: 43500 Basic stats:
> COMPLETE Column stats: COMPLETE
> Select Operator
> expressions: key (type: string)
> outputColumnNames: _col0
> Statistics: Num rows: 500 Data size: 43500 Basic stats:
> COMPLETE Column stats: COMPLETE
> Reduce Output Operator
> key expressions: _col0 (type: string)
> null sort order: a
> sort order: +
> Map-reduce partition columns: _col0 (type: string)
> Statistics: Num rows: 500 Data size: 43500 Basic
> stats: COMPLETE Column stats: COMPLETE
> tag: 0
> auto parallelism: true
> Execution mode: vectorized, llap
> LLAP IO: no inputs
> Path -> Alias:
> A masked pattern was here
> Path -> Partition:
> A masked pattern was here
> Partition
> base file name: src
> input format: org.apache.hadoop.mapred.TextInputFormat
> output format:
> org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat
> properties:
> COLUMN_STATS_ACCURATE
> {"BASIC_STATS":"true","COLUMN_STATS":{"key":"true","value":"true"}}
> bucket_count -1
> bucketing_version 2
> column.name.delimiter ,
> columns key,value
> columns.comments 'default','default'
> columns.types string:string
> A masked pattern was here
> name default.src
> numFiles 1
> numRows 500
> rawDataSize 5312
> serialization.ddl struct src { string key, string value}
> serialization.format 1
> serialization.lib
> org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe
> totalSize 5812
> A masked pattern was here
>
[jira] [Assigned] (HIVE-22639) Bucket file name does not match bucket id after query based major compaction
[
https://issues.apache.org/jira/browse/HIVE-22639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aron Hamvas reassigned HIVE-22639:
--
> Bucket file name does not match bucket id after query based major compaction
>
>
> Key: HIVE-22639
> URL: https://issues.apache.org/jira/browse/HIVE-22639
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Affects Versions: 3.1.0, 3.0.0
>Reporter: Aron Hamvas
>Assignee: Aron Hamvas
>Priority: Major
>
> While debugging
> {{TestCrudCompactorOnTez#testCompactionWithSchemaEvolutionAndBuckets()}}, it
> has come to my attention, that even though before compaction, the file name
> of the single bucket in the delta directories is {{bucket_1}}, in the new
> base, the name of the new single bucket file is {{bucket_0}}. At the same
> time, the bucket value in the ROW__ID of the records remain the same and
> suggest that the bucket id is 1.
> So the bucket id and the file name do not match. This could lead to problems.
> The test itself does not reveal this issue, although I think that the tests
> should check this, too. At the same time, the tests assume the exact bucket
> id value in cases where it cannot be predicted and fail, even though the
> bucket it does not change after the compaction, so the check should really
> pass.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-22638) Fix insert statement issue with return path
[ https://issues.apache.org/jira/browse/HIVE-22638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Miklos Gergely updated HIVE-22638: -- Status: Patch Available (was: Open) > Fix insert statement issue with return path > --- > > Key: HIVE-22638 > URL: https://issues.apache.org/jira/browse/HIVE-22638 > Project: Hive > Issue Type: Sub-task > Components: Hive >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Attachments: HIVE-22638.01.patch > > > Insert statements were not handled properly with return path. It was revealed > during examining why TestUpgradeTool is not working with return path. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22638) Fix insert statement issue with return path
[ https://issues.apache.org/jira/browse/HIVE-22638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Miklos Gergely updated HIVE-22638: -- Attachment: HIVE-22638.01.patch > Fix insert statement issue with return path > --- > > Key: HIVE-22638 > URL: https://issues.apache.org/jira/browse/HIVE-22638 > Project: Hive > Issue Type: Sub-task > Components: Hive >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Attachments: HIVE-22638.01.patch > > > Insert statements were not handled properly with return path. It was revealed > during examining why TestUpgradeTool is not working with return path. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22638) Fix insert statement issue with return path
[ https://issues.apache.org/jira/browse/HIVE-22638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Miklos Gergely updated HIVE-22638: -- Parent: HIVE-9132 Issue Type: Sub-task (was: Bug) > Fix insert statement issue with return path > --- > > Key: HIVE-22638 > URL: https://issues.apache.org/jira/browse/HIVE-22638 > Project: Hive > Issue Type: Sub-task > Components: Hive >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > > Insert statements were not handled properly with return path. It was revealed > during examining why TestUpgradeTool is not working with return path. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HIVE-22638) Fix insert statement issue with return path
[ https://issues.apache.org/jira/browse/HIVE-22638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Miklos Gergely reassigned HIVE-22638: - > Fix insert statement issue with return path > --- > > Key: HIVE-22638 > URL: https://issues.apache.org/jira/browse/HIVE-22638 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > > Insert statements were not handled properly with return path. It was revealed > during examining why TestUpgradeTool is not working with return path. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22617) Re-Enable PreCommit test org.apache.hadoop.hive.ql.TestMTQueries.testMTQueries1
[ https://issues.apache.org/jira/browse/HIVE-22617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16994743#comment-16994743 ] Zoltan Haindrich commented on HIVE-22617: - +1 > Re-Enable PreCommit test > org.apache.hadoop.hive.ql.TestMTQueries.testMTQueries1 > --- > > Key: HIVE-22617 > URL: https://issues.apache.org/jira/browse/HIVE-22617 > Project: Hive > Issue Type: Sub-task >Reporter: Oliver Draese >Assignee: László Bodor >Priority: Major > Attachments: HIVE-22617.01.patch, HIVE-22617.01.patch, hive.log, > initialize.log > > > The test was disabled via HIVE-22616 because it was flaky. If the test is > considered valid, it needs to be fixed and re-enabled. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22625) Syntax Error in findPotentialCompactions SQL query for MySql/Postgres
[
https://issues.apache.org/jira/browse/HIVE-22625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Denys Kuzmenko updated HIVE-22625:
--
Status: Patch Available (was: Open)
> Syntax Error in findPotentialCompactions SQL query for MySql/Postgres
> -
>
> Key: HIVE-22625
> URL: https://issues.apache.org/jira/browse/HIVE-22625
> Project: Hive
> Issue Type: Bug
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22625.1.patch
>
>
> {code}
> ERROR 1064 (42000): You have an error in your SQL syntax; check the manual
> that corresponds to your MySQL server version for the right syntax to use
> near '=> current_timestamp - interval '254' second'
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-22611) Use JDK Base64 Classes
[ https://issues.apache.org/jira/browse/HIVE-22611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mollitor updated HIVE-22611: -- Status: Patch Available (was: Open) > Use JDK Base64 Classes > -- > > Key: HIVE-22611 > URL: https://issues.apache.org/jira/browse/HIVE-22611 > Project: Hive > Issue Type: Improvement >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Minor > > Replace dependency on thirdparty libraries with native support for Base-64 > encode/decode. > https://docs.oracle.com/javase/8/docs/api/java/util/Base64.html > Might be able to remove some dependencies afterwards. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22631) Avoid deep copying partition list in listPartitionsByExpr
[
https://issues.apache.org/jira/browse/HIVE-22631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16994731#comment-16994731
]
Hive QA commented on HIVE-22631:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12988648/HIVE-22631.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 741 failed/errored test(s), 17770 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[smb_mapjoin_10]
(batchId=301)
org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[smb_mapjoin_11]
(batchId=301)
org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[smb_mapjoin_12]
(batchId=301)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[orc_format_part]
(batchId=304)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[orc_nonstd_partitions_loc]
(batchId=304)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[parquet_format_part]
(batchId=304)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[parquet_nonstd_partitions_loc]
(batchId=304)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[rcfile_format_part]
(batchId=304)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[rcfile_nonstd_partitions_loc]
(batchId=304)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_stats2] (batchId=52)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_stats3] (batchId=16)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_stats4] (batchId=68)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_stats] (batchId=44)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_subquery]
(batchId=44)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_table_stats]
(batchId=59)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter3] (batchId=24)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter5] (batchId=46)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alterColumnStatsPart]
(batchId=96)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_char2] (batchId=42)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_merge_2]
(batchId=46)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_merge_2_orc]
(batchId=83)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_merge_3]
(batchId=89)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_partition_coltype]
(batchId=29)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_partition_update_status]
(batchId=100)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_rename_partition]
(batchId=25)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_table_cascade]
(batchId=99)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_table_partition_drop]
(batchId=16)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_varchar2]
(batchId=24)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[analyze_tbl_part]
(batchId=54)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[annotate_stats_part]
(batchId=17)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[archive_excludeHadoop20]
(batchId=73)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[archive_multi]
(batchId=35)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[authorization_6]
(batchId=51)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[autoColumnStats_1]
(batchId=25)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[autoColumnStats_2]
(batchId=94)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[autoColumnStats_3]
(batchId=62)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[autoColumnStats_8]
(batchId=16)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join14] (batchId=16)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join19] (batchId=72)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join19_inclause]
(batchId=19)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join25] (batchId=81)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join9] (batchId=85)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[avro_partitioned]
(batchId=4)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[avro_partitioned_native]
(batchId=6)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[avro_schema_evolution_native]
(batchId=63)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[bucket3] (batchId=18)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[bucket_map_join_spark1]
(batchId=76)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[bucket_map_join_spark2]
(batchId=3)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[bucket_map_join_spark3]
(batchId=50)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[bucketmapjoin10]
(batchId=57)
[jira] [Commented] (HIVE-22570) Review of ExprNodeDesc.java
[
https://issues.apache.org/jira/browse/HIVE-22570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16994729#comment-16994729
]
David Mollitor commented on HIVE-22570:
---
[~pvary]
Thanks for the review.
According to the folks at Google, and I am inclined to agree, it is best that a
NPE be generated. This is a warning for developers to not pass in 'null' value
and instead they should be passing in real values (maybe just an empty list).
It's better to throw NPE than to mask the issue and to do a 'null' check at the
beginning of each method and handling it in an ambiguous way (for example,
method returns an empty list, or returns null, if parameter is null).
I personally would remove {{Utilities.mergeUniqElems}} altogether in favor of
{{return new ArrayList<>(new Hashset<>(elems)))}} but we can address these
concerns in a separate jira.
Do you have any issues with this particular patch?
Thanks.
> Review of ExprNodeDesc.java
> ---
>
> Key: HIVE-22570
> URL: https://issues.apache.org/jira/browse/HIVE-22570
> Project: Hive
> Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-22570.1.patch
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
