[
https://issues.apache.org/jira/browse/HIVE-22536?focusedWorklogId=359235&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-359235
]
ASF GitHub Bot logged work on HIVE-22536:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Dec/19 07:10
Start Date: 13/Dec/19 07:10
Worklog Time Spent: 10m
Work Description: jcamachor commented on pull request #866: HIVE-22536
Improve return path enabling/disabling
URL: https://github.com/apache/hive/pull/866#discussion_r357510056
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
##########
@@ -3025,8 +3025,7 @@ private RelNode genTableLogicalPlan(String tableAlias,
QB qb) throws SemanticExc
db, tabNameToTabObject, partitionCache, colStatsCache,
noColsMissingStats);
final TableScan scan = new HiveTableScan(cluster,
cluster.traitSetOf(HiveRelNode.CONVENTION),
optTable, null == tableAlias ? tabMetaData.getTableName() :
tableAlias,
- getAliasId(tableAlias, qb), HiveConf.getBoolVar(conf,
- HiveConf.ConfVars.HIVE_CBO_RETPATH_HIVEOP),
qb.isInsideView()
+ getAliasId(tableAlias, qb), ReturnPathManager.shouldUse(),
qb.isInsideView()
Review comment:
It may not be necessary to pass that boolean when we create HiveTableScan
operators anymore, since there was some follow-up work that included the alias
with the table name in the digest. If that is the case, we can remove it.
Otherwise, it seems it is OK that we pass true even if finally we end up
bailing out from return path when we check the operators/expressions in the
plan.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 359235)
Time Spent: 1h (was: 50m)
> Improve return path enabling/disabling
> --------------------------------------
>
> Key: HIVE-22536
> URL: https://issues.apache.org/jira/browse/HIVE-22536
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22536.01.patch, HIVE-22536.02.patch,
> HIVE-22536.03.patch
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Instead of having a boolean for hive.cbo.returnpath.hiveop it should be
> on/off/supported. In case of "supported" it should be used for a subset of
> commands which are already verified to be able to work with return path. This
> is a temporary solution for the time while we are developing return path,
> before making it the only way to handle commands.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
