[jira] [Commented] (HIVE-17746) Regenerate spark_explainuser_1.q.out

2017-10-09 Thread Vineet Garg (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-17746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197672#comment-16197672
 ] 

Vineet Garg commented on HIVE-17746:


Hi [~pvary]. Thanks for taking care of this! The changes are good and are 
expected.  +1.


> Regenerate spark_explainuser_1.q.out
> 
>
> Key: HIVE-17746
> URL: https://issues.apache.org/jira/browse/HIVE-17746
> Project: Hive
>  Issue Type: Bug
>  Components: Test
>Affects Versions: 3.0.0
>Reporter: Peter Vary
>Assignee: Peter Vary
> Attachments: HIVE-17746.patch
>
>
> There is 2 changes in  spark_explainuser_1.q.out:
> 1., After HIVE-17465, the row numbers are different in the explain plans. 
> [~vgarg], [~ashutoshc]: Could you please check, wether it is an intended 
> change?
> 2., After HIVE-17535, CBO optimization turned on and the output of the 
> following query changed:
> {code:title=Query}
> explain select explode(array('a', 'b'));
> {code}
> {code:title=Original}
>  POSTHOOK: query: explain select explode(array('a', 'b'))
>  POSTHOOK: type: QUERY
>  Plan not optimized by CBO.
>  
>  Stage-0
>Fetch Operator
>  limit:-1
> UDTF Operator [UDTF_2]
>   function name:explode
>   Select Operator [SEL_1]
> Output:["_col0"]
> TableScan [TS_0]
> {code}
> {code:title=New}
>  POSTHOOK: query: explain select explode(array('a', 'b'))
>  POSTHOOK: type: QUERY
>  Plan optimized by CBO.
>  
>  Stage-0
>Fetch Operator
>  limit:-1
> Select Operator [SEL_3]
>   Output:["_col0"]
>   UDTF Operator [UDTF_2]
> function name:explode
> Select Operator [SEL_1]
>   Output:["_col0"]
>   TableScan [TS_0]
> {code}
> This 2nd change does not look like a successful optimization for me. Is it 
> planned :)
> If you think these are planned changes, then I think it would be good to 
> update the golden file.
> Thanks,
> Peter



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HIVE-17746) Regenerate spark_explainuser_1.q.out

2017-10-09 Thread Hive QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-17746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197357#comment-16197357
 ] 

Hive QA commented on HIVE-17746:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12891066/HIVE-17746.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 11191 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[optimize_nullscan]
 (batchId=162)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_2] 
(batchId=101)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query14] 
(batchId=239)
org.apache.hive.jdbc.TestJdbcDriver2.testSelectExecAsync2 (batchId=226)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/7195/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/7195/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-7195/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 4 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12891066 - PreCommit-HIVE-Build

> Regenerate spark_explainuser_1.q.out
> 
>
> Key: HIVE-17746
> URL: https://issues.apache.org/jira/browse/HIVE-17746
> Project: Hive
>  Issue Type: Bug
>  Components: Test
>Affects Versions: 3.0.0
>Reporter: Peter Vary
>Assignee: Peter Vary
> Attachments: HIVE-17746.patch
>
>
> There is 2 changes in  spark_explainuser_1.q.out:
> 1., After HIVE-17465, the row numbers are different in the explain plans. 
> [~vgarg], [~ashutoshc]: Could you please check, wether it is an intended 
> change?
> 2., After HIVE-17535, CBO optimization turned on and the output of the 
> following query changed:
> {code:title=Query}
> explain select explode(array('a', 'b'));
> {code}
> {code:title=Original}
>  POSTHOOK: query: explain select explode(array('a', 'b'))
>  POSTHOOK: type: QUERY
>  Plan not optimized by CBO.
>  
>  Stage-0
>Fetch Operator
>  limit:-1
> UDTF Operator [UDTF_2]
>   function name:explode
>   Select Operator [SEL_1]
> Output:["_col0"]
> TableScan [TS_0]
> {code}
> {code:title=New}
>  POSTHOOK: query: explain select explode(array('a', 'b'))
>  POSTHOOK: type: QUERY
>  Plan optimized by CBO.
>  
>  Stage-0
>Fetch Operator
>  limit:-1
> Select Operator [SEL_3]
>   Output:["_col0"]
>   UDTF Operator [UDTF_2]
> function name:explode
> Select Operator [SEL_1]
>   Output:["_col0"]
>   TableScan [TS_0]
> {code}
> This 2nd change does not look like a successful optimization for me. Is it 
> planned :)
> If you think these are planned changes, then I think it would be good to 
> update the golden file.
> Thanks,
> Peter



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)