[jira] [Commented] (HIVE-20635) VectorizedOrcAcidRowBatchReader doesn't filter delete events for original files
[ https://issues.apache.org/jira/browse/HIVE-20635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640876#comment-16640876 ] Eugene Koifman commented on HIVE-20635: --- committed patch 3 to master thanks Saurabh for the contribution > VectorizedOrcAcidRowBatchReader doesn't filter delete events for original > files > --- > > Key: HIVE-20635 > URL: https://issues.apache.org/jira/browse/HIVE-20635 > Project: Hive > Issue Type: Improvement > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Saurabh Seth >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-20635.2.patch, HIVE-20635.3.patch, HIVE-20635.patch > > > this is a followup to HIVE-16812 which adds support for delete event > filtering for splits from native acid files > need to add the same for {{OrcSplit.isOriginal()}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20635) VectorizedOrcAcidRowBatchReader doesn't filter delete events for original files
[ https://issues.apache.org/jira/browse/HIVE-20635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640619#comment-16640619 ] Saurabh Seth commented on HIVE-20635: - The asf license warning is in an unrelated file - HiveJdbcImplementor.java. Everything else is green. > VectorizedOrcAcidRowBatchReader doesn't filter delete events for original > files > --- > > Key: HIVE-20635 > URL: https://issues.apache.org/jira/browse/HIVE-20635 > Project: Hive > Issue Type: Improvement > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Saurabh Seth >Priority: Major > Attachments: HIVE-20635.2.patch, HIVE-20635.3.patch, HIVE-20635.patch > > > this is a followup to HIVE-16812 which adds support for delete event > filtering for splits from native acid files > need to add the same for {{OrcSplit.isOriginal()}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20635) VectorizedOrcAcidRowBatchReader doesn't filter delete events for original files
[ https://issues.apache.org/jira/browse/HIVE-20635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640545#comment-16640545 ] Hive QA commented on HIVE-20635: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12942528/HIVE-20635.3.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 15028 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/14264/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14264/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14264/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12942528 - PreCommit-HIVE-Build > VectorizedOrcAcidRowBatchReader doesn't filter delete events for original > files > --- > > Key: HIVE-20635 > URL: https://issues.apache.org/jira/browse/HIVE-20635 > Project: Hive > Issue Type: Improvement > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Saurabh Seth >Priority: Major > Attachments: HIVE-20635.2.patch, HIVE-20635.3.patch, HIVE-20635.patch > > > this is a followup to HIVE-16812 which adds support for delete event > filtering for splits from native acid files > need to add the same for {{OrcSplit.isOriginal()}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20635) VectorizedOrcAcidRowBatchReader doesn't filter delete events for original files
[ https://issues.apache.org/jira/browse/HIVE-20635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640536#comment-16640536 ] Hive QA commented on HIVE-20635: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 24s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 3s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 40s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 2s{color} | {color:blue} ql in master has 2320 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 57s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 1s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 1s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 39s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 14s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 55s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 14s{color} | {color:red} The patch generated 1 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 24m 6s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-14264/dev-support/hive-personality.sh | | git revision | master / a4b087b | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-14264/yetus/patch-asflicense-problems.txt | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-14264/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > VectorizedOrcAcidRowBatchReader doesn't filter delete events for original > files > --- > > Key: HIVE-20635 > URL: https://issues.apache.org/jira/browse/HIVE-20635 > Project: Hive > Issue Type: Improvement > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Saurabh Seth >Priority: Major > Attachments: HIVE-20635.2.patch, HIVE-20635.3.patch, HIVE-20635.patch > > > this is a followup to HIVE-16812 which adds support for delete event > filtering for splits from native acid files > need to add the same for {{OrcSplit.isOriginal()}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20635) VectorizedOrcAcidRowBatchReader doesn't filter delete events for original files
[ https://issues.apache.org/jira/browse/HIVE-20635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640053#comment-16640053 ] Eugene Koifman commented on HIVE-20635: --- +1 patch 3 pending tests > VectorizedOrcAcidRowBatchReader doesn't filter delete events for original > files > --- > > Key: HIVE-20635 > URL: https://issues.apache.org/jira/browse/HIVE-20635 > Project: Hive > Issue Type: Improvement > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Saurabh Seth >Priority: Major > Attachments: HIVE-20635.2.patch, HIVE-20635.3.patch, HIVE-20635.patch > > > this is a followup to HIVE-16812 which adds support for delete event > filtering for splits from native acid files > need to add the same for {{OrcSplit.isOriginal()}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20635) VectorizedOrcAcidRowBatchReader doesn't filter delete events for original files
[ https://issues.apache.org/jira/browse/HIVE-20635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639013#comment-16639013 ] Eugene Koifman commented on HIVE-20635: --- A nit: {{ LOG.info("findOriginalMinMaxKeys(): " + keyIntervalTmp);}} is only logged {{if (minRowId >= maxRowId) {}} would be better to log it always otherwise LGTM > VectorizedOrcAcidRowBatchReader doesn't filter delete events for original > files > --- > > Key: HIVE-20635 > URL: https://issues.apache.org/jira/browse/HIVE-20635 > Project: Hive > Issue Type: Improvement > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Saurabh Seth >Priority: Major > Attachments: HIVE-20635.2.patch, HIVE-20635.patch > > > this is a followup to HIVE-16812 which adds support for delete event > filtering for splits from native acid files > need to add the same for {{OrcSplit.isOriginal()}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20635) VectorizedOrcAcidRowBatchReader doesn't filter delete events for original files
[ https://issues.apache.org/jira/browse/HIVE-20635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16635733#comment-16635733 ] Hive QA commented on HIVE-20635: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12942093/HIVE-20635.2.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 15008 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/14179/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14179/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14179/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12942093 - PreCommit-HIVE-Build > VectorizedOrcAcidRowBatchReader doesn't filter delete events for original > files > --- > > Key: HIVE-20635 > URL: https://issues.apache.org/jira/browse/HIVE-20635 > Project: Hive > Issue Type: Improvement > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Saurabh Seth >Priority: Major > Attachments: HIVE-20635.2.patch, HIVE-20635.patch > > > this is a followup to HIVE-16812 which adds support for delete event > filtering for splits from native acid files > need to add the same for {{OrcSplit.isOriginal()}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20635) VectorizedOrcAcidRowBatchReader doesn't filter delete events for original files
[ https://issues.apache.org/jira/browse/HIVE-20635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16635665#comment-16635665 ] Hive QA commented on HIVE-20635: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 14s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 4s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 40s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 58s{color} | {color:blue} ql in master has 2321 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 58s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 22s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 2s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 2s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 7s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 2s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 23m 49s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-14179/dev-support/hive-personality.sh | | git revision | master / 499539f | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-14179/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > VectorizedOrcAcidRowBatchReader doesn't filter delete events for original > files > --- > > Key: HIVE-20635 > URL: https://issues.apache.org/jira/browse/HIVE-20635 > Project: Hive > Issue Type: Improvement > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Saurabh Seth >Priority: Major > Attachments: HIVE-20635.2.patch, HIVE-20635.patch > > > this is a followup to HIVE-16812 which adds support for delete event > filtering for splits from native acid files > need to add the same for {{OrcSplit.isOriginal()}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20635) VectorizedOrcAcidRowBatchReader doesn't filter delete events for original files
[ https://issues.apache.org/jira/browse/HIVE-20635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634586#comment-16634586 ] Hive QA commented on HIVE-20635: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12941986/HIVE-20635.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 15009 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[load_dyn_part3] (batchId=160) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/14162/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14162/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14162/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12941986 - PreCommit-HIVE-Build > VectorizedOrcAcidRowBatchReader doesn't filter delete events for original > files > --- > > Key: HIVE-20635 > URL: https://issues.apache.org/jira/browse/HIVE-20635 > Project: Hive > Issue Type: Improvement > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Saurabh Seth >Priority: Major > Attachments: HIVE-20635.patch > > > this is a followup to HIVE-16812 which adds support for delete event > filtering for splits from native acid files > need to add the same for {{OrcSplit.isOriginal()}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20635) VectorizedOrcAcidRowBatchReader doesn't filter delete events for original files
[ https://issues.apache.org/jira/browse/HIVE-20635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634536#comment-16634536 ] Hive QA commented on HIVE-20635: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 48s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 6s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 42s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 7s{color} | {color:blue} ql in master has 2321 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 1s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 27s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 10s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 10s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 39s{color} | {color:red} ql: The patch generated 7 new + 68 unchanged - 0 fixed = 75 total (was 68) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 59s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 24m 56s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-14162/dev-support/hive-personality.sh | | git revision | master / c05733e | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-14162/yetus/diff-checkstyle-ql.txt | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-14162/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > VectorizedOrcAcidRowBatchReader doesn't filter delete events for original > files > --- > > Key: HIVE-20635 > URL: https://issues.apache.org/jira/browse/HIVE-20635 > Project: Hive > Issue Type: Improvement > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Saurabh Seth >Priority: Major > Attachments: HIVE-20635.patch > > > this is a followup to HIVE-16812 which adds support for delete event > filtering for splits from native acid files > need to add the same for {{OrcSplit.isOriginal()}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20635) VectorizedOrcAcidRowBatchReader doesn't filter delete events for original files
[ https://issues.apache.org/jira/browse/HIVE-20635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631274#comment-16631274 ] Eugene Koifman commented on HIVE-20635: --- [~saurabhseth] could you take this on? > VectorizedOrcAcidRowBatchReader doesn't filter delete events for original > files > --- > > Key: HIVE-20635 > URL: https://issues.apache.org/jira/browse/HIVE-20635 > Project: Hive > Issue Type: Improvement > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Priority: Major > > this is a followup to HIVE-16812 which adds support for delete event > filtering for splits from native acid files > need to add the same for {{OrcSplit.isOriginal()}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)