[jira] [Commented] (HIVE-19578) HLL merges tempList on every add

[ https://issues.apache.org/jira/browse/HIVE-19578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16490501#comment-16490501 ] Hive QA commented on HIVE-19578: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-19578) HLL merges tempList on every add

[ https://issues.apache.org/jira/browse/HIVE-19578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16490473#comment-16490473 ] Hive QA commented on HIVE-19578: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-19578) HLL merges tempList on every add

[ https://issues.apache.org/jira/browse/HIVE-19578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486623#comment-16486623 ] Hive QA commented on HIVE-19578: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-19578) HLL merges tempList on every add

[ https://issues.apache.org/jira/browse/HIVE-19578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486592#comment-16486592 ] Hive QA commented on HIVE-19578: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-19578) HLL merges tempList on every add

[ https://issues.apache.org/jira/browse/HIVE-19578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483486#comment-16483486 ] Hive QA commented on HIVE-19578: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-19578) HLL merges tempList on every add

[ https://issues.apache.org/jira/browse/HIVE-19578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482377#comment-16482377 ] Hive QA commented on HIVE-19578: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-19578) HLL merges tempList on every add

[ https://issues.apache.org/jira/browse/HIVE-19578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481360#comment-16481360 ] Hive QA commented on HIVE-19578: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-19578) HLL merges tempList on every add

[ https://issues.apache.org/jira/browse/HIVE-19578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481319#comment-16481319 ] Hive QA commented on HIVE-19578: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-19578) HLL merges tempList on every add

[ https://issues.apache.org/jira/browse/HIVE-19578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481308#comment-16481308 ] Prasanth Jayachandran commented on HIVE-19578: -- Yes. It used to be containsKey -> get ->

[jira] [Commented] (HIVE-19578) HLL merges tempList on every add

[ https://issues.apache.org/jira/browse/HIVE-19578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481303#comment-16481303 ] Sergey Shelukhin commented on HIVE-19578: - "if (sparseMap.containsKey" block is gone; by design?

[jira] [Commented] (HIVE-19578) HLL merges tempList on every add

[ https://issues.apache.org/jira/browse/HIVE-19578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479669#comment-16479669 ] Prasanth Jayachandran commented on HIVE-19578: -- [~sershe] can you look at .2 patch? > HLL

[jira] [Commented] (HIVE-19578) HLL merges tempList on every add

[ https://issues.apache.org/jira/browse/HIVE-19578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479665#comment-16479665 ] Prasanth Jayachandran commented on HIVE-19578: -- New benchmark run with and without .2 patch

[jira] [Commented] (HIVE-19578) HLL merges tempList on every add

[ https://issues.apache.org/jira/browse/HIVE-19578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479587#comment-16479587 ] Prasanth Jayachandran commented on HIVE-19578: -- Actually, let me put up another patch that

[jira] [Commented] (HIVE-19578) HLL merges tempList on every add

[ https://issues.apache.org/jira/browse/HIVE-19578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479566#comment-16479566 ] Sergey Shelukhin commented on HIVE-19578: - So the temp list is useless? I wonder if it would still

[jira] [Commented] (HIVE-19578) HLL merges tempList on every add

[ https://issues.apache.org/jira/browse/HIVE-19578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479218#comment-16479218 ] Hive QA commented on HIVE-19578: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-19578) HLL merges tempList on every add

[ https://issues.apache.org/jira/browse/HIVE-19578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479161#comment-16479161 ] Hive QA commented on HIVE-19578: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-19578) HLL merges tempList on every add

[ https://issues.apache.org/jira/browse/HIVE-19578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478708#comment-16478708 ] Prasanth Jayachandran commented on HIVE-19578: -- [~sershe] can you please review? > HLL

[jira] [Commented] (HIVE-19578) HLL merges tempList on every add

[ https://issues.apache.org/jira/browse/HIVE-19578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478696#comment-16478696 ] Prasanth Jayachandran commented on HIVE-19578: -- Int2ByteSortedMap is in fastutil. This

[jira] [Commented] (HIVE-19578) HLL merges tempList on every add

[ https://issues.apache.org/jira/browse/HIVE-19578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478651#comment-16478651 ] Prasanth Jayachandran commented on HIVE-19578: -- Ran a quick benchmark with following

[jira] [Commented] (HIVE-19578) HLL merges tempList on every add

[ https://issues.apache.org/jira/browse/HIVE-19578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478398#comment-16478398 ] Prasanth Jayachandran commented on HIVE-19578: -- HLL p value is also changing to 10 in