[
https://issues.apache.org/jira/browse/HIVE-20580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16802511#comment-16802511
]
Vaibhav Gumashta commented on HIVE-20580:
-
+1
[~pvary] Your patch looks good. I think with
[
https://issues.apache.org/jira/browse/HIVE-20580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798263#comment-16798263
]
Peter Vary commented on HIVE-20580:
---
[~ashutoshc]: isOriginal(Footer) is called from
[
https://issues.apache.org/jira/browse/HIVE-20580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798181#comment-16798181
]
Ashutosh Chauhan commented on HIVE-20580:
-
[~pvary] I will get rid of isOriginal(Footer). I don't
[
https://issues.apache.org/jira/browse/HIVE-20580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795934#comment-16795934
]
Peter Vary commented on HIVE-20580:
---
[~ekoifman]: The {{isOriginal(Footer footer)}} is called from
[
https://issues.apache.org/jira/browse/HIVE-20580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795638#comment-16795638
]
Eugene Koifman commented on HIVE-20580:
---
isOriginal should mean files w/o acid metadata columns in
[
https://issues.apache.org/jira/browse/HIVE-20580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794916#comment-16794916
]
Peter Vary commented on HIVE-20580:
---
[~ekoifman]: Could you please check my approach? I would like to
[
https://issues.apache.org/jira/browse/HIVE-20580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794511#comment-16794511
]
Eugene Koifman commented on HIVE-20580:
---
note that Query based compactor doesn't produce
[
https://issues.apache.org/jira/browse/HIVE-20580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792405#comment-16792405
]
Peter Vary commented on HIVE-20580:
---
Thanks for the pointers [~ashutoshc]! Created test in
[
https://issues.apache.org/jira/browse/HIVE-20580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792400#comment-16792400
]
Hive QA commented on HIVE-20580:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792374#comment-16792374
]
Hive QA commented on HIVE-20580:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-20580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791971#comment-16791971
]
Hive QA commented on HIVE-20580:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791932#comment-16791932
]
Hive QA commented on HIVE-20580:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-20580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790982#comment-16790982
]
Hive QA commented on HIVE-20580:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790941#comment-16790941
]
Hive QA commented on HIVE-20580:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-20580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790484#comment-16790484
]
Hive QA commented on HIVE-20580:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790466#comment-16790466
]
Hive QA commented on HIVE-20580:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-20580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790437#comment-16790437
]
Hive QA commented on HIVE-20580:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790436#comment-16790436
]
Hive QA commented on HIVE-20580:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788001#comment-16788001
]
Ashutosh Chauhan commented on HIVE-20580:
-
There are some test util methods in {{TestAcidUtils}}
[
https://issues.apache.org/jira/browse/HIVE-20580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787922#comment-16787922
]
Peter Vary commented on HIVE-20580:
---
Based on the description I suspect that the following methods
20 matches
Mail list logo
