[
https://issues.apache.org/jira/browse/HIVE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17754047#comment-17754047
]
Stamatis Zampetakis commented on HIVE-20838:
Ι see that the patch has been approved but it
[
https://issues.apache.org/jira/browse/HIVE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701148#comment-16701148
]
Gopal V commented on HIVE-20838:
LGTM - +1
The string to timestamp goes via the date route during
[
https://issues.apache.org/jira/browse/HIVE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684575#comment-16684575
]
Jaume M commented on HIVE-20838:
Can you take another look [~gopalv]?
> Timestamps with timezone are set
[
https://issues.apache.org/jira/browse/HIVE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684461#comment-16684461
]
Hive QA commented on HIVE-20838:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684438#comment-16684438
]
Hive QA commented on HIVE-20838:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681851#comment-16681851
]
Hive QA commented on HIVE-20838:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681797#comment-16681797
]
Hive QA commented on HIVE-20838:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679697#comment-16679697
]
Hive QA commented on HIVE-20838:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679628#comment-16679628
]
Hive QA commented on HIVE-20838:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678615#comment-16678615
]
Jaume M commented on HIVE-20838:
Subtle bug: {{catch (IllegalArgumentException | DateTimeParseException
[
https://issues.apache.org/jira/browse/HIVE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677709#comment-16677709
]
Hive QA commented on HIVE-20838:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677671#comment-16677671
]
Gopal V commented on HIVE-20838:
To fix on commit
{code}
[
https://issues.apache.org/jira/browse/HIVE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677668#comment-16677668
]
Hive QA commented on HIVE-20838:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16676502#comment-16676502
]
Hive QA commented on HIVE-20838:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674337#comment-16674337
]
Hive QA commented on HIVE-20838:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674326#comment-16674326
]
Hive QA commented on HIVE-20838:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674030#comment-16674030
]
Hive QA commented on HIVE-20838:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674022#comment-16674022
]
Hive QA commented on HIVE-20838:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672573#comment-16672573
]
Hive QA commented on HIVE-20838:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672553#comment-16672553
]
Hive QA commented on HIVE-20838:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669217#comment-16669217
]
Gopal V commented on HIVE-20838:
Heh, the parser test tests your fix and the other tests tests for the
[
https://issues.apache.org/jira/browse/HIVE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669211#comment-16669211
]
Jaume M commented on HIVE-20838:
I thought it was enough TestTimestampParser.java but there may be value
[
https://issues.apache.org/jira/browse/HIVE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669206#comment-16669206
]
Gopal V commented on HIVE-20838:
LGTM - +1
> Timestamps with timezone are set to null when using the
23 matches
Mail list logo