[jira] [Work logged] (HIVE-22274) Upgrade Calcite version to 1.21.0

2019-11-02 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-22274?focusedWorklogId=337767=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337767
 ]

ASF GitHub Bot logged work on HIVE-22274:
-

Author: ASF GitHub Bot
Created on: 03/Nov/19 05:18
Start Date: 03/Nov/19 05:18
Worklog Time Spent: 10m 
  Work Description: asfgit commented on pull request #809: HIVE-22274: 
upgrade Calcite to 1.21
URL: https://github.com/apache/hive/pull/809
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 337767)
Time Spent: 1h 10m  (was: 1h)

> Upgrade Calcite version to 1.21.0
> -
>
> Key: HIVE-22274
> URL: https://issues.apache.org/jira/browse/HIVE-22274
> Project: Hive
>  Issue Type: Task
>Affects Versions: 3.1.2
>Reporter: Steve Carlin
>Assignee: Steve Carlin
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-22274.1.patch, HIVE-22274.10.patch, 
> HIVE-22274.10.patch, HIVE-22274.11.patch, HIVE-22274.12.patch, 
> HIVE-22274.13.patch, HIVE-22274.15.patch, HIVE-22274.16.patch, 
> HIVE-22274.17.patch, HIVE-22274.18.patch, HIVE-22274.19.patch, 
> HIVE-22274.19.patch, HIVE-22274.19.patch, HIVE-22274.19.patch, 
> HIVE-22274.2.patch, HIVE-22274.3.patch, HIVE-22274.4.patch, 
> HIVE-22274.5.patch, HIVE-22274.6.patch, HIVE-22274.7.patch, 
> HIVE-22274.8.patch, HIVE-22274.9.patch, HIVE-22274.patch
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (HIVE-22274) Upgrade Calcite version to 1.21.0

2019-10-15 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-22274?focusedWorklogId=328657=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-328657
 ]

ASF GitHub Bot logged work on HIVE-22274:
-

Author: ASF GitHub Bot
Created on: 15/Oct/19 16:09
Start Date: 15/Oct/19 16:09
Worklog Time Spent: 10m 
  Work Description: scarlin-cloudera commented on pull request #809: 
HIVE-22274: upgrade Calcite to 1.21
URL: https://github.com/apache/hive/pull/809#discussion_r335046695
 
 

 ##
 File path: ql/src/test/results/clientpositive/concat_op.q.out
 ##
 @@ -311,7 +311,7 @@ POSTHOOK: query: explain formatted select key || value 
from src
 POSTHOOK: type: QUERY
 POSTHOOK: Input: default@src
  A masked pattern was here 
-{"CBOPlan":"{\n  \"rels\": [\n{\n  \"id\": \"0\",\n  \"relOp\": 
\"org.apache.hadoop.hive.ql.optimizer.calcite.reloperators.HiveTableScan\",\n   
   \"table\": [\n\"default\",\n\"src\"\n  ],\n  
\"table:alias\": \"src\",\n  \"inputs\": [],\n  \"rowCount\": 500.0,\n  
\"avgRowSize\": 9.624,\n  \"rowType\": [\n{\n  
\"type\": \"VARCHAR\",\n  \"nullable\": true,\n  \"precision\": 
2147483647,\n  \"name\": \"key\"\n},\n{\n  
\"type\": \"VARCHAR\",\n  \"nullable\": true,\n  \"precision\": 
2147483647,\n  \"name\": \"value\"\n},\n{\n  
\"type\": \"BIGINT\",\n  \"nullable\": true,\n  \"name\": 
\"BLOCK__OFFSET__INSIDE__FILE\"\n},\n{\n  \"type\": 
\"VARCHAR\",\n  \"nullable\": true,\n  \"precision\": 
2147483647,\n  \"name\": \"INPUT__FILE__NAME\"\n},\n{\n 
 \"fields\": [\n{\n  \"type\": \"BIGINT\",\n
  \"nullable\": true,\n  \"name\": \"writeid\"\n
},\n{\n  \"type\": \"INTEGER\",\n  
\"nullable\": true,\n  \"name\": \"bucketid\"\n},\n 
   {\n  \"type\": \"BIGINT\",\n  \"nullable\": 
true,\n  \"name\": \"rowid\"\n}\n  ],\n 
 \"name\": \"ROW__ID\"\n}\n  ],\n  \"colStats\": [\n{\n 
 \"name\": \"key\",\n  \"ndv\": 316\n},\n{\n
  \"name\": \"value\",\n  \"ndv\": 307\n}\n  ]\n
},\n{\n  \"id\": \"1\",\n  \"relOp\": 
\"org.apache.hadoop.hive.ql.optimizer.calcite.reloperators.HiveProject\",\n 
 \"fields\": [\n\"_o__c0\"\n  ],\n  \"exprs\": [\n{\n   
   \"op\": \"||\",\n  \"operands\": [\n{\n  
\"input\": 0,\n  \"name\": \"$0\"\n},\n{\n  
\"input\": 1,\n  \"name\": \"$1\"\n}\n  
]\n}\n  ],\n  \"rowCount\": 500.0\n}\n  
]\n}","optimizedSQL":"SELECT `key` || `value` AS `_o__c0`\nFROM 
`default`.`src`","cboInfo":"Plan optimized by CBO.","STAGE 
DEPENDENCIES":{"Stage-1":{"ROOT STAGE":"TRUE"},"Stage-0":{"DEPENDENT 
STAGES":"Stage-1"}},"STAGE PLANS":{"Stage-1":{"Map Reduce":{"Map Operator 
Tree:":[{"TableScan":{"alias:":"src","columns:":["key","value"],"database:":"default","Statistics:":"Num
 rows: 500 Data size: 89000 Basic stats: COMPLETE Column stats: 
COMPLETE","table:":"src","isTempTable:":"false","OperatorId:":"TS_0","children":{"Select
 Operator":{"expressions:":"concat(key, value) (type: 
string)","columnExprMap:":{"_col0":"concat(key, 
value)"},"outputColumnNames:":["_col0"],"Statistics:":"Num rows: 500 Data size: 
92000 Basic stats: COMPLETE Column stats: 
COMPLETE","OperatorId:":"SEL_3","children":{"File Output 
Operator":{"compressed:":"false","Statistics:":"Num rows: 500 Data size: 92000 
Basic stats: COMPLETE Column stats: COMPLETE","table:":{"input 
format:":"org.apache.hadoop.mapred.SequenceFileInputFormat","output 
format:":"org.apache.hadoop.hive.ql.io.HiveSequenceFileOutputFormat","serde:":"org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe"},"OperatorId:":"FS_4"}}],"Execution
 mode:":"vectorized"}},"Stage-0":{"Fetch Operator":{"limit:":"-1","Processor 
Tree:":{"ListSink":{"OperatorId:":"LIST_SINK_5"}}
+{"CBOPlan":"{\n  \"rels\": [\n{\n  \"id\": \"0\",\n  \"relOp\": 
\"org.apache.hadoop.hive.ql.optimizer.calcite.reloperators.HiveTableScan\",\n   
   \"table\": [\n\"default\",\n\"src\"\n  ],\n  
\"table:alias\": \"src\",\n  \"inputs\": [],\n  \"rowCount\": 500.0,\n  
\"avgRowSize\": 9.624,\n  \"rowType\": [\n{\n  
\"type\": \"VARCHAR\",\n  \"nullable\": true,\n  \"precision\": 
2147483647,\n  \"name\": \"key\"\n},\n{\n  
\"type\": \"VARCHAR\",\n

[jira] [Work logged] (HIVE-22274) Upgrade Calcite version to 1.21.0

2019-10-14 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-22274?focusedWorklogId=328124=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-328124
 ]

ASF GitHub Bot logged work on HIVE-22274:
-

Author: ASF GitHub Bot
Created on: 14/Oct/19 20:35
Start Date: 14/Oct/19 20:35
Worklog Time Spent: 10m 
  Work Description: jcamachor commented on pull request #809: HIVE-22274: 
upgrade Calcite to 1.21
URL: https://github.com/apache/hive/pull/809#discussion_r334651939
 
 

 ##
 File path: ql/src/test/results/clientpositive/llap/limit_pushdown.q.out
 ##
 @@ -816,12 +816,54 @@ POSTHOOK: type: QUERY
 POSTHOOK: Input: default@src
  A masked pattern was here 
 STAGE DEPENDENCIES:
-  Stage-0 is a root stage
+  Stage-1 is a root stage
+  Stage-0 depends on stages: Stage-1
 
 STAGE PLANS:
+  Stage: Stage-1
+Tez
+ A masked pattern was here 
+  Edges:
+Reducer 2 <- Map 1 (SIMPLE_EDGE)
+ A masked pattern was here 
+  Vertices:
+Map 1 
+Map Operator Tree:
+TableScan
+  alias: src
+  Statistics: Num rows: 500 Data size: 89000 Basic stats: 
COMPLETE Column stats: COMPLETE
+  Select Operator
+expressions: key (type: string), value (type: string)
+outputColumnNames: _col0, _col1
+Statistics: Num rows: 500 Data size: 89000 Basic stats: 
COMPLETE Column stats: COMPLETE
+Reduce Output Operator
+  key expressions: _col0 (type: string)
+  sort order: +
+  Statistics: Num rows: 500 Data size: 89000 Basic stats: 
COMPLETE Column stats: COMPLETE
+  value expressions: _col1 (type: string)
+Execution mode: vectorized, llap
+LLAP IO: no inputs
+Reducer 2 
+Execution mode: vectorized, llap
+Reduce Operator Tree:
+  Select Operator
+expressions: KEY.reducesinkkey0 (type: string), VALUE._col0 
(type: string)
+outputColumnNames: _col0, _col1
+Statistics: Num rows: 500 Data size: 89000 Basic stats: 
COMPLETE Column stats: COMPLETE
+Filter Operator
+  predicate: false (type: boolean)
+  Statistics: Num rows: 1 Data size: 178 Basic stats: COMPLETE 
Column stats: COMPLETE
+  File Output Operator
+compressed: false
+Statistics: Num rows: 1 Data size: 178 Basic stats: 
COMPLETE Column stats: COMPLETE
+table:
+input format: 
org.apache.hadoop.mapred.SequenceFileInputFormat
+output format: 
org.apache.hadoop.hive.ql.io.HiveSequenceFileOutputFormat
+serde: 
org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe
+
   Stage: Stage-0
 Fetch Operator
-  limit: 0
+  limit: -1
 
 Review comment:
   It seems the initial assessment that filter with false condition was going 
to be less disruptive does not hold... Which ones were the regressions with 
limit 0? It seems it may be worth to move to original logic again.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 328124)
Time Spent: 50m  (was: 40m)

> Upgrade Calcite version to 1.21.0
> -
>
> Key: HIVE-22274
> URL: https://issues.apache.org/jira/browse/HIVE-22274
> Project: Hive
>  Issue Type: Task
>Affects Versions: 3.1.2
>Reporter: Steve Carlin
>Assignee: Steve Carlin
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-22274.1.patch, HIVE-22274.2.patch, 
> HIVE-22274.3.patch, HIVE-22274.4.patch, HIVE-22274.5.patch, 
> HIVE-22274.6.patch, HIVE-22274.7.patch, HIVE-22274.patch
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (HIVE-22274) Upgrade Calcite version to 1.21.0

2019-10-14 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-22274?focusedWorklogId=328123=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-328123
 ]

ASF GitHub Bot logged work on HIVE-22274:
-

Author: ASF GitHub Bot
Created on: 14/Oct/19 20:33
Start Date: 14/Oct/19 20:33
Worklog Time Spent: 10m 
  Work Description: jcamachor commented on pull request #809: HIVE-22274: 
upgrade Calcite to 1.21
URL: https://github.com/apache/hive/pull/809#discussion_r334651216
 
 

 ##
 File path: 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/jdbc/HiveJdbcImplementor.java
 ##
 @@ -109,7 +109,7 @@ public HiveJdbcImplementor(SqlDialect dialect, 
JavaTypeFactory typeFactory) {
 SqlNode sqlCondition = null;
 SqlLiteral condType = JoinConditionType.ON.symbol(POS);
 JoinType joinType = joinType(e.getJoinType());
-if (e.getJoinType() == JoinRelType.INNER && 
e.getCondition().isAlwaysTrue()) {
+if ((e.getJoinType() == JoinRelType.INNER || e.isSemiJoin()) && 
e.getCondition().isAlwaysTrue()) {
 
 Review comment:
   `ql/src/test/queries/clientpositive/external_jdbc_table*` files contain 
tests for jdbc storage handler. We should add a test over there.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 328123)
Time Spent: 40m  (was: 0.5h)

> Upgrade Calcite version to 1.21.0
> -
>
> Key: HIVE-22274
> URL: https://issues.apache.org/jira/browse/HIVE-22274
> Project: Hive
>  Issue Type: Task
>Affects Versions: 3.1.2
>Reporter: Steve Carlin
>Assignee: Steve Carlin
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-22274.1.patch, HIVE-22274.2.patch, 
> HIVE-22274.3.patch, HIVE-22274.4.patch, HIVE-22274.5.patch, 
> HIVE-22274.6.patch, HIVE-22274.7.patch, HIVE-22274.patch
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (HIVE-22274) Upgrade Calcite version to 1.21.0

2019-10-14 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-22274?focusedWorklogId=328113=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-328113
 ]

ASF GitHub Bot logged work on HIVE-22274:
-

Author: ASF GitHub Bot
Created on: 14/Oct/19 20:23
Start Date: 14/Oct/19 20:23
Worklog Time Spent: 10m 
  Work Description: vineetgarg02 commented on pull request #809: 
HIVE-22274: upgrade Calcite to 1.21
URL: https://github.com/apache/hive/pull/809#discussion_r334609909
 
 

 ##
 File path: 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/jdbc/HiveJdbcImplementor.java
 ##
 @@ -109,7 +109,7 @@ public HiveJdbcImplementor(SqlDialect dialect, 
JavaTypeFactory typeFactory) {
 SqlNode sqlCondition = null;
 SqlLiteral condType = JoinConditionType.ON.symbol(POS);
 JoinType joinType = joinType(e.getJoinType());
-if (e.getJoinType() == JoinRelType.INNER && 
e.getCondition().isAlwaysTrue()) {
+if ((e.getJoinType() == JoinRelType.INNER || e.isSemiJoin()) && 
e.getCondition().isAlwaysTrue()) {
 
 Review comment:
   Existing logic looks wrong. Even for SEMI JOIN `JoinType.COMMA` with 
condition `NONE` is created (in case condition is always true). 
   @jcamachor Are there JDBC tests where I can test this logic for SEMI JOIN 
type?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 328113)
Time Spent: 0.5h  (was: 20m)

> Upgrade Calcite version to 1.21.0
> -
>
> Key: HIVE-22274
> URL: https://issues.apache.org/jira/browse/HIVE-22274
> Project: Hive
>  Issue Type: Task
>Affects Versions: 3.1.2
>Reporter: Steve Carlin
>Assignee: Steve Carlin
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-22274.1.patch, HIVE-22274.2.patch, 
> HIVE-22274.3.patch, HIVE-22274.4.patch, HIVE-22274.5.patch, 
> HIVE-22274.6.patch, HIVE-22274.7.patch, HIVE-22274.patch
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (HIVE-22274) Upgrade Calcite version to 1.21.0

2019-10-14 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-22274?focusedWorklogId=328111=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-328111
 ]

ASF GitHub Bot logged work on HIVE-22274:
-

Author: ASF GitHub Bot
Created on: 14/Oct/19 20:23
Start Date: 14/Oct/19 20:23
Worklog Time Spent: 10m 
  Work Description: vineetgarg02 commented on pull request #809: 
HIVE-22274: upgrade Calcite to 1.21
URL: https://github.com/apache/hive/pull/809#discussion_r334647026
 
 

 ##
 File path: ql/src/test/results/clientpositive/concat_op.q.out
 ##
 @@ -311,7 +311,7 @@ POSTHOOK: query: explain formatted select key || value 
from src
 POSTHOOK: type: QUERY
 POSTHOOK: Input: default@src
  A masked pattern was here 
-{"CBOPlan":"{\n  \"rels\": [\n{\n  \"id\": \"0\",\n  \"relOp\": 
\"org.apache.hadoop.hive.ql.optimizer.calcite.reloperators.HiveTableScan\",\n   
   \"table\": [\n\"default\",\n\"src\"\n  ],\n  
\"table:alias\": \"src\",\n  \"inputs\": [],\n  \"rowCount\": 500.0,\n  
\"avgRowSize\": 9.624,\n  \"rowType\": [\n{\n  
\"type\": \"VARCHAR\",\n  \"nullable\": true,\n  \"precision\": 
2147483647,\n  \"name\": \"key\"\n},\n{\n  
\"type\": \"VARCHAR\",\n  \"nullable\": true,\n  \"precision\": 
2147483647,\n  \"name\": \"value\"\n},\n{\n  
\"type\": \"BIGINT\",\n  \"nullable\": true,\n  \"name\": 
\"BLOCK__OFFSET__INSIDE__FILE\"\n},\n{\n  \"type\": 
\"VARCHAR\",\n  \"nullable\": true,\n  \"precision\": 
2147483647,\n  \"name\": \"INPUT__FILE__NAME\"\n},\n{\n 
 \"fields\": [\n{\n  \"type\": \"BIGINT\",\n
  \"nullable\": true,\n  \"name\": \"writeid\"\n
},\n{\n  \"type\": \"INTEGER\",\n  
\"nullable\": true,\n  \"name\": \"bucketid\"\n},\n 
   {\n  \"type\": \"BIGINT\",\n  \"nullable\": 
true,\n  \"name\": \"rowid\"\n}\n  ],\n 
 \"name\": \"ROW__ID\"\n}\n  ],\n  \"colStats\": [\n{\n 
 \"name\": \"key\",\n  \"ndv\": 316\n},\n{\n
  \"name\": \"value\",\n  \"ndv\": 307\n}\n  ]\n
},\n{\n  \"id\": \"1\",\n  \"relOp\": 
\"org.apache.hadoop.hive.ql.optimizer.calcite.reloperators.HiveProject\",\n 
 \"fields\": [\n\"_o__c0\"\n  ],\n  \"exprs\": [\n{\n   
   \"op\": \"||\",\n  \"operands\": [\n{\n  
\"input\": 0,\n  \"name\": \"$0\"\n},\n{\n  
\"input\": 1,\n  \"name\": \"$1\"\n}\n  
]\n}\n  ],\n  \"rowCount\": 500.0\n}\n  
]\n}","optimizedSQL":"SELECT `key` || `value` AS `_o__c0`\nFROM 
`default`.`src`","cboInfo":"Plan optimized by CBO.","STAGE 
DEPENDENCIES":{"Stage-1":{"ROOT STAGE":"TRUE"},"Stage-0":{"DEPENDENT 
STAGES":"Stage-1"}},"STAGE PLANS":{"Stage-1":{"Map Reduce":{"Map Operator 
Tree:":[{"TableScan":{"alias:":"src","columns:":["key","value"],"database:":"default","Statistics:":"Num
 rows: 500 Data size: 89000 Basic stats: COMPLETE Column stats: 
COMPLETE","table:":"src","isTempTable:":"false","OperatorId:":"TS_0","children":{"Select
 Operator":{"expressions:":"concat(key, value) (type: 
string)","columnExprMap:":{"_col0":"concat(key, 
value)"},"outputColumnNames:":["_col0"],"Statistics:":"Num rows: 500 Data size: 
92000 Basic stats: COMPLETE Column stats: 
COMPLETE","OperatorId:":"SEL_3","children":{"File Output 
Operator":{"compressed:":"false","Statistics:":"Num rows: 500 Data size: 92000 
Basic stats: COMPLETE Column stats: COMPLETE","table:":{"input 
format:":"org.apache.hadoop.mapred.SequenceFileInputFormat","output 
format:":"org.apache.hadoop.hive.ql.io.HiveSequenceFileOutputFormat","serde:":"org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe"},"OperatorId:":"FS_4"}}],"Execution
 mode:":"vectorized"}},"Stage-0":{"Fetch Operator":{"limit:":"-1","Processor 
Tree:":{"ListSink":{"OperatorId:":"LIST_SINK_5"}}
+{"CBOPlan":"{\n  \"rels\": [\n{\n  \"id\": \"0\",\n  \"relOp\": 
\"org.apache.hadoop.hive.ql.optimizer.calcite.reloperators.HiveTableScan\",\n   
   \"table\": [\n\"default\",\n\"src\"\n  ],\n  
\"table:alias\": \"src\",\n  \"inputs\": [],\n  \"rowCount\": 500.0,\n  
\"avgRowSize\": 9.624,\n  \"rowType\": [\n{\n  
\"type\": \"VARCHAR\",\n  \"nullable\": true,\n  \"precision\": 
2147483647,\n  \"name\": \"key\"\n},\n{\n  
\"type\": \"VARCHAR\",\n  \"nullable\":

[jira] [Work logged] (HIVE-22274) Upgrade Calcite version to 1.21.0

2019-10-14 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-22274?focusedWorklogId=328112=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-328112
 ]

ASF GitHub Bot logged work on HIVE-22274:
-

Author: ASF GitHub Bot
Created on: 14/Oct/19 20:23
Start Date: 14/Oct/19 20:23
Worklog Time Spent: 10m 
  Work Description: vineetgarg02 commented on pull request #809: 
HIVE-22274: upgrade Calcite to 1.21
URL: https://github.com/apache/hive/pull/809#discussion_r334602095
 
 

 ##
 File path: 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveMultiJoin.java
 ##
 @@ -225,7 +225,7 @@ public JoinPredicateInfo getJoinPredicateInfo() {
 
   private boolean containsOuter() {
 for (JoinRelType joinType : joinTypes) {
-  if (joinType != JoinRelType.INNER) {
+  if (joinType != JoinRelType.INNER && joinType != JoinRelType.SEMI) {
 
 Review comment:
   It would be better to whitelist this for outer types (FULL, LEFT, RIGHT).
   @scarlin-cloudera Either we can create separate jira or we can make the 
change with this patch..upto you.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 328112)
Time Spent: 0.5h  (was: 20m)

> Upgrade Calcite version to 1.21.0
> -
>
> Key: HIVE-22274
> URL: https://issues.apache.org/jira/browse/HIVE-22274
> Project: Hive
>  Issue Type: Task
>Affects Versions: 3.1.2
>Reporter: Steve Carlin
>Assignee: Steve Carlin
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-22274.1.patch, HIVE-22274.2.patch, 
> HIVE-22274.3.patch, HIVE-22274.4.patch, HIVE-22274.5.patch, 
> HIVE-22274.6.patch, HIVE-22274.7.patch, HIVE-22274.patch
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (HIVE-22274) Upgrade Calcite version to 1.21.0

2019-10-14 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-22274?focusedWorklogId=328110=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-328110
 ]

ASF GitHub Bot logged work on HIVE-22274:
-

Author: ASF GitHub Bot
Created on: 14/Oct/19 20:23
Start Date: 14/Oct/19 20:23
Worklog Time Spent: 10m 
  Work Description: vineetgarg02 commented on pull request #809: 
HIVE-22274: upgrade Calcite to 1.21
URL: https://github.com/apache/hive/pull/809#discussion_r333775973
 
 

 ##
 File path: 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelBuilder.java
 ##
 @@ -113,9 +113,8 @@ public RelBuilder filter(Iterable 
predicates) {
   @Override
   public RelBuilder empty() {
 final RelNode input = build();
-final RelNode sort = HiveRelFactories.HIVE_SORT_FACTORY.createSort(
-input, RelCollations.of(), null, literal(0));
-return this.push(sort);
+final RelNode filter = 
HiveRelFactories.HIVE_FILTER_FACTORY.createFilter(input, literal(false));
 
 Review comment:
   Method's comment is outdated (referring to Limit 0)
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 328110)
Time Spent: 20m  (was: 10m)

> Upgrade Calcite version to 1.21.0
> -
>
> Key: HIVE-22274
> URL: https://issues.apache.org/jira/browse/HIVE-22274
> Project: Hive
>  Issue Type: Task
>Affects Versions: 3.1.2
>Reporter: Steve Carlin
>Assignee: Steve Carlin
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-22274.1.patch, HIVE-22274.2.patch, 
> HIVE-22274.3.patch, HIVE-22274.4.patch, HIVE-22274.5.patch, 
> HIVE-22274.6.patch, HIVE-22274.7.patch, HIVE-22274.patch
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (HIVE-22274) Upgrade Calcite version to 1.21.0

2019-10-10 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-22274?focusedWorklogId=326488=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-326488
 ]

ASF GitHub Bot logged work on HIVE-22274:
-

Author: ASF GitHub Bot
Created on: 10/Oct/19 18:18
Start Date: 10/Oct/19 18:18
Worklog Time Spent: 10m 
  Work Description: scarlin-cloudera commented on pull request #809: 
HIVE-22274: upgrade Calcite to 1.21
URL: https://github.com/apache/hive/pull/809
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 326488)
Remaining Estimate: 0h
Time Spent: 10m

> Upgrade Calcite version to 1.21.0
> -
>
> Key: HIVE-22274
> URL: https://issues.apache.org/jira/browse/HIVE-22274
> Project: Hive
>  Issue Type: Task
>Affects Versions: 3.1.2
>Reporter: Steve Carlin
>Assignee: Steve Carlin
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-22274.1.patch, HIVE-22274.2.patch, 
> HIVE-22274.3.patch, HIVE-22274.4.patch, HIVE-22274.5.patch, HIVE-22274.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)