[jira] [Updated] (HTRACE-399) Exclude jackson from test dependency on htrace-core4 to avoid infinite loop on creating dependency-reduced-pom
[ https://issues.apache.org/jira/browse/HTRACE-399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin P. McCabe updated HTRACE-399: --- Target Version/s: 4.4 Fix Version/s: (was: 3.4.0) 4.4 > Exclude jackson from test dependency on htrace-core4 to avoid infinite loop > on creating dependency-reduced-pom > -- > > Key: HTRACE-399 > URL: https://issues.apache.org/jira/browse/HTRACE-399 > Project: HTrace > Issue Type: Bug > Components: htrace-hbase >Reporter: Masatake Iwasaki >Assignee: Masatake Iwasaki > Fix For: 4.4 > > Attachments: HTRACE-399.001.patch > > > This is follow-up of HTRACE-234. As it is descrived in MSHADE-148, depending > both of main and test jar of htrace-core4 causes the infinite loop on > creating dependency-reduced-pom. I found that the loop is on adding > jackson-core and jackson-databind to exclusions. Excluding jackson from test > dependency to htrace-core4 fixed the issue. Since htrace-core4 has its own > relocated jackson, htrace-hbase does not need the transitive dependency. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (HTRACE-236) Support building release artifacts with Maven versions other than 3.0.4
[ https://issues.apache.org/jira/browse/HTRACE-236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin P. McCabe resolved HTRACE-236. Resolution: Duplicate Assignee: Masatake Iwasaki Fix Version/s: 3.4.0 > Support building release artifacts with Maven versions other than 3.0.4 > --- > > Key: HTRACE-236 > URL: https://issues.apache.org/jira/browse/HTRACE-236 > Project: HTrace > Issue Type: Bug > Components: build >Affects Versions: 4.0 >Reporter: Colin P. McCabe >Assignee: Masatake Iwasaki > Fix For: 3.4.0 > > > Because of HTRACE-234, we have had to limit the Maven version we use to > create releases to Maven 3.0.4. We should figure out how to make things work > correctly with later Maven releases as well. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HTRACE-399) Exclude jackson from test dependency on htrace-core4 to avoid infinite loop on creating dependency-reduced-pom
[ https://issues.apache.org/jira/browse/HTRACE-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16022139#comment-16022139 ] Colin P. McCabe commented on HTRACE-399: Thanks, [~iwasakims]. This is great! Finally we can use other Maven versions. I tested this with Maven 3.3.9 and it worked great. +1. > Exclude jackson from test dependency on htrace-core4 to avoid infinite loop > on creating dependency-reduced-pom > -- > > Key: HTRACE-399 > URL: https://issues.apache.org/jira/browse/HTRACE-399 > Project: HTrace > Issue Type: Bug > Components: htrace-hbase >Reporter: Masatake Iwasaki >Assignee: Masatake Iwasaki > Attachments: HTRACE-399.001.patch > > > This is follow-up of HTRACE-234. As it is descrived in MSHADE-148, depending > both of main and test jar of htrace-core4 causes the infinite loop on > creating dependency-reduced-pom. I found that the loop is on adding > jackson-core and jackson-databind to exclusions. Excluding jackson from test > dependency to htrace-core4 fixed the issue. Since htrace-core4 has its own > relocated jackson, htrace-hbase does not need the transitive dependency. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HTRACE-153) htrace-c should compile with -Pnative on Mac
[ https://issues.apache.org/jira/browse/HTRACE-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735882#comment-15735882 ] Colin P. McCabe commented on HTRACE-153: Hmm.. looks like I still need to find a solution to the IN6_IS_ADDR_LOOPBACK thing... > htrace-c should compile with -Pnative on Mac > > > Key: HTRACE-153 > URL: https://issues.apache.org/jira/browse/HTRACE-153 > Project: HTrace > Issue Type: Bug >Affects Versions: 3.2.0 >Reporter: Abraham Elmahrek >Assignee: Colin P. McCabe > Attachments: HTRACE-153.001.patch > > > The C and C++ code in htrace-c should compile on Mac OS X. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HTRACE-153) htrace-c should compile with -Pnative on Mac
[ https://issues.apache.org/jira/browse/HTRACE-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735876#comment-15735876 ] Colin P. McCabe commented on HTRACE-153: I have a patch for this, which I tested out locally. * CMakeLists.txt: Check whether sys/prctl.h exists, and avoid using prctl if it does not. * CMakeLists.txt: Check in /usr/local/include and /usr/local/lib for dependencies. These seem to be standard-ish places to install dependencies on MacOS X. * core/htrace.hpp: This should include stream, since it's using ostreams. For some reason, this works on Linux (probably because someone else is including stream for us). * receiver/hrpc.c: MacOS needs #include to get access to the writev function that we need. * receiver/hrpc.c: Move the endian.h functions into a separate file, util/endian.h, and add support for MacOS X. * receiver/htraced.c: MacOS doesn't define the standard pthread_yield function. Use the platform-specific sched_yield instead * receiver/receiver.h: The external htrace_rcv_ty objects need "extern" here. * Unit tests: use typecasts to avoid annoying warnings about comparing long and long long. * util/tracer_id.c: IN6_IS_ADDR_LOOPBACK doesn't work without the macros in util.net.h > htrace-c should compile with -Pnative on Mac > > > Key: HTRACE-153 > URL: https://issues.apache.org/jira/browse/HTRACE-153 > Project: HTrace > Issue Type: Bug >Affects Versions: 3.2.0 >Reporter: Abraham Elmahrek >Assignee: Colin P. McCabe > Attachments: HTRACE-153.001.patch > > > The C and C++ code in htrace-c should compile on Mac OS X. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (HTRACE-153) htrace-c should compile with -Pnative on Mac
[ https://issues.apache.org/jira/browse/HTRACE-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin P. McCabe reassigned HTRACE-153: -- Assignee: Colin P. McCabe (was: Abraham Elmahrek) > htrace-c should compile with -Pnative on Mac > > > Key: HTRACE-153 > URL: https://issues.apache.org/jira/browse/HTRACE-153 > Project: HTrace > Issue Type: Bug >Affects Versions: 3.2.0 >Reporter: Abraham Elmahrek >Assignee: Colin P. McCabe > Attachments: HTRACE-153.001.patch > > > The C and C++ code in htrace-c should compile on Mac OS X. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HTRACE-153) htrace-c should compile with -Pnative on Mac
[ https://issues.apache.org/jira/browse/HTRACE-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin P. McCabe updated HTRACE-153: --- Attachment: HTRACE-153.001.patch > htrace-c should compile with -Pnative on Mac > > > Key: HTRACE-153 > URL: https://issues.apache.org/jira/browse/HTRACE-153 > Project: HTrace > Issue Type: Bug >Affects Versions: 3.2.0 >Reporter: Abraham Elmahrek >Assignee: Abraham Elmahrek > Attachments: HTRACE-153.001.patch > > > The C and C++ code in htrace-c should compile on Mac OS X. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HTRACE-392) MilliSpan does not implement equals and hashcode
[
https://issues.apache.org/jira/browse/HTRACE-392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15606305#comment-15606305
]
Colin P. McCabe commented on HTRACE-392:
Yeah, putting spans in a hash map as values is totally reasonable. What I
meant to say was that Spans as hash map _keys_ seemed a little weird to me. It
wasn't obvious to me what the hash function should be for that. That's why we
did implement equals and hashCode for the SpanId class, so that you could do
{{HashMap}}
bq. instead of implementing e/hc we could also make Span implement Comparable
and order by SpanId? Implementing equality based on id seems fine though.
Maybe. I'm not sure if this would help users or not, though... when you want
to compare spans, writing a comparator is pretty simple.
I guess what it comes down to is that you can compare spans a lot of different
ways (starting time, ending time, duration, etc). I'm not sure that comparing
by span id is more intuitive than those other ways.
> MilliSpan does not implement equals and hashcode
>
>
> Key: HTRACE-392
> URL: https://issues.apache.org/jira/browse/HTRACE-392
> Project: HTrace
> Issue Type: Bug
> Components: core
>Affects Versions: 4.2
>Reporter: Mike Drob
>
> MilliSpan does not implement equal and hashcode, which can make test fixtures
> unnecessarily brittle when doing comparisons.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HTRACE-391) Allow specifying a random for SpanId.fromRandom()
[ https://issues.apache.org/jira/browse/HTRACE-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15605926#comment-15605926 ] Colin P. McCabe commented on HTRACE-391: Sounds like a good idea. > Allow specifying a random for SpanId.fromRandom() > - > > Key: HTRACE-391 > URL: https://issues.apache.org/jira/browse/HTRACE-391 > Project: HTrace > Issue Type: Test > Components: core >Affects Versions: 4.2 >Reporter: Mike Drob > > It would be useful for testing purposes to be able to specify a given > instance of Random for creating new SpanId. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HTRACE-392) MilliSpan does not implement equals and hashcode
[
https://issues.apache.org/jira/browse/HTRACE-392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15605955#comment-15605955
]
Colin P. McCabe commented on HTRACE-392:
In tests, we generally just use {{toJson}} to compare two different spans. The
json output is deterministic, so two spans which are equal should have the same
json output.
I had some anxiety about overriding equals and hashCode for Span. It seems
very easy to get it wrong by leaving out a field (especially when people are
adding new fields)-- or by hashing things in a different order, etc. Since
these functions are inherently public, any change to them affects the public
API on a deep level.
I also wasn't excited about people doing things like putting spans in HashMaps
using a hash function which hashes all fields. For example, I think it makes
more sense to just hash the spanId, rather than hashing every field in the
span, when putting spans into a HashMap.
I'm curious what you guys think about this-- maybe my concerns are misplaced?
In any case, if we do implement these functions, it should be because we're
ready to put them in the public API for all time (and define how they work
there). Unit tests can just use toJson where needed
> MilliSpan does not implement equals and hashcode
>
>
> Key: HTRACE-392
> URL: https://issues.apache.org/jira/browse/HTRACE-392
> Project: HTrace
> Issue Type: Bug
> Components: core
>Affects Versions: 4.2
>Reporter: Mike Drob
>
> MilliSpan does not implement equal and hashcode, which can make test fixtures
> unnecessarily brittle when doing comparisons.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HTRACE-386) htrace-c: add functions for retrieving the span ID to the public API
[ https://issues.apache.org/jira/browse/HTRACE-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15526608#comment-15526608 ] Colin P. McCabe commented on HTRACE-386: Thanks, [~iwasakims]! > htrace-c: add functions for retrieving the span ID to the public API > > > Key: HTRACE-386 > URL: https://issues.apache.org/jira/browse/HTRACE-386 > Project: HTrace > Issue Type: Improvement >Reporter: Colin P. McCabe >Assignee: Colin P. McCabe > Fix For: 4.3 > > Attachments: HTRACE-386.001.patch, HTRACE-386.002.patch > > > htrace-c: add functions for retrieving the span ID to the public API -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HTRACE-388) htrace-c: add functions for creating spans with given parents
Colin P. McCabe created HTRACE-388: -- Summary: htrace-c: add functions for creating spans with given parents Key: HTRACE-388 URL: https://issues.apache.org/jira/browse/HTRACE-388 Project: HTrace Issue Type: Improvement Reporter: Colin P. McCabe htrace-c: add functions for creating spans with given parents. Add some unit tests for the C and C++ versions of this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HTRACE-386) htrace-c: add functions for retrieving the span ID to the public API
[ https://issues.apache.org/jira/browse/HTRACE-386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin P. McCabe updated HTRACE-386: --- Attachment: (was: HTRACE-386.002.patch) > htrace-c: add functions for retrieving the span ID to the public API > > > Key: HTRACE-386 > URL: https://issues.apache.org/jira/browse/HTRACE-386 > Project: HTrace > Issue Type: Improvement >Reporter: Colin P. McCabe >Assignee: Colin P. McCabe > Attachments: HTRACE-386.001.patch > > > htrace-c: add functions for retrieving the span ID to the public API -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HTRACE-386) htrace-c: add functions for retrieving the span ID to the public API
[ https://issues.apache.org/jira/browse/HTRACE-386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin P. McCabe updated HTRACE-386: --- Attachment: HTRACE-386.002.patch > htrace-c: add functions for retrieving the span ID to the public API > > > Key: HTRACE-386 > URL: https://issues.apache.org/jira/browse/HTRACE-386 > Project: HTrace > Issue Type: Improvement >Reporter: Colin P. McCabe >Assignee: Colin P. McCabe > Attachments: HTRACE-386.001.patch, HTRACE-386.002.patch > > > htrace-c: add functions for retrieving the span ID to the public API -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HTRACE-386) htrace-c: add functions for retrieving the span ID to the public API
[ https://issues.apache.org/jira/browse/HTRACE-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523518#comment-15523518 ] Colin P. McCabe commented on HTRACE-386: bq. Newly exported symbols should be added to PUBLIC_SYMS in linkage-unit.c. Good catch. Added. bq. SpanId in htrace.hpp lacks the equivalent feature of htrace_span_id_clear and htrace_span_id_parse. Shoule we have them too? yeah, will add > htrace-c: add functions for retrieving the span ID to the public API > > > Key: HTRACE-386 > URL: https://issues.apache.org/jira/browse/HTRACE-386 > Project: HTrace > Issue Type: Improvement >Reporter: Colin P. McCabe >Assignee: Colin P. McCabe > Attachments: HTRACE-386.001.patch, HTRACE-386.002.patch > > > htrace-c: add functions for retrieving the span ID to the public API -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HTRACE-387) htrace-c should have a test dependency on htrace-htraced
Colin P. McCabe created HTRACE-387:
--
Summary: htrace-c should have a test dependency on htrace-htraced
Key: HTRACE-387
URL: https://issues.apache.org/jira/browse/HTRACE-387
Project: HTrace
Issue Type: Bug
Affects Versions: 4.1
Reporter: Colin P. McCabe
Assignee: Colin P. McCabe
Priority: Minor
htrace-c should have a test dependency on htrace-htraced. Otherwise this
command will fail if the htrace-c module gets built before the htrace-htraced
module: {{mvn test -Pnative}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HTRACE-386) htrace-c: add functions for retrieving the span ID to the public API
[ https://issues.apache.org/jira/browse/HTRACE-386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin P. McCabe updated HTRACE-386: --- Attachment: HTRACE-386.001.patch Expose the span ID API. We probably will need follow-on changes to assign parent span IDs to spans, and add unit tests, as well. > htrace-c: add functions for retrieving the span ID to the public API > > > Key: HTRACE-386 > URL: https://issues.apache.org/jira/browse/HTRACE-386 > Project: HTrace > Issue Type: Improvement >Reporter: Colin P. McCabe >Assignee: Colin P. McCabe > Attachments: HTRACE-386.001.patch > > > htrace-c: add functions for retrieving the span ID to the public API -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HTRACE-382) Make 4.2.0 release
[ https://issues.apache.org/jira/browse/HTRACE-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494968#comment-15494968 ] Colin P. McCabe commented on HTRACE-382: Thanks, [~mdrob] and [~stack]! Let me know if you need a review for stuff > Make 4.2.0 release > -- > > Key: HTRACE-382 > URL: https://issues.apache.org/jira/browse/HTRACE-382 > Project: HTrace > Issue Type: Task >Reporter: stack >Assignee: Mike Drob > > I'm following along the instructions here: > http://htrace.incubator.apache.org/building.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HTRACE-362) Apache KUDU Span receiver implementation for Apache HTrace
[ https://issues.apache.org/jira/browse/HTRACE-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471767#comment-15471767 ] Colin P. McCabe commented on HTRACE-362: If there's no objections, I'll assign this one to myself. I think we're close. We should credit Nisala for his work on some of this in the commit message. > Apache KUDU Span receiver implementation for Apache HTrace > -- > > Key: HTRACE-362 > URL: https://issues.apache.org/jira/browse/HTRACE-362 > Project: HTrace > Issue Type: Bug >Reporter: Nisala Mendis >Assignee: Nisala Mendis > Attachments: HTRACE-362.001.patch, HTRACE-362.002.patch, > HTRACE-362.003.patch, HTRACE-362.004.patch, HTRACE-362.005.patch, > HTRACE-362.006.patch, kudu_receiver.patch, kudu_span_receiver_basic_design.pdf > > > Implementation should be carried two components as span receiver that writes > kudu back end and span viewer to view written span/traces. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (HTRACE-369) htrace-zipkin: fix jdk8 javadoc build error
[ https://issues.apache.org/jira/browse/HTRACE-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15459943#comment-15459943 ] Colin P. McCabe edited comment on HTRACE-369 at 9/3/16 12:03 AM: - +1. Committed to master, thanks. Should we get this in 4.2? was (Author: cmccabe): +1. Let's get this in 4.2. Committed to 4.2, thanks > htrace-zipkin: fix jdk8 javadoc build error > --- > > Key: HTRACE-369 > URL: https://issues.apache.org/jira/browse/HTRACE-369 > Project: HTrace > Issue Type: Bug > Components: docs >Affects Versions: 4.0 >Reporter: Colin P. McCabe >Assignee: Mike Drob >Priority: Minor > Fix For: 4.2 > > Attachments: HTRACE-369.patch.txt > > > htrace-zipkin: fix jdk8 javadoc build error -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (HTRACE-369) htrace-zipkin: fix jdk8 javadoc build error
[ https://issues.apache.org/jira/browse/HTRACE-369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin P. McCabe resolved HTRACE-369. Resolution: Fixed Target Version/s: 4.2 (was: 4.3) +1. Let's get this in 4.2. Committed to 4.2, thanks > htrace-zipkin: fix jdk8 javadoc build error > --- > > Key: HTRACE-369 > URL: https://issues.apache.org/jira/browse/HTRACE-369 > Project: HTrace > Issue Type: Bug > Components: docs >Affects Versions: 4.0 >Reporter: Colin P. McCabe >Assignee: Mike Drob >Priority: Minor > Fix For: 4.2 > > Attachments: HTRACE-369.patch.txt > > > htrace-zipkin: fix jdk8 javadoc build error -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (HTRACE-346) Replace references to LICENSE urls in LICENSE.txt with full texts
[ https://issues.apache.org/jira/browse/HTRACE-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin P. McCabe resolved HTRACE-346. Resolution: Fixed Fix Version/s: 4.2 committed, thanks > Replace references to LICENSE urls in LICENSE.txt with full texts > - > > Key: HTRACE-346 > URL: https://issues.apache.org/jira/browse/HTRACE-346 > Project: HTrace > Issue Type: Bug > Components: docs >Affects Versions: 4.1 >Reporter: Colin P. McCabe >Assignee: Mike Drob > Fix For: 4.2 > > Attachments: HTRACE-346.patch.txt, HTRACE-346.v2.patch.txt > > > We should replace references to LICENSE urls in LICENSE.txt with the full > license texts, as explained by [~jmclean]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HTRACE-353) Please delete old releases from mirroring system
[ https://issues.apache.org/jira/browse/HTRACE-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15459933#comment-15459933 ] Colin P. McCabe commented on HTRACE-353: Hi [~sebb], while 4.0.1 is not the newest release, there are still many projects using 4.0.1, including Hadoop (if I remember correctly). Is that a concern for removing it from the mirroring system? The actual jar files will be fetched from Sonatype, of course. > Please delete old releases from mirroring system > > > Key: HTRACE-353 > URL: https://issues.apache.org/jira/browse/HTRACE-353 > Project: HTrace > Issue Type: Bug > Environment: > https://dist.apache.org/repos/dist/release/incubator/htrace/ >Reporter: Sebb >Assignee: Colin P. McCabe > Fix For: n/a > > > To reduce the load on the ASF mirrors, projects are required to delete old > releases [1] > Please can you remove all non-current releases? > Thanks! > [1] http://www.apache.org/dev/release.html#when-to-archive -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Reopened] (HTRACE-369) htrace-zipkin: fix jdk8 javadoc build error
[ https://issues.apache.org/jira/browse/HTRACE-369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin P. McCabe reopened HTRACE-369: > htrace-zipkin: fix jdk8 javadoc build error > --- > > Key: HTRACE-369 > URL: https://issues.apache.org/jira/browse/HTRACE-369 > Project: HTrace > Issue Type: Bug > Components: docs >Affects Versions: 4.0 >Reporter: Colin P. McCabe >Assignee: Mike Drob >Priority: Minor > Fix For: 4.2 > > Attachments: HTRACE-369.patch.txt > > > htrace-zipkin: fix jdk8 javadoc build error -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (HTRACE-372) htrace4-core: fix new jdk8 javadoc build errors
[
https://issues.apache.org/jira/browse/HTRACE-372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin P. McCabe resolved HTRACE-372.
Resolution: Fixed
Fix Version/s: 4.2
> htrace4-core: fix new jdk8 javadoc build errors
> ---
>
> Key: HTRACE-372
> URL: https://issues.apache.org/jira/browse/HTRACE-372
> Project: HTrace
> Issue Type: Bug
> Components: docs
>Affects Versions: 4.2
>Reporter: Colin P. McCabe
>Assignee: Mike Drob
>Priority: Blocker
> Fix For: 4.2
>
> Attachments: HTRACE-372.patch.txt
>
>
> It seems like we've accumulated some new jdk8 javadoc build errors:
> {code}
> 5 warnings
> [WARNING] Javadoc Warnings
> [WARNING]
> /home/cmccabe/htrace1/htrace-core4/src/main/java/org/apache/htrace/core/Span.java:94:
> warning: no @param for description
> [WARNING] Span child(String description);
> [WARNING] ^
> [WARNING]
> /home/cmccabe/htrace1/htrace-core4/src/main/java/org/apache/htrace/core/TraceRunnable.java:32:
> warning: no @param for tracer
> [WARNING] public TraceRunnable(Tracer tracer, TraceScope parent,
> [WARNING] ^
> [WARNING]
> /home/cmccabe/htrace1/htrace-core4/src/main/java/org/apache/htrace/core/TraceRunnable.java:32:
> warning: no @param for parent
> [WARNING] public TraceRunnable(Tracer tracer, TraceScope parent,
> [WARNING] ^
> [WARNING]
> /home/cmccabe/htrace1/htrace-core4/src/main/java/org/apache/htrace/core/TraceRunnable.java:32:
> warning: no @param for runnable
> [WARNING] public TraceRunnable(Tracer tracer, TraceScope parent,
> [WARNING] ^
> [WARNING]
> /home/cmccabe/htrace1/htrace-core4/src/main/java/org/apache/htrace/core/TraceRunnable.java:32:
> warning: no @param for description
> [WARNING] public TraceRunnable(Tracer tracer, TraceScope parent,
> [WARNING] ^
> {code}
> It seems like we need to start doing a javadoc build as part of our Jenkins
> post-commit job.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HTRACE-369) htrace-zipkin: fix jdk8 javadoc build error
[ https://issues.apache.org/jira/browse/HTRACE-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15439550#comment-15439550 ] Colin P. McCabe commented on HTRACE-369: +1. Thanks, [~mdrob] > htrace-zipkin: fix jdk8 javadoc build error > --- > > Key: HTRACE-369 > URL: https://issues.apache.org/jira/browse/HTRACE-369 > Project: HTrace > Issue Type: Bug > Components: docs >Affects Versions: 4.0 >Reporter: Colin P. McCabe >Assignee: Mike Drob >Priority: Minor > Attachments: HTRACE-369.patch.txt > > > htrace-zipkin: fix jdk8 javadoc build error -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (HTRACE-358) Provide convenience wrapper around ScheduledExecutorService
[
https://issues.apache.org/jira/browse/HTRACE-358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin P. McCabe resolved HTRACE-358.
Resolution: Fixed
Fix Version/s: 4.2
> Provide convenience wrapper around ScheduledExecutorService
> ---
>
> Key: HTRACE-358
> URL: https://issues.apache.org/jira/browse/HTRACE-358
> Project: HTrace
> Issue Type: Improvement
> Components: core
>Affects Versions: 4.1
>Reporter: Mike Drob
>Assignee: Mike Drob
> Fix For: 4.2
>
> Attachments: HTRACE-358.patch.txt, HTRACE-358.v2.patch.txt,
> HTRACE-358.v3.patch.txt
>
>
> We already provide a convenience wrapper around {{ExecutorService}}, it would
> not be onerous to also provide a wrapper around {{ScheduledExecutorService}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HTRACE-358) Provide convenience wrapper around ScheduledExecutorService
[
https://issues.apache.org/jira/browse/HTRACE-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15438168#comment-15438168
]
Colin P. McCabe commented on HTRACE-358:
Cool. Thanks for working on this.
{code}
+final int taskCount = 3;
+final int delay = 500;
{code}
Let's put constants in all caps
{code}
+HTraceConfiguration conf =
HTraceConfiguration.fromKeyValuePairs("sampler.classes", "AlwaysSampler");
{code}
We should use the constants for these configuration keys, rather than spelling
them out directly
There are some lines which are way, way longer than 80 columns, which makes
diffs hard to read. Can you break the lines at 80 columns?
+1 once that's addressed
> Provide convenience wrapper around ScheduledExecutorService
> ---
>
> Key: HTRACE-358
> URL: https://issues.apache.org/jira/browse/HTRACE-358
> Project: HTrace
> Issue Type: Improvement
> Components: core
>Affects Versions: 4.1
>Reporter: Mike Drob
>Assignee: Mike Drob
> Attachments: HTRACE-358.patch.txt, HTRACE-358.v2.patch.txt
>
>
> We already provide a convenience wrapper around {{ExecutorService}}, it would
> not be onerous to also provide a wrapper around {{ScheduledExecutorService}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HTRACE-362) Apache KUDU Span receiver implementation for Apache HTrace
[ https://issues.apache.org/jira/browse/HTRACE-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15433787#comment-15433787 ] Colin P. McCabe commented on HTRACE-362: Thanks for the confirmation. While I've got you here :) can we keep the KuduTable open while the SpanReceiver is open? The current patch reopens it on each span received, which seems like quite a waste. > Apache KUDU Span receiver implementation for Apache HTrace > -- > > Key: HTRACE-362 > URL: https://issues.apache.org/jira/browse/HTRACE-362 > Project: HTrace > Issue Type: Bug >Reporter: Nisala Mendis >Assignee: Nisala Mendis > Attachments: HTRACE-362.001.patch, HTRACE-362.002.patch, > HTRACE-362.003.patch, HTRACE-362.004.patch, HTRACE-362.005.patch, > kudu_receiver.patch, kudu_span_receiver_basic_design.pdf > > > Implementation should be carried two components as span receiver that writes > kudu back end and span viewer to view written span/traces. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HTRACE-362) Apache KUDU Span receiver implementation for Apache HTrace
[
https://issues.apache.org/jira/browse/HTRACE-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414708#comment-15414708
]
Colin P. McCabe commented on HTRACE-362:
Thanks, [~nisala12]. The {{pom.xml}} looks much better.
{code}
public class KuduClientConfiguration {
private final String host;
private final String port;
...
{code}
Hmm. Port should be an Integer, right? (I would normally suggest a Short, but
Java doesn't have unsigned 16-bit numbers). Same comment in
{{KuduSpanReceiver.java}}.
{code}
if (this.service != null) {
this.service.shutdownNow();
this.service = null;
}
{code}
This code in the constructor can't ever be invoked, since "service" starts out
initialized to null.
{{KuduSpanReceiver}}: I can see that you are using a BlockingQueue plus threads
to implement an async Kudu client. However, there is already an official async
Kudu client. See
http://kudu.apache.org/apidocs/org/kududb/client/AsyncKuduSession.html So we
don't need any of this stuff... just use the async client.
{code}
this.column_span_trace_id =
conf.get(KuduReceiverConstants.KUDU_COLUMN_SPAN_TRACE_ID_KEY,
KuduReceiverConstants.DEFAULT_KUDU_COLUMN_SPAN_TRACE_ID);
this.column_span_start_time =
conf.get(KuduReceiverConstants.KUDU_COLUMN_SPAN_START_TIME_KEY,
KuduReceiverConstants.DEFAULT_KUDU_COLUMN_SPAN_START_TIME);
this.column_span_stop_time =
conf.get(KuduReceiverConstants.KUDU_COLUMN_SPAN_STOP_TIME_KEY,
KuduReceiverConstants.DEFAULT_KUDU_COLUMN_SPAN_STOP_TIME);
...
{code}
Do we really need to make the names of all the columns configurable? It adds a
lot of complexity, and I can't think of a scenario where this would be useful.
If we think of a case where this would be useful, we can add it later.
On the other hand, I agree with the decision to make the table name
configurable. It lets you use the same Kudu instance as a backend for multiple
HTraces.
{code}
spanRow.addString(column_span_process_id,span.getTracerId());
{code}
There's no such thing as process id for spans in htrace 4
{code}
if (span.getParents().length == 0) {
spanRow.addLong(column_span_parent_id,0);
spanRow.addBoolean(column_span_parent,false);
} else if (span.getParents().length > 0) {
spanRow.addLong(column_span_parent_id,span.getParents()[0].getLow());
spanRow.addBoolean(column_span_parent,true);
}
{code}
This isn't correct. It's only storing one-half of one parent ID. Spans in
HTrace can have multiple parent IDs, which are all 128-bit.
I don't think we should have a separate table for timeline annotations. They
should be part of the span.
> Apache KUDU Span receiver implementation for Apache HTrace
> --
>
> Key: HTRACE-362
> URL: https://issues.apache.org/jira/browse/HTRACE-362
> Project: HTrace
> Issue Type: Bug
>Reporter: Nisala Mendis
>Assignee: Nisala Mendis
> Attachments: HTRACE-362.001.patch, HTRACE-362.002.patch,
> HTRACE-362.003.patch, HTRACE-362.004.patch, kudu_receiver.patch,
> kudu_span_receiver_basic_design.pdf
>
>
> Implementation should be carried two components as span receiver that writes
> kudu back end and span viewer to view written span/traces.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HTRACE-380) Add how to contribute instruction to README.md
[ https://issues.apache.org/jira/browse/HTRACE-380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin P. McCabe updated HTRACE-380: --- Attachment: HTRACE-380.001.patch That's a very good point. We should let people know about the importance of creating a JIRA. Take a look at this patch. > Add how to contribute instruction to README.md > -- > > Key: HTRACE-380 > URL: https://issues.apache.org/jira/browse/HTRACE-380 > Project: HTrace > Issue Type: Improvement > Components: docs >Reporter: Masatake Iwasaki >Assignee: Masatake Iwasaki > Attachments: HTRACE-380.001.patch > > > HTrace is using JIRA for issue tracking. The top page (of > github.com/apache/incubator-htrace) should have instruction to file a JIRA > issue before creating pull request. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (HTRACE-380) Add how to contribute instruction to README.md
[ https://issues.apache.org/jira/browse/HTRACE-380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin P. McCabe reassigned HTRACE-380: -- Assignee: Colin P. McCabe (was: Masatake Iwasaki) > Add how to contribute instruction to README.md > -- > > Key: HTRACE-380 > URL: https://issues.apache.org/jira/browse/HTRACE-380 > Project: HTrace > Issue Type: Improvement > Components: docs >Reporter: Masatake Iwasaki >Assignee: Colin P. McCabe > Attachments: HTRACE-380.001.patch > > > HTrace is using JIRA for issue tracking. The top page (of > github.com/apache/incubator-htrace) should have instruction to file a JIRA > issue before creating pull request. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HTRACE-362) Apache KUDU Span receiver implementation for Apache HTrace
[
https://issues.apache.org/jira/browse/HTRACE-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1547#comment-1547
]
Colin P. McCabe commented on HTRACE-362:
Hmm. Patch 003 doesn't apply for me.
{code}
cmccabe@redwall:~/incubator-htrace> git pull --ff
Already up-to-date.
cmccabe@redwall:~/incubator-htrace> git clean -fdqx .
cmccabe@redwall:~/incubator-htrace> wget
https://issues.apache.org/jira/secure/attachment/12822485/HTRACE-362.003.patch
--2016-08-07 09:40:00--
https://issues.apache.org/jira/secure/attachment/12822485/HTRACE-362.003.patch
Resolving issues.apache.org (issues.apache.org)... 140.211.11.138
Connecting to issues.apache.org (issues.apache.org)|140.211.11.138|:443...
connected.
HTTP request sent, awaiting response... 200 OK
Length: 114298 (112K) [text/x-patch]
Saving to: ‘HTRACE-362.003.patch’
HTRACE-362.003.patch
100%[===>]
111.62K 230KB/s in 0.5s p
2016-08-07 09:40:00 (230 KB/s) - ‘HTRACE-362.003.patch’ saved [114298/114298]
cmccabe@redwall:~/incubator-htrace> patch -p1 < HTRACE-362.003.patch
can't find file to patch at input line 22
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--
|From a6ca3ccf8007f41a112baf98328b9311b7148e7b Mon Sep 17 00:00:00 2001
|From: Nisala Nirmana
|Date: Mon, 8 Aug 2016 02:55:35 +0530
|Subject: [PATCH] adding colin review changes to span receiver
|
|---
| htrace-kudu/pom.xml| 51 -
| .../htrace/impl/KuduClientConfiguration.java | 35 +-
| .../apache/htrace/impl/KuduReceiverConstants.java | 73 +-
| .../org/apache/htrace/impl/KuduSpanReceiver.java | 171 +-
| .../htrace/protobuf/generated/SpanProtos.java | 2241
| htrace-kudu/src/main/protobuf/Span.proto | 38 -
| .../apache/htrace/impl/TestKuduSpanReceiver.java | 144 +-
| 7 files changed, 295 insertions(+), 2458 deletions(-)
| delete mode 100644
htrace-kudu/src/main/java/org/apache/htrace/protobuf/generated/SpanProtos.java
| delete mode 100644 htrace-kudu/src/main/protobuf/Span.proto
|
|diff --git a/htrace-kudu/pom.xml b/htrace-kudu/pom.xml
|index 58140a6..e977bd9 100644
|--- a/htrace-kudu/pom.xml
|+++ b/htrace-kudu/pom.xml
--
File to patch: ^C
{code}
> Apache KUDU Span receiver implementation for Apache HTrace
> --
>
> Key: HTRACE-362
> URL: https://issues.apache.org/jira/browse/HTRACE-362
> Project: HTrace
> Issue Type: Bug
>Reporter: Nisala Mendis
>Assignee: Nisala Mendis
> Attachments: HTRACE-362.001.patch, HTRACE-362.002.patch,
> HTRACE-362.003.patch, kudu_receiver.patch, kudu_span_receiver_basic_design.pdf
>
>
> Implementation should be carried two components as span receiver that writes
> kudu back end and span viewer to view written span/traces.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HTRACE-378) Jar file of 4.1.0-incubating is too large
[ https://issues.apache.org/jira/browse/HTRACE-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391604#comment-15391604 ] Colin P. McCabe commented on HTRACE-378: Hmm. This was done in order to avoid CLASSPATH issues. Clearly Zipkin has many dependencies and oftentimes uses a different version of those dependencies than software which is trying to use it. Is the size of the jar file causing problems for you, or do you just feel that this is something we could improve? > Jar file of 4.1.0-incubating is too large > - > > Key: HTRACE-378 > URL: https://issues.apache.org/jira/browse/HTRACE-378 > Project: HTrace > Issue Type: Bug > Components: zipkin >Affects Versions: 4.1 >Reporter: qiuxiafei > > It seems that all dependencies are packed into it. > See > http://repo1.maven.org/maven2/org/apache/htrace/htrace-zipkin/4.1.0-incubating/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HTRACE-362) Apache KUDU Span receiver implementation for Apache HTrace
[ https://issues.apache.org/jira/browse/HTRACE-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15388091#comment-15388091 ] Colin P. McCabe commented on HTRACE-362: Can you please attach a patch file like I asked previously? > Apache KUDU Span receiver implementation for Apache HTrace > -- > > Key: HTRACE-362 > URL: https://issues.apache.org/jira/browse/HTRACE-362 > Project: HTrace > Issue Type: Bug >Reporter: Nisala Mendis >Assignee: Nisala Mendis > Attachments: HTRACE-362.001.patch, HTRACE-362.002.patch, > kudu_span_receiver_basic_design.pdf > > > Implementation should be carried two components as span receiver that writes > kudu back end and span viewer to view written span/traces. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HTRACE-362) Apache KUDU Span receiver implementation for Apache HTrace
[ https://issues.apache.org/jira/browse/HTRACE-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin P. McCabe updated HTRACE-362: --- Attachment: HTRACE-362.002.patch > Apache KUDU Span receiver implementation for Apache HTrace > -- > > Key: HTRACE-362 > URL: https://issues.apache.org/jira/browse/HTRACE-362 > Project: HTrace > Issue Type: Bug >Reporter: Nisala Mendis >Assignee: Nisala Mendis > Attachments: HTRACE-362.001.patch, HTRACE-362.002.patch, > kudu_span_receiver_basic_design.pdf > > > Implementation should be carried two components as span receiver that writes > kudu back end and span viewer to view written span/traces. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (HTRACE-363) Add tests for newScope with parent id
[ https://issues.apache.org/jira/browse/HTRACE-363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin P. McCabe resolved HTRACE-363. Resolution: Fixed Fix Version/s: 4.2 Target Version/s: 4.2 committed to 4.2 > Add tests for newScope with parent id > - > > Key: HTRACE-363 > URL: https://issues.apache.org/jira/browse/HTRACE-363 > Project: HTrace > Issue Type: Test > Components: core >Reporter: Mike Drob >Assignee: Nisala Mendis > Fix For: 4.2 > > Attachments: HTRACE-363.002.patch, HTRACE-363.003.patch > > > We should add some tests to verify that when there is a currently active > scope and `newScope` is called with a valid parent id that both are included > in the child span. The current code does this correctly, I think, but we > should have tests to prevent accidental regressions in the future. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HTRACE-363) Add tests for newScope with parent id
[ https://issues.apache.org/jira/browse/HTRACE-363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin P. McCabe updated HTRACE-363: --- Attachment: HTRACE-363.003.patch > Add tests for newScope with parent id > - > > Key: HTRACE-363 > URL: https://issues.apache.org/jira/browse/HTRACE-363 > Project: HTrace > Issue Type: Test > Components: core >Reporter: Mike Drob >Assignee: Nisala Mendis > Attachments: HTRACE-363.002.patch, HTRACE-363.003.patch > > > We should add some tests to verify that when there is a currently active > scope and `newScope` is called with a valid parent id that both are included > in the child span. The current code does this correctly, I think, but we > should have tests to prevent accidental regressions in the future. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HTRACE-377) The HTrace website should include the Apache incubator disclaimer
[ https://issues.apache.org/jira/browse/HTRACE-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15383449#comment-15383449 ] Colin P. McCabe commented on HTRACE-377: Thanks, [~iwasakims]. I should have closed this one after I pushed to the website. > The HTrace website should include the Apache incubator disclaimer > - > > Key: HTRACE-377 > URL: https://issues.apache.org/jira/browse/HTRACE-377 > Project: HTrace > Issue Type: Bug >Reporter: Colin P. McCabe >Assignee: Colin P. McCabe > Fix For: 4.2 > > Attachments: HTRACE-377.001.patch > > > The HTrace website should include the Apache incubator disclaimer. From > http://incubator.apache.org/guides/branding.html > bq. Apache Podling-Name is an effort undergoing incubation at The Apache > Software Foundation (ASF), sponsored by the name of Apache TLP sponsor. > Incubation is required of all newly accepted projects until a further review > indicates that the infrastructure, communications, and decision making > process have stabilized in a manner consistent with other successful ASF > projects. While incubation status is not necessarily a reflection of the > completeness or stability of the code, it does indicate that the project has > yet to be fully endorsed by the ASF. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HTRACE-377) The HTrace website should include the Apache incubator disclaimer
[ https://issues.apache.org/jira/browse/HTRACE-377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin P. McCabe updated HTRACE-377: --- Attachment: HTRACE-377.001.patch > The HTrace website should include the Apache incubator disclaimer > - > > Key: HTRACE-377 > URL: https://issues.apache.org/jira/browse/HTRACE-377 > Project: HTrace > Issue Type: Bug >Reporter: Colin P. McCabe > Attachments: HTRACE-377.001.patch > > > The HTrace website should include the Apache incubator disclaimer. From > http://incubator.apache.org/guides/branding.html > bq. Apache Podling-Name is an effort undergoing incubation at The Apache > Software Foundation (ASF), sponsored by the name of Apache TLP sponsor. > Incubation is required of all newly accepted projects until a further review > indicates that the infrastructure, communications, and decision making > process have stabilized in a manner consistent with other successful ASF > projects. While incubation status is not necessarily a reflection of the > completeness or stability of the code, it does indicate that the project has > yet to be fully endorsed by the ASF. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
