[
https://issues.apache.org/jira/browse/HTRACE-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15438168#comment-15438168
]
Colin P. McCabe commented on HTRACE-358:
----------------------------------------
Cool. Thanks for working on this.
{code}
+ final int taskCount = 3;
+ final int delay = 500;
{code}
Let's put constants in all caps
{code}
+ HTraceConfiguration conf =
HTraceConfiguration.fromKeyValuePairs("sampler.classes", "AlwaysSampler");
{code}
We should use the constants for these configuration keys, rather than spelling
them out directly
There are some lines which are way, way longer than 80 columns, which makes
diffs hard to read. Can you break the lines at 80 columns?
+1 once that's addressed
> Provide convenience wrapper around ScheduledExecutorService
> -----------------------------------------------------------
>
> Key: HTRACE-358
> URL: https://issues.apache.org/jira/browse/HTRACE-358
> Project: HTrace
> Issue Type: Improvement
> Components: core
> Affects Versions: 4.1
> Reporter: Mike Drob
> Assignee: Mike Drob
> Attachments: HTRACE-358.patch.txt, HTRACE-358.v2.patch.txt
>
>
> We already provide a convenience wrapper around {{ExecutorService}}, it would
> not be onerous to also provide a wrapper around {{ScheduledExecutorService}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
