[
https://issues.apache.org/jira/browse/HTRACE-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16066969#comment-16066969
]
Mike Drob commented on HTRACE-389:
--
+1
> remove the copyright line from bin/gen_thrift.sh
>
[
https://issues.apache.org/jira/browse/HTRACE-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated HTRACE-389:
-
Target Version/s: 4.4
Priority: Blocker (was: Major)
> remove the copyright line from
[
https://issues.apache.org/jira/browse/HTRACE-398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011636#comment-16011636
]
Mike Drob commented on HTRACE-398:
--
[~cmccabe] - can you take a look?
> Document build limitations
[
https://issues.apache.org/jira/browse/HTRACE-398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated HTRACE-398:
-
Description:
In the 4.2 release, we had the suggestion to use maven-enforcer-plugin to guide
people
[
https://issues.apache.org/jira/browse/HTRACE-398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated HTRACE-398:
-
Attachment: HTRACE-398.patch
Patch to add enforcer rules and more explicit instructions in `BUILDING.txt`
Mike Drob created HTRACE-398:
Summary: Document build limitations present in HTRACE-236
Key: HTRACE-398
URL: https://issues.apache.org/jira/browse/HTRACE-398
Project: HTrace
Issue Type: Bug
Mike Drob created HTRACE-397:
Summary: Update C client version string automatically
Key: HTRACE-397
URL: https://issues.apache.org/jira/browse/HTRACE-397
Project: HTrace
Issue Type: Bug
Mike Drob created HTRACE-395:
Summary: Update Website after 4.3.0
Key: HTRACE-395
URL: https://issues.apache.org/jira/browse/HTRACE-395
Project: HTrace
Issue Type: Task
Reporter:
[
https://issues.apache.org/jira/browse/HTRACE-394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated HTRACE-394:
-
Fix Version/s: 4.3
> Release 4.3.0-incubating
>
>
> Key:
Mike Drob created HTRACE-394:
Summary: Release 4.3.0-incubating
Key: HTRACE-394
URL: https://issues.apache.org/jira/browse/HTRACE-394
Project: HTrace
Issue Type: Task
Reporter: Mike
Mike Drob created HTRACE-392:
Summary: MilliSpan does not implement equals and hashcode
Key: HTRACE-392
URL: https://issues.apache.org/jira/browse/HTRACE-392
Project: HTrace
Issue Type: Bug
[
https://issues.apache.org/jira/browse/HTRACE-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated HTRACE-336:
-
Affects Version/s: (was: 4.01)
4.1
> htraced: add a method of searching based
Mike Drob created HTRACE-390:
Summary: LICENSE is missing MIT licensed normalise.css bundled in
several bootstrap files
Key: HTRACE-390
URL: https://issues.apache.org/jira/browse/HTRACE-390
Project:
[
https://issues.apache.org/jira/browse/HTRACE-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495311#comment-15495311
]
Mike Drob commented on HTRACE-383:
--
Some more changes to the doc:
{noformat}
diff --git
[
https://issues.apache.org/jira/browse/HTRACE-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493645#comment-15493645
]
Mike Drob commented on HTRACE-382:
--
The version in the pom is set to {{4.2.0}}. Does that need to be
[
https://issues.apache.org/jira/browse/HTRACE-374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated HTRACE-374:
-
Target Version/s: 4.3 (was: 4.2)
> Add markdown documentation about htraced span receiver
>
[
https://issues.apache.org/jira/browse/HTRACE-381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated HTRACE-381:
-
Target Version/s: 4.3 (was: 4.2)
> Refactor tests to use contants instead of Strings
>
[
https://issues.apache.org/jira/browse/HTRACE-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15456608#comment-15456608
]
Mike Drob commented on HTRACE-346:
--
[~cmccabe] - Can you take a look at this? This seems fairly important
[
https://issues.apache.org/jira/browse/HTRACE-381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated HTRACE-381:
-
Attachment: HTRACE-381.patch.txt
Patch attached.
> Refactor tests to use contants instead of Strings
>
[
https://issues.apache.org/jira/browse/HTRACE-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15439567#comment-15439567
]
Mike Drob commented on HTRACE-369:
--
Yea. It also has the unfortunate side effect of suppressing missing
[
https://issues.apache.org/jira/browse/HTRACE-381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated HTRACE-381:
-
Priority: Minor (was: Major)
> Refactor tests to use contants instead of Strings
>
[
https://issues.apache.org/jira/browse/HTRACE-369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob reassigned HTRACE-369:
Assignee: Mike Drob
> htrace-zipkin: fix jdk8 javadoc build error
>
[
https://issues.apache.org/jira/browse/HTRACE-369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated HTRACE-369:
-
Attachment: HTRACE-369.patch.txt
A patch to fix some of the errors seen. We continue to ignore errors on
[
https://issues.apache.org/jira/browse/HTRACE-372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated HTRACE-372:
-
Attachment: HTRACE-372.patch.txt
Attaching a patch that adds the missing javadoc tags.
> htrace4-core:
[
https://issues.apache.org/jira/browse/HTRACE-372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated HTRACE-372:
-
Priority: Blocker (was: Major)
> htrace4-core: fix new jdk8 javadoc build errors
>
Mike Drob created HTRACE-381:
Summary: Refactor tests to use contants instead of Strings
Key: HTRACE-381
URL: https://issues.apache.org/jira/browse/HTRACE-381
Project: HTrace
Issue Type: Task
[
https://issues.apache.org/jira/browse/HTRACE-358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated HTRACE-358:
-
Attachment: HTRACE-358.v3.patch.txt
v3: Used CAPS for constants, used constants for Strings, and wrapped
[
https://issues.apache.org/jira/browse/HTRACE-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15275726#comment-15275726
]
Mike Drob commented on HTRACE-363:
--
Something like...
{code}
TraceScope scope = tracer.newScope();
[
https://issues.apache.org/jira/browse/HTRACE-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15274074#comment-15274074
]
Mike Drob commented on HTRACE-358:
--
bq. Rather than adding these new APIs, can we just have an API for
[
https://issues.apache.org/jira/browse/HTRACE-359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated HTRACE-359:
-
Attachment: HTRACE-359.v4.patch.txt
New patch that undoes most of the Tracer.java changes, adds public
Mike Drob created HTRACE-366:
Summary: Add JavaDoc to missing classes.
Key: HTRACE-366
URL: https://issues.apache.org/jira/browse/HTRACE-366
Project: HTrace
Issue Type: Bug
Components:
Mike Drob created HTRACE-363:
Summary: Add tests for newScope with parent id
Key: HTRACE-363
URL: https://issues.apache.org/jira/browse/HTRACE-363
Project: HTrace
Issue Type: Test
[
https://issues.apache.org/jira/browse/HTRACE-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15258763#comment-15258763
]
Mike Drob commented on HTRACE-359:
--
Filed HTRACE-363
> TraceRunnable and TraceCallable should be built
[
https://issues.apache.org/jira/browse/HTRACE-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15258758#comment-15258758
]
Mike Drob commented on HTRACE-359:
--
bq. It might "feel" cleaner to simply make the constructor which
[
https://issues.apache.org/jira/browse/HTRACE-359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated HTRACE-359:
-
Attachment: HTRACE-359.v3.patch.txt
New patch attached that does not modify public constructors.
>
[
https://issues.apache.org/jira/browse/HTRACE-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257071#comment-15257071
]
Mike Drob commented on HTRACE-347:
--
Let's talk about the JavaDoc as a separate issue, since I believe
[
https://issues.apache.org/jira/browse/HTRACE-359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated HTRACE-359:
-
Summary: TraceRunnable and TraceCallable should be built using parent
spanId not scope (was:
[
https://issues.apache.org/jira/browse/HTRACE-359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated HTRACE-359:
-
Attachment: HTRACE-359.patch.txt
Patch attached with new Tracer methods.
> TraceRunnable and
[
https://issues.apache.org/jira/browse/HTRACE-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248332#comment-15248332
]
Mike Drob commented on HTRACE-359:
--
Would you suggest making the {{TraceRunnable}} constructor non-public
[
https://issues.apache.org/jira/browse/HTRACE-360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated HTRACE-360:
-
Attachment: HTRACE-360.patch.txt
> Missing space in Sampler.java
> -
>
>
Mike Drob created HTRACE-360:
Summary: Missing space in Sampler.java
Key: HTRACE-360
URL: https://issues.apache.org/jira/browse/HTRACE-360
Project: HTrace
Issue Type: Bug
Components:
[
https://issues.apache.org/jira/browse/HTRACE-359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated HTRACE-359:
-
Attachment: HTRACE-359.patch.txt
> TraceRunnable and TraceCallable should store parent spanId not scope
>
[
https://issues.apache.org/jira/browse/HTRACE-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248003#comment-15248003
]
Mike Drob commented on HTRACE-359:
--
Also, TraceCallable should have a public constructor to match
Mike Drob created HTRACE-359:
Summary: TraceRunnable and TraceCallable should store parent
spanId not scope
Key: HTRACE-359
URL: https://issues.apache.org/jira/browse/HTRACE-359
Project: HTrace
[
https://issues.apache.org/jira/browse/HTRACE-358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated HTRACE-358:
-
Attachment: HTRACE-358.patch.txt
> Provide convenience wrapper around ScheduledExecutorService
>
Mike Drob created HTRACE-358:
Summary: Provide convenience wrapper around
ScheduledExecutorService
Key: HTRACE-358
URL: https://issues.apache.org/jira/browse/HTRACE-358
Project: HTrace
Issue
[
https://issues.apache.org/jira/browse/HTRACE-355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated HTRACE-355:
-
Attachment: HTRACE-355.patch.txt
Updated patch with Colin's suggestions.
I did not see an existing
Mike Drob created HTRACE-355:
Summary: TraceRunnable and TraceCallable should pull description
from child thread instead of parent
Key: HTRACE-355
URL: https://issues.apache.org/jira/browse/HTRACE-355
[
https://issues.apache.org/jira/browse/HTRACE-355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated HTRACE-355:
-
Attachment: HTRACE-355.patch.txt
> TraceRunnable and TraceCallable should pull description from child
[
https://issues.apache.org/jira/browse/HTRACE-349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated HTRACE-349:
-
Priority: Minor (was: Major)
> Java implementation should use try-with-resources for scopes
>
[
https://issues.apache.org/jira/browse/HTRACE-349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated HTRACE-349:
-
Attachment: HTRACE-349.patch.txt
Simple patch attached. Does not touch most of the tests since they
[
https://issues.apache.org/jira/browse/HTRACE-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15215968#comment-15215968
]
Mike Drob commented on HTRACE-347:
--
A bit more generally, the website was Last Published: 2015-09-15 and
[
https://issues.apache.org/jira/browse/HTRACE-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15214265#comment-15214265
]
Mike Drob commented on HTRACE-348:
--
https://github.com/apache/incubator-htrace/pull/5
> Tracer.java
Mike Drob created HTRACE-348:
Summary: Tracer.java error message cites SpanReceiver instead of
Sampler
Key: HTRACE-348
URL: https://issues.apache.org/jira/browse/HTRACE-348
Project: HTrace
Mike Drob created HTRACE-347:
Summary: Dependency info page lists snapshots instead of releases
Key: HTRACE-347
URL: https://issues.apache.org/jira/browse/HTRACE-347
Project: HTrace
Issue Type:
55 matches
Mail list logo
