[
https://issues.apache.org/jira/browse/HTRACE-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274074#comment-15274074
]
Mike Drob commented on HTRACE-358:
----------------------------------
bq. Rather than adding these new APIs, can we just have an API for getting the
Tracer owned by the base class?
If we did this, we'd end up implementing the same `wrap` methods twice in
`TraceExecutorService` and `ScheduledTraceExecutorService` and I don't think
that will lead to sustainable code in the future.
bq. I would also prefer that this method be package-private for now rather than
protected... let's keep the API surface small.
Do protected methods show up in the public API? I was unaware of this
previously, but have no problems with doing package-private instead.
bq. Also, let's have some javadoc for the new class
Will get this in the next patch once we settle the rest of the questions.
> Provide convenience wrapper around ScheduledExecutorService
> -----------------------------------------------------------
>
> Key: HTRACE-358
> URL: https://issues.apache.org/jira/browse/HTRACE-358
> Project: HTrace
> Issue Type: Improvement
> Components: core
> Affects Versions: 4.1
> Reporter: Mike Drob
> Assignee: Mike Drob
> Attachments: HTRACE-358.patch.txt
>
>
> We already provide a convenience wrapper around {{ExecutorService}}, it would
> not be onerous to also provide a wrapper around {{ScheduledExecutorService}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
