[GitHub] [incubator-iceberg] waterlx commented on issue #394: Re-deploy web page to fix #333

2019-08-25 Thread GitBox
waterlx commented on issue #394: Re-deploy web page to fix #333 URL: https://github.com/apache/incubator-iceberg/issues/394#issuecomment-524706332 The web page is updated, thanks! This is an automated message from the Apache

[GitHub] [incubator-iceberg] jbapple commented on issue #348: Avoid floating point number ordering NaN semantics

2019-08-25 Thread GitBox
jbapple commented on issue #348: Avoid floating point number ordering NaN semantics URL: https://github.com/apache/incubator-iceberg/pull/348#issuecomment-524681562 OK, pushed a new version. I didn't make any changes to Java or Python code in order to keep this commit focused on doing one

[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #362: Support create and replace transactions in Catalog

2019-08-25 Thread GitBox
aokolnychyi commented on a change in pull request #362: Support create and replace transactions in Catalog URL: https://github.com/apache/incubator-iceberg/pull/362#discussion_r317420150 ## File path: hive/src/test/java/org/apache/iceberg/hive/HiveCreateReplaceTableTest.java

[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #362: Support create and replace transactions in Catalog

2019-08-25 Thread GitBox
aokolnychyi commented on a change in pull request #362: Support create and replace transactions in Catalog URL: https://github.com/apache/incubator-iceberg/pull/362#discussion_r317420104 ## File path: hive/src/test/java/org/apache/iceberg/hive/HiveCreateReplaceTableTest.java

[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #362: Support create and replace transactions in Catalog

2019-08-25 Thread GitBox
aokolnychyi commented on a change in pull request #362: Support create and replace transactions in Catalog URL: https://github.com/apache/incubator-iceberg/pull/362#discussion_r317420055 ## File path: hive/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java ##

[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #362: Support create and replace transactions in Catalog

2019-08-25 Thread GitBox
aokolnychyi commented on a change in pull request #362: Support create and replace transactions in Catalog URL: https://github.com/apache/incubator-iceberg/pull/362#discussion_r317419683 ## File path: core/src/main/java/org/apache/iceberg/BaseTransaction.java ## @@ -241,7

[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #398: Push down StringStartsWith in Spark IcebergSource

2019-08-25 Thread GitBox
aokolnychyi commented on a change in pull request #398: Push down StringStartsWith in Spark IcebergSource URL: https://github.com/apache/incubator-iceberg/pull/398#discussion_r317416149 ## File path: api/src/main/java/org/apache/iceberg/expressions/InclusiveMetricsEvaluator.java

[GitHub] [incubator-iceberg] aokolnychyi opened a new pull request #414: Add toByteBuffer to Literal

2019-08-25 Thread GitBox
aokolnychyi opened a new pull request #414: Add toByteBuffer to Literal URL: https://github.com/apache/incubator-iceberg/pull/414 This PR extends `Literal` with `toByteBuffer` to allow us to get binary representations of literals.

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #348: Avoid floating point number ordering NaN semantics

2019-08-25 Thread GitBox
rdblue commented on a change in pull request #348: Avoid floating point number ordering NaN semantics URL: https://github.com/apache/incubator-iceberg/pull/348#discussion_r317413767 ## File path: site/docs/spec.md ## @@ -206,19 +206,22 @@ The schema of a manifest file is

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #348: Avoid floating point number ordering NaN semantics

2019-08-25 Thread GitBox
rdblue commented on a change in pull request #348: Avoid floating point number ordering NaN semantics URL: https://github.com/apache/incubator-iceberg/pull/348#discussion_r317413690 ## File path: site/docs/spec.md ## @@ -206,19 +206,22 @@ The schema of a manifest file is

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #362: Support create and replace transactions in Catalog

2019-08-25 Thread GitBox
rdblue commented on a change in pull request #362: Support create and replace transactions in Catalog URL: https://github.com/apache/incubator-iceberg/pull/362#discussion_r317413447 ## File path: core/src/main/java/org/apache/iceberg/BaseTransaction.java ## @@ -241,7

[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes

2019-08-25 Thread GitBox
aokolnychyi commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r317398734 ## File path: core/src/main/java/org/apache/iceberg/OverwriteData.java

[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes

2019-08-25 Thread GitBox
aokolnychyi commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r317398659 ## File path: core/src/main/java/org/apache/iceberg/OverwriteData.java

[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes

2019-08-25 Thread GitBox
aokolnychyi commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r317398607 ## File path: core/src/main/java/org/apache/iceberg/OverwriteData.java

[GitHub] [incubator-iceberg] aokolnychyi opened a new pull request #412: Use null counts in metrics evaluators

2019-08-25 Thread GitBox
aokolnychyi opened a new pull request #412: Use null counts in metrics evaluators URL: https://github.com/apache/incubator-iceberg/pull/412 As discussed in #398, we need to take into account null counts in metrics evaluators. This PR resolves #408.

[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #362: Support create and replace transactions in Catalog

2019-08-25 Thread GitBox
aokolnychyi commented on a change in pull request #362: Support create and replace transactions in Catalog URL: https://github.com/apache/incubator-iceberg/pull/362#discussion_r317387008 ## File path: core/src/main/java/org/apache/iceberg/BaseTransaction.java ## @@ -241,7