[GitHub] [incubator-iceberg] xabriel commented on a change in pull request #432: Allow writers to control size of files generated

xabriel commented on a change in pull request #432: Allow writers to control size of files generated URL: https://github.com/apache/incubator-iceberg/pull/432#discussion_r321031899 ## File path: spark/src/main/java/org/apache/iceberg/spark/source/Writer.java ## @@ -303,66

[GitHub] [incubator-iceberg] danielcweeks merged pull request #418: Add missing manifest cleanup tests

danielcweeks merged pull request #418: Add missing manifest cleanup tests URL: https://github.com/apache/incubator-iceberg/pull/418 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-iceberg] xabriel commented on a change in pull request #432: Allow writers to control size of files generated

xabriel commented on a change in pull request #432: Allow writers to control size of files generated URL: https://github.com/apache/incubator-iceberg/pull/432#discussion_r321022808 ## File path: spark/src/main/java/org/apache/iceberg/spark/source/Writer.java ## @@ -303,66

[GitHub] [incubator-iceberg] xabriel commented on a change in pull request #432: Allow writers to control size of files generated

xabriel commented on a change in pull request #432: Allow writers to control size of files generated URL: https://github.com/apache/incubator-iceberg/pull/432#discussion_r321022527 ## File path: spark/src/main/java/org/apache/iceberg/spark/source/Writer.java ## @@ -303,66

[GitHub] [incubator-iceberg] xabriel commented on a change in pull request #432: Allow writers to control size of files generated

xabriel commented on a change in pull request #432: Allow writers to control size of files generated URL: https://github.com/apache/incubator-iceberg/pull/432#discussion_r321022403 ## File path: spark/src/main/java/org/apache/iceberg/spark/source/Writer.java ## @@ -303,66

[GitHub] [incubator-iceberg] xabriel commented on a change in pull request #432: Allow writers to control size of files generated

xabriel commented on a change in pull request #432: Allow writers to control size of files generated URL: https://github.com/apache/incubator-iceberg/pull/432#discussion_r321022059 ## File path: spark/src/main/java/org/apache/iceberg/spark/source/Writer.java ## @@ -303,66

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #432: Allow writers to control size of files generated

rdblue commented on a change in pull request #432: Allow writers to control size of files generated URL: https://github.com/apache/incubator-iceberg/pull/432#discussion_r321017786 ## File path: spark/src/main/java/org/apache/iceberg/spark/source/Writer.java ## @@ -425,17

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #432: Allow writers to control size of files generated

rdblue commented on a change in pull request #432: Allow writers to control size of files generated URL: https://github.com/apache/incubator-iceberg/pull/432#discussion_r321016820 ## File path: spark/src/main/java/org/apache/iceberg/spark/source/Writer.java ## @@ -303,66

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #432: Allow writers to control size of files generated

rdblue commented on a change in pull request #432: Allow writers to control size of files generated URL: https://github.com/apache/incubator-iceberg/pull/432#discussion_r321016595 ## File path: spark/src/main/java/org/apache/iceberg/spark/source/Writer.java ## @@ -303,66

[GitHub] [incubator-iceberg] chenjunjiedada commented on a change in pull request #374: Migrate spark table to iceberg table

chenjunjiedada commented on a change in pull request #374: Migrate spark table to iceberg table URL: https://github.com/apache/incubator-iceberg/pull/374#discussion_r321016145 ## File path: hive/src/test/java/org/apache/iceberg/hive/TestHiveMetastore.java ## @@ -102,7

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #432: Allow writers to control size of files generated

rdblue commented on a change in pull request #432: Allow writers to control size of files generated URL: https://github.com/apache/incubator-iceberg/pull/432#discussion_r321015709 ## File path: spark/src/main/java/org/apache/iceberg/spark/source/Writer.java ## @@ -303,66

[GitHub] [incubator-iceberg] rdblue merged pull request #380: Rename some implementations for consistency

rdblue merged pull request #380: Rename some implementations for consistency URL: https://github.com/apache/incubator-iceberg/pull/380 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-iceberg] bsannicolas opened a new issue #451: Encryption not working

bsannicolas opened a new issue #451: Encryption not working URL: https://github.com/apache/incubator-iceberg/issues/451 I don't know if I'm doing something wrong but I haven't been able to get encryption to work with Iceberg. I've created an implementation of the EncryptionManager that

[GitHub] [incubator-iceberg] rdblue commented on issue #252: Add metadata tables

rdblue commented on issue #252: Add metadata tables URL: https://github.com/apache/incubator-iceberg/pull/252#issuecomment-528043541 Yeah, the catalog first looks up the table name that is passed in and if it doesn't find that one, checks to see if the table name is a metadata table name

[GitHub] [incubator-iceberg] linxingyuan1102 commented on issue #252: Add metadata tables

linxingyuan1102 commented on issue #252: Add metadata tables URL: https://github.com/apache/incubator-iceberg/pull/252#issuecomment-528039000 Thank you for the pointer. I see the point now. The name of the underlying table to be queried is stored in `Namespace::levels` when a metadata

[GitHub] [incubator-iceberg] xabriel commented on issue #432: Allow writers to control size of files generated

xabriel commented on issue #432: Allow writers to control size of files generated URL: https://github.com/apache/incubator-iceberg/pull/432#issuecomment-528027010 Fix in #450 indeed takes care of the test failure. Thanks @rdblue. @rdblue, @aokolnychyi: This PR is now ready for

[GitHub] [incubator-iceberg] danielcweeks merged pull request #444: Use constant readers for Pig partition values

danielcweeks merged pull request #444: Use constant readers for Pig partition values URL: https://github.com/apache/incubator-iceberg/pull/444 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-iceberg] danielcweeks commented on issue #444: Use constant readers for Pig partition values

danielcweeks commented on issue #444: Use constant readers for Pig partition values URL: https://github.com/apache/incubator-iceberg/pull/444#issuecomment-528011492 +1 This is an automated message from the Apache Git

[GitHub] [incubator-iceberg] edgarRd commented on issue #227: ORC column map fix

edgarRd commented on issue #227: ORC column map fix URL: https://github.com/apache/incubator-iceberg/pull/227#issuecomment-527999715 @rdblue Yeah, I'll work on this today. I will update everyone once this is ready for final review.

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #374: Migrate spark table to iceberg table

rdblue commented on a change in pull request #374: Migrate spark table to iceberg table URL: https://github.com/apache/incubator-iceberg/pull/374#discussion_r320878326 ## File path: hive/src/test/java/org/apache/iceberg/hive/TestHiveMetastore.java ## @@ -102,7 +102,7 @@

[GitHub] [incubator-iceberg] rdblue merged pull request #450: Move Hive concurrency tests and run one at a time

rdblue merged pull request #450: Move Hive concurrency tests and run one at a time URL: https://github.com/apache/incubator-iceberg/pull/450 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-iceberg] rdblue commented on issue #450: Move Hive concurrency tests and run one at a time

rdblue commented on issue #450: Move Hive concurrency tests and run one at a time URL: https://github.com/apache/incubator-iceberg/pull/450#issuecomment-527992082 Thanks, I'll merge this to unblock #432. This is an automated

[GitHub] [incubator-iceberg] rdblue commented on issue #442: Optimize ExpressionVisitors.visit method to traverse minimum nodes number required for determining the result

rdblue commented on issue #442: Optimize ExpressionVisitors.visit method to traverse minimum nodes number required for determining the result URL: https://github.com/apache/incubator-iceberg/pull/442#issuecomment-527991469 Thanks for working on this, @vvysotskyi. This looks like a good

[GitHub] [incubator-iceberg] rdblue commented on issue #450: Move Hive concurrency tests and run one at a time

rdblue commented on issue #450: Move Hive concurrency tests and run one at a time URL: https://github.com/apache/incubator-iceberg/pull/450#issuecomment-527980038 @xabriel, I think this should fix your current CI test failures. Can you take a look?

[GitHub] [incubator-iceberg] rdblue opened a new pull request #450: Move Hive concurrency tests and run one at a time

rdblue opened a new pull request #450: Move Hive concurrency tests and run one at a time URL: https://github.com/apache/incubator-iceberg/pull/450 This moves the Hive concurrency tests into a separate suite and adds `synchronized` to the test methods so that the test cases do not run

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #447: Update doc to state that day partition transform produces data type

rdblue commented on a change in pull request #447: Update doc to state that day partition transform produces data type URL: https://github.com/apache/incubator-iceberg/pull/447#discussion_r320848766 ## File path: site/docs/spec.md ## @@ -139,7 +139,7 @@ Partition specs

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #448: Correct typo about PARTITION_DATA_ID_START

rdblue commented on a change in pull request #448: Correct typo about PARTITION_DATA_ID_START URL: https://github.com/apache/incubator-iceberg/pull/448#discussion_r320848311 ## File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java ## @@ -109,7 +109,10 @@

[GitHub] [incubator-iceberg] rdblue commented on issue #252: Add metadata tables

rdblue commented on issue #252: Add metadata tables URL: https://github.com/apache/incubator-iceberg/pull/252#issuecomment-527970235 @linxingyuan1102, look at the docs here: http://iceberg.apache.org/spark/#inspecting-tables

[GitHub] [incubator-iceberg] rdblue commented on issue #227: ORC column map fix

rdblue commented on issue #227: ORC column map fix URL: https://github.com/apache/incubator-iceberg/pull/227#issuecomment-527967306 ORC 1.6.0 is released: https://orc.apache.org/news/2019/09/03/ORC-1.6.0/ @edgarRd, can you update this so we can get it in? I'd like to get it into a

[GitHub] [incubator-iceberg] jerryshao commented on issue #448: Correct typo about PARTITION_DATA_ID_START

jerryshao commented on issue #448: Correct typo about PARTITION_DATA_ID_START URL: https://github.com/apache/incubator-iceberg/pull/448#issuecomment-527888645 +1 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-iceberg] waterlx opened a new issue #449: PARTITION_DATA_ID_START has a hard limit

waterlx opened a new issue #449: PARTITION_DATA_ID_START has a hard limit URL: https://github.com/apache/incubator-iceberg/issues/449 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-iceberg] waterlx commented on issue #448: Correct typo about PARTITION_DATA_ID_START

waterlx commented on issue #448: Correct typo about PARTITION_DATA_ID_START URL: https://github.com/apache/incubator-iceberg/pull/448#issuecomment-527787123 Hi @rdblue , would you please help to review this small change? Thanks!

[GitHub] [incubator-iceberg] waterlx opened a new pull request #448: Correct typo about PARTITION_DATA_ID_START

waterlx opened a new pull request #448: Correct typo about PARTITION_DATA_ID_START URL: https://github.com/apache/incubator-iceberg/pull/448 It is about a typo in comment, no change on any logic. (1) 100 should be 1000 (2) Add link to point to the declaration of

[GitHub] [incubator-iceberg] waterlx edited a comment on issue #279: Transforming timestamp to date should produce date

waterlx edited a comment on issue #279: Transforming timestamp to date should produce date URL: https://github.com/apache/incubator-iceberg/issues/279#issuecomment-527778821 Hi @rdblue , would you please review PR #447 at your most convenience? Thanks!

[GitHub] [incubator-iceberg] waterlx commented on issue #279: Transforming timestamp to date should produce date

waterlx commented on issue #279: Transforming timestamp to date should produce date URL: https://github.com/apache/incubator-iceberg/issues/279#issuecomment-527778821 Hi @rdblue , would you please review PR #447 at your most convenience?

[GitHub] [incubator-iceberg] waterlx opened a new pull request #447: Update doc to state that day partition transform produces data type

waterlx opened a new pull request #447: Update doc to state that day partition transform produces data type URL: https://github.com/apache/incubator-iceberg/pull/447 This is an automated message from the Apache Git Service.