[GitHub] [incubator-iceberg] rdsr commented on pull request #759: Update schema for field additions, updates [e.g type widening] using an input schema

rdsr commented on pull request #759: URL: https://github.com/apache/incubator-iceberg/pull/759#issuecomment-631890464 @fbocse . This PR is still relevant. I just didn't have the time to get back to it. Happy to collaborate.

[GitHub] [incubator-iceberg] pranaydharmale opened a new pull request #1051: replaced DateDayVector and TimestampMicroTZVector

pranaydharmale opened a new pull request #1051: URL: https://github.com/apache/incubator-iceberg/pull/1051 With IntVector and Bi…gIntVector #834 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-iceberg] rdblue commented on pull request #935: [WIP] Internal relocated version of Guava

rdblue commented on pull request #935: URL: https://github.com/apache/incubator-iceberg/pull/935#issuecomment-631824627 I was able to get `publishToMavenLocal` working by making the `GuavaClasses` public and removing the lines that suppress Javadoc. We have to publish Javadoc for each Jar

[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #989: [WIP] ORC nested Identity partition support

rdsr commented on a change in pull request #989: URL: https://github.com/apache/incubator-iceberg/pull/989#discussion_r428302411 ## File path: orc/src/main/java/org/apache/iceberg/orc/OrcValueReaders.java ## @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #989: [WIP] ORC nested Identity partition support

rdsr commented on a change in pull request #989: URL: https://github.com/apache/incubator-iceberg/pull/989#discussion_r428299279 ## File path: orc/src/main/java/org/apache/iceberg/orc/ORCSchemaUtil.java ## @@ -214,6 +214,7 @@ public static Schema convert(TypeDescription

[GitHub] [incubator-iceberg] rdsr commented on pull request #989: [WIP] ORC nested Identity partition support

rdsr commented on pull request #989: URL: https://github.com/apache/incubator-iceberg/pull/989#issuecomment-63165 thanks @rdblue . Picking this up again. Should address ur comments soon This is an automated message from

[GitHub] [incubator-iceberg] fbocse edited a comment on pull request #759: Update schema for field additions, updates [e.g type widening] using an input schema

fbocse edited a comment on pull request #759: URL: https://github.com/apache/incubator-iceberg/pull/759#issuecomment-631683741 @rdsr wanted to check in w/ you on whether this PR is still relevant or not - I tried to continue to complete the implementation you've started on this PR - I'll

[GitHub] [incubator-iceberg] rdblue commented on issue #1014: Concurrent commit issue for HadoopTable

rdblue commented on issue #1014: URL: https://github.com/apache/incubator-iceberg/issues/1014#issuecomment-631684123 @vanliu-tx, the `UpdateEvent` problem is happening because the snapshot is missing. Just after the commit, the snapshot is loaded to clean up uncommitted files and to send

[GitHub] [incubator-iceberg] fbocse edited a comment on pull request #759: Update schema for field additions, updates [e.g type widening] using an input schema

fbocse edited a comment on pull request #759: URL: https://github.com/apache/incubator-iceberg/pull/759#issuecomment-631683741 @rdsr wanted to check in w/ if this PR is still relevant - I tried to continue working the bugs and complete implementation for the PR you had started here - I'll

[GitHub] [incubator-iceberg] fbocse commented on pull request #759: Update schema for field additions, updates [e.g type widening] using an input schema

fbocse commented on pull request #759: URL: https://github.com/apache/incubator-iceberg/pull/759#issuecomment-631683741 @rdsr wanted to check in w/ if this PR is still relevant - I tried to continue working the bugs and complete implementation for this - I'll share a branch from my fork

[GitHub] [incubator-iceberg] rdblue commented on issue #540: Iceberg tables should optionally allow for automatic schema evolution

rdblue commented on issue #540: URL: https://github.com/apache/incubator-iceberg/issues/540#issuecomment-631586214 @geota, in Spark, "automatic schema evolution" usually means not validating the schema on write and merging schemas together on read to find what the table schema actually

[GitHub] [incubator-iceberg] geota commented on issue #540: Iceberg tables should optionally allow for automatic schema evolution

geota commented on issue #540: URL: https://github.com/apache/incubator-iceberg/issues/540#issuecomment-631581764 Databricks recently released support for automatic schema evolution in merge operations:

[GitHub] [incubator-iceberg] massdosage commented on pull request #935: [WIP] Internal relocated version of Guava

massdosage commented on pull request #935: URL: https://github.com/apache/incubator-iceberg/pull/935#issuecomment-631340806 > > > I'm taking a look at this. I think we should try to get this in without worrying about the consistent versions plugin just yet. We will very likely

[GitHub] [incubator-iceberg] chenjunjiedada commented on pull request #1038: Add assertions for sequence numbers to TestFastAppend

chenjunjiedada commented on pull request #1038: URL: https://github.com/apache/incubator-iceberg/pull/1038#issuecomment-631331167 +1 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-iceberg] xhochy commented on pull request #1033: Add PyUpgrade to the CI

xhochy commented on pull request #1033: URL: https://github.com/apache/incubator-iceberg/pull/1033#issuecomment-631301174 > Can you explain a bit more about what this does? Is the pre-commit hook validation only? The tool sounds like it will modify code, but that shouldn't be done in a

[GitHub] [incubator-iceberg] chenjunjiedada commented on a change in pull request #971: Add reader for position based delete file

chenjunjiedada commented on a change in pull request #971: URL: https://github.com/apache/incubator-iceberg/pull/971#discussion_r427769383 ## File path: core/src/main/java/org/apache/iceberg/PositionBasedDeleteRecord.java ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-iceberg] chenjunjiedada commented on a change in pull request #971: Add reader for position based delete file

chenjunjiedada commented on a change in pull request #971: URL: https://github.com/apache/incubator-iceberg/pull/971#discussion_r427766654 ## File path: spark/src/main/java/org/apache/iceberg/spark/source/DeleteRecordReader.java ## @@ -0,0 +1,82 @@ +/* + * Licensed to the