[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #1046: ISSUE-189: Add support for union record type

rdblue commented on a change in pull request #1046: URL: https://github.com/apache/incubator-iceberg/pull/1046#discussion_r430012232 ## File path: api/src/main/java/org/apache/iceberg/types/Types.java ## @@ -526,25 +526,25 @@ public static StructType of(List fields) {

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #1046: ISSUE-189: Add support for union record type

rdblue commented on a change in pull request #1046: URL: https://github.com/apache/incubator-iceberg/pull/1046#discussion_r429310052 ## File path: core/src/test/java/org/apache/iceberg/avro/AvroDataUnionRecordTest.java ## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #1046: ISSUE-189: Add support for union record type

rdblue commented on a change in pull request #1046: URL: https://github.com/apache/incubator-iceberg/pull/1046#discussion_r428879377 ## File path: core/src/test/java/org/apache/iceberg/avro/AvroDataUnionRecordTest.java ## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #1046: ISSUE-189: Add support for union record type

rdblue commented on a change in pull request #1046: URL: https://github.com/apache/incubator-iceberg/pull/1046#discussion_r428877247 ## File path: core/src/test/java/org/apache/iceberg/avro/AvroDataUnionRecordTest.java ## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #1046: ISSUE-189: Add support for union record type

rdblue commented on a change in pull request #1046: URL: https://github.com/apache/incubator-iceberg/pull/1046#discussion_r428876705 ## File path: core/src/main/java/org/apache/iceberg/avro/TypeToSchema.java ## @@ -112,7 +112,9 @@ public Schema struct(Types.StructType struct,

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #1046: ISSUE-189: Add support for union record type

rdblue commented on a change in pull request #1046: URL: https://github.com/apache/incubator-iceberg/pull/1046#discussion_r428875887 ## File path: core/src/main/java/org/apache/iceberg/avro/SchemaToType.java ## @@ -169,18 +184,15 @@ public Type primitive(Schema primitive) {

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #1046: ISSUE-189: Add support for union record type

rdblue commented on a change in pull request #1046: URL: https://github.com/apache/incubator-iceberg/pull/1046#discussion_r428875652 ## File path: core/src/main/java/org/apache/iceberg/avro/SchemaToType.java ## @@ -106,11 +106,27 @@ public Type record(Schema record, List

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #1046: ISSUE-189: Add support for union record type

rdblue commented on a change in pull request #1046: URL: https://github.com/apache/incubator-iceberg/pull/1046#discussion_r428869358 ## File path: core/src/main/java/org/apache/iceberg/avro/GenericAvroWriter.java ## @@ -133,4 +141,38 @@ private WriteBuilder() { } }

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #1046: ISSUE-189: Add support for union record type

rdblue commented on a change in pull request #1046: URL: https://github.com/apache/incubator-iceberg/pull/1046#discussion_r428868296 ## File path: core/src/main/java/org/apache/iceberg/avro/AvroSchemaUtil.java ## @@ -120,7 +124,7 @@ public static boolean isTimestamptz(Schema

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #1046: ISSUE-189: Add support for union record type

rdblue commented on a change in pull request #1046: URL: https://github.com/apache/incubator-iceberg/pull/1046#discussion_r428867073 ## File path: core/src/main/java/org/apache/iceberg/avro/AvroSchemaUtil.java ## @@ -47,20 +47,23 @@ private AvroSchemaUtil() {} public static

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #1046: ISSUE-189: Add support for union record type

rdblue commented on a change in pull request #1046: URL: https://github.com/apache/incubator-iceberg/pull/1046#discussion_r42887 ## File path: api/src/main/java/org/apache/iceberg/types/Types.java ## @@ -641,6 +650,13 @@ public int hashCode() { } return