[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #735: Refactor FilteredManifest and ManifestGroup

2020-01-27 Thread GitBox
rdblue commented on a change in pull request #735: Refactor FilteredManifest and ManifestGroup URL: https://github.com/apache/incubator-iceberg/pull/735#discussion_r371403002 ## File path: core/src/main/java/org/apache/iceberg/FilteredManifest.java ## @@ -193,4 +164,29 @@

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #735: Refactor FilteredManifest and ManifestGroup

2020-01-27 Thread GitBox
rdblue commented on a change in pull request #735: Refactor FilteredManifest and ManifestGroup URL: https://github.com/apache/incubator-iceberg/pull/735#discussion_r371401794 ## File path: core/src/main/java/org/apache/iceberg/FilteredManifest.java ## @@ -193,4 +164,29 @@

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #735: Refactor FilteredManifest and ManifestGroup

2020-01-27 Thread GitBox
rdblue commented on a change in pull request #735: Refactor FilteredManifest and ManifestGroup URL: https://github.com/apache/incubator-iceberg/pull/735#discussion_r371400965 ## File path: core/src/main/java/org/apache/iceberg/FilteredManifest.java ## @@ -95,60 +94,32 @@

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #735: Refactor FilteredManifest and ManifestGroup

2020-01-27 Thread GitBox
rdblue commented on a change in pull request #735: Refactor FilteredManifest and ManifestGroup URL: https://github.com/apache/incubator-iceberg/pull/735#discussion_r371399781 ## File path: core/src/main/java/org/apache/iceberg/FilteredManifest.java ## @@ -95,60 +94,32 @@

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #735: Refactor FilteredManifest and ManifestGroup

2020-01-23 Thread GitBox
rdblue commented on a change in pull request #735: Refactor FilteredManifest and ManifestGroup URL: https://github.com/apache/incubator-iceberg/pull/735#discussion_r370434314 ## File path: core/src/main/java/org/apache/iceberg/FilteredManifest.java ## @@ -95,60 +94,38 @@

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #735: Refactor FilteredManifest and ManifestGroup

2020-01-23 Thread GitBox
rdblue commented on a change in pull request #735: Refactor FilteredManifest and ManifestGroup URL: https://github.com/apache/incubator-iceberg/pull/735#discussion_r370336896 ## File path: core/src/main/java/org/apache/iceberg/ManifestGroup.java ## @@ -204,4 +141,78 @@

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #735: Refactor FilteredManifest and ManifestGroup

2020-01-23 Thread GitBox
rdblue commented on a change in pull request #735: Refactor FilteredManifest and ManifestGroup URL: https://github.com/apache/incubator-iceberg/pull/735#discussion_r370335684 ## File path: core/src/main/java/org/apache/iceberg/FilteredManifest.java ## @@ -95,60 +94,38 @@

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #735: Refactor FilteredManifest and ManifestGroup

2020-01-23 Thread GitBox
rdblue commented on a change in pull request #735: Refactor FilteredManifest and ManifestGroup URL: https://github.com/apache/incubator-iceberg/pull/735#discussion_r370292764 ## File path: core/src/main/java/org/apache/iceberg/FilteredManifest.java ## @@ -95,60 +94,38 @@

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #735: Refactor FilteredManifest and ManifestGroup

2020-01-23 Thread GitBox
rdblue commented on a change in pull request #735: Refactor FilteredManifest and ManifestGroup URL: https://github.com/apache/incubator-iceberg/pull/735#discussion_r370291337 ## File path: core/src/main/java/org/apache/iceberg/FilteredManifest.java ## @@ -95,60 +94,38 @@

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #735: Refactor FilteredManifest and ManifestGroup

2020-01-23 Thread GitBox
rdblue commented on a change in pull request #735: Refactor FilteredManifest and ManifestGroup URL: https://github.com/apache/incubator-iceberg/pull/735#discussion_r370295445 ## File path: core/src/main/java/org/apache/iceberg/ManifestReader.java ## @@ -226,11 +226,11 @@

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #735: Refactor FilteredManifest and ManifestGroup

2020-01-23 Thread GitBox
rdblue commented on a change in pull request #735: Refactor FilteredManifest and ManifestGroup URL: https://github.com/apache/incubator-iceberg/pull/735#discussion_r370294851 ## File path: core/src/main/java/org/apache/iceberg/ManifestGroup.java ## @@ -204,4 +141,78 @@

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #735: Refactor FilteredManifest and ManifestGroup

2020-01-17 Thread GitBox
rdblue commented on a change in pull request #735: Refactor FilteredManifest and ManifestGroup URL: https://github.com/apache/incubator-iceberg/pull/735#discussion_r368159068 ## File path: core/src/main/java/org/apache/iceberg/FilteredManifest.java ## @@ -193,4 +164,19 @@

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #735: Refactor FilteredManifest and ManifestGroup

2020-01-17 Thread GitBox
rdblue commented on a change in pull request #735: Refactor FilteredManifest and ManifestGroup URL: https://github.com/apache/incubator-iceberg/pull/735#discussion_r368158676 ## File path: core/src/main/java/org/apache/iceberg/FilteredManifest.java ## @@ -95,60 +95,31 @@

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #735: Refactor FilteredManifest and ManifestGroup

2020-01-17 Thread GitBox
rdblue commented on a change in pull request #735: Refactor FilteredManifest and ManifestGroup URL: https://github.com/apache/incubator-iceberg/pull/735#discussion_r368158161 ## File path: core/src/main/java/org/apache/iceberg/FilteredManifest.java ## @@ -95,60 +95,31 @@