rahil-c commented on PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#issuecomment-2093492003
Thanks @nastra and @danielcweeks for the help on this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
nastra merged PR #9782:
URL: https://github.com/apache/iceberg/pull/9782
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
nastra commented on PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#issuecomment-2092390890
Thanks for working on this @rahil-c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
rahil-c commented on PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#issuecomment-2091903148
@danielcweeks Seems to be green now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
rahil-c commented on PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#issuecomment-2091882544
> Approved, pending checks. There's one that failed, but may have been a
transient failure.
@danielcweeks yea I think it is transient, since every time I go to check
this link it
danielcweeks commented on PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#issuecomment-2091881609
Approved, pending checks. There's one that failed, but may have been a
transient failure.
--
This is an automated message from the Apache Git Service.
To respond to the message,
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1587974890
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -494,22 +515,30 @@ public void createNamespace(
@Override
public List
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1587968616
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -136,6 +137,7 @@ public class RESTSessionCatalog extends
BaseViewSessionCatalog
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1587208312
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -494,22 +515,30 @@ public void createNamespace(
@Override
public List
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1587206338
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -228,6 +230,12 @@ public void initialize(String name, Map
unresolved) {
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1587205432
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -136,6 +137,7 @@ public class RESTSessionCatalog extends
BaseViewSessionCatalog
private
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1587205432
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -136,6 +137,7 @@ public class RESTSessionCatalog extends
BaseViewSessionCatalog
private
rahil-c commented on PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#issuecomment-2087717449
@danielcweeks @nastra Have made recent revisions, hoping we can land this if
no other concerns and if CI run is green.
--
This is an automated message from the Apache Git Service.
To
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1585624769
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -278,14 +286,26 @@ public void setConf(Object newConf) {
@Override
public List
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1585614568
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -228,6 +230,13 @@ public void initialize(String name, Map
unresolved) {
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1585614340
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -136,6 +137,7 @@ public class RESTSessionCatalog extends
BaseViewSessionCatalog
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1584794537
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -278,14 +286,26 @@ public void setConf(Object newConf) {
@Override
public List
danielcweeks commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1581860457
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -136,6 +137,7 @@ public class RESTSessionCatalog extends
BaseViewSessionCatalog
rahil-c commented on PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#issuecomment-2080224394
Thanks @nastra for the help I appreciate it, will wait on @danielcweeks
review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1581590662
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -278,14 +286,26 @@ public void setConf(Object newConf) {
@Override
public List
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1581598929
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -494,22 +514,29 @@ public void createNamespace(
@Override
public List
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1581591136
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -2329,6 +2332,129 @@ public void
multipleDiffsAgainstMultipleTablesLastFails() {
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1581590662
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -278,14 +286,26 @@ public void setConf(Object newConf) {
@Override
public List
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1581389185
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -494,22 +514,29 @@ public void createNamespace(
@Override
public List
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1581390737
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -2329,6 +2332,129 @@ public void
multipleDiffsAgainstMultipleTablesLastFails() {
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1581389185
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -494,22 +514,29 @@ public void createNamespace(
@Override
public List
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1581388814
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -278,14 +286,26 @@ public void setConf(Object newConf) {
@Override
public List
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1581204955
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -2329,6 +2332,129 @@ public void
multipleDiffsAgainstMultipleTablesLastFails() {
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1580993539
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -2329,6 +2332,129 @@ public void
multipleDiffsAgainstMultipleTablesLastFails() {
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1580991187
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -2329,6 +2332,129 @@ public void
multipleDiffsAgainstMultipleTablesLastFails() {
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1580985211
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -494,22 +514,29 @@ public void createNamespace(
@Override
public List
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1580983794
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -278,14 +286,26 @@ public void setConf(Object newConf) {
@Override
public List
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1580469059
##
core/src/test/java/org/apache/iceberg/rest/TestRESTViewCatalog.java:
##
@@ -144,6 +157,65 @@ public void closeCatalog() throws Exception {
}
}
+ @Test
+
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1580469059
##
core/src/test/java/org/apache/iceberg/rest/TestRESTViewCatalog.java:
##
@@ -144,6 +157,65 @@ public void closeCatalog() throws Exception {
}
}
+ @Test
+
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1577061740
##
core/src/test/java/org/apache/iceberg/rest/TestRESTViewCatalog.java:
##
@@ -144,6 +157,65 @@ public void closeCatalog() throws Exception {
}
}
+ @Test
+
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1575784851
##
core/src/test/java/org/apache/iceberg/rest/TestRESTViewCatalog.java:
##
@@ -144,6 +157,65 @@ public void closeCatalog() throws Exception {
}
}
+ @Test
+
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1575784851
##
core/src/test/java/org/apache/iceberg/rest/TestRESTViewCatalog.java:
##
@@ -144,6 +157,65 @@ public void closeCatalog() throws Exception {
}
}
+ @Test
+
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1571188458
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -2329,6 +2332,119 @@ public void
multipleDiffsAgainstMultipleTablesLastFails() {
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1571188458
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -2329,6 +2332,119 @@ public void
multipleDiffsAgainstMultipleTablesLastFails() {
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1571188458
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -2329,6 +2332,119 @@ public void
multipleDiffsAgainstMultipleTablesLastFails() {
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1571188458
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -2329,6 +2332,119 @@ public void
multipleDiffsAgainstMultipleTablesLastFails() {
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1571017091
##
core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java:
##
@@ -117,6 +118,29 @@ public static ListNamespacesResponse listNamespaces(
return
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1570124615
##
core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java:
##
@@ -117,6 +118,29 @@ public static ListNamespacesResponse listNamespaces(
return
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1570117531
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -2329,6 +2332,119 @@ public void
multipleDiffsAgainstMultipleTablesLastFails() {
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1569192411
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -2329,6 +2332,120 @@ public void
multipleDiffsAgainstMultipleTablesLastFails() {
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1569180280
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -2329,6 +2332,120 @@ public void
multipleDiffsAgainstMultipleTablesLastFails() {
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1568415371
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -2329,6 +2332,120 @@ public void
multipleDiffsAgainstMultipleTablesLastFails() {
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1568398951
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -2329,6 +2332,120 @@ public void
multipleDiffsAgainstMultipleTablesLastFails() {
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1568086253
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -1796,6 +1799,48 @@ public void
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1567967380
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -1796,6 +1799,48 @@ public void
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1567967116
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -1796,6 +1799,48 @@ public void
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1567730841
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -278,14 +286,26 @@ public void setConf(Object newConf) {
@Override
public List
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1567855351
##
core/src/test/java/org/apache/iceberg/rest/TestRESTViewCatalog.java:
##
@@ -144,6 +151,36 @@ public void closeCatalog() throws Exception {
}
}
+ @Test
+
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1567854386
##
core/src/test/java/org/apache/iceberg/rest/responses/TestListTablesResponse.java:
##
@@ -105,9 +105,32 @@ public void testBuilderDoesNotCreateInvalidObjects() {
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1567853170
##
core/src/test/java/org/apache/iceberg/rest/responses/TestListNamespacesResponse.java:
##
@@ -83,9 +83,32 @@ public void testBuilderDoesNotCreateInvalidObjects() {
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1567755548
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -2329,6 +2374,57 @@ public void
multipleDiffsAgainstMultipleTablesLastFails() {
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1567748849
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -2329,6 +2374,57 @@ public void
multipleDiffsAgainstMultipleTablesLastFails() {
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1567745943
##
core/src/test/java/org/apache/iceberg/rest/responses/TestListTablesResponse.java:
##
@@ -36,7 +36,7 @@ public class TestListTablesResponse extends
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1567734951
##
core/src/test/java/org/apache/iceberg/rest/responses/TestListNamespacesResponse.java:
##
@@ -34,7 +34,7 @@ public class TestListNamespacesResponse extends
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1567730841
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -278,14 +286,26 @@ public void setConf(Object newConf) {
@Override
public List
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1567097286
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -278,14 +286,26 @@ public void setConf(Object newConf) {
@Override
public List
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1566940267
##
core/src/test/java/org/apache/iceberg/rest/TestRESTViewCatalog.java:
##
@@ -144,6 +151,36 @@ public void closeCatalog() throws Exception {
}
}
+ @Test
+
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1567077122
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -1796,6 +1799,48 @@ public void
testCatalogExpiredBearerTokenIsRefreshedWithCredential(String
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1566939429
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -2329,6 +2374,57 @@ public void
multipleDiffsAgainstMultipleTablesLastFails() {
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1567077122
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -1796,6 +1799,48 @@ public void
testCatalogExpiredBearerTokenIsRefreshedWithCredential(String
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1567071915
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -1796,6 +1799,48 @@ public void
testCatalogExpiredBearerTokenIsRefreshedWithCredential(String
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1566946785
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -1796,6 +1799,48 @@ public void
testCatalogExpiredBearerTokenIsRefreshedWithCredential(String
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1566939429
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -2329,6 +2374,57 @@ public void
multipleDiffsAgainstMultipleTablesLastFails() {
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1566939950
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -2329,6 +2374,57 @@ public void
multipleDiffsAgainstMultipleTablesLastFails() {
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1566937039
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -2329,6 +2374,57 @@ public void
multipleDiffsAgainstMultipleTablesLastFails() {
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1566933302
##
core/src/test/java/org/apache/iceberg/rest/responses/TestListNamespacesResponse.java:
##
@@ -34,7 +34,7 @@ public class TestListNamespacesResponse extends
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1566944912
##
core/src/test/java/org/apache/iceberg/rest/TestRESTViewCatalog.java:
##
@@ -144,6 +151,36 @@ public void closeCatalog() throws Exception {
}
}
+ @Test
+
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1566941917
##
core/src/test/java/org/apache/iceberg/rest/responses/TestListTablesResponse.java:
##
@@ -105,9 +105,32 @@ public void testBuilderDoesNotCreateInvalidObjects() {
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1566941616
##
core/src/test/java/org/apache/iceberg/rest/responses/TestListNamespacesResponse.java:
##
@@ -83,9 +83,32 @@ public void testBuilderDoesNotCreateInvalidObjects() {
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1566934826
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -2329,6 +2374,57 @@ public void
multipleDiffsAgainstMultipleTablesLastFails() {
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1566583155
##
core/src/test/java/org/apache/iceberg/rest/responses/TestListNamespacesResponse.java:
##
@@ -34,7 +34,7 @@ public class TestListNamespacesResponse extends
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1566713074
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -278,14 +286,26 @@ public void setConf(Object newConf) {
@Override
public List
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1566583155
##
core/src/test/java/org/apache/iceberg/rest/responses/TestListNamespacesResponse.java:
##
@@ -34,7 +34,7 @@ public class TestListNamespacesResponse extends
danielcweeks commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1566524213
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -278,14 +286,26 @@ public void setConf(Object newConf) {
@Override
public List
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1558712520
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -278,14 +286,26 @@ public void setConf(Object newConf) {
@Override
public List
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1561347274
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -278,14 +286,26 @@ public void setConf(Object newConf) {
@Override
public List
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1561341671
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -278,14 +286,26 @@ public void setConf(Object newConf) {
@Override
public List
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1561325160
##
core/src/test/java/org/apache/iceberg/rest/responses/TestListNamespacesResponse.java:
##
@@ -34,7 +34,7 @@ public class TestListNamespacesResponse extends
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1560470048
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -278,14 +286,26 @@ public void setConf(Object newConf) {
@Override
public List
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1560187855
##
core/src/test/java/org/apache/iceberg/rest/responses/TestListTablesResponse.java:
##
@@ -36,7 +36,7 @@ public class TestListTablesResponse extends
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1560187545
##
core/src/test/java/org/apache/iceberg/rest/responses/TestListNamespacesResponse.java:
##
@@ -34,7 +34,7 @@ public class TestListNamespacesResponse extends
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1560180427
##
core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java:
##
@@ -68,7 +68,7 @@
import org.junit.jupiter.api.Test;
public abstract class CatalogTests {
-
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1560093868
##
core/src/test/java/org/apache/iceberg/rest/TestRESTViewCatalog.java:
##
@@ -144,6 +151,39 @@ public void closeCatalog() throws Exception {
}
}
+ @Test
+
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1560039876
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -2329,6 +2330,46 @@ public void
multipleDiffsAgainstMultipleTablesLastFails() {
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1560038289
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -2329,6 +2330,46 @@ public void
multipleDiffsAgainstMultipleTablesLastFails() {
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1560030414
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -224,6 +226,7 @@ public void initialize(String name, Map
unresolved) {
rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1558712520
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -278,14 +286,26 @@ public void setConf(Object newConf) {
@Override
public List
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1559623826
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -278,14 +286,26 @@ public void setConf(Object newConf) {
@Override
public List
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1559612907
##
core/src/test/java/org/apache/iceberg/rest/responses/TestListTablesResponse.java:
##
@@ -36,7 +36,7 @@ public class TestListTablesResponse extends
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1559607741
##
core/src/test/java/org/apache/iceberg/rest/TestRESTViewCatalog.java:
##
@@ -144,6 +151,39 @@ public void closeCatalog() throws Exception {
}
}
+ @Test
+
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1559611564
##
core/src/test/java/org/apache/iceberg/rest/responses/TestListNamespacesResponse.java:
##
@@ -34,7 +34,7 @@ public class TestListNamespacesResponse extends
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1559605425
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -2329,6 +2330,46 @@ public void
multipleDiffsAgainstMultipleTablesLastFails() {
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1559608101
##
core/src/test/java/org/apache/iceberg/rest/TestRESTViewCatalog.java:
##
@@ -144,6 +151,39 @@ public void closeCatalog() throws Exception {
}
}
+ @Test
+
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1559602390
##
core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java:
##
@@ -68,7 +68,7 @@
import org.junit.jupiter.api.Test;
public abstract class CatalogTests {
-
nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1559602987
##
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##
@@ -2329,6 +2330,46 @@ public void
multipleDiffsAgainstMultipleTablesLastFails() {
1 - 100 of 154 matches
Mail list logo