[GitHub] [incubator-iceberg] jerryshao commented on a change in pull request #681: [ISSUE #680] Fix the listTable in HadoopCatalog

2019-12-03 Thread GitBox
jerryshao commented on a change in pull request #681: [ISSUE #680] Fix the listTable in HadoopCatalog URL: https://github.com/apache/incubator-iceberg/pull/681#discussion_r353584606 ## File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java ## @@ -195,6

[GitHub] [incubator-iceberg] jerryshao commented on a change in pull request #674: [WIP]Supports spark-3.0 data source V2 APIs

2019-12-03 Thread GitBox
jerryshao commented on a change in pull request #674: [WIP]Supports spark-3.0 data source V2 APIs URL: https://github.com/apache/incubator-iceberg/pull/674#discussion_r353592567 ## File path: spark/src/main/java/org/apache/iceberg/spark/source/IcebergBatchScan.java ## @@

[GitHub] [incubator-iceberg] jerryshao commented on a change in pull request #674: [WIP]Supports spark-3.0 data source V2 APIs

2019-12-03 Thread GitBox
jerryshao commented on a change in pull request #674: [WIP]Supports spark-3.0 data source V2 APIs URL: https://github.com/apache/incubator-iceberg/pull/674#discussion_r353586701 ## File path: api/src/main/java/org/apache/iceberg/Table.java ## @@ -228,4 +228,13 @@ default

[GitHub] [incubator-iceberg] shawnding opened a new pull request #681: [ISSUE #680] Fix the listTable in HadoopCatalog

2019-12-03 Thread GitBox
shawnding opened a new pull request #681: [ISSUE #680] Fix the listTable in HadoopCatalog URL: https://github.com/apache/incubator-iceberg/pull/681 Check the metadata directory is an iceberg table directory, use the file `.metadata.json` .

[GitHub] [incubator-iceberg] shawnding opened a new pull request #679: [WIP] [ISSUE #672] Add namespace metadata

2019-12-03 Thread GitBox
shawnding opened a new pull request #679: [WIP] [ISSUE #672] Add namespace metadata URL: https://github.com/apache/incubator-iceberg/pull/679 **Create a namespace metadata file and save it into** _${WAREHOUSE_BASE}/namespace_metadata_ **Then :** 1. The commands of `list

[GitHub] [incubator-iceberg] xabriel commented on a change in pull request #315: [WIP] Incremental processing prototype

2019-12-03 Thread GitBox
xabriel commented on a change in pull request #315: [WIP] Incremental processing prototype URL: https://github.com/apache/incubator-iceberg/pull/315#discussion_r353445158 ## File path: core/src/main/java/org/apache/iceberg/IncrementalDataScan.java ## @@ -0,0 +1,119 @@ +/*

[GitHub] [incubator-iceberg] xabriel commented on a change in pull request #315: [WIP] Incremental processing prototype

2019-12-03 Thread GitBox
xabriel commented on a change in pull request #315: [WIP] Incremental processing prototype URL: https://github.com/apache/incubator-iceberg/pull/315#discussion_r353443961 ## File path: api/src/main/java/org/apache/iceberg/Table.java ## @@ -44,6 +44,15 @@ */

[GitHub] [incubator-iceberg] shardulm94 commented on issue #227: ORC column map fix

2019-12-03 Thread GitBox
shardulm94 commented on issue #227: ORC column map fix URL: https://github.com/apache/incubator-iceberg/pull/227#issuecomment-561439577 I saw issues with GenericOrcWriter w.r.t. date/time/timestamp/decimal types when I tried to extend `org.apache.iceberg.data.DataTest` for ORC.

[GitHub] [incubator-iceberg] shawnding opened a new issue #680: while the namespace and table name is 'metadata' cannot list it

2019-12-03 Thread GitBox
shawnding opened a new issue #680: while the namespace and table name is 'metadata' cannot list it URL: https://github.com/apache/incubator-iceberg/issues/680 create a table like this `createTable('db.metadata.metadata');` While use the `listTables()` in `HadoopCatalog `, cannot list