[GitHub] [incubator-iceberg] rdblue commented on issue #841: Upgrade Hive to 2.3.6 for Iceberg

2020-03-17 Thread GitBox
rdblue commented on issue #841: Upgrade Hive to 2.3.6 for Iceberg URL: https://github.com/apache/incubator-iceberg/pull/841#issuecomment-600163797 Merging this. Thanks for the quick fixes, @jerryshao! This is an automated

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #841: Upgrade Hive to 2.3.6 for Iceberg

2020-03-17 Thread GitBox
rdblue commented on a change in pull request #841: Upgrade Hive to 2.3.6 for Iceberg URL: https://github.com/apache/incubator-iceberg/pull/841#discussion_r393802858 ## File path: versions.lock ## @@ -170,24 +188,33 @@ org.apache.spark:spark-sketch_2.11:2.4.4 (2

[GitHub] [incubator-iceberg] waterlx commented on issue #567: Iceberg sink for Apache Flink

2020-03-17 Thread GitBox
waterlx commented on issue #567: Iceberg sink for Apache Flink URL: https://github.com/apache/incubator-iceberg/issues/567#issuecomment-600139656 Just would like to share some progress: I have moved the source code part of

[GitHub] [incubator-iceberg] rdblue merged pull request #841: Upgrade Hive to 2.3.6 for Iceberg

2020-03-17 Thread GitBox
rdblue merged pull request #841: Upgrade Hive to 2.3.6 for Iceberg URL: https://github.com/apache/incubator-iceberg/pull/841 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-iceberg] waterlx edited a comment on issue #567: Iceberg sink for Apache Flink

2020-03-17 Thread GitBox
waterlx edited a comment on issue #567: Iceberg sink for Apache Flink URL: https://github.com/apache/incubator-iceberg/issues/567#issuecomment-600139656 Just would like to share some progress: I have moved the source code part of

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #841: Upgrade Hive to 2.3.6 for Iceberg

2020-03-17 Thread GitBox
rdblue commented on a change in pull request #841: Upgrade Hive to 2.3.6 for Iceberg URL: https://github.com/apache/incubator-iceberg/pull/841#discussion_r393801741 ## File path: versions.lock ## @@ -1,31 +1,39 @@ # Run ./gradlew --write-locks to regenerate this file

[GitHub] [incubator-iceberg] jerryshao commented on a change in pull request #796: Support Spark Structured Streaming Read for Iceberg

2020-03-17 Thread GitBox
jerryshao commented on a change in pull request #796: Support Spark Structured Streaming Read for Iceberg URL: https://github.com/apache/incubator-iceberg/pull/796#discussion_r393675798 ## File path: spark/src/main/java/org/apache/iceberg/spark/source/StreamingReader.java

[GitHub] [incubator-iceberg] jerryshao commented on a change in pull request #796: Support Spark Structured Streaming Read for Iceberg

2020-03-17 Thread GitBox
jerryshao commented on a change in pull request #796: Support Spark Structured Streaming Read for Iceberg URL: https://github.com/apache/incubator-iceberg/pull/796#discussion_r393665966 ## File path: spark/src/main/java/org/apache/iceberg/spark/source/StreamingReader.java

[GitHub] [incubator-iceberg] jerryshao commented on a change in pull request #841: Upgrade Hive to 2.3.6 for Iceberg

2020-03-17 Thread GitBox
jerryshao commented on a change in pull request #841: Upgrade Hive to 2.3.6 for Iceberg URL: https://github.com/apache/incubator-iceberg/pull/841#discussion_r393614374 ## File path: versions.lock ## @@ -37,34 +37,36 @@ com.sun.jersey:jersey-json:1.9 (5 constraints:

[GitHub] [incubator-iceberg] jerryshao commented on a change in pull request #796: Support Spark Structured Streaming Read for Iceberg

2020-03-17 Thread GitBox
jerryshao commented on a change in pull request #796: Support Spark Structured Streaming Read for Iceberg URL: https://github.com/apache/incubator-iceberg/pull/796#discussion_r393641676 ## File path: spark/src/main/java/org/apache/iceberg/spark/source/StreamingReader.java

[GitHub] [incubator-iceberg] jerryshao commented on a change in pull request #796: Support Spark Structured Streaming Read for Iceberg

2020-03-17 Thread GitBox
jerryshao commented on a change in pull request #796: Support Spark Structured Streaming Read for Iceberg URL: https://github.com/apache/incubator-iceberg/pull/796#discussion_r393675798 ## File path: spark/src/main/java/org/apache/iceberg/spark/source/StreamingReader.java

[GitHub] [incubator-iceberg] rdsr commented on issue #843: [WIP] InputFormat support for Iceberg

2020-03-17 Thread GitBox
rdsr commented on issue #843: [WIP] InputFormat support for Iceberg URL: https://github.com/apache/incubator-iceberg/pull/843#issuecomment-600382310 Any suggestions on how we support the mapred API? We can go the route of

[GitHub] [incubator-iceberg] openinx commented on issue #788: Integrate the Apache Flink into Apache Iceberg

2020-03-17 Thread GitBox
openinx commented on issue #788: Integrate the Apache Flink into Apache Iceberg URL: https://github.com/apache/incubator-iceberg/issues/788#issuecomment-600383981 Currently, @waterlx is working on the code integration, the progress is here.

[GitHub] [incubator-iceberg] aokolnychyi closed issue #659: Refactor metadata table tests in Spark to share the logic

2020-03-17 Thread GitBox
aokolnychyi closed issue #659: Refactor metadata table tests in Spark to share the logic URL: https://github.com/apache/incubator-iceberg/issues/659 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-iceberg] aokolnychyi commented on issue #659: Refactor metadata table tests in Spark to share the logic

2020-03-17 Thread GitBox
aokolnychyi commented on issue #659: Refactor metadata table tests in Spark to share the logic URL: https://github.com/apache/incubator-iceberg/issues/659#issuecomment-600264055 @golammott, sorry I was out for a while. Thanks for contributing this!

[GitHub] [incubator-iceberg] rdsr opened a new issue #848: IcebergGenerics should support ORC format

2020-03-17 Thread GitBox
rdsr opened a new issue #848: IcebergGenerics should support ORC format URL: https://github.com/apache/incubator-iceberg/issues/848 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-iceberg] rdsr opened a new issue #849: Add support for reading Avro and ORC data files in Iceberg Pig

2020-03-17 Thread GitBox
rdsr opened a new issue #849: Add support for reading Avro and ORC data files in Iceberg Pig URL: https://github.com/apache/incubator-iceberg/issues/849 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-iceberg] openinx commented on issue #567: Iceberg sink for Apache Flink

2020-03-17 Thread GitBox
openinx commented on issue #567: Iceberg sink for Apache Flink URL: https://github.com/apache/incubator-iceberg/issues/567#issuecomment-600386856 @waterlx , I think the first pull request version don't have to be so perfect, can put the rough patch to review and see what's the feedback

[GitHub] [incubator-iceberg] shardulm94 commented on a change in pull request #778: ORC: Implement TestGenericData and fix reader and writer issues

2020-03-17 Thread GitBox
shardulm94 commented on a change in pull request #778: ORC: Implement TestGenericData and fix reader and writer issues URL: https://github.com/apache/incubator-iceberg/pull/778#discussion_r394077241 ## File path: site/docs/spec.md ## @@ -483,25 +483,25 @@ Lists must use

[GitHub] [incubator-iceberg] shardulm94 commented on a change in pull request #778: ORC: Implement TestGenericData and fix reader and writer issues

2020-03-17 Thread GitBox
shardulm94 commented on a change in pull request #778: ORC: Implement TestGenericData and fix reader and writer issues URL: https://github.com/apache/incubator-iceberg/pull/778#discussion_r394077232 ## File path: data/src/test/java/org/apache/iceberg/data/orc/TestGenericData.java

[GitHub] [incubator-iceberg] shardulm94 commented on a change in pull request #778: ORC: Implement TestGenericData and fix reader and writer issues

2020-03-17 Thread GitBox
shardulm94 commented on a change in pull request #778: ORC: Implement TestGenericData and fix reader and writer issues URL: https://github.com/apache/incubator-iceberg/pull/778#discussion_r394077109 ## File path: data/src/main/java/org/apache/iceberg/data/orc/GenericOrcReader.java

[GitHub] [incubator-iceberg] shardulm94 commented on issue #778: ORC: Implement TestGenericData and fix reader and writer issues

2020-03-17 Thread GitBox
shardulm94 commented on issue #778: ORC: Implement TestGenericData and fix reader and writer issues URL: https://github.com/apache/incubator-iceberg/pull/778#issuecomment-600396097 Sorry this took so long to address. Got sidetracked. I made a few changes in the latest commit. -

[GitHub] [incubator-iceberg] yathindranath commented on issue #780: expire table metadata with ExpireSnapshots

2020-03-17 Thread GitBox
yathindranath commented on issue #780: expire table metadata with ExpireSnapshots URL: https://github.com/apache/incubator-iceberg/pull/780#issuecomment-600394238 @rdblue sounds good, shall I close this PR then? This is an

[GitHub] [incubator-iceberg] shardulm94 commented on a change in pull request #778: ORC: Implement TestGenericData and fix reader and writer issues

2020-03-17 Thread GitBox
shardulm94 commented on a change in pull request #778: ORC: Implement TestGenericData and fix reader and writer issues URL: https://github.com/apache/incubator-iceberg/pull/778#discussion_r394075083 ## File path: data/src/main/java/org/apache/iceberg/data/orc/GenericOrcWriter.java

[GitHub] [incubator-iceberg] jun-he commented on issue #819: Support configurable split size for metadata tables

2020-03-17 Thread GitBox
jun-he commented on issue #819: Support configurable split size for metadata tables URL: https://github.com/apache/incubator-iceberg/pull/819#issuecomment-600417010 @rdblue can you please take a look? Thanks. This is an

[GitHub] [incubator-iceberg] jerryshao commented on a change in pull request #841: Upgrade Hive to 2.3.6 for Iceberg

2020-03-17 Thread GitBox
jerryshao commented on a change in pull request #841: Upgrade Hive to 2.3.6 for Iceberg URL: https://github.com/apache/incubator-iceberg/pull/841#discussion_r393554452 ## File path: versions.lock ## @@ -37,34 +37,36 @@ com.sun.jersey:jersey-json:1.9 (5 constraints:

[GitHub] [incubator-iceberg] jerryshao commented on a change in pull request #841: Upgrade Hive to 2.3.6 for Iceberg

2020-03-17 Thread GitBox
jerryshao commented on a change in pull request #841: Upgrade Hive to 2.3.6 for Iceberg URL: https://github.com/apache/incubator-iceberg/pull/841#discussion_r393554719 ## File path: versions.lock ## @@ -73,44 +75,45 @@ javax.annotation:javax.annotation-api:1.3.2 (3

[GitHub] [incubator-iceberg] jerryshao commented on a change in pull request #841: Upgrade Hive to 2.3.6 for Iceberg

2020-03-17 Thread GitBox
jerryshao commented on a change in pull request #841: Upgrade Hive to 2.3.6 for Iceberg URL: https://github.com/apache/incubator-iceberg/pull/841#discussion_r393542421 ## File path: versions.lock ## @@ -170,24 +188,33 @@ org.apache.spark:spark-sketch_2.11:2.4.4 (2

[GitHub] [incubator-iceberg] jerryshao commented on a change in pull request #841: Upgrade Hive to 2.3.6 for Iceberg

2020-03-17 Thread GitBox
jerryshao commented on a change in pull request #841: Upgrade Hive to 2.3.6 for Iceberg URL: https://github.com/apache/incubator-iceberg/pull/841#discussion_r393556681 ## File path: versions.lock ## @@ -37,34 +37,36 @@ com.sun.jersey:jersey-json:1.9 (5 constraints: