electrum commented on issue #350: Add dropTableAndData to Catalog API
URL: https://github.com/apache/incubator-iceberg/pull/350#issuecomment-518447383
This looks like it can fail to cleanup if the process crashes after the
drop. Should we have a special deleted state for tables that
rdblue commented on issue #351: Provide an API to modify records within files
URL: https://github.com/apache/incubator-iceberg/pull/351#issuecomment-518439477
My high-level feedback is that I'd prefer to reuse `OverwriteFiles` and
update it to expose the behavior required by this. If the
rdblue commented on a change in pull request #351: Provide an API to modify
records within files
URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r310830765
##
File path: core/src/main/java/org/apache/iceberg/DefaultModifyFiles.java
##
@@ -0,0 +1,114
rdblue commented on a change in pull request #351: Provide an API to modify
records within files
URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r310828631
##
File path: api/src/main/java/org/apache/iceberg/DataOperations.java
##
@@ -44,6 +44,13 @@
rdblue commented on issue #352: Fix transaction cleanup.
URL: https://github.com/apache/incubator-iceberg/pull/352#issuecomment-518435272
@arina-ielchiieva, this fixes #330, if you would like to have a look at it.
This is an
rdblue opened a new pull request #352: Fix transaction cleanup.
URL: https://github.com/apache/incubator-iceberg/pull/352
#218 refactored how intermediate metadata files are handled in transactions
by adding a callback to collect files to delete in each transaction attempt and
delete just
mccheah commented on issue #24: Run checkstyle in CI
URL:
https://github.com/apache/incubator-iceberg/issues/24#issuecomment-518434781
This can probably be superceded by all the individual tasks for Baseline
integration.
rdblue commented on issue #24: Run checkstyle in CI
URL:
https://github.com/apache/incubator-iceberg/issues/24#issuecomment-518433522
How are we doing on this? Most modules are running checkstyle, right?
This is an automated
rdblue commented on issue #261: Support create and replace transactions in
Catalog
URL:
https://github.com/apache/incubator-iceberg/issues/261#issuecomment-518433111
Here are the original implementations from BaseMetastoreTables, if it helps:
rdblue commented on issue #261: Support create and replace transactions in
Catalog
URL:
https://github.com/apache/incubator-iceberg/issues/261#issuecomment-518432833
I don't think so. Feel free to pick it up!
This is an
aokolnychyi commented on issue #179: Use Iceberg tables as sources for Spark
Structured Streaming
URL:
https://github.com/apache/incubator-iceberg/issues/179#issuecomment-518423067
I am thinking to pick this up in the near future. Let me know if there is
anybody already working on this.
aokolnychyi commented on a change in pull request #351: Provide an API to
modify records within files
URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r310806685
##
File path: core/src/main/java/org/apache/iceberg/DefaultModifyFiles.java
##
@@ -0,0
aokolnychyi commented on a change in pull request #351: Provide an API to
modify records within files
URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r310802612
##
File path: api/src/main/java/org/apache/iceberg/ModifyFiles.java
##
@@ -0,0 +1,59 @@
aokolnychyi commented on a change in pull request #351: Provide an API to
modify records within files
URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r310801433
##
File path: core/src/main/java/org/apache/iceberg/BaseTransaction.java
##
@@ -158,6
aokolnychyi commented on a change in pull request #351: Provide an API to
modify records within files
URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r310801254
##
File path: api/src/main/java/org/apache/iceberg/ModifyFiles.java
##
@@ -0,0 +1,59 @@
aokolnychyi commented on a change in pull request #351: Provide an API to
modify records within files
URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r310801433
##
File path: core/src/main/java/org/apache/iceberg/BaseTransaction.java
##
@@ -158,6
aokolnychyi commented on issue #351: Provide an API to modify records within
files
URL: https://github.com/apache/incubator-iceberg/pull/351#issuecomment-518408801
@johnclara @rdblue I gave it more thought and it probably makes sense to
merge this with `OverwriteFiles` API to avoid the
aokolnychyi opened a new pull request #351: Provide an API to modify records
within files
URL: https://github.com/apache/incubator-iceberg/pull/351
We need an API to remove some existing files and add new ones to perform
"eager" updates and deletes. While `RewriteFiles` is doing exactly
aokolnychyi commented on issue #261: Support create and replace transactions in
Catalog
URL:
https://github.com/apache/incubator-iceberg/issues/261#issuecomment-518404694
Anyone working on this already?
This is an automated
rdblue commented on a change in pull request #350: Add dropTableAndData to
Catalog API
URL: https://github.com/apache/incubator-iceberg/pull/350#discussion_r310776282
##
File path: core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java
##
@@ -92,6 +106,91 @@
rdblue commented on issue #350: Add dropTableAndData to Catalog API
URL: https://github.com/apache/incubator-iceberg/pull/350#issuecomment-518384355
@electrum and @aokolnychyi, this PR fixes delete behavior concerns that you
both raised on #240. Please have a look.
rdblue opened a new pull request #350: Add dropTableAndData to Catalog API
URL: https://github.com/apache/incubator-iceberg/pull/350
This fixes
[concerns](https://github.com/apache/incubator-iceberg/pull/240#discussion_r298692031)
aokolnychyi commented on issue #315: [WIP] Incremental processing prototype
URL: https://github.com/apache/incubator-iceberg/pull/315#issuecomment-518295994
Will it be possible to use this API for #179?
This is an automated
23 matches
Mail list logo
