[GitHub] [incubator-iceberg] rdblue commented on issue #369: Return full stats for added files from Snapshot

rdblue commented on issue #369: Return full stats for added files from Snapshot URL: https://github.com/apache/incubator-iceberg/pull/369#issuecomment-519736267 @rdsr, can you review? This is an automated message from the

[GitHub] [incubator-iceberg] rdblue opened a new pull request #368: Minor update to BaseTransaction snapshot ID handling

rdblue opened a new pull request #368: Minor update to BaseTransaction snapshot ID handling URL: https://github.com/apache/incubator-iceberg/pull/368 Found a minor problem after deploying the recent transaction cleanup fixes.

[GitHub] [incubator-iceberg] rdblue opened a new pull request #367: Add public factory methods for NameMapping

rdblue opened a new pull request #367: Add public factory methods for NameMapping URL: https://github.com/apache/incubator-iceberg/pull/367 These were missing from #338. This is an automated message from the Apache Git

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #365: test cases for parquetMetrics with multiple rowgroup

rdblue commented on a change in pull request #365: test cases for parquetMetrics with multiple rowgroup URL: https://github.com/apache/incubator-iceberg/pull/365#discussion_r312223400 ## File path: parquet/src/test/java/org/apache/iceberg/parquet/TestParquetMetrics.java

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #365: test cases for parquetMetrics with multiple rowgroup

rdblue commented on a change in pull request #365: test cases for parquetMetrics with multiple rowgroup URL: https://github.com/apache/incubator-iceberg/pull/365#discussion_r312223092 ## File path: core/src/test/java/org/apache/iceberg/TestMetrics.java ## @@ -72,23 +78,14

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #365: test cases for parquetMetrics with multiple rowgroup

rdblue commented on a change in pull request #365: test cases for parquetMetrics with multiple rowgroup URL: https://github.com/apache/incubator-iceberg/pull/365#discussion_r312221740 ## File path: core/src/test/java/org/apache/iceberg/TestMetrics.java ## @@ -270,6

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #365: test cases for parquetMetrics with multiple rowgroup

rdblue commented on a change in pull request #365: test cases for parquetMetrics with multiple rowgroup URL: https://github.com/apache/incubator-iceberg/pull/365#discussion_r312221307 ## File path: core/src/test/java/org/apache/iceberg/TestMetrics.java ## @@ -270,6

[GitHub] [incubator-iceberg] rdblue merged pull request #364: Clean up after create and replace transaction failures

rdblue merged pull request #364: Clean up after create and replace transaction failures URL: https://github.com/apache/incubator-iceberg/pull/364 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-iceberg] rdblue commented on issue #170: Add support for Iceberg MR / InputFormat and OutputFormat APIs

rdblue commented on issue #170: Add support for Iceberg MR / InputFormat and OutputFormat APIs URL: https://github.com/apache/incubator-iceberg/issues/170#issuecomment-519659314 @guilload, good points about the reader functions. This is an area where we haven't invested more time because

[GitHub] [incubator-iceberg] moulimukherjee commented on a change in pull request #327: Introduce startsWith Predicate

moulimukherjee commented on a change in pull request #327: Introduce startsWith Predicate URL: https://github.com/apache/incubator-iceberg/pull/327#discussion_r312199486 ## File path: api/src/test/java/org/apache/iceberg/transforms/TestStartsWith.java ## @@ -0,0 +1,99 @@

[GitHub] [incubator-iceberg] rdsr opened a new issue #366: Concurrent appends to the same table using HiveCatalog lead to deadlock

rdsr opened a new issue #366: Concurrent appends to the same table using HiveCatalog lead to deadlock URL: https://github.com/apache/incubator-iceberg/issues/366 I've noticed that, appending files the the same table from multiple threads takes a very large amount of time. The problem is

[GitHub] [incubator-iceberg] TGooch44 commented on issue #277: Moving/Renaming hadoop module to filesystem

TGooch44 commented on issue #277: Moving/Renaming hadoop module to filesystem URL: https://github.com/apache/incubator-iceberg/pull/277#issuecomment-519627784 I think this got back in Peter's PR on Tuesday to fix some of the build. I'm not sure what the best way to resolve this is. I

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #350: Add dropTable purge option to Catalog API

rdblue commented on a change in pull request #350: Add dropTable purge option to Catalog API URL: https://github.com/apache/incubator-iceberg/pull/350#discussion_r312165721 ## File path: api/src/main/java/org/apache/iceberg/catalog/Catalog.java ## @@ -120,6 +120,14 @@

[GitHub] [incubator-iceberg] danielcweeks commented on issue #277: Moving/Renaming hadoop module to filesystem

danielcweeks commented on issue #277: Moving/Renaming hadoop module to filesystem URL: https://github.com/apache/incubator-iceberg/pull/277#issuecomment-519573456 @TGooch44 Just noticed there's a small conflict in the setup.py. Looks like the s3fs somehow got back in and the wasn't

[GitHub] [incubator-iceberg] electrum commented on issue #279: Transforming timestamp to date should produce date

electrum commented on issue #279: Transforming timestamp to date should produce date URL: https://github.com/apache/incubator-iceberg/issues/279#issuecomment-519572394 Use `java.time.LocalDate`. The older `java.util.Date` actually represents an instant.

[GitHub] [incubator-iceberg] danielcweeks commented on a change in pull request #350: Add dropTable purge option to Catalog API

danielcweeks commented on a change in pull request #350: Add dropTable purge option to Catalog API URL: https://github.com/apache/incubator-iceberg/pull/350#discussion_r312103966 ## File path: api/src/main/java/org/apache/iceberg/catalog/Catalog.java ## @@ -120,6 +120,14

[GitHub] [incubator-iceberg] waterlx commented on issue #279: Transforming timestamp to date should produce date

waterlx commented on issue #279: Transforming timestamp to date should produce date URL: https://github.com/apache/incubator-iceberg/issues/279#issuecomment-519485711 Hi @rdblue please correct me if I am wrong: I am not sure if Transforms.day() is the function to transfer timestamps to

[GitHub] [incubator-iceberg] waterlx removed a comment on issue #279: Transforming timestamp to date should produce date

waterlx removed a comment on issue #279: Transforming timestamp to date should produce date URL: https://github.com/apache/incubator-iceberg/issues/279#issuecomment-519469487 Hi @rdblue, I am new to iceberg, really appreciate your guidance in advance! Regarding "The output type of

[GitHub] [incubator-iceberg] waterlx commented on issue #279: Transforming timestamp to date should produce date

waterlx commented on issue #279: Transforming timestamp to date should produce date URL: https://github.com/apache/incubator-iceberg/issues/279#issuecomment-519469487 Hi @rdblue, I am new to iceberg, really appreciate your guidance in advance! Regarding "The output type of transforming

[GitHub] [incubator-iceberg] manishmalhotrawork closed pull request #314: test cases for parquetMetrics with multiple rowgroups

manishmalhotrawork closed pull request #314: test cases for parquetMetrics with multiple rowgroups URL: https://github.com/apache/incubator-iceberg/pull/314 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-iceberg] manishmalhotrawork commented on issue #314: test cases for parquetMetrics with multiple rowgroups

manishmalhotrawork commented on issue #314: test cases for parquetMetrics with multiple rowgroups URL: https://github.com/apache/incubator-iceberg/pull/314#issuecomment-519406362 closing this one, as `TestParquetMetrics` is refactored. opened

[GitHub] [incubator-iceberg] manishmalhotrawork opened a new pull request #365: test cases for parquetMetrics with multiple rowgroup

manishmalhotrawork opened a new pull request #365: test cases for parquetMetrics with multiple rowgroup URL: https://github.com/apache/incubator-iceberg/pull/365 this PR is for issue #132. -- tested firstLevel fields and nestedStructure with multipleRowGroups. closing old