rdblue commented on issue #279: Transforming timestamp to date should produce
date
URL:
https://github.com/apache/incubator-iceberg/issues/279#issuecomment-527532305
@waterlx, I think you're right. We should update that line. Do you want to
open a PR?
rdblue commented on issue #279: Transforming timestamp to date should produce
date
URL:
https://github.com/apache/incubator-iceberg/issues/279#issuecomment-526753469
Yep. Thank you!
This is an automated message from the
rdblue commented on issue #279: Transforming timestamp to date should produce
date
URL:
https://github.com/apache/incubator-iceberg/issues/279#issuecomment-522800271
> can you point me to any other test-case or code path, where
[getResultType] is being used can be verified.
There
rdblue commented on issue #279: Transforming timestamp to date should produce
date
URL:
https://github.com/apache/incubator-iceberg/issues/279#issuecomment-522102358
Yes, I think both should return `DateType`
This is an
rdblue commented on issue #279: Transforming timestamp to date should produce
date
URL:
https://github.com/apache/incubator-iceberg/issues/279#issuecomment-521322801
Sorry for the confusion. I'm talking about the Iceberg date type,
`Types.DateType.get()`. The transform implementation is
rdblue commented on issue #279: Transforming timestamp to date should produce
date
URL:
https://github.com/apache/incubator-iceberg/issues/279#issuecomment-520563552
@manishmalhotrawork, only the `day` transform should return a date. Years,
months, and hours should continue returning
rdblue commented on issue #279: Transforming timestamp to date should produce
date
URL:
https://github.com/apache/incubator-iceberg/issues/279#issuecomment-512611741
You're probably right, although there shouldn't be a difference between the
two in practice, once strict projection for
