[GitHub] [incubator-iceberg] yathindranath commented on a change in pull request #497: Support retaining last N snapshots

yathindranath commented on a change in pull request #497: Support retaining last N snapshots URL: https://github.com/apache/incubator-iceberg/pull/497#discussion_r355753282 ## File path: api/src/main/java/org/apache/iceberg/ExpireSnapshots.java ## @@ -55,6 +55,15 @@

[GitHub] [incubator-iceberg] yathindranath commented on a change in pull request #497: Support retaining last N snapshots

yathindranath commented on a change in pull request #497: Support retaining last N snapshots URL: https://github.com/apache/incubator-iceberg/pull/497#discussion_r334128531 ## File path: core/src/main/java/org/apache/iceberg/RemoveSnapshots.java ## @@ -77,8 +79,34 @@

[GitHub] [incubator-iceberg] yathindranath commented on a change in pull request #497: Support retaining last N snapshots

yathindranath commented on a change in pull request #497: Support retaining last N snapshots URL: https://github.com/apache/incubator-iceberg/pull/497#discussion_r333790897 ## File path: core/src/main/java/org/apache/iceberg/RemoveSnapshots.java ## @@ -77,8 +79,34 @@

[GitHub] [incubator-iceberg] yathindranath commented on a change in pull request #497: Support retaining last N snapshots

yathindranath commented on a change in pull request #497: Support retaining last N snapshots URL: https://github.com/apache/incubator-iceberg/pull/497#discussion_r333158423 ## File path: core/src/main/java/org/apache/iceberg/RemoveSnapshots.java ## @@ -77,8 +79,34 @@

[GitHub] [incubator-iceberg] yathindranath commented on a change in pull request #497: Support retaining last N snapshots

yathindranath commented on a change in pull request #497: Support retaining last N snapshots URL: https://github.com/apache/incubator-iceberg/pull/497#discussion_r332683939 ## File path: core/src/main/java/org/apache/iceberg/RemoveSnapshots.java ## @@ -77,8 +79,34 @@

[GitHub] [incubator-iceberg] yathindranath commented on a change in pull request #497: Support retaining last N snapshots

yathindranath commented on a change in pull request #497: Support retaining last N snapshots URL: https://github.com/apache/incubator-iceberg/pull/497#discussion_r332287273 ## File path: core/src/main/java/org/apache/iceberg/RemoveSnapshots.java ## @@ -77,8 +79,34 @@

[GitHub] [incubator-iceberg] yathindranath commented on a change in pull request #497: Support retaining last N snapshots

yathindranath commented on a change in pull request #497: Support retaining last N snapshots URL: https://github.com/apache/incubator-iceberg/pull/497#discussion_r331309609 ## File path: core/src/main/java/org/apache/iceberg/RemoveSnapshots.java ## @@ -82,6 +83,18 @@

[GitHub] [incubator-iceberg] yathindranath commented on a change in pull request #497: Support retaining last N snapshots

yathindranath commented on a change in pull request #497: Support retaining last N snapshots URL: https://github.com/apache/incubator-iceberg/pull/497#discussion_r331308932 ## File path: api/src/main/java/org/apache/iceberg/ExpireSnapshots.java ## @@ -55,6 +55,14 @@

[GitHub] [incubator-iceberg] yathindranath commented on a change in pull request #497: Support retaining last N snapshots

yathindranath commented on a change in pull request #497: Support retaining last N snapshots URL: https://github.com/apache/incubator-iceberg/pull/497#discussion_r329742705 ## File path: core/src/main/java/org/apache/iceberg/RemoveSnapshots.java ## @@ -82,6 +83,18 @@

[GitHub] [incubator-iceberg] yathindranath commented on a change in pull request #497: Support retaining last N snapshots

yathindranath commented on a change in pull request #497: Support retaining last N snapshots URL: https://github.com/apache/incubator-iceberg/pull/497#discussion_r329741161 ## File path: core/src/main/java/org/apache/iceberg/RemoveSnapshots.java ## @@ -310,6 +323,19 @@

[GitHub] [incubator-iceberg] yathindranath commented on a change in pull request #497: Support retaining last N snapshots

yathindranath commented on a change in pull request #497: Support retaining last N snapshots URL: https://github.com/apache/incubator-iceberg/pull/497#discussion_r329194963 ## File path: core/src/main/java/org/apache/iceberg/RemoveSnapshots.java ## @@ -310,6 +323,19 @@

[GitHub] [incubator-iceberg] yathindranath commented on a change in pull request #497: Support retaining last N snapshots

yathindranath commented on a change in pull request #497: Support retaining last N snapshots URL: https://github.com/apache/incubator-iceberg/pull/497#discussion_r329191462 ## File path: core/src/main/java/org/apache/iceberg/RemoveSnapshots.java ## @@ -310,6 +323,22 @@

[GitHub] [incubator-iceberg] yathindranath commented on a change in pull request #497: Support retaining last N snapshots

yathindranath commented on a change in pull request #497: Support retaining last N snapshots URL: https://github.com/apache/incubator-iceberg/pull/497#discussion_r329189650 ## File path: core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java ## @@ -0,0 +1,132 @@

[GitHub] [incubator-iceberg] yathindranath commented on a change in pull request #497: Support retaining last N snapshots

yathindranath commented on a change in pull request #497: Support retaining last N snapshots URL: https://github.com/apache/incubator-iceberg/pull/497#discussion_r328769072 ## File path: core/src/main/java/org/apache/iceberg/RemoveSnapshots.java ## @@ -310,6 +323,19 @@

[GitHub] [incubator-iceberg] yathindranath commented on a change in pull request #497: Support retaining last N snapshots

yathindranath commented on a change in pull request #497: Support retaining last N snapshots URL: https://github.com/apache/incubator-iceberg/pull/497#discussion_r328755892 ## File path: api/src/main/java/org/apache/iceberg/ExpireSnapshots.java ## @@ -55,6 +55,14 @@