[
https://issues.apache.org/jira/browse/IGNITE-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971542#comment-16971542
]
Yuriy Shuliha commented on IGNITE-12189:
-
[~Pavlukhin] - added the "Release Note"
> Implement
[
https://issues.apache.org/jira/browse/IGNITE-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971499#comment-16971499
]
Ivan Pavlukhin commented on IGNITE-12189:
-
[~Yuriy_Shuliha], could you please fill in "Release
[
https://issues.apache.org/jira/browse/IGNITE-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971497#comment-16971497
]
Ivan Pavlukhin commented on IGNITE-12189:
-
[~Yuriy_Shuliha], thank you for contribution! Merged
[
https://issues.apache.org/jira/browse/IGNITE-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971457#comment-16971457
]
Yuriy Shuliha commented on IGNITE-12189:
-
[~Pavlukhin] - Sorry for delay, was on vacation
[
https://issues.apache.org/jira/browse/IGNITE-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971455#comment-16971455
]
Yuriy Shuliha commented on IGNITE-12189:
-
[~Pavlukhin] There's no more work to be done on the
[
https://issues.apache.org/jira/browse/IGNITE-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967465#comment-16967465
]
Ivan Pavlukhin commented on IGNITE-12189:
-
[~Yuriy_Shuliha], could you please create a ticket
[
https://issues.apache.org/jira/browse/IGNITE-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967463#comment-16967463
]
Ivan Pavlukhin commented on IGNITE-12189:
-
[~Yuriy_Shuliha], the PR looks fine to be merged. If
[
https://issues.apache.org/jira/browse/IGNITE-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967460#comment-16967460
]
Ignite TC Bot commented on IGNITE-12189:
{panel:title=Branch: [pull/6917/head] Base: [master] :
[
https://issues.apache.org/jira/browse/IGNITE-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967319#comment-16967319
]
Ignite TC Bot commented on IGNITE-12189:
{panel:title=Branch: [pull/6917/head] Base: [master] :
[
https://issues.apache.org/jira/browse/IGNITE-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16966888#comment-16966888
]
Ignite TC Bot commented on IGNITE-12189:
{panel:title=Branch: [pull/6917/head] Base: [master] :
[
https://issues.apache.org/jira/browse/IGNITE-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16966879#comment-16966879
]
Yuriy Shuliha commented on IGNITE-12189:
-
[~Pavlukhin] - running TC tests now
[
https://issues.apache.org/jira/browse/IGNITE-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964902#comment-16964902
]
Yuriy Shuliha commented on IGNITE-12189:
-
[~Pavlukhin] - #2 did resolved according to your
[
https://issues.apache.org/jira/browse/IGNITE-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964708#comment-16964708
]
Ivan Pavlukhin commented on IGNITE-12189:
-
[~Yuriy_Shuliha], check a couple of comments on
[
https://issues.apache.org/jira/browse/IGNITE-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964264#comment-16964264
]
Yuriy Shuliha commented on IGNITE-12189:
-
[~Pavlukhin] - did resolved according to your
[
https://issues.apache.org/jira/browse/IGNITE-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963070#comment-16963070
]
Ivan Pavlukhin commented on IGNITE-12189:
-
[~Yuriy_Shuliha], I left comments on GitHub.
>
[
https://issues.apache.org/jira/browse/IGNITE-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961789#comment-16961789
]
Ivan Pavlukhin commented on IGNITE-12189:
-
[~Yuriy_Shuliha], sorry a delay. A little rush these
[
https://issues.apache.org/jira/browse/IGNITE-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961071#comment-16961071
]
Yuriy Shuliha commented on IGNITE-12189:
-
[~amashenkov], [~Pavlukhin] the recent changes
[
https://issues.apache.org/jira/browse/IGNITE-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957103#comment-16957103
]
Andrey Mashenkov commented on IGNITE-12189:
---
[~Yuriy_Shuliha],
i've left a comment to the PR.
[
https://issues.apache.org/jira/browse/IGNITE-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956980#comment-16956980
]
Yuriy Shuliha commented on IGNITE-12189:
-
'total' and 'limit' merged into single 'totalCnt'
[
https://issues.apache.org/jira/browse/IGNITE-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956977#comment-16956977
]
Yuriy Shuliha commented on IGNITE-12189:
-
On behalf of [~amashenkov]
>>>
I've found
[
https://issues.apache.org/jira/browse/IGNITE-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952012#comment-16952012
]
Yuriy Shuliha commented on IGNITE-12189:
-
[~amashenkov] IGNITE-12291 ticket was created and
[
https://issues.apache.org/jira/browse/IGNITE-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948677#comment-16948677
]
Andrey Mashenkov commented on IGNITE-12189:
---
Thanks.
I've just found you apply 'limit' on
[
https://issues.apache.org/jira/browse/IGNITE-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948629#comment-16948629
]
Yuriy Shuliha commented on IGNITE-12189:
-
[~amashenkov] - I have made corrections according to
[
https://issues.apache.org/jira/browse/IGNITE-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948574#comment-16948574
]
Ignite TC Bot commented on IGNITE-12189:
{panel:title=Branch: [pull/6917/head] Base: [master] :
[
https://issues.apache.org/jira/browse/IGNITE-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16947760#comment-16947760
]
Ignite TC Bot commented on IGNITE-12189:
{panel:title=Branch: [pull/6917/head] Base: [master] :
[
https://issues.apache.org/jira/browse/IGNITE-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16947429#comment-16947429
]
Andrey Mashenkov commented on IGNITE-12189:
---
Yuri,
Check code style test failed due to
[
https://issues.apache.org/jira/browse/IGNITE-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946934#comment-16946934
]
Yuriy Shuliha commented on IGNITE-12189:
-
[~amashenkov] thank you for starting TC Bot.
Can the
[
https://issues.apache.org/jira/browse/IGNITE-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946684#comment-16946684
]
Ignite TC Bot commented on IGNITE-12189:
{panel:title=Branch: [pull/6917/head] Base: [master] :
[
https://issues.apache.org/jira/browse/IGNITE-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944584#comment-16944584
]
Andrey Mashenkov commented on IGNITE-12189:
---
[~Yuriy_Shuliha], looks better.
I've added a
[
https://issues.apache.org/jira/browse/IGNITE-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943640#comment-16943640
]
Andrey Mashenkov commented on IGNITE-12189:
---
[~Yuriy_Shuliha], good try. I've left few
[
https://issues.apache.org/jira/browse/IGNITE-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16939338#comment-16939338
]
Yuriy Shuliha commented on IGNITE-12189:
-
[~yzhdanov] please review my pull-request in scope
31 matches
Mail list logo
