[jira] [Commented] (IGNITE-8485) TDE - Phase-1

2018-10-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639598#comment-16639598 ] ASF GitHub Bot commented on IGNITE-8485: Github user asfgit closed the pull request at:

[jira] [Commented] (IGNITE-8485) TDE - Phase-1

2018-10-05 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639583#comment-16639583 ] Nikolay Izhikov commented on IGNITE-8485: - Run All -

[jira] [Commented] (IGNITE-8485) TDE - Phase-1

2018-10-03 Thread Ignite TC Bot (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636779#comment-16636779 ] Ignite TC Bot commented on IGNITE-8485: --- {panel:title=No blockers

[jira] [Commented] (IGNITE-8485) TDE - Phase-1

2018-10-03 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636567#comment-16636567 ] Nikolay Izhikov commented on IGNITE-8485: - Run All results -

[jira] [Commented] (IGNITE-8485) TDE - Phase-1

2018-10-02 Thread Dmitriy Pavlov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16635481#comment-16635481 ] Dmitriy Pavlov commented on IGNITE-8485: We should definitely fix .NET compilation before the

[jira] [Commented] (IGNITE-8485) TDE - Phase-1

2018-10-02 Thread Dmitriy Pavlov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16635406#comment-16635406 ] Dmitriy Pavlov commented on IGNITE-8485: I left several comments in the PR about API uniformity,

[jira] [Commented] (IGNITE-8485) TDE - Phase-1

2018-10-02 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16635111#comment-16635111 ] Nikolay Izhikov commented on IGNITE-8485: - [~avinogradov] I double checked benchmark results on

[jira] [Commented] (IGNITE-8485) TDE - Phase-1

2018-10-01 Thread Ignite TC Bot (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633971#comment-16633971 ] Ignite TC Bot commented on IGNITE-8485: --- {panel:title=Possible

[jira] [Commented] (IGNITE-8485) TDE - Phase-1

2018-10-01 Thread Ignite TC Bot (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633800#comment-16633800 ] Ignite TC Bot commented on IGNITE-8485: --- {panel:title=Possible

[jira] [Commented] (IGNITE-8485) TDE - Phase-1

2018-10-01 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633767#comment-16633767 ] Nikolay Izhikov commented on IGNITE-8485: - Benchmark results !Screen Shot 2018-10-01 at 10.27.37

[jira] [Commented] (IGNITE-8485) TDE - Phase-1

2018-09-28 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631518#comment-16631518 ] Nikolay Izhikov commented on IGNITE-8485: - Hello, [~agoncharuk] > did you add a check if Ignite

[jira] [Commented] (IGNITE-8485) TDE - Phase-1

2018-09-28 Thread Alexey Goncharuk (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631509#comment-16631509 ] Alexey Goncharuk commented on IGNITE-8485: -- [~NIzhikov], did you add a check if Ignite starts

[jira] [Commented] (IGNITE-8485) TDE - Phase-1

2018-09-25 Thread Vladimir Ozerov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627410#comment-16627410 ] Vladimir Ozerov commented on IGNITE-8485: - [~NIzhikov], thank you. Now encryption part looks

[jira] [Commented] (IGNITE-8485) TDE - Phase-1

2018-09-24 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625677#comment-16625677 ] Nikolay Izhikov commented on IGNITE-8485: - [~vozerov] As we discussed privately, I've moved

[jira] [Commented] (IGNITE-8485) TDE - Phase-1

2018-09-24 Thread Vladimir Ozerov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625424#comment-16625424 ] Vladimir Ozerov commented on IGNITE-8485: - [~NIzhikov], I am not sure I understand the whole

[jira] [Commented] (IGNITE-8485) TDE - Phase-1

2018-09-19 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620535#comment-16620535 ] Nikolay Izhikov commented on IGNITE-8485: - [~vozerov] > 5) GridEncryptionManager - checks for

[jira] [Commented] (IGNITE-8485) TDE - Phase-1

2018-09-19 Thread Alexey Goncharuk (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620242#comment-16620242 ] Alexey Goncharuk commented on IGNITE-8485: -- I will take a look shortly. [~DmitriyGovorukhin],

[jira] [Commented] (IGNITE-8485) TDE - Phase-1

2018-09-19 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620253#comment-16620253 ] Nikolay Izhikov commented on IGNITE-8485: - [~agoncharuk] I will fix Vladimir comments in a

[jira] [Commented] (IGNITE-8485) TDE - Phase-1

2018-09-18 Thread Vladimir Ozerov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619628#comment-16619628 ] Vladimir Ozerov commented on IGNITE-8485: - Hi [~NIzhikov], my comments: First part of comments

[jira] [Commented] (IGNITE-8485) TDE - Phase-1

2018-09-13 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16613207#comment-16613207 ] Nikolay Izhikov commented on IGNITE-8485: - [~vozerov] > 7) There is no need to throw exception

[jira] [Commented] (IGNITE-8485) TDE - Phase-1

2018-09-12 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612504#comment-16612504 ] Nikolay Izhikov commented on IGNITE-8485: - [~vozerov] I've fixed all your comments excluding 7.

[jira] [Commented] (IGNITE-8485) TDE - Phase-1

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611999#comment-16611999 ] ASF GitHub Bot commented on IGNITE-8485: Github user nizhikov closed the pull request at:

[jira] [Commented] (IGNITE-8485) TDE - Phase-1

2018-09-11 Thread Vladimir Ozerov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610255#comment-16610255 ] Vladimir Ozerov commented on IGNITE-8485: - Hi [~NIzhikov], my comments: 1) Styling: please look

[jira] [Commented] (IGNITE-8485) TDE - Phase-1

2018-09-04 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603538#comment-16603538 ] Nikolay Izhikov commented on IGNITE-8485: - [~vozerov] I've fixed all comments from your first

[jira] [Commented] (IGNITE-8485) TDE - Phase-1

2018-08-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595122#comment-16595122 ] ASF GitHub Bot commented on IGNITE-8485: GitHub user nizhikov opened a pull request:

[jira] [Commented] (IGNITE-8485) TDE - Phase-1

2018-06-26 Thread Ryabov Dmitrii (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523957#comment-16523957 ] Ryabov Dmitrii commented on IGNITE-8485: Looks good to me. > TDE - Phase-1 > - > >

[jira] [Commented] (IGNITE-8485) TDE - Phase-1

2018-06-26 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523799#comment-16523799 ] Nikolay Izhikov commented on IGNITE-8485: - Please, note: To run TDE tests one should install

[jira] [Commented] (IGNITE-8485) TDE - Phase-1

2018-06-14 Thread Vladimir Ozerov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1651#comment-1651 ] Vladimir Ozerov commented on IGNITE-8485: - Hi, [~NIzhikov]. Several preliminary questions

[jira] [Commented] (IGNITE-8485) TDE - Phase-1

2018-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506896#comment-16506896 ] ASF GitHub Bot commented on IGNITE-8485: GitHub user nizhikov opened a pull request: