[jira] [Assigned] (IGNITE-13040) Remove unused parameter from TcpDiscoverySpi.writeToSocket()
[
https://issues.apache.org/jira/browse/IGNITE-13040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksey Kurinov reassigned IGNITE-13040:
Assignee: (was: Aleksey Kurinov)
> Remove unused parameter from TcpDiscoverySpi.writeToSocket()
>
>
> Key: IGNITE-13040
> URL: https://issues.apache.org/jira/browse/IGNITE-13040
> Project: Ignite
> Issue Type: Improvement
> Environment:
>Reporter: Vladimir Steshin
>Priority: Trivial
>
> Unused parameter
> {code:java}
> TcpDiscoveryAbstractMessage msg{code}
> should be removed from
> {code:java}
> TcpDiscoverySpi.writeToSocket(Socket sock, TcpDiscoveryAbstractMessage msg,
> byte[] data, long timeout){code}
> This method seems to send raw data, not a message.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (IGNITE-13218) System view walker generator wrong sorts imports
[
https://issues.apache.org/jira/browse/IGNITE-13218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksey Kurinov updated IGNITE-13218:
-
Labels: community_source newbie (was: newbie)
> System view walker generator wrong sorts imports
>
>
> Key: IGNITE-13218
> URL: https://issues.apache.org/jira/browse/IGNITE-13218
> Project: Ignite
> Issue Type: Bug
>Reporter: Amelchev Nikita
>Assignee: Aleksey Kurinov
>Priority: Trivial
> Labels: community_source, newbie
> Fix For: 2.10
>
> Attachments: master_3693e41326_IGNITE-13218.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> {{SystemViewRowAttributeWalkerGenerator}} wrong sorts imports.
> 1. Run SystemViewRowAttributeWalkerGenerator
> 2. Run check codestyle to obtain the error:
> {noformat}
> ComputeJobViewWalker.java:23: Wrong lexicographical order for
> 'org.apache.ignite.spi.systemview.view.ComputeJobView' import. Should be
> before
> 'org.apache.ignite.spi.systemview.view.ComputeJobView.ComputeJobState'.
> [CustomImportOrder]
> Audit done.
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-13218) System view walker generator wrong sorts imports
[
https://issues.apache.org/jira/browse/IGNITE-13218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185200#comment-17185200
]
Aleksey Kurinov commented on IGNITE-13218:
--
[~NSAmelchev], [~avinogradov],[~agoncharuk]
PR is https://github.com/apache/ignite/pull/8187
test run without possible blockers -
https://mtcga.gridgain.com/pr.html?serverId=apache=IgniteTests24Java8_RunAll=pull/8187/head=Latest
please review PR.
please note can't add reviewers to this PR for some reasons
> System view walker generator wrong sorts imports
>
>
> Key: IGNITE-13218
> URL: https://issues.apache.org/jira/browse/IGNITE-13218
> Project: Ignite
> Issue Type: Bug
>Reporter: Amelchev Nikita
>Assignee: Aleksey Kurinov
>Priority: Trivial
> Labels: newbie
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {{SystemViewRowAttributeWalkerGenerator}} wrong sorts imports.
> 1. Run SystemViewRowAttributeWalkerGenerator
> 2. Run check codestyle to obtain the error:
> {noformat}
> ComputeJobViewWalker.java:23: Wrong lexicographical order for
> 'org.apache.ignite.spi.systemview.view.ComputeJobView' import. Should be
> before
> 'org.apache.ignite.spi.systemview.view.ComputeJobView.ComputeJobState'.
> [CustomImportOrder]
> Audit done.
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-13218) System view walker generator wrong sorts imports
[
https://issues.apache.org/jira/browse/IGNITE-13218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183882#comment-17183882
]
Aleksey Kurinov commented on IGNITE-13218:
--
[~NSAmelchev] I've started working on this task. let me know if you have any
objections
> System view walker generator wrong sorts imports
>
>
> Key: IGNITE-13218
> URL: https://issues.apache.org/jira/browse/IGNITE-13218
> Project: Ignite
> Issue Type: Bug
>Reporter: Amelchev Nikita
>Assignee: Aleksey Kurinov
>Priority: Trivial
> Labels: newbie
>
> {{SystemViewRowAttributeWalkerGenerator}} wrong sorts imports.
> 1. Run SystemViewRowAttributeWalkerGenerator
> 2. Run check codestyle to obtain the error:
> {noformat}
> ComputeJobViewWalker.java:23: Wrong lexicographical order for
> 'org.apache.ignite.spi.systemview.view.ComputeJobView' import. Should be
> before
> 'org.apache.ignite.spi.systemview.view.ComputeJobView.ComputeJobState'.
> [CustomImportOrder]
> Audit done.
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (IGNITE-13218) System view walker generator wrong sorts imports
[
https://issues.apache.org/jira/browse/IGNITE-13218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksey Kurinov reassigned IGNITE-13218:
Assignee: Aleksey Kurinov
> System view walker generator wrong sorts imports
>
>
> Key: IGNITE-13218
> URL: https://issues.apache.org/jira/browse/IGNITE-13218
> Project: Ignite
> Issue Type: Bug
>Reporter: Amelchev Nikita
>Assignee: Aleksey Kurinov
>Priority: Trivial
> Labels: newbie
>
> {{SystemViewRowAttributeWalkerGenerator}} wrong sorts imports.
> 1. Run SystemViewRowAttributeWalkerGenerator
> 2. Run check codestyle to obtain the error:
> {noformat}
> ComputeJobViewWalker.java:23: Wrong lexicographical order for
> 'org.apache.ignite.spi.systemview.view.ComputeJobView' import. Should be
> before
> 'org.apache.ignite.spi.systemview.view.ComputeJobView.ComputeJobState'.
> [CustomImportOrder]
> Audit done.
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-13040) Remove unused parameter from TcpDiscoverySpi.writeToSocket()
[
https://issues.apache.org/jira/browse/IGNITE-13040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181799#comment-17181799
]
Aleksey Kurinov commented on IGNITE-13040:
--
non-trivial tests update is required.
> Remove unused parameter from TcpDiscoverySpi.writeToSocket()
>
>
> Key: IGNITE-13040
> URL: https://issues.apache.org/jira/browse/IGNITE-13040
> Project: Ignite
> Issue Type: Improvement
> Environment:
>Reporter: Vladimir Steshin
>Assignee: Aleksey Kurinov
>Priority: Trivial
>
> Unused parameter
> {code:java}
> TcpDiscoveryAbstractMessage msg{code}
> should be removed from
> {code:java}
> TcpDiscoverySpi.writeToSocket(Socket sock, TcpDiscoveryAbstractMessage msg,
> byte[] data, long timeout){code}
> This method seems to send raw data, not a message.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (IGNITE-13040) Remove unused parameter from TcpDiscoverySpi.writeToSocket()
[
https://issues.apache.org/jira/browse/IGNITE-13040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksey Kurinov updated IGNITE-13040:
-
Labels: (was: newbie)
> Remove unused parameter from TcpDiscoverySpi.writeToSocket()
>
>
> Key: IGNITE-13040
> URL: https://issues.apache.org/jira/browse/IGNITE-13040
> Project: Ignite
> Issue Type: Improvement
> Environment:
>Reporter: Vladimir Steshin
>Assignee: Aleksey Kurinov
>Priority: Trivial
>
> Unused parameter
> {code:java}
> TcpDiscoveryAbstractMessage msg{code}
> should be removed from
> {code:java}
> TcpDiscoverySpi.writeToSocket(Socket sock, TcpDiscoveryAbstractMessage msg,
> byte[] data, long timeout){code}
> This method seems to send raw data, not a message.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-13040) Remove unused parameter from TcpDiscoverySpi.writeToSocket()
[
https://issues.apache.org/jira/browse/IGNITE-13040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172093#comment-17172093
]
Aleksey Kurinov commented on IGNITE-13040:
--
[~vladsz83] I've updated source code according you your recommendations.
{color:#24292e}TcpDiscoveryConnectionCheckMessage
{color:#003000}m{color}{color}essage stub is used according to your comment
{color:#24292e}// Replace logic routine message with a stub to update
last-sent-time to avoid segmentation on{color}
{color:#24292e} // connRecoveryTimeout.{color}
{color:#24292e}please review PR changes to check if I updated it
correctly{color}
[~slava.koptilin] , [~vladsz83] test still fail in TeamCity and i'm not sure why
here is the link to report in teamcity Bot:
[https://mtcga.gridgain.com/pr.html?serverId=apache=IgniteTests24Java8_RunAll=pull/7977/head=Latest]
to double check I submitted another Pull Request with a minor change against
master branch. I just added a comment line. TemCity test also failed for this
fake PR:
[https://mtcga.gridgain.com/pr.html?serverId=apache=IgniteTests24Java8_RunAll=pull/8121/head=Latest]
Please clarify how to get TeamCity test passed ?
> Remove unused parameter from TcpDiscoverySpi.writeToSocket()
>
>
> Key: IGNITE-13040
> URL: https://issues.apache.org/jira/browse/IGNITE-13040
> Project: Ignite
> Issue Type: Improvement
> Environment:
>Reporter: Vladimir Steshin
>Assignee: Aleksey Kurinov
>Priority: Trivial
> Labels: newbie
>
> Unused parameter
> {code:java}
> TcpDiscoveryAbstractMessage msg{code}
> should be removed from
> {code:java}
> TcpDiscoverySpi.writeToSocket(Socket sock, TcpDiscoveryAbstractMessage msg,
> byte[] data, long timeout){code}
> This method seems to send raw data, not a message.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-13040) Remove unused parameter from TcpDiscoverySpi.writeToSocket()
[
https://issues.apache.org/jira/browse/IGNITE-13040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160789#comment-17160789
]
Aleksey Kurinov commented on IGNITE-13040:
--
[~vladsz83], [~agoncharuk] , please check out the pull request.
[https://github.com/apache/ignite/pull/7977]
> Remove unused parameter from TcpDiscoverySpi.writeToSocket()
>
>
> Key: IGNITE-13040
> URL: https://issues.apache.org/jira/browse/IGNITE-13040
> Project: Ignite
> Issue Type: Improvement
> Environment:
>Reporter: Vladimir Steshin
>Assignee: Aleksey Kurinov
>Priority: Trivial
> Labels: newbie
>
> Unused parameter
> {code:java}
> TcpDiscoveryAbstractMessage msg{code}
> should be removed from
> {code:java}
> TcpDiscoverySpi.writeToSocket(Socket sock, TcpDiscoveryAbstractMessage msg,
> byte[] data, long timeout){code}
> This method seems to send raw data, not a message.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-13040) Remove unused parameter from TcpDiscoverySpi.writeToSocket()
[
https://issues.apache.org/jira/browse/IGNITE-13040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148083#comment-17148083
]
Aleksey Kurinov commented on IGNITE-13040:
--
[~agoncharuk] , pull request is https://github.com/apache/ignite/pull/7977
> Remove unused parameter from TcpDiscoverySpi.writeToSocket()
>
>
> Key: IGNITE-13040
> URL: https://issues.apache.org/jira/browse/IGNITE-13040
> Project: Ignite
> Issue Type: Improvement
> Environment:
>Reporter: Vladimir Steshin
>Assignee: Aleksey Kurinov
>Priority: Trivial
> Labels: newbie
>
> Unused parameter
> {code:java}
> TcpDiscoveryAbstractMessage msg{code}
> should be removed from
> {code:java}
> TcpDiscoverySpi.writeToSocket(Socket sock, TcpDiscoveryAbstractMessage msg,
> byte[] data, long timeout){code}
> This method seems to send raw data, not a message.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-13040) Remove unused parameter from TcpDiscoverySpi.writeToSocket()
[
https://issues.apache.org/jira/browse/IGNITE-13040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17130668#comment-17130668
]
Aleksey Kurinov commented on IGNITE-13040:
--
I've assigned the ticket to me. no problem. thank you
> Remove unused parameter from TcpDiscoverySpi.writeToSocket()
>
>
> Key: IGNITE-13040
> URL: https://issues.apache.org/jira/browse/IGNITE-13040
> Project: Ignite
> Issue Type: Improvement
> Environment:
>Reporter: Vladimir Steshin
>Assignee: Aleksey Kurinov
>Priority: Trivial
> Labels: newbie
>
> Unused parameter
> {code:java}
> TcpDiscoveryAbstractMessage msg{code}
> should be removed from
> {code:java}
> TcpDiscoverySpi.writeToSocket(Socket sock, TcpDiscoveryAbstractMessage msg,
> byte[] data, long timeout){code}
> This method seems to send raw data, not a message.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (IGNITE-13040) Remove unused parameter from TcpDiscoverySpi.writeToSocket()
[
https://issues.apache.org/jira/browse/IGNITE-13040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksey Kurinov reassigned IGNITE-13040:
Assignee: Aleksey Kurinov
> Remove unused parameter from TcpDiscoverySpi.writeToSocket()
>
>
> Key: IGNITE-13040
> URL: https://issues.apache.org/jira/browse/IGNITE-13040
> Project: Ignite
> Issue Type: Improvement
> Environment:
>Reporter: Vladimir Steshin
>Assignee: Aleksey Kurinov
>Priority: Trivial
> Labels: newbie
>
> Unused parameter
> {code:java}
> TcpDiscoveryAbstractMessage msg{code}
> should be removed from
> {code:java}
> TcpDiscoverySpi.writeToSocket(Socket sock, TcpDiscoveryAbstractMessage msg,
> byte[] data, long timeout){code}
> This method seems to send raw data, not a message.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
