[jira] [Commented] (IGNITE-11921) [IEP-35] Migrate CacheGroupMetrics

2019-07-20 Thread Ignite TC Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889478#comment-16889478
 ] 

Ignite TC Bot commented on IGNITE-11921:


{panel:title=Branch: [pull/6647/head] Base: [master] : Possible Blockers 
(1)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}MVCC Cache 7{color} [[tests 
1|https://ci.ignite.apache.org/viewLog.html?buildId=4360603]]
* IgniteCacheMvccTestSuite7: MvccCacheGroupMetricsTest.testCacheGroupMetrics

{panel}
[TeamCity *-- Run :: All* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=4360612buildTypeId=IgniteTests24Java8_RunAll]

> [IEP-35] Migrate CacheGroupMetrics
> --
>
> Key: IGNITE-11921
> URL: https://issues.apache.org/jira/browse/IGNITE-11921
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Major
>  Labels: IEP-35
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> After merging of IGNITE-11848 we should migrate `CacheGroupMetricsMXBean` to 
> the new metric framework.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (IGNITE-11921) [IEP-35] Migrate CacheGroupMetrics

2019-07-19 Thread Anton Vinogradov (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888630#comment-16888630
 ] 

Anton Vinogradov commented on IGNITE-11921:
---

[~NIzhikov], 

Checked the code. 
A don't like 
- explicit type usage at fields and method params. Interface should be used. 
- implementation hiding methods like {noformat}mreg.longMetric(...){noformat} 
(it's not cleat it based on {{AtomicLong}}).

Also, I'm not sure its a good case to use {{AtomicLong}} based counter since 
they may slowdown the system, seems every counter should be replaced with 
{{LongAdder}}.
Do we really need {{AtomicLong}} implementation?

So, my ALGTM for now :) 
Please check the TC before the merge.

> [IEP-35] Migrate CacheGroupMetrics
> --
>
> Key: IGNITE-11921
> URL: https://issues.apache.org/jira/browse/IGNITE-11921
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Major
>  Labels: IEP-35
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> After merging of IGNITE-11848 we should migrate `CacheGroupMetricsMXBean` to 
> the new metric framework.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (IGNITE-11921) [IEP-35] Migrate CacheGroupMetrics

2019-07-14 Thread Nikolay Izhikov (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884605#comment-16884605
 ] 

Nikolay Izhikov commented on IGNITE-11921:
--

Fail of the test is not related to the changes.

Test now is very unstable - 
https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8=-8410532475647722188=testDetails

Success rate - 16,4% 
Tests runs: 360 total/301 fail

> [IEP-35] Migrate CacheGroupMetrics
> --
>
> Key: IGNITE-11921
> URL: https://issues.apache.org/jira/browse/IGNITE-11921
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Major
>  Labels: IEP-35
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> After merging of IGNITE-11848 we should migrate `CacheGroupMetricsMXBean` to 
> the new metric framework.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (IGNITE-11921) [IEP-35] Migrate CacheGroupMetrics

2019-07-14 Thread Ignite TC Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884603#comment-16884603
 ] 

Ignite TC Bot commented on IGNITE-11921:


{panel:title=-- Run :: All: Possible 
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}MVCC Cache 7{color} [[tests 
2|https://ci.ignite.apache.org/viewLog.html?buildId=4297031]]
* IgniteCacheMvccTestSuite7: MvccCacheGroupMetricsTest.testCacheGroupMetrics

{panel}
[TeamCity *-- Run :: All* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=4297040buildTypeId=IgniteTests24Java8_RunAll]

> [IEP-35] Migrate CacheGroupMetrics
> --
>
> Key: IGNITE-11921
> URL: https://issues.apache.org/jira/browse/IGNITE-11921
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Major
>  Labels: IEP-35
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> After merging of IGNITE-11848 we should migrate `CacheGroupMetricsMXBean` to 
> the new metric framework.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)