[jira] [Commented] (IGNITE-3682) GridFunc: move all inner anonymous classes to separate top-level classes.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120594#comment-16120594
 ] 

ASF GitHub Bot commented on IGNITE-3682:


Github user daradurvs closed the pull request at:

https://github.com/apache/ignite/pull/1652


> GridFunc: move all inner anonymous classes to separate top-level classes.
> -
>
> Key: IGNITE-3682
> URL: https://issues.apache.org/jira/browse/IGNITE-3682
> Project: Ignite
>  Issue Type: Task
>  Components: general
>Affects Versions: 1.6
>Reporter: Vladimir Ozerov
>Assignee: Vyacheslav Daradur
>  Labels: important
> Fix For: 2.0
>
>
> Otherwise almost any change to class {{GridFunc}} will lead to serialization 
> issues because we have no control over inner class names.
> E.g. if removed single anonymous class, another anonymous class might change 
> it's name from {{GridFunc$4}} to {{GridFunc$3}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-3682) GridFunc: move all inner anonymous classes to separate top-level classes.

[Andrey Gura (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966121#comment-15966121
 ] 

Andrey Gura commented on IGNITE-3682:
-

[~daradurvs], I've removed unused methods during code review. Changes and TC 
look good to me. Merged into master branch with some fixes.
Thanks a lot for your contribution!

> GridFunc: move all inner anonymous classes to separate top-level classes.
> -
>
> Key: IGNITE-3682
> URL: https://issues.apache.org/jira/browse/IGNITE-3682
> Project: Ignite
>  Issue Type: Task
>  Components: general
>Affects Versions: 1.6
>Reporter: Vladimir Ozerov
>Assignee: Vyacheslav Daradur
>  Labels: important
> Fix For: 2.0
>
>
> Otherwise almost any change to class {{GridFunc}} will lead to serialization 
> issues because we have no control over inner class names.
> E.g. if removed single anonymous class, another anonymous class might change 
> it's name from {{GridFunc$4}} to {{GridFunc$3}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-3682) GridFunc: move all inner anonymous classes to separate top-level classes.

[Vyacheslav Daradur (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15965684#comment-15965684
 ] 

Vyacheslav Daradur commented on IGNITE-3682:


It is remade after rebase.
Sent to [ci.tests|http://ci.ignite.apache.org/viewQueued.html?itemId=543067].

[There is same problem of packaging as in 
master-branch.|http://apache-ignite-developers.2346864.n4.nabble.com/build-failure-in-the-master-branch-td16477.html]

> GridFunc: move all inner anonymous classes to separate top-level classes.
> -
>
> Key: IGNITE-3682
> URL: https://issues.apache.org/jira/browse/IGNITE-3682
> Project: Ignite
>  Issue Type: Task
>  Components: general
>Affects Versions: 1.6
>Reporter: Vladimir Ozerov
>Assignee: Vyacheslav Daradur
>  Labels: important
> Fix For: 2.0
>
>
> Otherwise almost any change to class {{GridFunc}} will lead to serialization 
> issues because we have no control over inner class names.
> E.g. if removed single anonymous class, another anonymous class might change 
> it's name from {{GridFunc$4}} to {{GridFunc$3}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-3682) GridFunc: move all inner anonymous classes to separate top-level classes.

[Vyacheslav Daradur (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15965635#comment-15965635
 ] 

Vyacheslav Daradur commented on IGNITE-3682:


Looks like many methods were removed within IGNITE-4733

> GridFunc: move all inner anonymous classes to separate top-level classes.
> -
>
> Key: IGNITE-3682
> URL: https://issues.apache.org/jira/browse/IGNITE-3682
> Project: Ignite
>  Issue Type: Task
>  Components: general
>Affects Versions: 1.6
>Reporter: Vladimir Ozerov
>Assignee: Vyacheslav Daradur
>  Labels: important
> Fix For: 2.0
>
>
> Otherwise almost any change to class {{GridFunc}} will lead to serialization 
> issues because we have no control over inner class names.
> E.g. if removed single anonymous class, another anonymous class might change 
> it's name from {{GridFunc$4}} to {{GridFunc$3}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-3682) GridFunc: move all inner anonymous classes to separate top-level classes.

[Vyacheslav Daradur (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15965567#comment-15965567
 ] 

Vyacheslav Daradur commented on IGNITE-3682:


[~agura]
Branch was rebased in order to avoid a merge conflict.

There are two new unused methods:
1. GridFunc#nodeId8s
2. GridFunc#toIntArray

Should I remove them?

> GridFunc: move all inner anonymous classes to separate top-level classes.
> -
>
> Key: IGNITE-3682
> URL: https://issues.apache.org/jira/browse/IGNITE-3682
> Project: Ignite
>  Issue Type: Task
>  Components: general
>Affects Versions: 1.6
>Reporter: Vladimir Ozerov
>Assignee: Vyacheslav Daradur
>  Labels: important
> Fix For: 2.0
>
>
> Otherwise almost any change to class {{GridFunc}} will lead to serialization 
> issues because we have no control over inner class names.
> E.g. if removed single anonymous class, another anonymous class might change 
> it's name from {{GridFunc$4}} to {{GridFunc$3}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-3682) GridFunc: move all inner anonymous classes to separate top-level classes.

[Vyacheslav Daradur (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15956674#comment-15956674
 ] 

Vyacheslav Daradur commented on IGNITE-3682:


[The latest ci.tests|http://ci.ignite.apache.org/viewLog.html?buildId=530728]

> GridFunc: move all inner anonymous classes to separate top-level classes.
> -
>
> Key: IGNITE-3682
> URL: https://issues.apache.org/jira/browse/IGNITE-3682
> Project: Ignite
>  Issue Type: Task
>  Components: general
>Affects Versions: 1.6
>Reporter: Vladimir Ozerov
>Assignee: Vyacheslav Daradur
>  Labels: important
> Fix For: 2.0
>
>
> Otherwise almost any change to class {{GridFunc}} will lead to serialization 
> issues because we have no control over inner class names.
> E.g. if removed single anonymous class, another anonymous class might change 
> it's name from {{GridFunc$4}} to {{GridFunc$3}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-3682) GridFunc: move all inner anonymous classes to separate top-level classes.

[Vyacheslav Daradur (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15956434#comment-15956434
 ] 

Vyacheslav Daradur commented on IGNITE-3682:


[~agura]
bq. GridFunc.as method should be removed because this method doesn't have any 
usages.
This removal was the reason.

Sorry about that.
I was hoping at ci.tests.

I've fixed it. 
([ci.tests|http://ci.ignite.apache.org/viewLog.html?buildId=530449])

> GridFunc: move all inner anonymous classes to separate top-level classes.
> -
>
> Key: IGNITE-3682
> URL: https://issues.apache.org/jira/browse/IGNITE-3682
> Project: Ignite
>  Issue Type: Task
>  Components: general
>Affects Versions: 1.6
>Reporter: Vladimir Ozerov
>Assignee: Vyacheslav Daradur
>  Labels: important
> Fix For: 2.0
>
>
> Otherwise almost any change to class {{GridFunc}} will lead to serialization 
> issues because we have no control over inner class names.
> E.g. if removed single anonymous class, another anonymous class might change 
> it's name from {{GridFunc$4}} to {{GridFunc$3}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-3682) GridFunc: move all inner anonymous classes to separate top-level classes.

[Andrey Gura (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15955275#comment-15955275
 ] 

Andrey Gura commented on IGNITE-3682:
-

[~daradurvs],

{{ignite-scalar}} module has compilation error.

> GridFunc: move all inner anonymous classes to separate top-level classes.
> -
>
> Key: IGNITE-3682
> URL: https://issues.apache.org/jira/browse/IGNITE-3682
> Project: Ignite
>  Issue Type: Task
>  Components: general
>Affects Versions: 1.6
>Reporter: Vladimir Ozerov
>Assignee: Vyacheslav Daradur
>  Labels: important
> Fix For: 2.0
>
>
> Otherwise almost any change to class {{GridFunc}} will lead to serialization 
> issues because we have no control over inner class names.
> E.g. if removed single anonymous class, another anonymous class might change 
> it's name from {{GridFunc$4}} to {{GridFunc$3}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-3682) GridFunc: move all inner anonymous classes to separate top-level classes.

[Vyacheslav Daradur (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15952365#comment-15952365
 ] 

Vyacheslav Daradur commented on IGNITE-3682:


[~agura]
Your notes were resolved.
[ci.tests|http://ci.ignite.apache.org/viewLog.html?buildId=526756] look good.
Please, review it again, thanks.

> GridFunc: move all inner anonymous classes to separate top-level classes.
> -
>
> Key: IGNITE-3682
> URL: https://issues.apache.org/jira/browse/IGNITE-3682
> Project: Ignite
>  Issue Type: Task
>  Components: general
>Affects Versions: 1.6
>Reporter: Vladimir Ozerov
>Assignee: Vyacheslav Daradur
>  Labels: important
> Fix For: 2.0
>
>
> Otherwise almost any change to class {{GridFunc}} will lead to serialization 
> issues because we have no control over inner class names.
> E.g. if removed single anonymous class, another anonymous class might change 
> it's name from {{GridFunc$4}} to {{GridFunc$3}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-3682) GridFunc: move all inner anonymous classes to separate top-level classes.

[Andrey Gura (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15947590#comment-15947590
 ] 

Andrey Gura commented on IGNITE-3682:
-

[~daradurvs]

Hi, I've reviewed pull request and have some comments:

* {{GridAbsClosureNoOperation}} class. Please rename it. First of all "Abs" 
prefix should be removed because this class isn't abstract. The second, "Grid" 
prefix is legacy and should be removed also. I think good name for this class 
is "NoOpClosure"
* {{GridAbsClosurePrint}} class and {{GridFunc.println()}} method should be 
removed. {{GridFunc.println()}} method has only one usage in 
{{GridIndexingSpiAbstractSelfTest.testLongQueries}} test that doesn't use 
returned value yet.
* {{GridAbsClosureRunnableWrapper}} class and {{GridFunc.as}} method should be 
removed because this method doesn't have any usages.
* {{GridAbsClosureWrapper}} class and {{GridFunc.curry}} method should be 
removed because this method doesn't have any usages.
* {{GridIteratorAdapterClosurePredicatesWrapper}} class should be renamed to 
something shorter. E.g. {{TransformFilteringItefator}}. Also use short cuts for 
variables like {{iterator}} (corret name is {{iter}}). See code styles.
* {{GridIteratorAdapterWrapper}} class should be renamed accordingly to it 
purpose. E.g. {{FlatIterator}}. {{iterable}} field could be converted to a 
local variable. {{iterator}} field should be renamed to {{iter}}.
* {{GridIteratorOverInnerCollectionsAdapter}} class should be renamed 
accordingly to it purpose. Moreover it very similar to 
{{GridIteratorAdapterWrapper}} class with only diffrence in input parameter: 
{{Iterable}} of {{Iterable}}'s vs {{Iterable}} of {{Iterator}}'s. But we always 
can get {{Iterator}} from {{Iterable}}. Try to remove one of them.
* {{GridSerializableCollectionPredicateWrapper}} class should be renamed to 
something shorter. E.g. {{CollectionView}}. Just add javadoc that will clarify 
that it private predicate that used only in {{GridFunc.view}} method. 
{{collection}} field and parameter should be renamed to {{col}}.
* {{GridSerializableCollectionWrapper}} class should be renamed to something 
shorter. E.g. {{FlatCollectionWrapper}}.
* {{GridSerializableListReadOnlyWithTransformation}} class and 
{{GridFunc.viewListReadOnly}} method should be removed because this method 
doesn't have any usages.
* {{GridSerializableMapPredicatesTransformerWrapper}} class should be renamed 
accordingly to it purpose. E.g. {{MapView}}.
* {{GridSerializableMapPredicatesWrapper}} class should be renamed accordingly 
to it purpose. E.g. {{MapView}}. {{entryPredicate}} field should be renamed to 
{{entryPred}}.

Please look at all newly created classe once again and make changes similar to 
described above.



> GridFunc: move all inner anonymous classes to separate top-level classes.
> -
>
> Key: IGNITE-3682
> URL: https://issues.apache.org/jira/browse/IGNITE-3682
> Project: Ignite
>  Issue Type: Task
>  Components: general
>Affects Versions: 1.6
>Reporter: Vladimir Ozerov
>Assignee: Vyacheslav Daradur
>  Labels: important
> Fix For: 2.0
>
>
> Otherwise almost any change to class {{GridFunc}} will lead to serialization 
> issues because we have no control over inner class names.
> E.g. if removed single anonymous class, another anonymous class might change 
> it's name from {{GridFunc$4}} to {{GridFunc$3}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-3682) GridFunc: move all inner anonymous classes to separate top-level classes.

[Vyacheslav Daradur (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15931874#comment-15931874
 ] 

Vyacheslav Daradur commented on IGNITE-3682:


[~vozerov]

It's done already.
Without any refactoring and changes of code style. (the single changed class - 
[see for 
yourself|https://github.com/apache/ignite/pull/1614/files#diff-169436669aabfa588cd703b6ef6ae036])
Just anonymous classes were extracted. All classes in separate package.
Class names begin with the name of their type, just to be clear.
Merge-conflicts won't be because calls of GridFunc-methods didn't change.

[сi.tests|http://ci.ignite.apache.org/viewLog.html?buildId=504596] look good. 
(.NET fails was just random, [previous is was 
good|http://ci.ignite.apache.org/viewLog.html?buildId=504224=buildResultsDiv=IgniteTests_IgnitePlatformNet])
Decision up to you.


> GridFunc: move all inner anonymous classes to separate top-level classes.
> -
>
> Key: IGNITE-3682
> URL: https://issues.apache.org/jira/browse/IGNITE-3682
> Project: Ignite
>  Issue Type: Task
>  Components: general
>Affects Versions: 1.6
>Reporter: Vladimir Ozerov
>Assignee: Vyacheslav Daradur
>  Labels: important
> Fix For: 2.0
>
>
> Otherwise almost any change to class {{GridFunc}} will lead to serialization 
> issues because we have no control over inner class names.
> E.g. if removed single anonymous class, another anonymous class might change 
> it's name from {{GridFunc$4}} to {{GridFunc$3}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-3682) GridFunc: move all inner anonymous classes to separate top-level classes.

[Vladimir Ozerov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929845#comment-15929845
 ] 

Vladimir Ozerov commented on IGNITE-3682:
-

[~daradurvs], I would skip this task for now and wait for all other major 
tickets targeted for 2.0 to be merged. The reason for this is that {{GridFunc}} 
is one of the most used classes all over the project and even minor changes to 
it might cause lot's of conflicts in other tickets.

Answering your questions:
1) There is separate ticket for removal of unused methods.
2) {{GridFunc}} should not be deprecated because it will contain some useful 
methods still.

> GridFunc: move all inner anonymous classes to separate top-level classes.
> -
>
> Key: IGNITE-3682
> URL: https://issues.apache.org/jira/browse/IGNITE-3682
> Project: Ignite
>  Issue Type: Task
>  Components: general
>Affects Versions: 1.6
>Reporter: Vladimir Ozerov
>Assignee: Vyacheslav Daradur
>  Labels: important
> Fix For: 2.0
>
>
> Otherwise almost any change to class {{GridFunc}} will lead to serialization 
> issues because we have no control over inner class names.
> E.g. if removed single anonymous class, another anonymous class might change 
> it's name from {{GridFunc$4}} to {{GridFunc$3}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-3682) GridFunc: move all inner anonymous classes to separate top-level classes.

[Vyacheslav Daradur (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15907418#comment-15907418
 ] 

Vyacheslav Daradur commented on IGNITE-3682:


[~vozerov]
Can I do some refactoring within this task? (to remove unused methods and code 
duplicates)

> GridFunc: move all inner anonymous classes to separate top-level classes.
> -
>
> Key: IGNITE-3682
> URL: https://issues.apache.org/jira/browse/IGNITE-3682
> Project: Ignite
>  Issue Type: Task
>  Components: general
>Affects Versions: 1.6
>Reporter: Vladimir Ozerov
>Assignee: Vyacheslav Daradur
>  Labels: important
> Fix For: 2.0
>
>
> Otherwise almost any change to class {{GridFunc}} will lead to serialization 
> issues because we have no control over inner class names.
> E.g. if removed single anonymous class, another anonymous class might change 
> it's name from {{GridFunc$4}} to {{GridFunc$3}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-3682) GridFunc: move all inner anonymous classes to separate top-level classes.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15907373#comment-15907373
 ] 

ASF GitHub Bot commented on IGNITE-3682:


GitHub user daradurvs opened a pull request:

https://github.com/apache/ignite/pull/1614

IGNITE-3682



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/daradurvs/ignite ignite-3682

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/1614.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1614


commit 1d91a26e668e6976bde1fed09b8dbb4e55af9350
Author: daradurvs 
Date:   2017-03-08T21:40:07Z

ignite-3682: work in progress

commit 155c95e75090ab1f84c4d204e1ff315f170e4ae3
Author: Vyacheslav Daradur 
Date:   2017-03-09T08:53:45Z

ignite-3682: move new classes to different package; change toString-methods

commit 063b16444a55fbc21143fbec43e03c05f6c94a32
Author: Vyacheslav Daradur 
Date:   2017-03-09T08:56:14Z

ignite-3682: package-info was added

commit 5c2a56d50edd2f79d4ac3d0495cb144f1a67cf03
Author: Vyacheslav Daradur 
Date:   2017-03-09T09:29:55Z

ignite-3682: work in progress

commit 84f311943e02e7178ae61865f163fc7c1d91564f
Author: Vyacheslav Daradur 
Date:   2017-03-09T10:17:05Z

ignite-3682: work in progress

commit 577f1e2bc5533aac1fe17a7120eae34c66f7cb98
Author: Vyacheslav Daradur 
Date:   2017-03-09T11:41:37Z

ignite-3682: anonymous classes defined in class level were extracted to top 
level classes

commit 97e0a420851a801f8007106a482d1d59f51820ba
Author: Vyacheslav Daradur 
Date:   2017-03-09T13:41:31Z

ignite-3682: work in progress

commit 719dec5a251102738d6efa40401db9cf13e1ca84
Author: Vyacheslav Daradur 
Date:   2017-03-10T11:42:21Z

ignite-3682: work in progress

commit 54300f7f0e1fd1b6cb99a666515ade9bf9239701
Author: Vyacheslav Daradur 
Date:   2017-03-10T16:09:45Z

ignite-3682: work in progress

commit 0947be7aa42e7655503da6770d5d4b10423f1347
Author: daradurvs 
Date:   2017-03-11T20:12:48Z

ignite-3682: work in progress

commit a4aafa9253d5c5ca7bd8a99314b401b46a4b213d
Author: daradurvs 
Date:   2017-03-12T09:15:34Z

ignite-3682: minor refactoring with anonymous class extraction

commit 843fd270005c7920bc3881d42323facd24430c67
Author: Vyacheslav Daradur 
Date:   2017-03-13T09:46:25Z

ignite-3682: work in progress

commit 8ea18e36eb1263f34b327b02b3c313c994d85de6
Author: Vyacheslav Daradur 
Date:   2017-03-13T11:39:47Z

ignite-3682: all anonymous classes were extracted

commit b5b11ead2a00bb01fd7c6104aae779035bdcb263
Author: Vyacheslav Daradur 
Date:   2017-03-13T12:32:01Z

ignite-3682: minor changes




> GridFunc: move all inner anonymous classes to separate top-level classes.
> -
>
> Key: IGNITE-3682
> URL: https://issues.apache.org/jira/browse/IGNITE-3682
> Project: Ignite
>  Issue Type: Task
>  Components: general
>Affects Versions: 1.6
>Reporter: Vladimir Ozerov
>Assignee: Vyacheslav Daradur
>  Labels: important
> Fix For: 2.0
>
>
> Otherwise almost any change to class {{GridFunc}} will lead to serialization 
> issues because we have no control over inner class names.
> E.g. if removed single anonymous class, another anonymous class might change 
> it's name from {{GridFunc$4}} to {{GridFunc$3}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-3682) GridFunc: move all inner anonymous classes to separate top-level classes.

[Denis Magda (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826290#comment-15826290
 ] 

Denis Magda commented on IGNITE-3682:
-

[~michael.gri...@gridgain.com], I've granted you contributors permission. 
Please go ahead and assign the ticket on yourself. Thanks!

> GridFunc: move all inner anonymous classes to separate top-level classes.
> -
>
> Key: IGNITE-3682
> URL: https://issues.apache.org/jira/browse/IGNITE-3682
> Project: Ignite
>  Issue Type: Task
>  Components: general
>Affects Versions: 1.6
>Reporter: Vladimir Ozerov
>  Labels: important
> Fix For: 2.0
>
>
> Otherwise almost any change to class {{GridFunc}} will lead to serialization 
> issues because we have no control over inner class names.
> E.g. if removed single anonymous class, another anonymous class might change 
> it's name from {{GridFunc$4}} to {{GridFunc$3}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3682) GridFunc: move all inner anonymous classes to separate top-level classes.

[Michael Griggs (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823200#comment-15823200
 ] 

Michael Griggs commented on IGNITE-3682:


[~dmagda] Denis, please assign this to me!  Mike.

> GridFunc: move all inner anonymous classes to separate top-level classes.
> -
>
> Key: IGNITE-3682
> URL: https://issues.apache.org/jira/browse/IGNITE-3682
> Project: Ignite
>  Issue Type: Task
>  Components: general
>Affects Versions: 1.6
>Reporter: Vladimir Ozerov
>  Labels: important
> Fix For: 2.0
>
>
> Otherwise almost any change to class {{GridFunc}} will lead to serialization 
> issues because we have no control over inner class names.
> E.g. if removed single anonymous class, another anonymous class might change 
> it's name from {{GridFunc$4}} to {{GridFunc$3}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3682) GridFunc: move all inner anonymous classes to separate top-level classes.

[Denis Magda (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822157#comment-15822157
 ] 

Denis Magda commented on IGNITE-3682:
-

Discussion on the dev list:
http://apache-ignite-developers.2346864.n4.nabble.com/Deprecate-GridFunc-td8214.html

> GridFunc: move all inner anonymous classes to separate top-level classes.
> -
>
> Key: IGNITE-3682
> URL: https://issues.apache.org/jira/browse/IGNITE-3682
> Project: Ignite
>  Issue Type: Task
>  Components: general
>Affects Versions: 1.6
>Reporter: Vladimir Ozerov
>  Labels: important
> Fix For: 2.0
>
>
> Otherwise almost any change to class {{GridFunc}} will lead to serialization 
> issues because we have no control over inner class names.
> E.g. if removed single anonymous class, another anonymous class might change 
> it's name from {{GridFunc$4}} to {{GridFunc$3}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)