[jira] [Commented] (IGNITE-9601) Write rollover WAL record as the last record in current segment

2018-10-12 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-9601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648314#comment-16648314
 ] 

ASF GitHub Bot commented on IGNITE-9601:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/4762


> Write rollover WAL record as the last record in current segment
> ---
>
> Key: IGNITE-9601
> URL: https://issues.apache.org/jira/browse/IGNITE-9601
> Project: Ignite
>  Issue Type: Task
>Affects Versions: 2.6
>Reporter: Andrey Kuznetsov
>Assignee: Andrey Kuznetsov
>Priority: Major
> Fix For: 2.8
>
>
> Currently, rollover WAL record gets to the next segment when being logged. 
> Moreover, the implementation allows data races, and rollover record is not 
> necessarily the first record in the next segment. We are to add an option to 
> logging facility to allow writing rollover record to the end of the current 
> segment; subsequent records should get to the next segment then.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-9601) Write rollover WAL record as the last record in current segment

2018-10-12 Thread Ivan Rakov (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-9601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648313#comment-16648313
 ] 

Ivan Rakov commented on IGNITE-9601:


[~andrey-kuznetsov], thanks for your contribution!
Merged to master.

> Write rollover WAL record as the last record in current segment
> ---
>
> Key: IGNITE-9601
> URL: https://issues.apache.org/jira/browse/IGNITE-9601
> Project: Ignite
>  Issue Type: Task
>Affects Versions: 2.6
>Reporter: Andrey Kuznetsov
>Assignee: Andrey Kuznetsov
>Priority: Major
> Fix For: 2.8
>
>
> Currently, rollover WAL record gets to the next segment when being logged. 
> Moreover, the implementation allows data races, and rollover record is not 
> necessarily the first record in the next segment. We are to add an option to 
> logging facility to allow writing rollover record to the end of the current 
> segment; subsequent records should get to the next segment then.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-9601) Write rollover WAL record as the last record in current segment

2018-10-10 Thread Ignite TC Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-9601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645112#comment-16645112
 ] 

Ignite TC Bot commented on IGNITE-9601:
---

{panel:title=No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity Run 
All|http://ci.ignite.apache.org/viewLog.html?buildId=2046528buildTypeId=IgniteTests24Java8_RunAll]

> Write rollover WAL record as the last record in current segment
> ---
>
> Key: IGNITE-9601
> URL: https://issues.apache.org/jira/browse/IGNITE-9601
> Project: Ignite
>  Issue Type: Task
>Affects Versions: 2.6
>Reporter: Andrey Kuznetsov
>Assignee: Andrey Kuznetsov
>Priority: Major
> Fix For: 2.8
>
>
> Currently, rollover WAL record gets to the next segment when being logged. 
> Moreover, the implementation allows data races, and rollover record is not 
> necessarily the first record in the next segment. We are to add an option to 
> logging facility to allow writing rollover record to the end of the current 
> segment; subsequent records should get to the next segment then.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-9601) Write rollover WAL record as the last record in current segment

2018-09-20 Thread Andrey Gura (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-9601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622570#comment-16622570
 ] 

Andrey Gura commented on IGNITE-9601:
-

[~andrey-kuznetsov] I've looked at your change and have the following comments:

* {{FsyncModeFileWriteAheadLogManager}} haы different logic in compare with 
{{FileWriteAheadLogManager}}.
* Could you please add multi-threaded test for case of rollover type 
{{NEXT_SEGMENT}}? Test must generate some load from thread pool and dedicated 
thread must log record with {{NEXT_SEGMENT}} rollover type. After some time or 
amount of {{log(rec, NEXT_SEGMENT)}} calls you can check WAL for the following 
invariant: every rollover record must be the second record in the WAL segment 
(the first record is {{HEADER_RECORD}}).
* Please, fix java doc description of 
{{IgniteWriteAheadLogManager.log(WALRecord entry, RolloverType rolloverType)}} 
method. Now it is just copy version of {{log(rec)}} method.

> Write rollover WAL record as the last record in current segment
> ---
>
> Key: IGNITE-9601
> URL: https://issues.apache.org/jira/browse/IGNITE-9601
> Project: Ignite
>  Issue Type: Task
>Affects Versions: 2.6
>Reporter: Andrey Kuznetsov
>Assignee: Andrey Kuznetsov
>Priority: Major
> Fix For: 2.8
>
>
> Currently, rollover WAL record gets to the next segment when being logged. 
> Moreover, the implementation allows data races, and rollover record is not 
> necessarily the first record in the next segment. We are to add an option to 
> logging facility to allow writing rollover record to the end of the current 
> segment; subsequent records should get to the next segment then.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-9601) Write rollover WAL record as the last record in current segment

2018-09-14 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-9601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614794#comment-16614794
 ] 

ASF GitHub Bot commented on IGNITE-9601:


GitHub user andrey-kuznetsov opened a pull request:

https://github.com/apache/ignite/pull/4762

IGNITE-9601 Writing rollover record to the end of current segment.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andrey-kuznetsov/ignite ignite-9601

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/4762.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4762


commit 13a1dfea64e5974f0014930a08bcf58d239f0428
Author: Andrey Kuznetsov 
Date:   2018-09-14T12:50:47Z

IGNITE-9601 Writing rollover record to the end of current segment.




> Write rollover WAL record as the last record in current segment
> ---
>
> Key: IGNITE-9601
> URL: https://issues.apache.org/jira/browse/IGNITE-9601
> Project: Ignite
>  Issue Type: Task
>Affects Versions: 2.6
>Reporter: Andrey Kuznetsov
>Assignee: Andrey Kuznetsov
>Priority: Major
> Fix For: 2.8
>
>
> Currently, rollover WAL record gets to the next segment when being logged. 
> Moreover, the implementation does allows data races, and rollover record is 
> not necessarily the first record in the next segment. We are to add an option 
> to logging facility to allow writing rollover record to the end of the 
> current segment; subsequent records should get to the next segment then.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)