[Bug 62914] Add a hint in Thread Group UI about duration of test
https://bz.apache.org/bugzilla/show_bug.cgi?id=62914 Philippe Mouawad changed: What|Removed |Added Resolution|--- |FIXED CC||p.mouawad@ubik-ingenierie.c ||om Keywords||FixedInTrunk Status|NEW |RESOLVED --- Comment #1 from Philippe Mouawad --- Author: pmouawad Date: Thu Nov 15 22:14:15 2018 New Revision: 1846687 URL: http://svn.apache.org/viewvc?rev=1846687=rev Log: Bug 62914 - Add a hint in Thread Group UI about duration of test Bugzilla Id: 62914 Modified: jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties jmeter/trunk/src/core/org/apache/jmeter/threads/gui/ThreadGroupGui.java jmeter/trunk/xdocs/changes.xml -- You are receiving this mail because: You are the assignee for the bug.
[Bug 62914] New: Add a hint in Thread Group UI about duration of test
https://bz.apache.org/bugzilla/show_bug.cgi?id=62914 Bug ID: 62914 Summary: Add a hint in Thread Group UI about duration of test Product: JMeter Version: 5.0 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P2 Component: Main Assignee: issues@jmeter.apache.org Reporter: p.moua...@ubik-ingenierie.com Target Milestone: JMETER_5.1 I often see on stackoverflow and during my training / consulting work a misunderstanding about duration of test when user: - configures scheduler with a duration - but keeps Loop Count to a limited number The question is then, how come my test didn't last for the expected duration ? To disambiguate this, I propose to add this note in UI: If Loop Count is not -1 or Forever, duration will be min(Duration, Loop Count * iteration duration) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 62887] Customized SampleLabel is ignored and overwritten by JMeter 5.0
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887 --- Comment #17 from Philippe Mouawad --- (In reply to Alan Silva from comment #16) > (In reply to Philippe Mouawad from comment #10) > > (In reply to Alan Silva from comment #9) > > > Oh yes. You're absolutely right @Philippe Mouawad. > > > > > > The patch should haven been an if/else. My mistake. > > > > > > In any case, as I said in my previous comment: > > > > > > Calling addSubResult(SampleResult subResult, false) is good enough I > > > think. > > > > > > That's what I ended up doing and I would presume that it's what other > > > Jmeter > > > users that upgraded to 5.0 and use custom result labels did as well. > > > > Hello Alan, > > Thanks for your feedback. > > > > So In your opinion, is it ok to do nothing ? or should we do something. > > > > Of course we should add a note on this in release notes. > > > > Thanks > > Hi, sorry I stopped monitoring this ticket for a bit. > > IMO, you could leave the current implementation as is, as long as it's > mentioned in the rel notes like you suggested. > > As long as other users like myself don't have to open up the code to find > out why things changed, then I think everything is good. > > Cheers Thanks Alan for your feedback. @Artem, thanks a lot for your work on this and PR. But, IMO, we shouldn't do anything about it except add to release notes of 5.0 the Incompatible changes section. -- You are receiving this mail because: You are the assignee for the bug.
