[jira] [Commented] (KYLIN-3649) segment region count and size are not correct when using mysql as Kylin metadata storage

2018-10-29 Thread Shaofeng SHI (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668186#comment-16668186 ] Shaofeng SHI commented on KYLIN-3649: - Patch merged; Also found the StorageCleanupJob has the same

[jira] [Commented] (KYLIN-3649) segment region count and size are not correct when using mysql as Kylin metadata storage

2018-10-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668184#comment-16668184 ] ASF subversion and git services commented on KYLIN-3649: Commit

[jira] [Commented] (KYLIN-3649) segment region count and size are not correct when using mysql as Kylin metadata storage

2018-10-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668185#comment-16668185 ] ASF subversion and git services commented on KYLIN-3649: Commit

[jira] [Updated] (KYLIN-3649) segment region count and size are not correct when using mysql as Kylin metadata storage

2018-10-29 Thread Lingang Deng (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lingang Deng updated KYLIN-3649: Attachment: (was: KYLIN-3649.patch) > segment region count and size are not correct when using

[jira] [Updated] (KYLIN-3649) segment region count and size are not correct when using mysql as Kylin metadata storage

2018-10-29 Thread Lingang Deng (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lingang Deng updated KYLIN-3649: Attachment: 0001-KYLIN-3649.patch > segment region count and size are not correct when using mysql

[jira] [Commented] (KYLIN-3652) Segment auto-merge should not be triggered in some cases

2018-10-29 Thread Chao Long (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668074#comment-16668074 ] Chao Long commented on KYLIN-3652: -- I'd like to fix this issue. > Segment auto-merge should not be

[jira] [Created] (KYLIN-3652) Segment auto-merge should not be triggered in some cases

2018-10-29 Thread Shaofeng SHI (JIRA)
Shaofeng SHI created KYLIN-3652: --- Summary: Segment auto-merge should not be triggered in some cases Key: KYLIN-3652 URL: https://issues.apache.org/jira/browse/KYLIN-3652 Project: Kylin Issue

[jira] [Assigned] (KYLIN-3649) segment region count and size are not correct when using mysql as Kylin metadata storage

2018-10-29 Thread Shaofeng SHI (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI reassigned KYLIN-3649: --- Assignee: Lingang Deng > segment region count and size are not correct when using mysql as

[jira] [Commented] (KYLIN-3517) Couldn't update coprocessor on HBase 2.0

2018-10-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667995#comment-16667995 ] ASF subversion and git services commented on KYLIN-3517: Commit

[jira] [Commented] (KYLIN-2565) Support Hadoop 3.0

2018-10-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667993#comment-16667993 ] ASF subversion and git services commented on KYLIN-2565: Commit

[jira] [Commented] (KYLIN-3651) JDBCResourceStore doesn't list all resources

2018-10-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667990#comment-16667990 ] ASF subversion and git services commented on KYLIN-3651: Commit

[jira] [Commented] (KYLIN-2565) Support Hadoop 3.0

2018-10-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667992#comment-16667992 ] ASF subversion and git services commented on KYLIN-2565: Commit

[jira] [Commented] (KYLIN-3562) TS conflict when kylin update metadata in HBase

2018-10-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667989#comment-16667989 ] ASF subversion and git services commented on KYLIN-3562: Commit

[jira] [Commented] (KYLIN-3518) Coprocessor reports NPE when execute a query on HBase 2.0

2018-10-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667994#comment-16667994 ] ASF subversion and git services commented on KYLIN-3518: Commit

[jira] [Commented] (KYLIN-2565) Support Hadoop 3.0

2018-10-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667996#comment-16667996 ] ASF subversion and git services commented on KYLIN-2565: Commit

[jira] [Commented] (KYLIN-3646) Add instruction about rowkey sequence in "Advanced setting" page

2018-10-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667991#comment-16667991 ] ASF subversion and git services commented on KYLIN-3646: Commit

[jira] [Updated] (KYLIN-3646) Add instruction about rowkey sequence in "Advanced setting" page

2018-10-29 Thread Shaofeng SHI (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI updated KYLIN-3646: Fix Version/s: (was: v2.6.0) v2.5.1 v2.4.2 > Add

[jira] [Commented] (KYLIN-3646) Add instruction about rowkey sequence in "Advanced setting" page

2018-10-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667975#comment-16667975 ] ASF subversion and git services commented on KYLIN-3646: Commit

[jira] [Commented] (KYLIN-3646) Add instruction about rowkey sequence in "Advanced setting" page

2018-10-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667976#comment-16667976 ] ASF subversion and git services commented on KYLIN-3646: Commit

[jira] [Updated] (KYLIN-2899) Introduce segment level query cache

2018-10-29 Thread Zhong Yanghong (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhong Yanghong updated KYLIN-2899: -- Summary: Introduce segment level query cache (was: Enable segment level query cache) >

[jira] [Updated] (KYLIN-3649) segment region count and size are not correct when using mysql as Kylin metadata storage

2018-10-29 Thread Shaofeng SHI (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI updated KYLIN-3649: Fix Version/s: v2.5.1 > segment region count and size are not correct when using mysql as Kylin

[jira] [Updated] (KYLIN-3649) segment region count and size are not correct when using mysql as Kylin metadata storage

2018-10-29 Thread Lingang Deng (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lingang Deng updated KYLIN-3649: Attachment: KYLIN-3649.patch > segment region count and size are not correct when using mysql as

[jira] [Updated] (KYLIN-2894) Change the query cache expiration strategy by signature checking

2018-10-29 Thread Shaofeng SHI (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI updated KYLIN-2894: Fix Version/s: v2.6.0 > Change the query cache expiration strategy by signature checking >

[jira] [Updated] (KYLIN-2896) Refine query exception cache

2018-10-29 Thread Shaofeng SHI (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI updated KYLIN-2896: Fix Version/s: v2.6.0 > Refine query exception cache > > >

[jira] [Updated] (KYLIN-2897) Improve the query execution for a set of duplicate queries in a short period

2018-10-29 Thread Shaofeng SHI (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI updated KYLIN-2897: Fix Version/s: v2.6.0 > Improve the query execution for a set of duplicate queries in a short

[jira] [Updated] (KYLIN-2898) Introduce memcached as a distributed cache for queries

2018-10-29 Thread Shaofeng SHI (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI updated KYLIN-2898: Affects Version/s: (was: v2.1.0) Fix Version/s: v2.6.0 > Introduce memcached as a

[jira] [Commented] (KYLIN-2898) Introduce memcached as a distributed cache for queries

2018-10-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667052#comment-16667052 ] ASF subversion and git services commented on KYLIN-2898: Commit

[jira] [Commented] (KYLIN-2897) Improve the query execution for a set of duplicate queries in a short period

2018-10-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667046#comment-16667046 ] ASF subversion and git services commented on KYLIN-2897: Commit

[jira] [Commented] (KYLIN-2899) Enable segment level query cache

2018-10-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667050#comment-16667050 ] ASF subversion and git services commented on KYLIN-2899: Commit

[jira] [Commented] (KYLIN-2896) Refine query exception cache

2018-10-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667045#comment-16667045 ] ASF subversion and git services commented on KYLIN-2896: Commit

[jira] [Commented] (KYLIN-2898) Introduce memcached as a distributed cache for queries

2018-10-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667048#comment-16667048 ] ASF subversion and git services commented on KYLIN-2898: Commit

[jira] [Commented] (KYLIN-2898) Introduce memcached as a distributed cache for queries

2018-10-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667047#comment-16667047 ] ASF subversion and git services commented on KYLIN-2898: Commit

[jira] [Commented] (KYLIN-2894) Change the query cache expiration strategy by signature checking

2018-10-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667044#comment-16667044 ] ASF subversion and git services commented on KYLIN-2894: Commit

[jira] [Commented] (KYLIN-2898) Introduce memcached as a distributed cache for queries

2018-10-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667049#comment-16667049 ] ASF subversion and git services commented on KYLIN-2898: Commit

[jira] [Commented] (KYLIN-2723) Introduce metrics collector for query & job metrics

2018-10-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667051#comment-16667051 ] ASF subversion and git services commented on KYLIN-2723: Commit

[jira] [Commented] (KYLIN-2894) Change the query cache expiration strategy by signature checking

2018-10-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667043#comment-16667043 ] ASF subversion and git services commented on KYLIN-2894: Commit

[GitHub] shaofengshi closed pull request #318: Add document for how to become Apache Committer

2018-10-29 Thread GitBox
shaofengshi closed pull request #318: Add document for how to become Apache Committer URL: https://github.com/apache/kylin/pull/318 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[jira] [Commented] (KYLIN-3556) Interned string should not be used as lock object

2018-10-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1920#comment-1920 ] ASF GitHub Bot commented on KYLIN-3556: --- asfgit commented on issue #319: KYLIN-3556, replace

[jira] [Commented] (KYLIN-3556) Interned string should not be used as lock object

2018-10-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1919#comment-1919 ] ASF GitHub Bot commented on KYLIN-3556: --- etherge opened a new pull request #319: KYLIN-3556,

[GitHub] asfgit commented on issue #319: KYLIN-3556, replace String.intern to avoid unexpected locking collisions

2018-10-29 Thread GitBox
asfgit commented on issue #319: KYLIN-3556, replace String.intern to avoid unexpected locking collisions URL: https://github.com/apache/kylin/pull/319#issuecomment-433846327 Can one of the admins verify this patch? This is

[GitHub] etherge opened a new pull request #319: KYLIN-3556, replace String.intern to avoid unexpected locking collisions

2018-10-29 Thread GitBox
etherge opened a new pull request #319: KYLIN-3556, replace String.intern to avoid unexpected locking collisions URL: https://github.com/apache/kylin/pull/319 Locking on an interned string can cause unexpected locking collisions with other part of code. A better option is **_Interner_**

[GitHub] asfgit commented on issue #318: Add document for how to become Apache Committer

2018-10-29 Thread GitBox
asfgit commented on issue #318: Add document for how to become Apache Committer URL: https://github.com/apache/kylin/pull/318#issuecomment-433844365 Can one of the admins verify this patch? This is an automated message from

[GitHub] GinaZhai opened a new pull request #318: Add document for how to become Apache Committer

2018-10-29 Thread GitBox
GinaZhai opened a new pull request #318: Add document for how to become Apache Committer URL: https://github.com/apache/kylin/pull/318 This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Resolved] (KYLIN-3599) Bulk Add Measures

2018-10-29 Thread Shaofeng SHI (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI resolved KYLIN-3599. - Resolution: Fixed > Bulk Add Measures > - > > Key: KYLIN-3599 >

[jira] [Updated] (KYLIN-3562) TS conflict when kylin update metadata in HBase

2018-10-29 Thread Shaofeng SHI (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI updated KYLIN-3562: Fix Version/s: (was: Future) > TS conflict when kylin update metadata in HBase >

[jira] [Resolved] (KYLIN-3526) No check for hybrid name with special character

2018-10-29 Thread Shaofeng SHI (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI resolved KYLIN-3526. - Resolution: Fixed > No check for hybrid name with special character >

[jira] [Resolved] (KYLIN-3527) Hybrid couldn't save when there is only 1 cube

2018-10-29 Thread Shaofeng SHI (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI resolved KYLIN-3527. - Resolution: Fixed > Hybrid couldn't save when there is only 1 cube >

[jira] [Resolved] (KYLIN-3528) No details page for hybrid

2018-10-29 Thread Shaofeng SHI (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI resolved KYLIN-3528. - Resolution: Fixed > No details page for hybrid > -- > >

[jira] [Resolved] (KYLIN-3629) NullPointException throws when use preparedStatement cache in some case

2018-10-29 Thread Shaofeng SHI (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI resolved KYLIN-3629. - Resolution: Fixed > NullPointException throws when use preparedStatement cache in some case >

[jira] [Updated] (KYLIN-3637) Union All not working with count()

2018-10-29 Thread Shaofeng SHI (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI updated KYLIN-3637: Fix Version/s: (was: v2.5.1) > Union All not working with count() >

[jira] [Closed] (KYLIN-3637) Union All not working with count()

2018-10-29 Thread Shaofeng SHI (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI closed KYLIN-3637. --- Resolution: Duplicate > Union All not working with count() > -- > >

[jira] [Resolved] (KYLIN-3635) Percentile calculation on Spark engine is wrong

2018-10-29 Thread Shaofeng SHI (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI resolved KYLIN-3635. - Resolution: Fixed > Percentile calculation on Spark engine is wrong >

[jira] [Resolved] (KYLIN-3651) JDBCResourceStore doesn't list all resources

2018-10-29 Thread Shaofeng SHI (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI resolved KYLIN-3651. - Resolution: Fixed > JDBCResourceStore doesn't list all resources >

[jira] [Comment Edited] (KYLIN-3562) TS conflict when kylin update metadata in HBase

2018-10-29 Thread Jiatao Tao (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1824#comment-1824 ] Jiatao Tao edited comment on KYLIN-3562 at 10/29/18 7:33 AM: - We cannot

[jira] [Commented] (KYLIN-3562) TS conflict when kylin update metadata in HBase

2018-10-29 Thread Jiatao Tao (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1824#comment-1824 ] Jiatao Tao commented on KYLIN-3562: --- We can not remove the logic that updates user when user login in

[jira] [Commented] (KYLIN-3562) TS conflict when kylin update metadata in HBase

2018-10-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1817#comment-1817 ] ASF GitHub Bot commented on KYLIN-3562: --- shaofengshi closed pull request #317: KYLIN-3562,

[jira] [Commented] (KYLIN-3562) TS conflict when kylin update metadata in HBase

2018-10-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1818#comment-1818 ] ASF subversion and git services commented on KYLIN-3562: Commit

[GitHub] shaofengshi closed pull request #317: KYLIN-3562, optimization the logic that updating the user when user logged in.

2018-10-29 Thread GitBox
shaofengshi closed pull request #317: KYLIN-3562, optimization the logic that updating the user when user logged in. URL: https://github.com/apache/kylin/pull/317 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[jira] [Commented] (KYLIN-3635) Percentile calculation on Spark engine is wrong

2018-10-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1785#comment-1785 ] ASF subversion and git services commented on KYLIN-3635: Commit

[jira] [Commented] (KYLIN-3635) Percentile calculation on Spark engine is wrong

2018-10-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1784#comment-1784 ] ASF GitHub Bot commented on KYLIN-3635: --- shaofengshi closed pull request #316: KYLIN-3635, make a

[GitHub] shaofengshi closed pull request #316: KYLIN-3635, make a stronger constraint about implementing method reset().

2018-10-29 Thread GitBox
shaofengshi closed pull request #316: KYLIN-3635, make a stronger constraint about implementing method reset(). URL: https://github.com/apache/kylin/pull/316 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of