[jira] [Updated] (KYLIN-3385) Error when have sum(1) measure
[
https://issues.apache.org/jira/browse/KYLIN-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shaofeng SHI updated KYLIN-3385:
Summary: Error when have sum(1) measure (was: when the cube contain sum(1)
measure, tables in "Query" page cannot be load)
> Error when have sum(1) measure
> --
>
> Key: KYLIN-3385
> URL: https://issues.apache.org/jira/browse/KYLIN-3385
> Project: Kylin
> Issue Type: Bug
>Reporter: Yifei Wu
>Assignee: Yifei Wu
>Priority: Major
> Fix For: v2.5.0
>
> Attachments: 0001-KYLIN-3385-fix-sum-1.patch
>
>
> In the current version, the sum(1), equals with count(*) actually, is
> allowed to add to cube Measures.
> However, if you add, it will cause some errors, such as tables in "Query"
> page cannot be load and the query like this cannot run.
> {code:java}
> select sum(1) from kylin_fact
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KYLIN-3385) when the cube contain sum(1) measure, tables in "Query" page cannot be load
[
https://issues.apache.org/jira/browse/KYLIN-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569727#comment-16569727
]
ASF subversion and git services commented on KYLIN-3385:
Commit 23ff19d4e4c095742f4efc6ae5472000193f5c14 in kylin's branch
refs/heads/master from yifei.wu
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=23ff19d ]
KYLIN-3385 fix sum1 error
> when the cube contain sum(1) measure, tables in "Query" page cannot be load
> ---
>
> Key: KYLIN-3385
> URL: https://issues.apache.org/jira/browse/KYLIN-3385
> Project: Kylin
> Issue Type: Bug
>Reporter: Yifei Wu
>Assignee: Yifei Wu
>Priority: Major
> Fix For: v2.5.0
>
> Attachments: 0001-KYLIN-3385-fix-sum-1.patch
>
>
> In the current version, the sum(1), equals with count(*) actually, is
> allowed to add to cube Measures.
> However, if you add, it will cause some errors, such as tables in "Query"
> page cannot be load and the query like this cannot run.
> {code:java}
> select sum(1) from kylin_fact
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KYLIN-3385) when the cube contain sum(1) measure, tables in "Query" page cannot be load
[
https://issues.apache.org/jira/browse/KYLIN-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569726#comment-16569726
]
ASF GitHub Bot commented on KYLIN-3385:
---
shaofengshi closed pull request #184: KYLIN-3385 fix sum1 error
URL: https://github.com/apache/kylin/pull/184
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/core-metadata/src/main/java/org/apache/kylin/metadata/model/FunctionDesc.java
b/core-metadata/src/main/java/org/apache/kylin/metadata/model/FunctionDesc.java
index d93ada403f..c34d06c595 100644
---
a/core-metadata/src/main/java/org/apache/kylin/metadata/model/FunctionDesc.java
+++
b/core-metadata/src/main/java/org/apache/kylin/metadata/model/FunctionDesc.java
@@ -158,7 +158,7 @@ public DataType getRewriteFieldType() {
if (isMax() || isMin()) {
return parameter.getColRefs().get(0).getType();
} else if (isSum()) {
-return parameter.getColRefs().get(0).getType();
+return parameter.isColumnType() ?
parameter.getColRefs().get(0).getType() : DataType.getType("bigint");
} else if (isCount()) {
return DataType.getType("bigint");
} else {
@@ -249,7 +249,7 @@ public String getExpression() {
public void setExpression(String expression) {
this.expression = expression;
}
-
+
public ParameterDesc getParameter() {
return parameter;
}
diff --git
a/core-metadata/src/test/java/org/apache/kylin/metadata/model/FunctionDescTest.java
b/core-metadata/src/test/java/org/apache/kylin/metadata/model/FunctionDescTest.java
new file mode 100644
index 00..5676d33731
--- /dev/null
+++
b/core-metadata/src/test/java/org/apache/kylin/metadata/model/FunctionDescTest.java
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kylin.metadata.model;
+
+import static org.junit.Assert.assertEquals;
+
+import org.apache.kylin.common.KylinConfig;
+import org.apache.kylin.common.util.LocalFileMetadataTestCase;
+import org.apache.kylin.metadata.datatype.DataType;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+
+public class FunctionDescTest {
+
+@Before
+public void setUp() throws Exception {
+System.setProperty(KylinConfig.KYLIN_CONF,
LocalFileMetadataTestCase.LOCALMETA_TEST_DATA);
+}
+
+@Test
+public void getRewriteFieldType() {
+TblColRef mockColOfDoubleType =
TblColRef.mockup(TableDesc.mockup("mock_table"), 0, "price", "double", "");
+TblColRef mockColOfDecimalType =
TblColRef.mockup(TableDesc.mockup("mock_table"), 1, "price", "decimal", "");
+
+FunctionDesc function = FunctionDesc.newInstance("SUM",
ParameterDesc.newInstance("1"), "bigint");
+assertEquals(DataType.getType("bigint"),
function.getRewriteFieldType());
+function = FunctionDesc.newInstance("COUNT",
ParameterDesc.newInstance("1"), "bigint");
+assertEquals(DataType.getType("bigint"),
function.getRewriteFieldType());
+function = FunctionDesc.newInstance("SUM",
ParameterDesc.newInstance(mockColOfDoubleType), "double");
+assertEquals(DataType.getType("double"),
function.getRewriteFieldType());
+function = FunctionDesc.newInstance("MAX",
ParameterDesc.newInstance(mockColOfDecimalType), "double");
+assertEquals(DataType.getType("decimal"),
function.getRewriteFieldType());
+function = FunctionDesc.newInstance("MIN",
ParameterDesc.newInstance(mockColOfDecimalType), "double");
+assertEquals(DataType.getType("decimal"),
function.getRewriteFieldType());
+function = FunctionDesc.newInstance(FunctionDesc.FUNC_PERCENTILE,
+ParameterDesc.newInstance(mockColOfDecimalType), "double");
+assertEquals(DataType.ANY, function.getRewriteFieldType());
+}
+
+@After
+public void tearDown() throws Exception {
+
[jira] [Commented] (KYLIN-3379) timestampadd test coverage is not enough
[ https://issues.apache.org/jira/browse/KYLIN-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569707#comment-16569707 ] ASF GitHub Bot commented on KYLIN-3379: --- tttMelody commented on issue #188: KYLIN-3379 fix ts add bug and enhance the test coverage of timestamp add. URL: https://github.com/apache/kylin/pull/188#issuecomment-410583317 Hi @shaofengshi, CI passed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > timestampadd test coverage is not enough > > > Key: KYLIN-3379 > URL: https://issues.apache.org/jira/browse/KYLIN-3379 > Project: Kylin > Issue Type: Bug >Affects Versions: v2.3.1 >Reporter: hongbin ma >Assignee: hongbin ma >Priority: Major > > complex cases like > timestampadd(MONTH,23,test_kylin_fact.cal_dt) or > timestampadd(MONTH,-23,test_kylin_fact.cal_dt) is not covered. > > And my tests shows this kind of queries will fail IT. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3480) change the conformance of calcite from default to lenient
[ https://issues.apache.org/jira/browse/KYLIN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569689#comment-16569689 ] Shaofeng SHI commented on KYLIN-3480: - Hi Yanghong, Will this change has other side-effect? Can we keep DEFAULT as the default conformance? > change the conformance of calcite from default to lenient > - > > Key: KYLIN-3480 > URL: https://issues.apache.org/jira/browse/KYLIN-3480 > Project: Kylin > Issue Type: Improvement >Reporter: Zhong Yanghong >Assignee: Zhong Yanghong >Priority: Major > Fix For: v2.5.0 > > Attachments: APACHE-KYLIN-3480.patch > > > By this change, Kylin can support GroupByOrdinal & SortByOrdinal > * group by 1,2,... > * order by 1,2,... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3385) when the cube contain sum(1) measure, tables in "Query" page cannot be load
[
https://issues.apache.org/jira/browse/KYLIN-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569683#comment-16569683
]
ASF GitHub Bot commented on KYLIN-3385:
---
shaofengshi commented on issue #184: KYLIN-3385 fix sum1 error
URL: https://github.com/apache/kylin/pull/184#issuecomment-410576923
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.5.1:compile (default-compile)
on project kylin-core-cube: Compilation failure: Compilation failure:
[ERROR]
/Users/shaofeng.shi/workspace/kylin-15/core-cube/src/main/java/org/apache/kylin/cube/model/validation/rule/FunctionRule.java:[104,31]
错误: 程序包TopNMeasureType不存在
[ERROR]
/Users/shaofeng.shi/workspace/kylin-15/core-cube/src/main/java/org/apache/kylin/cube/model/validation/rule/FunctionRule.java:[111,45]
错误: 找不到符号
[ERROR] 符号: 变量 Lists
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> when the cube contain sum(1) measure, tables in "Query" page cannot be load
> ---
>
> Key: KYLIN-3385
> URL: https://issues.apache.org/jira/browse/KYLIN-3385
> Project: Kylin
> Issue Type: Bug
>Reporter: Yifei Wu
>Assignee: Yifei Wu
>Priority: Major
> Fix For: v2.5.0
>
> Attachments: 0001-KYLIN-3385-fix-sum-1.patch
>
>
> In the current version, the sum(1), equals with count(*) actually, is
> allowed to add to cube Measures.
> However, if you add, it will cause some errors, such as tables in "Query"
> page cannot be load and the query like this cannot run.
> {code:java}
> select sum(1) from kylin_fact
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KYLIN-3379) timestampadd test coverage is not enough
[ https://issues.apache.org/jira/browse/KYLIN-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569632#comment-16569632 ] ASF GitHub Bot commented on KYLIN-3379: --- tttMelody commented on issue #188: KYLIN-3379 fix ts add bug and enhance the test coverage of timestamp add. URL: https://github.com/apache/kylin/pull/188#issuecomment-410564680 @shaofengshi Thanks shaofeng, something wrong with timestamp add, I pushed the fix and retriggered CI. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > timestampadd test coverage is not enough > > > Key: KYLIN-3379 > URL: https://issues.apache.org/jira/browse/KYLIN-3379 > Project: Kylin > Issue Type: Bug >Affects Versions: v2.3.1 >Reporter: hongbin ma >Assignee: hongbin ma >Priority: Major > > complex cases like > timestampadd(MONTH,23,test_kylin_fact.cal_dt) or > timestampadd(MONTH,-23,test_kylin_fact.cal_dt) is not covered. > > And my tests shows this kind of queries will fail IT. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3483) Imprecise comparison between double and integer division
[
https://issues.apache.org/jira/browse/KYLIN-3483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shaofeng SHI updated KYLIN-3483:
Fix Version/s: v2.5.0
> Imprecise comparison between double and integer division
>
>
> Key: KYLIN-3483
> URL: https://issues.apache.org/jira/browse/KYLIN-3483
> Project: Kylin
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: jiatao.tao
>Priority: Minor
> Fix For: v2.5.0
>
>
> In HLLCSerializer :
> {code}
> || averageNumOfElementsInCounter < (m - 5) / (1 +
> registerIndexSize)) {
> {code}
> The integer division on the right side of < would lose remainder, or
> fractional part of the quotient.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KYLIN-3379) timestampadd test coverage is not enough
[ https://issues.apache.org/jira/browse/KYLIN-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569622#comment-16569622 ] ASF GitHub Bot commented on KYLIN-3379: --- shaofengshi commented on issue #188: KYLIN-3379 enhance the test coverage of timestamp add. URL: https://github.com/apache/kylin/pull/188#issuecomment-410561246 Hi Jiatao, the CI is failed, you will update the PR right? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > timestampadd test coverage is not enough > > > Key: KYLIN-3379 > URL: https://issues.apache.org/jira/browse/KYLIN-3379 > Project: Kylin > Issue Type: Bug >Affects Versions: v2.3.1 >Reporter: hongbin ma >Assignee: hongbin ma >Priority: Major > > complex cases like > timestampadd(MONTH,23,test_kylin_fact.cal_dt) or > timestampadd(MONTH,-23,test_kylin_fact.cal_dt) is not covered. > > And my tests shows this kind of queries will fail IT. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3417) Consider replacing ReentrantReadWriteLock with StampedLock
[
https://issues.apache.org/jira/browse/KYLIN-3417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569620#comment-16569620
]
Shaofeng SHI commented on KYLIN-3417:
-
Kylin 2.5 will require Java 8; I remember Long Chao intestigated this; @Chao,
please share your findings if any.
> Consider replacing ReentrantReadWriteLock with StampedLock
> --
>
> Key: KYLIN-3417
> URL: https://issues.apache.org/jira/browse/KYLIN-3417
> Project: Kylin
> Issue Type: Improvement
>Reporter: Ted Yu
>Assignee: jiatao.tao
>Priority: Major
> Fix For: v2.5.0
>
>
> ReentrantReadWriteLock's are only the right solution when there is long hold
> time due to expensive I/O.
> It is expensive for readers.
> We should see if the lighter {{StampedLock}} can be used instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KYLIN-3379) timestampadd test coverage is not enough
[ https://issues.apache.org/jira/browse/KYLIN-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569496#comment-16569496 ] ASF GitHub Bot commented on KYLIN-3379: --- asfgit commented on issue #188: KYLIN-3379 enhance the test coverage of timestamp add. URL: https://github.com/apache/kylin/pull/188#issuecomment-410526957 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > timestampadd test coverage is not enough > > > Key: KYLIN-3379 > URL: https://issues.apache.org/jira/browse/KYLIN-3379 > Project: Kylin > Issue Type: Bug >Affects Versions: v2.3.1 >Reporter: hongbin ma >Assignee: hongbin ma >Priority: Major > > complex cases like > timestampadd(MONTH,23,test_kylin_fact.cal_dt) or > timestampadd(MONTH,-23,test_kylin_fact.cal_dt) is not covered. > > And my tests shows this kind of queries will fail IT. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3379) timestampadd test coverage is not enough
[ https://issues.apache.org/jira/browse/KYLIN-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569495#comment-16569495 ] ASF GitHub Bot commented on KYLIN-3379: --- tttMelody opened a new pull request #188: KYLIN-3379 enhance the test coverage of timestamp add. URL: https://github.com/apache/kylin/pull/188 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > timestampadd test coverage is not enough > > > Key: KYLIN-3379 > URL: https://issues.apache.org/jira/browse/KYLIN-3379 > Project: Kylin > Issue Type: Bug >Affects Versions: v2.3.1 >Reporter: hongbin ma >Assignee: hongbin ma >Priority: Major > > complex cases like > timestampadd(MONTH,23,test_kylin_fact.cal_dt) or > timestampadd(MONTH,-23,test_kylin_fact.cal_dt) is not covered. > > And my tests shows this kind of queries will fail IT. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3417) Consider replacing ReentrantReadWriteLock with StampedLock
[
https://issues.apache.org/jira/browse/KYLIN-3417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569436#comment-16569436
]
jiatao.tao commented on KYLIN-3417:
---
Hi [~yuzhih...@gmail.com] , nowadays, kylin's minimum java version requirement
is sitll 1.7, when it comes to 1.8, we can replace ReentrantReadWriteLock in
class AutoReadWriteLock with StampedLock.
> Consider replacing ReentrantReadWriteLock with StampedLock
> --
>
> Key: KYLIN-3417
> URL: https://issues.apache.org/jira/browse/KYLIN-3417
> Project: Kylin
> Issue Type: Improvement
>Reporter: Ted Yu
>Assignee: jiatao.tao
>Priority: Major
> Fix For: v2.5.0
>
>
> ReentrantReadWriteLock's are only the right solution when there is long hold
> time due to expensive I/O.
> It is expensive for readers.
> We should see if the lighter {{StampedLock}} can be used instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (KYLIN-3483) Imprecise comparison between double and integer division
[
https://issues.apache.org/jira/browse/KYLIN-3483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569435#comment-16569435
]
jiatao.tao edited comment on KYLIN-3483 at 8/5/18 11:01 AM:
Thanks Ted Yu! Here's the commit https://github.com/apache/kylin/pull/187/files.
was (Author: aron.tao):
Thanks Ted Yu! here's the https://github.com/apache/kylin/pull/187/files.
> Imprecise comparison between double and integer division
>
>
> Key: KYLIN-3483
> URL: https://issues.apache.org/jira/browse/KYLIN-3483
> Project: Kylin
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: jiatao.tao
>Priority: Minor
>
> In HLLCSerializer :
> {code}
> || averageNumOfElementsInCounter < (m - 5) / (1 +
> registerIndexSize)) {
> {code}
> The integer division on the right side of < would lose remainder, or
> fractional part of the quotient.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KYLIN-3483) Imprecise comparison between double and integer division
[
https://issues.apache.org/jira/browse/KYLIN-3483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569435#comment-16569435
]
jiatao.tao commented on KYLIN-3483:
---
Thanks Ted Yu! here's the https://github.com/apache/kylin/pull/187/files.
> Imprecise comparison between double and integer division
>
>
> Key: KYLIN-3483
> URL: https://issues.apache.org/jira/browse/KYLIN-3483
> Project: Kylin
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: jiatao.tao
>Priority: Minor
>
> In HLLCSerializer :
> {code}
> || averageNumOfElementsInCounter < (m - 5) / (1 +
> registerIndexSize)) {
> {code}
> The integer division on the right side of < would lose remainder, or
> fractional part of the quotient.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KYLIN-3483) Imprecise comparison between double and integer division
[
https://issues.apache.org/jira/browse/KYLIN-3483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569429#comment-16569429
]
ASF GitHub Bot commented on KYLIN-3483:
---
asfgit commented on issue #187: KYLIN-3483, fix the loss of precision in
HLLCSerializer.
URL: https://github.com/apache/kylin/pull/187#issuecomment-410511344
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Imprecise comparison between double and integer division
>
>
> Key: KYLIN-3483
> URL: https://issues.apache.org/jira/browse/KYLIN-3483
> Project: Kylin
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: jiatao.tao
>Priority: Minor
>
> In HLLCSerializer :
> {code}
> || averageNumOfElementsInCounter < (m - 5) / (1 +
> registerIndexSize)) {
> {code}
> The integer division on the right side of < would lose remainder, or
> fractional part of the quotient.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KYLIN-3483) Imprecise comparison between double and integer division
[
https://issues.apache.org/jira/browse/KYLIN-3483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569428#comment-16569428
]
ASF GitHub Bot commented on KYLIN-3483:
---
tttMelody opened a new pull request #187: KYLIN-3483, fix the loss of precision
in HLLCSerializer.
URL: https://github.com/apache/kylin/pull/187
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Imprecise comparison between double and integer division
>
>
> Key: KYLIN-3483
> URL: https://issues.apache.org/jira/browse/KYLIN-3483
> Project: Kylin
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: jiatao.tao
>Priority: Minor
>
> In HLLCSerializer :
> {code}
> || averageNumOfElementsInCounter < (m - 5) / (1 +
> registerIndexSize)) {
> {code}
> The integer division on the right side of < would lose remainder, or
> fractional part of the quotient.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (KYLIN-3482) Unclosed SetAndUnsetThreadLocalConfig in SparkCubingByLayer
[
https://issues.apache.org/jira/browse/KYLIN-3482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jiatao.tao reassigned KYLIN-3482:
-
Assignee: jiatao.tao
> Unclosed SetAndUnsetThreadLocalConfig in SparkCubingByLayer
> ---
>
> Key: KYLIN-3482
> URL: https://issues.apache.org/jira/browse/KYLIN-3482
> Project: Kylin
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: jiatao.tao
>Priority: Minor
>
> Here is related code:
> {code}
> KylinConfig kylinConfig =
> AbstractHadoopJob.loadKylinConfigFromHdfs(sConf, metaUrl);
>
> KylinConfig.setAndUnsetThreadLocalConfig(kylinConfig);
> {code}
> The return value from setAndUnsetThreadLocalConfig should be closed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (KYLIN-3483) Imprecise comparison between double and integer division
[
https://issues.apache.org/jira/browse/KYLIN-3483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jiatao.tao reassigned KYLIN-3483:
-
Assignee: jiatao.tao
> Imprecise comparison between double and integer division
>
>
> Key: KYLIN-3483
> URL: https://issues.apache.org/jira/browse/KYLIN-3483
> Project: Kylin
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: jiatao.tao
>Priority: Minor
>
> In HLLCSerializer :
> {code}
> || averageNumOfElementsInCounter < (m - 5) / (1 +
> registerIndexSize)) {
> {code}
> The integer division on the right side of < would lose remainder, or
> fractional part of the quotient.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
