[jira] [Commented] (KYLIN-4385) KYLIN system cube failing to update table when run on EMR with S3 as storage and EMRFS
[ https://issues.apache.org/jira/browse/KYLIN-4385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17111773#comment-17111773 ] Sonu Singh commented on KYLIN-4385: --- Hi [~raghu_medapati] Thank you for the update. > KYLIN system cube failing to update table when run on EMR with S3 as storage > and EMRFS > -- > > Key: KYLIN-4385 > URL: https://issues.apache.org/jira/browse/KYLIN-4385 > Project: Kylin > Issue Type: Bug >Reporter: raghu ram reddy >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: v3.1.0, v3.0.2, v2.6.6 > > > > 2020-02-24T15:35:46,548 INFO [metrics-blocking-reservoir-scheduler-0] > org.apache.kylin.metrics.lib.impl.hive.HiveReservoirReporter - Try to write > 113 records2020-02-24T15:35:46,566 INFO > [metrics-blocking-reservoir-scheduler-0] org.apache.hadoop.hive.conf.HiveConf > - Found configuration file > file:/etc/hive/conf.dist/hive-site.xml2020-02-24T15:35:47,097 INFO > [metrics-blocking-reservoir-scheduler-0] hive.metastore - Trying to connect > to metastore with URI > thrift://ip-1-1-1-1.ec2.internal:90832020-02-24T15:35:47,216 INFO > [metrics-blocking-reservoir-scheduler-0] hive.metastore - Opened a connection > to metastore, current connections: 12020-02-24T15:35:47,216 INFO > [metrics-blocking-reservoir-scheduler-0] hive.metastore - Connected to > metastore.2020-02-24T15:35:47,433 INFO > [metrics-blocking-reservoir-scheduler-0] hive.metastore - Closed a connection > to metastore, current connections: 02020-02-24T15:35:47,824 INFO > [metrics-blocking-reservoir-scheduler-0] > org.apache.kylin.metrics.lib.impl.hive.HiveProducer - Try to use new > partition content path: > hdfs://ip-1-1-2-1.ec2.internal:8020/tmp/system_cube/hive_metrics_query_cube_qa/kday_date=2020-02-24/ip-1-1-1-1-1582558547056-part- > for metric: METRICS_QUERY_CUBE_QA2020-02-24T15:35:47,959 INFO > [metrics-blocking-reservoir-scheduler-0] > org.apache.kylin.metrics.lib.impl.hive.HiveProducer - Success to write 37 > metrics (METRICS_QUERY_CUBE_QA) to file > hdfs://ip-1-1-2-1.ec2.internal:8020/tmp/system_cube/hive_metrics_query_cube_qa/kday_date=2020-02-24/ip-1-1-1-1-1582558547056-part-2020-02-24T15:35:48,275 > INFO [metrics-blocking-reservoir-scheduler-0] hive.metastore - Trying to > connect to metastore with URI > thrift://ip-1-1-2-1.ec2.internal:90832020-02-24T15:35:48,288 INFO > [metrics-blocking-reservoir-scheduler-0] hive.metastore - Opened a connection > to metastore, current connections: 12020-02-24T15:35:48,289 INFO > [metrics-blocking-reservoir-scheduler-0] hive.metastore - Connected to > metastore.2020-02-24T15:35:48,711 INFO > [metrics-blocking-reservoir-scheduler-0] hive.metastore - Closed a connection > to metastore, current connections: 02020-02-24T15:35:50,223 INFO > [metrics-blocking-reservoir-scheduler-0] > org.apache.hadoop.hive.ql.session.SessionState - Created HDFS directory: > /tmp/hive/kylin/3f98a154-e471-40fc-9829-4c4283266d462020-02-24T15:35:50,224 > INFO [metrics-blocking-reservoir-scheduler-0] > org.apache.hadoop.hive.ql.session.SessionState - Created local directory: > /usr/local/kylin/tomcat/temp/kylin/3f98a154-e471-40fc-9829-4c4283266d462020-02-24T15:35:50,232 > INFO [metrics-blocking-reservoir-scheduler-0] > org.apache.hadoop.hive.ql.session.SessionState - Created HDFS directory: > /tmp/hive/kylin/3f98a154-e471-40fc-9829-4c4283266d46/_tmp_space.db2020-02-24T15:35:50,291 > INFO [metrics-blocking-reservoir-scheduler-0] > org.apache.hadoop.hive.ql.exec.tez.TezSessionState - User of session id > 3f98a154-e471-40fc-9829-4c4283266d46 is kylin2020-02-24T15:35:50,389 INFO > [metrics-blocking-reservoir-scheduler-0] > org.apache.hadoop.hive.ql.exec.tez.DagUtils - Jar dir is null / directory > doesn't exist. Choosing HIVE_INSTALL_DIR - > /user/kylin/.hiveJars2020-02-24T15:35:50,933 INFO > [metrics-blocking-reservoir-scheduler-0] > org.apache.hadoop.hive.ql.exec.tez.DagUtils - Resource modification time: > 1581024148854 for > hdfs://ip-1-1-2-1.ec2.internal:8020/user/kylin/.hiveJars/hive-exec-2.3.6-amzn-0-9f4c4d2a9ab8330bfec9b3ce23e40355288cc5c08a20165b20aca86b2b6c2c95.jar2020-02-24T15:35:51,066 > INFO [metrics-blocking-reservoir-scheduler-0] > org.apache.hadoop.hive.ql.security.authorization.plugin.sqlstd.SQLStdHiveAccessController > - Created SQLStdHiveAccessController for session context : > HiveAuthzSessionContext [sessionString=3f98a154-e471-40fc-9829-4c4283266d46, > clientType=HIVECLI]2020-02-24T15:35:51,073 WARN > [metrics-blocking-reservoir-scheduler-0] > org.apache.hadoop.hive.ql.session.SessionState - METASTORE_FILTER_HOOK will > be ignored, since hive.security.authorization.manager is set to instance of > HiveAuthorizerFactory.2020-02-24T15:35:51,646 INFO >
[jira] [Commented] (KYLIN-4385) KYLIN system cube failing to update table when run on EMR with S3 as storage and EMRFS
[ https://issues.apache.org/jira/browse/KYLIN-4385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17111769#comment-17111769 ] raghu ram reddy commented on KYLIN-4385: [~sonuSINGH] looks like it resolved now in the latest release, try it out. > KYLIN system cube failing to update table when run on EMR with S3 as storage > and EMRFS > -- > > Key: KYLIN-4385 > URL: https://issues.apache.org/jira/browse/KYLIN-4385 > Project: Kylin > Issue Type: Bug >Reporter: raghu ram reddy >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: v3.1.0, v3.0.2, v2.6.6 > > > > 2020-02-24T15:35:46,548 INFO [metrics-blocking-reservoir-scheduler-0] > org.apache.kylin.metrics.lib.impl.hive.HiveReservoirReporter - Try to write > 113 records2020-02-24T15:35:46,566 INFO > [metrics-blocking-reservoir-scheduler-0] org.apache.hadoop.hive.conf.HiveConf > - Found configuration file > file:/etc/hive/conf.dist/hive-site.xml2020-02-24T15:35:47,097 INFO > [metrics-blocking-reservoir-scheduler-0] hive.metastore - Trying to connect > to metastore with URI > thrift://ip-1-1-1-1.ec2.internal:90832020-02-24T15:35:47,216 INFO > [metrics-blocking-reservoir-scheduler-0] hive.metastore - Opened a connection > to metastore, current connections: 12020-02-24T15:35:47,216 INFO > [metrics-blocking-reservoir-scheduler-0] hive.metastore - Connected to > metastore.2020-02-24T15:35:47,433 INFO > [metrics-blocking-reservoir-scheduler-0] hive.metastore - Closed a connection > to metastore, current connections: 02020-02-24T15:35:47,824 INFO > [metrics-blocking-reservoir-scheduler-0] > org.apache.kylin.metrics.lib.impl.hive.HiveProducer - Try to use new > partition content path: > hdfs://ip-1-1-2-1.ec2.internal:8020/tmp/system_cube/hive_metrics_query_cube_qa/kday_date=2020-02-24/ip-1-1-1-1-1582558547056-part- > for metric: METRICS_QUERY_CUBE_QA2020-02-24T15:35:47,959 INFO > [metrics-blocking-reservoir-scheduler-0] > org.apache.kylin.metrics.lib.impl.hive.HiveProducer - Success to write 37 > metrics (METRICS_QUERY_CUBE_QA) to file > hdfs://ip-1-1-2-1.ec2.internal:8020/tmp/system_cube/hive_metrics_query_cube_qa/kday_date=2020-02-24/ip-1-1-1-1-1582558547056-part-2020-02-24T15:35:48,275 > INFO [metrics-blocking-reservoir-scheduler-0] hive.metastore - Trying to > connect to metastore with URI > thrift://ip-1-1-2-1.ec2.internal:90832020-02-24T15:35:48,288 INFO > [metrics-blocking-reservoir-scheduler-0] hive.metastore - Opened a connection > to metastore, current connections: 12020-02-24T15:35:48,289 INFO > [metrics-blocking-reservoir-scheduler-0] hive.metastore - Connected to > metastore.2020-02-24T15:35:48,711 INFO > [metrics-blocking-reservoir-scheduler-0] hive.metastore - Closed a connection > to metastore, current connections: 02020-02-24T15:35:50,223 INFO > [metrics-blocking-reservoir-scheduler-0] > org.apache.hadoop.hive.ql.session.SessionState - Created HDFS directory: > /tmp/hive/kylin/3f98a154-e471-40fc-9829-4c4283266d462020-02-24T15:35:50,224 > INFO [metrics-blocking-reservoir-scheduler-0] > org.apache.hadoop.hive.ql.session.SessionState - Created local directory: > /usr/local/kylin/tomcat/temp/kylin/3f98a154-e471-40fc-9829-4c4283266d462020-02-24T15:35:50,232 > INFO [metrics-blocking-reservoir-scheduler-0] > org.apache.hadoop.hive.ql.session.SessionState - Created HDFS directory: > /tmp/hive/kylin/3f98a154-e471-40fc-9829-4c4283266d46/_tmp_space.db2020-02-24T15:35:50,291 > INFO [metrics-blocking-reservoir-scheduler-0] > org.apache.hadoop.hive.ql.exec.tez.TezSessionState - User of session id > 3f98a154-e471-40fc-9829-4c4283266d46 is kylin2020-02-24T15:35:50,389 INFO > [metrics-blocking-reservoir-scheduler-0] > org.apache.hadoop.hive.ql.exec.tez.DagUtils - Jar dir is null / directory > doesn't exist. Choosing HIVE_INSTALL_DIR - > /user/kylin/.hiveJars2020-02-24T15:35:50,933 INFO > [metrics-blocking-reservoir-scheduler-0] > org.apache.hadoop.hive.ql.exec.tez.DagUtils - Resource modification time: > 1581024148854 for > hdfs://ip-1-1-2-1.ec2.internal:8020/user/kylin/.hiveJars/hive-exec-2.3.6-amzn-0-9f4c4d2a9ab8330bfec9b3ce23e40355288cc5c08a20165b20aca86b2b6c2c95.jar2020-02-24T15:35:51,066 > INFO [metrics-blocking-reservoir-scheduler-0] > org.apache.hadoop.hive.ql.security.authorization.plugin.sqlstd.SQLStdHiveAccessController > - Created SQLStdHiveAccessController for session context : > HiveAuthzSessionContext [sessionString=3f98a154-e471-40fc-9829-4c4283266d46, > clientType=HIVECLI]2020-02-24T15:35:51,073 WARN > [metrics-blocking-reservoir-scheduler-0] > org.apache.hadoop.hive.ql.session.SessionState - METASTORE_FILTER_HOOK will > be ignored, since hive.security.authorization.manager is set to instance of >
[GitHub] [kylin] codecov-commenter commented on pull request #1217: Add considerations for hbase-shad-client -*.jar
codecov-commenter commented on pull request #1217: URL: https://github.com/apache/kylin/pull/1217#issuecomment-631235862 # [Codecov](https://codecov.io/gh/apache/kylin/pull/1217?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`3.0.x-hadoop3.1@4490cc2`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/kylin/pull/1217?src=pr=tree) ```diff @@Coverage Diff @@ ## 3.0.x-hadoop3.1#1217 +/- ## == Coverage ? 24.59% Complexity ? 6141 == Files ? 1421 Lines ?86532 Branches ?12137 == Hits ?21286 Misses ?63211 Partials ? 2035 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1217?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1217?src=pr=footer). Last update [4490cc2...72c8849](https://codecov.io/gh/apache/kylin/pull/1217?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (KYLIN-4503) Kylin query failing with Upper in query
raghu ram reddy created KYLIN-4503: -- Summary: Kylin query failing with Upper in query Key: KYLIN-4503 URL: https://issues.apache.org/jira/browse/KYLIN-4503 Project: Kylin Issue Type: Bug Components: Query Engine Affects Versions: v3.0.1 Reporter: raghu ram reddy This query fails with below error, when we use "UPPER" function in where clause. IF we remove the second where condition from query "AND UPPER(CAST(TRIM(FACT."COLLEGE_NAME") as VARCHAR(2048))) LIKE '%TEST%'", it works fine. Query: SELECT TRIM(FACT."COLLEGE_NAME") AS "College Name ", CAST(TRIM(FACT."COLLEGE_NAME") as VARCHAR(2048)) AS "RN392 ", UPPER(CAST(TRIM(FACT."COLLEGE_NAME") as VARCHAR(2048))) AS "RN543 " FROM NAVIANCE_COLLEGE_TRANSFORM_03262020.COLLEGE_APPLICATION_FACT FACT WHERE TRIM(FACT."COLLEGE_NAME") LIKE '%Test name%' AND UPPER(CAST(TRIM(FACT."COLLEGE_NAME") as VARCHAR(2048))) LIKE '%TEST%' GROUP BY TRIM(FACT."COLLEGE_NAME"), CAST(TRIM(FACT."COLLEGE_NAME") as VARCHAR(2048)), UPPER(CAST(TRIM(FACT."COLLEGE_NAME") as VARCHAR(2048))) ORDER BY TRIM(FACT."COLLEGE_NAME") ASC LIMIT 250 ERROR: Caused by: java.lang.NullPointerException at org.apache.kylin.cube.CubeSegment.getDictResPath(CubeSegment.java:322) at org.apache.kylin.cube.CubeManager$DictionaryAssist.getDictionary(CubeManager.java:1189) at org.apache.kylin.cube.CubeManager.getDictionary(CubeManager.java:1126) at org.apache.kylin.cube.CubeSegment.getDictionary(CubeSegment.java:354) at org.apache.kylin.cube.kv.CubeDimEncMap.getDictionary(CubeDimEncMap.java:87) at org.apache.kylin.dict.BuiltInFunctionTransformer.translateFunctionTupleFilter(BuiltInFunctionTransformer.java:92) at org.apache.kylin.dict.BuiltInFunctionTransformer.transform(BuiltInFunctio -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [kylin] gitlbo opened a new pull request #1217: Add considerations for hbase-shad-client -*.jar
gitlbo opened a new pull request #1217: URL: https://github.com/apache/kylin/pull/1217 When work with HBase 2.1, the script `find-hbase-dependency.sh` returns `hbase-common lib not found`, because the output of this command `hbase classpath` does not contain `hbase-common-*.jar` but `hbase-shaded-client-*.jar` ## Proposed changes When looking for hbase dependencies, add considerations for `hbase-shaded-client -*.jar`. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If this change need a document change, I will prepare another pr against the `document` branch - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] gitlbo closed pull request #1216: 3.0.x hadoop3.1
gitlbo closed pull request #1216: URL: https://github.com/apache/kylin/pull/1216 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (KYLIN-4502) Add alluxio dependence jar
[ https://issues.apache.org/jira/browse/KYLIN-4502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harvey Yue updated KYLIN-4502: -- Component/s: Spark Engine > Add alluxio dependence jar > -- > > Key: KYLIN-4502 > URL: https://issues.apache.org/jira/browse/KYLIN-4502 > Project: Kylin > Issue Type: New Feature > Components: Spark Engine >Reporter: Harvey Yue >Assignee: Harvey Yue >Priority: Major > Fix For: v4.0.0-beta > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [kylin] gitlbo opened a new pull request #1216: 3.0.x hadoop3.1
gitlbo opened a new pull request #1216: URL: https://github.com/apache/kylin/pull/1216 ## Proposed changes When looking for hbase dependencies, add considerations for `hbase-shaded-client -*.jar`. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [x] I have added tests that prove my fix is effective or that my feature works - [ ] If this change need a document change, I will prepare another pr against the `document` branch - [ ] Any dependent changes have been merged ## Further comments When work with HBase 2.1, this script returns "hbase-common lib not found", because the output of this command `hbase classpath` does not contain `hbase-common-*.jar` but `hbase-shaded-client-*.jar` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (KYLIN-2971) Fix the wrong "Realization Names" in logQuery when hit cache
[ https://issues.apache.org/jira/browse/KYLIN-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17111662#comment-17111662 ] ASF GitHub Bot commented on KYLIN-2971: --- codecov-commenter commented on pull request #1215: URL: https://github.com/apache/kylin/pull/1215#issuecomment-631180807 # [Codecov](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=h1) Report > Merging [#1215](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/7886a2498178ded085497d6204b4b367f56ce0c8=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1215 +/- ## - Coverage 24.85% 24.84% -0.02% + Complexity 6266 6263 -3 Files 1453 1453 Lines 8922589236 +11 Branches 1245612458 +2 - Hits 2217522168 -7 - Misses6487464888 +14 - Partials 2176 2180 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...va/org/apache/kylin/rest/service/QueryService.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9RdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0.00%> (-5.41%)` | `6.00% <0.00%> (-1.00%)` | | | [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `35.71% <0.00%> (-4.77%)` | `5.00% <0.00%> (-1.00%)` | | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0.00%> (-2.31%)` | `0.00% <0.00%> (ø%)` | | | [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `50.00% <0.00%> (-2.28%)` | `7.00% <0.00%> (-1.00%)` | | | [...ain/java/org/apache/kylin/dict/TrieDictionary.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L1RyaWVEaWN0aW9uYXJ5LmphdmE=) | `72.55% <0.00%> (-0.47%)` | `56.00% <0.00%> (-1.00%)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.60% <0.00%> (+0.30%)` | `7.00% <0.00%> (ø%)` | | | [...core/storage/columnar/GeneralColumnDataReader.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvR2VuZXJhbENvbHVtbkRhdGFSZWFkZXIuamF2YQ==) | `94.73% <0.00%> (+5.26%)` | `7.00% <0.00%> (+1.00%)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=footer). Last update [7886a24...87cd508](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix the wrong "Realization Names" in logQuery
[GitHub] [kylin] codecov-commenter commented on pull request #1215: KYLIN-2971 Fix the wrong "Realization Names" and missing "Cuboid Ids" in logQuery when hit cache
codecov-commenter commented on pull request #1215: URL: https://github.com/apache/kylin/pull/1215#issuecomment-631180807 # [Codecov](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=h1) Report > Merging [#1215](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/7886a2498178ded085497d6204b4b367f56ce0c8=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1215 +/- ## - Coverage 24.85% 24.84% -0.02% + Complexity 6266 6263 -3 Files 1453 1453 Lines 8922589236 +11 Branches 1245612458 +2 - Hits 2217522168 -7 - Misses6487464888 +14 - Partials 2176 2180 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...va/org/apache/kylin/rest/service/QueryService.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9RdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0.00%> (-5.41%)` | `6.00% <0.00%> (-1.00%)` | | | [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `35.71% <0.00%> (-4.77%)` | `5.00% <0.00%> (-1.00%)` | | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0.00%> (-2.31%)` | `0.00% <0.00%> (ø%)` | | | [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `50.00% <0.00%> (-2.28%)` | `7.00% <0.00%> (-1.00%)` | | | [...ain/java/org/apache/kylin/dict/TrieDictionary.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L1RyaWVEaWN0aW9uYXJ5LmphdmE=) | `72.55% <0.00%> (-0.47%)` | `56.00% <0.00%> (-1.00%)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.60% <0.00%> (+0.30%)` | `7.00% <0.00%> (ø%)` | | | [...core/storage/columnar/GeneralColumnDataReader.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvR2VuZXJhbENvbHVtbkRhdGFSZWFkZXIuamF2YQ==) | `94.73% <0.00%> (+5.26%)` | `7.00% <0.00%> (+1.00%)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=footer). Last update [7886a24...87cd508](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (KYLIN-2971) Fix the wrong "Realization Names" in logQuery when hit cache
[
https://issues.apache.org/jira/browse/KYLIN-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17111647#comment-17111647
]
ASF GitHub Bot commented on KYLIN-2971:
---
coveralls commented on pull request #1215:
URL: https://github.com/apache/kylin/pull/1215#issuecomment-631164387
## Pull Request Test Coverage Report for [Build
5915](https://coveralls.io/builds/30905195)
* **0** of **12** **(0.0%)** changed or added relevant lines in **1**
file are covered.
* **8** unchanged lines in **4** files lost coverage.
* Overall coverage decreased (**-0.006%**) to **27.288%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-|--||---: |
|
[server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java](https://coveralls.io/builds/30905195/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FQueryService.java#L337)
| 0 | 12 | 0.0%
| Files with Coverage Reduction | New Missed Lines | % |
| :-|--|--: |
|
[core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/30905195/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62)
| 1 | 81.08% |
|
[stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/30905195/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L146)
| 1 | 56.82% |
|
[core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/30905195/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124)
| 2 | 68.46% |
|
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/30905195/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449)
| 4 | 78.12% |
| Totals | [](https://coveralls.io/builds/30905195)
|
| :-- | --: |
| Change from base [Build 5911](https://coveralls.io/builds/30861301): |
-0.006% |
| Covered Lines: | 24351 |
| Relevant Lines: | 89236 |
---
# - [Coveralls](https://coveralls.io)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix the wrong "Realization Names" in logQuery when hit cache
>
>
> Key: KYLIN-2971
> URL: https://issues.apache.org/jira/browse/KYLIN-2971
> Project: Kylin
> Issue Type: Bug
>Reporter: Zhong Yanghong
>Assignee: Zhichao Zhang
>Priority: Minor
> Fix For: v3.1.0
>
> Attachments: APACHE-KYLIN-2971.patch
>
>
> # The value of "Realization Names" in logQuery is wrong when query two
> different sqls within the same thread and second sql hits cache:
> Example:
> 1). query Q1 hit project P1 and cube C1;
> 2). query Q2 hit project P2 and cube C2 in the same thread with Q1;
> 3). Q1 comes again and hits cache, it will show project P1 and
> {color:#f79232}cube C2{color}. However, it should be {color:#f79232}cube
> C1{color}.
> # Missing "Cuboid Ids" in logQuery when hit cache in a new thread which does
> not have OLAPContext;
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [kylin] coveralls commented on pull request #1215: KYLIN-2971 Fix the wrong "Realization Names" and missing "Cuboid Ids" in logQuery when hit cache
coveralls commented on pull request #1215: URL: https://github.com/apache/kylin/pull/1215#issuecomment-631164387 ## Pull Request Test Coverage Report for [Build 5915](https://coveralls.io/builds/30905195) * **0** of **12** **(0.0%)** changed or added relevant lines in **1** file are covered. * **8** unchanged lines in **4** files lost coverage. * Overall coverage decreased (**-0.006%**) to **27.288%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java](https://coveralls.io/builds/30905195/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FQueryService.java#L337) | 0 | 12 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/30905195/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% | | [stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/30905195/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L146) | 1 | 56.82% | | [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/30905195/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/30905195/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 4 | 78.12% | | Totals | [](https://coveralls.io/builds/30905195) | | :-- | --: | | Change from base [Build 5911](https://coveralls.io/builds/30861301): | -0.006% | | Covered Lines: | 24351 | | Relevant Lines: | 89236 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (KYLIN-2971) Fix the wrong "Realization Names" in logQuery when hit cache
[
https://issues.apache.org/jira/browse/KYLIN-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhichao Zhang updated KYLIN-2971:
--
Description:
# The value of "Realization Names" in logQuery is wrong when query two
different sqls within the same thread and second sql hits cache:
Example:
1). query Q1 hit project P1 and cube C1;
2). query Q2 hit project P2 and cube C2 in the same thread with Q1;
3). Q1 comes again and hits cache, it will show project P1 and
{color:#f79232}cube C2{color}. However, it should be {color:#f79232}cube
C1{color}.
# Missing "Cuboid Ids" in logQuery when hit cache in a new thread which does
not have OLAPContext;
was:
OLAPContext.clearThreadLocalContexts() should be called before a query starts.
And we should consider query hit cache.
Example,
# query Q1 hit project P1 and cube C1;
# then query Q2 hit project P2 and cube C2;
# then Q1 comes again, it will show project P1 and {color:#f79232}cube
C2{color}. However, it should be {color:#f79232}cube C1{color}
> Fix the wrong "Realization Names" in logQuery when hit cache
>
>
> Key: KYLIN-2971
> URL: https://issues.apache.org/jira/browse/KYLIN-2971
> Project: Kylin
> Issue Type: Bug
>Reporter: Zhong Yanghong
>Assignee: Zhichao Zhang
>Priority: Minor
> Fix For: v3.1.0
>
> Attachments: APACHE-KYLIN-2971.patch
>
>
> # The value of "Realization Names" in logQuery is wrong when query two
> different sqls within the same thread and second sql hits cache:
> Example:
> 1). query Q1 hit project P1 and cube C1;
> 2). query Q2 hit project P2 and cube C2 in the same thread with Q1;
> 3). Q1 comes again and hits cache, it will show project P1 and
> {color:#f79232}cube C2{color}. However, it should be {color:#f79232}cube
> C1{color}.
> # Missing "Cuboid Ids" in logQuery when hit cache in a new thread which does
> not have OLAPContext;
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [kylin] zzcclp opened a new pull request #1215: KYLIN-2971 Fix the wrong "Realization Names" and missing "Cuboid Ids" in logQuery when hit cache
zzcclp opened a new pull request #1215: URL: https://github.com/apache/kylin/pull/1215 **Problems:** 1. The value of "Realization Names" in logQuery is wrong when query two different sqls within the same thread and second sql hits cache: Example: 1). query Q1 hit project P1 and cube C1; 2). query Q2 hit project P2 and cube C2 in the same thread with Q1; 3). Q1 comes again and hits cache, it will show project P1 and cube C2. However, it should be cube C1. 2. Missing "Cuboid Ids" in logQuery when hit cache in a new thread which does not have OLAPContext; **Solutions:** 1. Call 'OLAPContext.clearThreadLocalContexts()' before a query starts; 2. Get "Cuboid Ids" from SQLResponse when "OLAPContext.getThreadLocalContexts()" is null; ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If this change need a document change, I will prepare another pr against the `document` branch - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (KYLIN-2971) Fix the wrong "Realization Names" in logQuery when hit cache
[
https://issues.apache.org/jira/browse/KYLIN-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17111634#comment-17111634
]
ASF GitHub Bot commented on KYLIN-2971:
---
zzcclp opened a new pull request #1215:
URL: https://github.com/apache/kylin/pull/1215
**Problems:**
1. The value of "Realization Names" in logQuery is wrong when query two
different sqls within the same thread and second sql hits cache:
Example:
1). query Q1 hit project P1 and cube C1;
2). query Q2 hit project P2 and cube C2 in the same thread with Q1;
3). Q1 comes again and hits cache, it will show project P1 and cube C2.
However, it should be cube C1.
2. Missing "Cuboid Ids" in logQuery when hit cache in a new thread which
does not have OLAPContext;
**Solutions:**
1. Call 'OLAPContext.clearThreadLocalContexts()' before a query starts;
2. Get "Cuboid Ids" from SQLResponse when
"OLAPContext.getThreadLocalContexts()" is null;
## Proposed changes
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug or
resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to Kylin?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to ask.
We're here to help! This is simply a reminder of what we are going to look for
before merging your code._
- [ ] I have create an issue on [Kylin's
jira](https://issues.apache.org/jira/browse/KYLIN), and have described the
bug/feature there in detail
- [ ] Commit messages in my PR start with the related jira ID, like
"KYLIN- Make Kylin project open-source"
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature
works
- [ ] If this change need a document change, I will prepare another pr
against the `document` branch
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at
user@kylin or dev@kylin by explaining why you chose the solution you did and
what alternatives you considered, etc...
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix the wrong "Realization Names" in logQuery when hit cache
>
>
> Key: KYLIN-2971
> URL: https://issues.apache.org/jira/browse/KYLIN-2971
> Project: Kylin
> Issue Type: Bug
>Reporter: Zhong Yanghong
>Assignee: Zhichao Zhang
>Priority: Minor
> Fix For: v3.1.0
>
> Attachments: APACHE-KYLIN-2971.patch
>
>
> OLAPContext.clearThreadLocalContexts() should be called before a query
> starts. And we should consider query hit cache.
> Example,
> # query Q1 hit project P1 and cube C1;
> # then query Q2 hit project P2 and cube C2;
> # then Q1 comes again, it will show project P1 and {color:#f79232}cube
> C2{color}. However, it should be {color:#f79232}cube C1{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [kylin] coveralls commented on pull request #1214: [Bugfix] fix error with sending mail on ssl
coveralls commented on pull request #1214: URL: https://github.com/apache/kylin/pull/1214#issuecomment-630794650 ## Pull Request Test Coverage Report for [Build 5913](https://coveralls.io/builds/30887221) * **0** of **1** **(0.0%)** changed or added relevant line in **1** file are covered. * **7** unchanged lines in **4** files lost coverage. * Overall coverage decreased (**-0.003%**) to **27.291%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [core-common/src/main/java/org/apache/kylin/common/util/MailService.java](https://coveralls.io/builds/30887221/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Futil%2FMailService.java#L92) | 0 | 1 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/30887221/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% | | [stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/30887221/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L146) | 1 | 56.82% | | [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/30887221/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L194) | 2 | 80.23% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/30887221/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 3 | 78.42% | | Totals | [](https://coveralls.io/builds/30887221) | | :-- | --: | | Change from base [Build 5911](https://coveralls.io/builds/30861301): | -0.003% | | Covered Lines: | 24351 | | Relevant Lines: | 89226 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] codecov-commenter commented on pull request #1214: [Bugfix] fix error with sending mail on ssl
codecov-commenter commented on pull request #1214: URL: https://github.com/apache/kylin/pull/1214#issuecomment-630792231 # [Codecov](https://codecov.io/gh/apache/kylin/pull/1214?src=pr=h1) Report > Merging [#1214](https://codecov.io/gh/apache/kylin/pull/1214?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/7886a2498178ded085497d6204b4b367f56ce0c8=desc) will **decrease** coverage by `0.00%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/kylin/pull/1214?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1214 +/- ## - Coverage 24.85% 24.84% -0.01% + Complexity 6265 6263 -2 Files 1453 1453 Lines 8922589226 +1 Branches 1245612456 - Hits 2217322170 -3 - Misses6487564878 +3 - Partials 2177 2178 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1214?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...java/org/apache/kylin/common/util/MailService.java](https://codecov.io/gh/apache/kylin/pull/1214/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL01haWxTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1214/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0.00%> (-5.41%)` | `6.00% <0.00%> (-1.00%)` | | | [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/1214/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `74.41% <0.00%> (-2.33%)` | `12.00% <0.00%> (ø%)` | | | [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1214/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `50.00% <0.00%> (-2.28%)` | `7.00% <0.00%> (-1.00%)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1214/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0.00%> (+0.91%)` | `7.00% <0.00%> (ø%)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1214?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1214?src=pr=footer). Last update [7886a24...5a94852](https://codecov.io/gh/apache/kylin/pull/1214?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (KYLIN-4502) Add alluxio dependence jar
Harvey Yue created KYLIN-4502: - Summary: Add alluxio dependence jar Key: KYLIN-4502 URL: https://issues.apache.org/jira/browse/KYLIN-4502 Project: Kylin Issue Type: New Feature Reporter: Harvey Yue Assignee: Harvey Yue Fix For: v4.0.0-beta -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (KYLIN-4501) Support alluxio to adapt more storage like s3, oss ...
Harvey Yue created KYLIN-4501: - Summary: Support alluxio to adapt more storage like s3, oss ... Key: KYLIN-4501 URL: https://issues.apache.org/jira/browse/KYLIN-4501 Project: Kylin Issue Type: New Feature Components: Spark Engine Reporter: Harvey Yue Assignee: Harvey Yue Fix For: v4.0.0-beta -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [kylin] chenqingspring opened a new pull request #1214: [Bugfix] fix error with sending mail on ssl
chenqingspring opened a new pull request #1214: URL: https://github.com/apache/kylin/pull/1214 ## Proposed changes Here is context of this problem：https://www.mail-archive.com/user@kylin.apache.org/msg04009.html When I set `starttlsEnabled` to true, and specify a ssl port as 465, the email could not be sent by this ssl port. It still use 25 default port. The root cause is, with such config above, HTMLEmail client doesn't enable ssl connection, so we need to enable ssl connection by `setSSLOnConnect` as well when using ssl port. ## Types of changes [Bugfix] fix error with sending mail on ssl This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] wlrlp closed pull request #1213: fix bug opening starttlsenabled with port 25 disabled setting SSL po…
wlrlp closed pull request #1213: URL: https://github.com/apache/kylin/pull/1213 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (KYLIN-3361) Support stddev as a new measure
[ https://issues.apache.org/jira/browse/KYLIN-3361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nichunen updated KYLIN-3361: Sprint: Sprint 51 Issue Type: New Feature (was: Improvement) > Support stddev as a new measure > --- > > Key: KYLIN-3361 > URL: https://issues.apache.org/jira/browse/KYLIN-3361 > Project: Kylin > Issue Type: New Feature >Reporter: Zhong Yanghong >Assignee: Zhong Yanghong >Priority: Major > Fix For: v3.1.0 > > > (x ~1~ - +x+) ^2^ + (x ~2~ - +x+) ^2^ + ... + (x ~n~ - +x+) ^2^ = x ~1~ ^2^ + > x ~2~ ^2^ + ... + x ~n~ ^2^ - n +x+ ^2^, where +x+ is the average of x ~1~, x > ~2~, ..., x ~n~. Therefore, to compute stddev, what kylin need to do is to > pre-calculate sum(x ~i~ ^2^), sum(x ~i~) and count -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (KYLIN-3361) Support stddev as a new measure
[ https://issues.apache.org/jira/browse/KYLIN-3361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nichunen updated KYLIN-3361: Parent: (was: KYLIN-3358) Issue Type: Improvement (was: Sub-task) > Support stddev as a new measure > --- > > Key: KYLIN-3361 > URL: https://issues.apache.org/jira/browse/KYLIN-3361 > Project: Kylin > Issue Type: Improvement >Reporter: Zhong Yanghong >Assignee: Zhong Yanghong >Priority: Major > Fix For: v3.1.0 > > > (x ~1~ - +x+) ^2^ + (x ~2~ - +x+) ^2^ + ... + (x ~n~ - +x+) ^2^ = x ~1~ ^2^ + > x ~2~ ^2^ + ... + x ~n~ ^2^ - n +x+ ^2^, where +x+ is the average of x ~1~, x > ~2~, ..., x ~n~. Therefore, to compute stddev, what kylin need to do is to > pre-calculate sum(x ~i~ ^2^), sum(x ~i~) and count -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (KYLIN-3361) Support stddev as a new measure
[ https://issues.apache.org/jira/browse/KYLIN-3361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nichunen updated KYLIN-3361: Fix Version/s: (was: Backlog) v3.1.0 > Support stddev as a new measure > --- > > Key: KYLIN-3361 > URL: https://issues.apache.org/jira/browse/KYLIN-3361 > Project: Kylin > Issue Type: Sub-task >Reporter: Zhong Yanghong >Assignee: Zhong Yanghong >Priority: Major > Fix For: v3.1.0 > > > (x ~1~ - +x+) ^2^ + (x ~2~ - +x+) ^2^ + ... + (x ~n~ - +x+) ^2^ = x ~1~ ^2^ + > x ~2~ ^2^ + ... + x ~n~ ^2^ - n +x+ ^2^, where +x+ is the average of x ~1~, x > ~2~, ..., x ~n~. Therefore, to compute stddev, what kylin need to do is to > pre-calculate sum(x ~i~ ^2^), sum(x ~i~) and count -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [kylin] coveralls commented on pull request #1213: fix bug opening starttlsenabled with port 25 disabled setting SSL po…
coveralls commented on pull request #1213: URL: https://github.com/apache/kylin/pull/1213#issuecomment-630689832 ## Pull Request Test Coverage Report for [Build 5912](https://coveralls.io/builds/30882903) * **0** of **1** **(0.0%)** changed or added relevant line in **1** file are covered. * **7** unchanged lines in **4** files lost coverage. * Overall coverage decreased (**-0.001%**) to **27.292%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [core-common/src/main/java/org/apache/kylin/common/util/MailService.java](https://coveralls.io/builds/30882903/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Futil%2FMailService.java#L93) | 0 | 1 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-common/src/main/java/org/apache/kylin/common/util/MailService.java](https://coveralls.io/builds/30882903/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Futil%2FMailService.java#L94) | 1 | 0% | | [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/30882903/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% | | [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/30882903/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/30882903/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 3 | 78.42% | | Totals | [](https://coveralls.io/builds/30882903) | | :-- | --: | | Change from base [Build 5911](https://coveralls.io/builds/30861301): | -0.001% | | Covered Lines: | 24352 | | Relevant Lines: | 89226 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] codecov-commenter commented on pull request #1213: fix bug opening starttlsenabled with port 25 disabled setting SSL po…
codecov-commenter commented on pull request #1213: URL: https://github.com/apache/kylin/pull/1213#issuecomment-630689253 # [Codecov](https://codecov.io/gh/apache/kylin/pull/1213?src=pr=h1) Report > Merging [#1213](https://codecov.io/gh/apache/kylin/pull/1213?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/7886a2498178ded085497d6204b4b367f56ce0c8=desc) will **decrease** coverage by `0.00%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/kylin/pull/1213?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1213 +/- ## - Coverage 24.85% 24.84% -0.01% + Complexity 6265 6264 -1 Files 1453 1453 Lines 8922589226 +1 Branches 1245612456 - Hits 2217322171 -2 - Misses6487564877 +2 - Partials 2177 2178 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1213?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...java/org/apache/kylin/common/util/MailService.java](https://codecov.io/gh/apache/kylin/pull/1213/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL01haWxTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1213/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0.00%> (-5.41%)` | `6.00% <0.00%> (-1.00%)` | | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1213/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0.00%> (-2.31%)` | `0.00% <0.00%> (ø%)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1213/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0.00%> (+0.91%)` | `7.00% <0.00%> (ø%)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1213?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1213?src=pr=footer). Last update [7886a24...dbd4a5d](https://codecov.io/gh/apache/kylin/pull/1213?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] wlrlp removed a comment on pull request #1213: fix bug opening starttlsenabled with port 25 disabled setting SSL po…
wlrlp removed a comment on pull request #1213: URL: https://github.com/apache/kylin/pull/1213#issuecomment-630656555 fixbug This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] wlrlp commented on pull request #1213: fix bug opening starttlsenabled with port 25 disabled setting SSL po…
wlrlp commented on pull request #1213: URL: https://github.com/apache/kylin/pull/1213#issuecomment-630656555 fixbug This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] wlrlp opened a new pull request #1213: fix bug opening starttlsenabled with port 25 disabled setting SSL po…
wlrlp opened a new pull request #1213: URL: https://github.com/apache/kylin/pull/1213 …rt 465 is invalid ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If this change need a document change, I will prepare another pr against the `document` branch - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
