[GitHub] [kylin] asfgit commented on issue #709: KYLIN-3982 Add measures without purging segments

2019-06-23 Thread GitBox
asfgit commented on issue #709: KYLIN-3982 Add measures without purging segments URL: https://github.com/apache/kylin/pull/709#issuecomment-504725709 Can one of the admins verify this patch? This is an automated message from

[GitHub] [kylin] Qsimple opened a new pull request #709: KYLIN-3982 Add measures without purging segments

2019-06-23 Thread GitBox
Qsimple opened a new pull request #709: KYLIN-3982 Add measures without purging segments URL: https://github.com/apache/kylin/pull/709 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kylin] codecov-io commented on issue #707: KYLIN-4013 Only show the cubes under one model

2019-06-22 Thread GitBox
codecov-io commented on issue #707: KYLIN-4013 Only show the cubes under one model URL: https://github.com/apache/kylin/pull/707#issuecomment-504718946 # [Codecov](https://codecov.io/gh/apache/kylin/pull/707?src=pr=h1) Report > Merging

[GitHub] [kylin] Qsimple opened a new pull request #707: KYLIN-4013 Only show the cubes under one model

2019-06-22 Thread GitBox
Qsimple opened a new pull request #707: KYLIN-4013 Only show the cubes under one model URL: https://github.com/apache/kylin/pull/707 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kylin] asfgit commented on issue #707: KYLIN-4013 Only show the cubes under one model

2019-06-22 Thread GitBox
asfgit commented on issue #707: KYLIN-4013 Only show the cubes under one model URL: https://github.com/apache/kylin/pull/707#issuecomment-504717706 Can one of the admins verify this patch? This is an automated message from

[GitHub] [kylin] coveralls commented on issue #707: KYLIN-4013 Only show the cubes under one model

2019-06-22 Thread GitBox
coveralls commented on issue #707: KYLIN-4013 Only show the cubes under one model URL: https://github.com/apache/kylin/pull/707#issuecomment-504718829 ## Pull Request Test Coverage Report for [Build 4647](https://coveralls.io/builds/24152042) * **0** of **0** changed or added

[GitHub] [kylin] asfgit commented on issue #711: KYLIN-4054 Logger of HCreateTableJob record error message

2019-06-23 Thread GitBox
asfgit commented on issue #711: KYLIN-4054 Logger of HCreateTableJob record error message URL: https://github.com/apache/kylin/pull/711#issuecomment-504844932 Can one of the admins verify this patch? This is an automated

[GitHub] [kylin] hit-lacus opened a new pull request #711: KYLIN-4054 Logger of HCreateTableJob record error message

2019-06-23 Thread GitBox
hit-lacus opened a new pull request #711: KYLIN-4054 Logger of HCreateTableJob record error message URL: https://github.com/apache/kylin/pull/711 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kylin] codecov-io commented on issue #710: KYLIN-4046 Refine JDBC Source(source.default=8)

2019-06-23 Thread GitBox
codecov-io commented on issue #710: KYLIN-4046 Refine JDBC Source(source.default=8) URL: https://github.com/apache/kylin/pull/710#issuecomment-504846974 # [Codecov](https://codecov.io/gh/apache/kylin/pull/710?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base

[GitHub] [kylin] nichunen merged pull request #711: KYLIN-4054 Logger of HCreateTableJob record error message

2019-06-23 Thread GitBox
nichunen merged pull request #711: KYLIN-4054 Logger of HCreateTableJob record error message URL: https://github.com/apache/kylin/pull/711 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kylin] nichunen merged pull request #705: Add docs for KYLIN-4033

2019-06-23 Thread GitBox
nichunen merged pull request #705: Add docs for KYLIN-4033 URL: https://github.com/apache/kylin/pull/705 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kylin] hit-lacus closed pull request #703: Revert "#KYLIN-4044, upgrade curator dependency version"

2019-06-23 Thread GitBox
hit-lacus closed pull request #703: Revert "#KYLIN-4044, upgrade curator dependency version" URL: https://github.com/apache/kylin/pull/703 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kylin] nichunen merged pull request #680: KYLIN-4035 Calculate column cardinality by using spark engine

2019-06-23 Thread GitBox
nichunen merged pull request #680: KYLIN-4035 Calculate column cardinality by using spark engine URL: https://github.com/apache/kylin/pull/680 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kylin] coveralls commented on issue #711: KYLIN-4054 Logger of HCreateTableJob record error message

2019-06-23 Thread GitBox
coveralls commented on issue #711: KYLIN-4054 Logger of HCreateTableJob record error message URL: https://github.com/apache/kylin/pull/711#issuecomment-504851650 ## Pull Request Test Coverage Report for [Build 4656](https://coveralls.io/builds/24161630) * **0** of **33**

[GitHub] [kylin] coveralls commented on issue #708: KYLIN-4031 RestClient will throw exception with message contains clea…

2019-06-23 Thread GitBox
coveralls commented on issue #708: KYLIN-4031 RestClient will throw exception with message contains clea… URL: https://github.com/apache/kylin/pull/708#issuecomment-504723245 ## Pull Request Test Coverage Report for [Build 4648](https://coveralls.io/builds/24152434) * **0** of

[GitHub] [kylin] luguosheng1314 merged pull request #693: KYLIN-3933 Invalid replica set cache after status updated

2019-06-23 Thread GitBox
luguosheng1314 merged pull request #693: KYLIN-3933 Invalid replica set cache after status updated URL: https://github.com/apache/kylin/pull/693 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kylin] hit-lacus commented on issue #710: KYLIN-4046 Refine JDBC Source(source.default=8)

2019-06-23 Thread GitBox
hit-lacus commented on issue #710: KYLIN-4046 Refine JDBC Source(source.default=8) URL: https://github.com/apache/kylin/pull/710#issuecomment-504847464 Fix rat-plugin error. This is an automated message from the Apache Git

[GitHub] [kylin] coveralls commented on issue #710: KYLIN-4046 Refine JDBC Source(source.default=8)

2019-06-23 Thread GitBox
coveralls commented on issue #710: KYLIN-4046 Refine JDBC Source(source.default=8) URL: https://github.com/apache/kylin/pull/710#issuecomment-504769865 ## Pull Request Test Coverage Report for [Build 4650](https://coveralls.io/builds/24157131) * **68** of **249** **(27.31%)**

[GitHub] [kylin] hit-lacus opened a new pull request #710: KYLIN-4046 Refine JDBC Source(source.default=8)

2019-06-23 Thread GitBox
hit-lacus opened a new pull request #710: KYLIN-4046 Refine JDBC Source(source.default=8) URL: https://github.com/apache/kylin/pull/710 Currently, the function of ingest data from RDBMS(kylin.source.default=8) to Kylin has some problems , in this patch, I want to fix: - fix

[GitHub] [kylin] asfgit commented on issue #710: KYLIN-4046 Refine JDBC Source(source.default=8)

2019-06-23 Thread GitBox
asfgit commented on issue #710: KYLIN-4046 Refine JDBC Source(source.default=8) URL: https://github.com/apache/kylin/pull/710#issuecomment-504767850 Can one of the admins verify this patch? This is an automated message from

[GitHub] [kylin] codecov-io edited a comment on issue #710: KYLIN-4046 Refine JDBC Source(source.default=8)

2019-06-24 Thread GitBox
codecov-io edited a comment on issue #710: KYLIN-4046 Refine JDBC Source(source.default=8) URL: https://github.com/apache/kylin/pull/710#issuecomment-504846974 # [Codecov](https://codecov.io/gh/apache/kylin/pull/710?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request

[GitHub] [kylin] nichunen merged pull request #699: fix add jacoco.version in pom.xml

2019-06-24 Thread GitBox
nichunen merged pull request #699: fix add jacoco.version in pom.xml URL: https://github.com/apache/kylin/pull/699 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kylin] Qsimple closed pull request #709: KYLIN-3982 Add measures without purging segments

2019-06-24 Thread GitBox
Qsimple closed pull request #709: KYLIN-3982 Add measures without purging segments URL: https://github.com/apache/kylin/pull/709 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kylin] Qsimple opened a new pull request #712: KYLIN-3982 Add measures without purging segments

2019-06-24 Thread GitBox
Qsimple opened a new pull request #712: KYLIN-3982 Add measures without purging segments URL: https://github.com/apache/kylin/pull/712 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kylin] asfgit commented on issue #712: KYLIN-3982 Add measures without purging segments

2019-06-24 Thread GitBox
asfgit commented on issue #712: KYLIN-3982 Add measures without purging segments URL: https://github.com/apache/kylin/pull/712#issuecomment-505079110 Can one of the admins verify this patch? This is an automated message from

[GitHub] [kylin] shaofengshi merged pull request #661: KYLIN-4015 "Build UHC Dictionary" step filter ".dci" files

2019-06-12 Thread GitBox
shaofengshi merged pull request #661: KYLIN-4015 "Build UHC Dictionary" step filter ".dci" files URL: https://github.com/apache/kylin/pull/661 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kylin] nichunen commented on a change in pull request #664: KYLIN-4017 Build engine get zk(zookeeper) lock failed when building job, it causes the whole build engine doesn't work

2019-06-12 Thread GitBox
nichunen commented on a change in pull request #664: KYLIN-4017 Build engine get zk(zookeeper) lock failed when building job, it causes the whole build engine doesn't work URL: https://github.com/apache/kylin/pull/664#discussion_r293188955 ## File path:

[GitHub] [kylin] nichunen merged pull request #664: KYLIN-4017 Build engine get zk(zookeeper) lock failed when building job, it causes the whole build engine doesn't work

2019-06-12 Thread GitBox
nichunen merged pull request #664: KYLIN-4017 Build engine get zk(zookeeper) lock failed when building job, it causes the whole build engine doesn't work URL: https://github.com/apache/kylin/pull/664 This is an automated

[GitHub] [kylin] hn5092 commented on a change in pull request #676: KYLIN-4033 Can not access Kerberized Cluster with DebugTomcat

2019-06-11 Thread GitBox
hn5092 commented on a change in pull request #676: KYLIN-4033 Can not access Kerberized Cluster with DebugTomcat URL: https://github.com/apache/kylin/pull/676#discussion_r292724726 ## File path: server/src/main/java/org/apache/kylin/rest/DebugTomcat.java ## @@ -99,6

[GitHub] [kylin] hn5092 commented on a change in pull request #676: KYLIN-4033 Can not access Kerberized Cluster with DebugTomcat

2019-06-11 Thread GitBox
hn5092 commented on a change in pull request #676: KYLIN-4033 Can not access Kerberized Cluster with DebugTomcat URL: https://github.com/apache/kylin/pull/676#discussion_r292726096 ## File path: server/src/main/java/org/apache/kylin/rest/DebugTomcat.java ## @@ -99,6

[GitHub] [kylin] hn5092 commented on a change in pull request #676: KYLIN-4033 Can not access Kerberized Cluster with DebugTomcat

2019-06-11 Thread GitBox
hn5092 commented on a change in pull request #676: KYLIN-4033 Can not access Kerberized Cluster with DebugTomcat URL: https://github.com/apache/kylin/pull/676#discussion_r292726863 ## File path: server/src/main/java/org/apache/kylin/rest/DebugTomcat.java ## @@ -99,6

[GitHub] [kylin] hn5092 commented on a change in pull request #676: KYLIN-4033 Can not access Kerberized Cluster with DebugTomcat

2019-06-11 Thread GitBox
hn5092 commented on a change in pull request #676: KYLIN-4033 Can not access Kerberized Cluster with DebugTomcat URL: https://github.com/apache/kylin/pull/676#discussion_r292726635 ## File path: server/src/main/java/org/apache/kylin/rest/DebugTomcat.java ## @@ -99,6

[GitHub] [kylin] hn5092 commented on a change in pull request #676: KYLIN-4033 Can not access Kerberized Cluster with DebugTomcat

2019-06-11 Thread GitBox
hn5092 commented on a change in pull request #676: KYLIN-4033 Can not access Kerberized Cluster with DebugTomcat URL: https://github.com/apache/kylin/pull/676#discussion_r292726863 ## File path: server/src/main/java/org/apache/kylin/rest/DebugTomcat.java ## @@ -99,6

[GitHub] [kylin] hn5092 commented on a change in pull request #676: KYLIN-4033 Can not access Kerberized Cluster with DebugTomcat

2019-06-11 Thread GitBox
hn5092 commented on a change in pull request #676: KYLIN-4033 Can not access Kerberized Cluster with DebugTomcat URL: https://github.com/apache/kylin/pull/676#discussion_r292726635 ## File path: server/src/main/java/org/apache/kylin/rest/DebugTomcat.java ## @@ -99,6

[GitHub] [kylin] hit-lacus commented on a change in pull request #680: KYLIN-4035 Calculate column cardinality by using spark engine

2019-06-16 Thread GitBox
hit-lacus commented on a change in pull request #680: KYLIN-4035 Calculate column cardinality by using spark engine URL: https://github.com/apache/kylin/pull/680#discussion_r294071741 ## File path:

[GitHub] [kylin] hit-lacus commented on a change in pull request #680: KYLIN-4035 Calculate column cardinality by using spark engine

2019-06-16 Thread GitBox
hit-lacus commented on a change in pull request #680: KYLIN-4035 Calculate column cardinality by using spark engine URL: https://github.com/apache/kylin/pull/680#discussion_r294071741 ## File path:

[GitHub] [kylin] codecov-io commented on issue #694: KYLIN-4049 Make storage clean configurable for refreshing job

2019-06-18 Thread GitBox
codecov-io commented on issue #694: KYLIN-4049 Make storage clean configurable for refreshing job URL: https://github.com/apache/kylin/pull/694#issuecomment-503039537 # [Codecov](https://codecov.io/gh/apache/kylin/pull/694?src=pr=h1) Report > Merging

[GitHub] [kylin] nichunen merged pull request #694: KYLIN-4049 Make storage clean configurable for refreshing job

2019-06-18 Thread GitBox
nichunen merged pull request #694: KYLIN-4049 Make storage clean configurable for refreshing job URL: https://github.com/apache/kylin/pull/694 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kylin] coveralls commented on issue #694: KYLIN-4049 Make storage clean configurable for refreshing job

2019-06-18 Thread GitBox
coveralls commented on issue #694: KYLIN-4049 Make storage clean configurable for refreshing job URL: https://github.com/apache/kylin/pull/694#issuecomment-503040338 ## Pull Request Test Coverage Report for [Build 4623](https://coveralls.io/builds/24057638) * **0** of **1**

[GitHub] [kylin] coveralls commented on issue #689: KYLIN-4047 Use push-down query when division dynamic column cube query is not supported

2019-06-17 Thread GitBox
coveralls commented on issue #689: KYLIN-4047 Use push-down query when division dynamic column cube query is not supported URL: https://github.com/apache/kylin/pull/689#issuecomment-502610604 ## Pull Request Test Coverage Report for [Build 4613](https://coveralls.io/builds/24033066)

[GitHub] [kylin] asfgit commented on issue #695: KYLIN-4050 Fix a CLI option parse error in FlinkMergingDictionary and some little code refactor

2019-06-18 Thread GitBox
asfgit commented on issue #695: KYLIN-4050 Fix a CLI option parse error in FlinkMergingDictionary and some little code refactor URL: https://github.com/apache/kylin/pull/695#issuecomment-503079241 Can one of the admins verify this patch?

[GitHub] [kylin] asfgit commented on issue #695: KYLIN-4050 Fix a CLI option parse error in FlinkMergingDictionary and some little code refactor

2019-06-18 Thread GitBox
asfgit commented on issue #695: KYLIN-4050 Fix a CLI option parse error in FlinkMergingDictionary and some little code refactor URL: https://github.com/apache/kylin/pull/695#issuecomment-503079244 Can one of the admins verify this patch?

[GitHub] [kylin] asfgit commented on issue #695: KYLIN-4050 Fix a CLI option parse error in FlinkMergingDictionary and some little code refactor

2019-06-18 Thread GitBox
asfgit commented on issue #695: KYLIN-4050 Fix a CLI option parse error in FlinkMergingDictionary and some little code refactor URL: https://github.com/apache/kylin/pull/695#issuecomment-503079237 Can one of the admins verify this patch?

[GitHub] [kylin] asfgit commented on issue #695: KYLIN-4050 Fix a CLI option parse error in FlinkMergingDictionary and some little code refactor

2019-06-18 Thread GitBox
asfgit commented on issue #695: KYLIN-4050 Fix a CLI option parse error in FlinkMergingDictionary and some little code refactor URL: https://github.com/apache/kylin/pull/695#issuecomment-503079242 Can one of the admins verify this patch?

[GitHub] [kylin] yanghua opened a new pull request #695: KYLIN-4050 Fix a CLI option parse error in FlinkMergingDictionary and some little code refactor

2019-06-18 Thread GitBox
yanghua opened a new pull request #695: KYLIN-4050 Fix a CLI option parse error in FlinkMergingDictionary and some little code refactor URL: https://github.com/apache/kylin/pull/695 JIRA : https://issues.apache.org/jira/browse/KYLIN-4050

[GitHub] [kylin] liuzx32 commented on issue #654: Bug Fix: remove HBase tableName toUpperCase()

2019-06-17 Thread GitBox
liuzx32 commented on issue #654: Bug Fix: remove HBase tableName toUpperCase() URL: https://github.com/apache/kylin/pull/654#issuecomment-502554022 @nichunen Thank you, I will try it. This is an automated message from the

[GitHub] [kylin] liuzx32 edited a comment on issue #657: adjust HBase tableName toUpperCase for HFile

2019-06-17 Thread GitBox
liuzx32 edited a comment on issue #657: adjust HBase tableName toUpperCase for HFile URL: https://github.com/apache/kylin/pull/657#issuecomment-502587332 @nichunen Because HBase tableName is case sensitive. HBase tableName.toUpperCase() will different from the original table, leading to

[GitHub] [kylin] asfgit commented on issue #688: remove tableName.toUppderCase() for hbase table Name,

2019-06-17 Thread GitBox
asfgit commented on issue #688: remove tableName.toUppderCase() for hbase table Name, URL: https://github.com/apache/kylin/pull/688#issuecomment-502592818 Can one of the admins verify this patch? This is an automated message

[GitHub] [kylin] asfgit commented on issue #688: remove tableName.toUppderCase() for hbase table Name,

2019-06-17 Thread GitBox
asfgit commented on issue #688: remove tableName.toUppderCase() for hbase table Name, URL: https://github.com/apache/kylin/pull/688#issuecomment-502592834 Can one of the admins verify this patch? This is an automated message

[GitHub] [kylin] liuzx32 opened a new pull request #688: remove tableName.toUppderCase() for hbase table Name,

2019-06-17 Thread GitBox
liuzx32 opened a new pull request #688: remove tableName.toUppderCase() for hbase table Name, URL: https://github.com/apache/kylin/pull/688 **Description** HBase is case sensitive,tableName.toUpperCase() will lead to the created table could not be found. If my tableName of HBase is

[GitHub] [kylin] asfgit commented on issue #688: remove tableName.toUppderCase() for hbase table Name,

2019-06-17 Thread GitBox
asfgit commented on issue #688: remove tableName.toUppderCase() for hbase table Name, URL: https://github.com/apache/kylin/pull/688#issuecomment-502592827 Can one of the admins verify this patch? This is an automated message

[GitHub] [kylin] asfgit commented on issue #688: remove tableName.toUppderCase() for hbase table Name,

2019-06-17 Thread GitBox
asfgit commented on issue #688: remove tableName.toUppderCase() for hbase table Name, URL: https://github.com/apache/kylin/pull/688#issuecomment-502592820 Can one of the admins verify this patch? This is an automated message

[GitHub] [kylin] wangxiaojing123 opened a new pull request #689: KYLIN-4047 Use push-down query when division dynamic column cube query is not supported

2019-06-17 Thread GitBox
wangxiaojing123 opened a new pull request #689: KYLIN-4047 Use push-down query when division dynamic column cube query is not supported URL: https://github.com/apache/kylin/pull/689 Scene: SQL:select round (car_dismatch_cnt*100/answer_order_cnt, 4) from db.table1. -

[GitHub] [kylin] asfgit commented on issue #689: KYLIN-4047 Use push-down query when division dynamic column cube query is not supported

2019-06-17 Thread GitBox
asfgit commented on issue #689: KYLIN-4047 Use push-down query when division dynamic column cube query is not supported URL: https://github.com/apache/kylin/pull/689#issuecomment-502593815 Can one of the admins verify this patch?

[GitHub] [kylin] asfgit commented on issue #689: KYLIN-4047 Use push-down query when division dynamic column cube query is not supported

2019-06-17 Thread GitBox
asfgit commented on issue #689: KYLIN-4047 Use push-down query when division dynamic column cube query is not supported URL: https://github.com/apache/kylin/pull/689#issuecomment-502593816 Can one of the admins verify this patch?

[GitHub] [kylin] asfgit commented on issue #689: KYLIN-4047 Use push-down query when division dynamic column cube query is not supported

2019-06-17 Thread GitBox
asfgit commented on issue #689: KYLIN-4047 Use push-down query when division dynamic column cube query is not supported URL: https://github.com/apache/kylin/pull/689#issuecomment-502593817 Can one of the admins verify this patch?

[GitHub] [kylin] asfgit commented on issue #689: KYLIN-4047 Use push-down query when division dynamic column cube query is not supported

2019-06-17 Thread GitBox
asfgit commented on issue #689: KYLIN-4047 Use push-down query when division dynamic column cube query is not supported URL: https://github.com/apache/kylin/pull/689#issuecomment-502593818 Can one of the admins verify this patch?

[GitHub] [kylin] majic31 commented on a change in pull request #680: KYLIN-4035 Calculate column cardinality by using spark engine

2019-06-17 Thread GitBox
majic31 commented on a change in pull request #680: KYLIN-4035 Calculate column cardinality by using spark engine URL: https://github.com/apache/kylin/pull/680#discussion_r294143074 ## File path: engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkColumnCardinality.java

[GitHub] [kylin] liuzx32 edited a comment on issue #657: adjust HBase tableName toUpperCase for HFile

2019-06-17 Thread GitBox
liuzx32 edited a comment on issue #657: adjust HBase tableName toUpperCase for HFile URL: https://github.com/apache/kylin/pull/657#issuecomment-502587332 @nichunen Because HBase tableName is case sensitive. HBase tableName.toUpperCase() will different from the original table, leading to

[GitHub] [kylin] liuzx32 commented on issue #657: adjust HBase tableName toUpperCase for HFile

2019-06-17 Thread GitBox
liuzx32 commented on issue #657: adjust HBase tableName toUpperCase for HFile URL: https://github.com/apache/kylin/pull/657#issuecomment-502587332 @nichunen Because HBase tableName is case sensitive. HBase tableName.toUpperCase() will different from the original table, leading to table

[GitHub] [kylin] nichunen commented on a change in pull request #629: KYLIN-3983 Add extra metadata for measure. Add test case and example/…

2019-05-09 Thread GitBox
nichunen commented on a change in pull request #629: KYLIN-3983 Add extra metadata for measure. Add test case and example/… URL: https://github.com/apache/kylin/pull/629#discussion_r282519903 ## File path: core-cube/src/main/java/org/apache/kylin/measure/MeasureManager.java

[GitHub] [kylin] nichunen commented on a change in pull request #629: KYLIN-3983 Add extra metadata for measure. Add test case and example/…

2019-05-09 Thread GitBox
nichunen commented on a change in pull request #629: KYLIN-3983 Add extra metadata for measure. Add test case and example/… URL: https://github.com/apache/kylin/pull/629#discussion_r282483148 ## File path: core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java ##

[GitHub] [kylin] nichunen commented on a change in pull request #629: KYLIN-3983 Add extra metadata for measure. Add test case and example/…

2019-05-09 Thread GitBox
nichunen commented on a change in pull request #629: KYLIN-3983 Add extra metadata for measure. Add test case and example/… URL: https://github.com/apache/kylin/pull/629#discussion_r282517673 ## File path: core-cube/src/main/java/org/apache/kylin/measure/MeasureManager.java

[GitHub] [kylin] nichunen commented on a change in pull request #629: KYLIN-3983 Add extra metadata for measure. Add test case and example/…

2019-05-09 Thread GitBox
nichunen commented on a change in pull request #629: KYLIN-3983 Add extra metadata for measure. Add test case and example/… URL: https://github.com/apache/kylin/pull/629#discussion_r282458112 ## File path: core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java

[GitHub] [kylin] nichunen commented on a change in pull request #629: KYLIN-3983 Add extra metadata for measure. Add test case and example/…

2019-05-09 Thread GitBox
nichunen commented on a change in pull request #629: KYLIN-3983 Add extra metadata for measure. Add test case and example/… URL: https://github.com/apache/kylin/pull/629#discussion_r282502592 ## File path: core-cube/src/main/java/org/apache/kylin/measure/CubeL2Cache.java

[GitHub] [kylin] nichunen merged pull request #635: KYLIN-3934 add config for sqoop config null-string and null-non-string

2019-05-09 Thread GitBox
nichunen merged pull request #635: KYLIN-3934 add config for sqoop config null-string and null-non-string URL: https://github.com/apache/kylin/pull/635 This is an automated message from the Apache Git Service. To respond to

[GitHub] [kylin] Qsimple commented on a change in pull request #629: KYLIN-3983 Add extra metadata for measure. Add test case and example/…

2019-05-09 Thread GitBox
Qsimple commented on a change in pull request #629: KYLIN-3983 Add extra metadata for measure. Add test case and example/… URL: https://github.com/apache/kylin/pull/629#discussion_r282714032 ## File path: core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java ##

[GitHub] [kylin] codecov-io commented on issue #637: KYLIN-3998 Make "bpus-min-benefit-ratio" configurable in cube planner phase 1

2019-05-09 Thread GitBox
codecov-io commented on issue #637: KYLIN-3998 Make "bpus-min-benefit-ratio" configurable in cube planner phase 1 URL: https://github.com/apache/kylin/pull/637#issuecomment-491114316 # [Codecov](https://codecov.io/gh/apache/kylin/pull/637?src=pr=h1) Report > :exclamation: No coverage

[GitHub] [kylin] Wayne1c opened a new pull request #637: KYLIN-3998 Make "bpus-min-benefit-ratio" configurable in cube planner phase 1

2019-05-09 Thread GitBox
Wayne1c opened a new pull request #637: KYLIN-3998 Make "bpus-min-benefit-ratio" configurable in cube planner phase 1 URL: https://github.com/apache/kylin/pull/637 …hase 1 This is an automated message from the Apache Git

[GitHub] [kylin] asfgit commented on issue #637: KYLIN-3998 Make "bpus-min-benefit-ratio" configurable in cube planner phase 1

2019-05-09 Thread GitBox
asfgit commented on issue #637: KYLIN-3998 Make "bpus-min-benefit-ratio" configurable in cube planner phase 1 URL: https://github.com/apache/kylin/pull/637#issuecomment-491110024 Can one of the admins verify this patch? This

[GitHub] [kylin] Qsimple commented on issue #629: KYLIN-3983 Add extra metadata for measure. Add test case and example/…

2019-05-09 Thread GitBox
Qsimple commented on issue #629: KYLIN-3983 Add extra metadata for measure. Add test case and example/… URL: https://github.com/apache/kylin/pull/629#issuecomment-490970062 Yes, I agree with you. Another PR will be prepared to replace this one. Tks for you, chunen

[GitHub] [kylin] coveralls edited a comment on issue #631: Add additional unit tests

2019-05-09 Thread GitBox
coveralls edited a comment on issue #631: Add additional unit tests URL: https://github.com/apache/kylin/pull/631#issuecomment-490178792 ## Pull Request Test Coverage Report for [Build 4480](https://coveralls.io/builds/23288694) * **0** of **0** changed or added relevant lines in

[GitHub] [kylin] nichunen merged pull request #637: KYLIN-3998 Make "bpus-min-benefit-ratio" configurable in cube planner phase 1

2019-05-11 Thread GitBox
nichunen merged pull request #637: KYLIN-3998 Make "bpus-min-benefit-ratio" configurable in cube planner phase 1 URL: https://github.com/apache/kylin/pull/637 This is an automated message from the Apache Git Service. To

[GitHub] [kylin] asfgit commented on issue #636: Modify the display format of 'Get job list' api

2019-05-09 Thread GitBox
asfgit commented on issue #636: Modify the display format of 'Get job list' api URL: https://github.com/apache/kylin/pull/636#issuecomment-490797168 Can one of the admins verify this patch? This is an automated message from

[GitHub] [kylin] GinaZhai opened a new pull request #636: Modify the display format of 'Get job list' api

2019-05-09 Thread GitBox
GinaZhai opened a new pull request #636: Modify the display format of 'Get job list' api URL: https://github.com/apache/kylin/pull/636 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kylin] codecov-io edited a comment on issue #624: KYLIN-4001 Allow user-specified time format using real-time

2019-05-11 Thread GitBox
codecov-io edited a comment on issue #624: KYLIN-4001 Allow user-specified time format using real-time URL: https://github.com/apache/kylin/pull/624#issuecomment-487864284 # [Codecov](https://codecov.io/gh/apache/kylin/pull/624?src=pr=h1) Report > :exclamation: No coverage uploaded for

[GitHub] [kylin] codecov-io edited a comment on issue #624: KYLIN-4001 Allow user-specified time format using real-time

2019-05-11 Thread GitBox
codecov-io edited a comment on issue #624: KYLIN-4001 Allow user-specified time format using real-time URL: https://github.com/apache/kylin/pull/624#issuecomment-487864284 # [Codecov](https://codecov.io/gh/apache/kylin/pull/624?src=pr=h1) Report > Merging

[GitHub] [kylin] hit-lacus commented on a change in pull request #624: KYLIN-4001 Allow user-specified time format using real-time

2019-05-11 Thread GitBox
hit-lacus commented on a change in pull request #624: KYLIN-4001 Allow user-specified time format using real-time URL: https://github.com/apache/kylin/pull/624#discussion_r283117876 ## File path:

[GitHub] [kylin] coveralls edited a comment on issue #624: KYLIN-4001 Allow user-specified time format using real-time

2019-05-11 Thread GitBox
coveralls edited a comment on issue #624: KYLIN-4001 Allow user-specified time format using real-time URL: https://github.com/apache/kylin/pull/624#issuecomment-487863142 ## Pull Request Test Coverage Report for [Build 4486](https://coveralls.io/builds/23331565) * **20** of **49**

[GitHub] [kylin] nichunen commented on a change in pull request #629: KYLIN-3983 Add extra metadata for measure. Add test case and example/…

2019-05-12 Thread GitBox
nichunen commented on a change in pull request #629: KYLIN-3983 Add extra metadata for measure. Add test case and example/… URL: https://github.com/apache/kylin/pull/629#discussion_r283126065 ## File path: core-cube/src/main/java/org/apache/kylin/measure/MeasureManager.java

[GitHub] [kylin] nichunen merged pull request #631: Add additional unit tests

2019-05-12 Thread GitBox
nichunen merged pull request #631: Add additional unit tests URL: https://github.com/apache/kylin/pull/631 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kylin] Qsimple commented on a change in pull request #629: KYLIN-3983 Add extra metadata for measure. Add test case and example/…

2019-05-12 Thread GitBox
Qsimple commented on a change in pull request #629: KYLIN-3983 Add extra metadata for measure. Add test case and example/… URL: https://github.com/apache/kylin/pull/629#discussion_r283127561 ## File path: core-cube/src/main/java/org/apache/kylin/measure/MeasureManager.java

[GitHub] [kylin] coveralls commented on issue #639: Add unit tests three

2019-05-13 Thread GitBox
coveralls commented on issue #639: Add unit tests three URL: https://github.com/apache/kylin/pull/639#issuecomment-491921501 ## Pull Request Test Coverage Report for [Build 4490](https://coveralls.io/builds/23356161) * **0** of **0** changed or added relevant lines in **0** files

[GitHub] [kylin] codecov-io commented on issue #639: Add unit tests three

2019-05-13 Thread GitBox
codecov-io commented on issue #639: Add unit tests three URL: https://github.com/apache/kylin/pull/639#issuecomment-491922284 # [Codecov](https://codecov.io/gh/apache/kylin/pull/639?src=pr=h1) Report > Merging [#639](https://codecov.io/gh/apache/kylin/pull/639?src=pr=desc) into

[GitHub] [kylin] asfgit commented on issue #639: Add unit tests three

2019-05-13 Thread GitBox
asfgit commented on issue #639: Add unit tests three URL: https://github.com/apache/kylin/pull/639#issuecomment-491899719 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [kylin] TheRealHaui opened a new pull request #639: Add unit tests three

2019-05-13 Thread GitBox
TheRealHaui opened a new pull request #639: Add unit tests three URL: https://github.com/apache/kylin/pull/639 Added additional Unit Tests to increase code coverage. This is an automated message from the Apache Git Service.

[GitHub] [kylin] nichunen merged pull request #638: KYLIN-3983 Add extra metadata for measure. Add test case and example/…

2019-05-13 Thread GitBox
nichunen merged pull request #638: KYLIN-3983 Add extra metadata for measure. Add test case and example/… URL: https://github.com/apache/kylin/pull/638 This is an automated message from the Apache Git Service. To respond to

[GitHub] [kylin] nichunen merged pull request #639: Add unit tests three

2019-05-13 Thread GitBox
nichunen merged pull request #639: Add unit tests three URL: https://github.com/apache/kylin/pull/639 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kylin] codecov-io commented on issue #640: Add unit tests four

2019-05-14 Thread GitBox
codecov-io commented on issue #640: Add unit tests four URL: https://github.com/apache/kylin/pull/640#issuecomment-492119779 # [Codecov](https://codecov.io/gh/apache/kylin/pull/640?src=pr=h1) Report > Merging [#640](https://codecov.io/gh/apache/kylin/pull/640?src=pr=desc) into

[GitHub] [kylin] TheRealHaui opened a new pull request #640: Add unit tests four

2019-05-14 Thread GitBox
TheRealHaui opened a new pull request #640: Add unit tests four URL: https://github.com/apache/kylin/pull/640 Added Unit Tests to improve code coverage. This is an automated message from the Apache Git Service. To respond to

[GitHub] [kylin] TempleZhou opened a new pull request #641: KYLIN-3978 InternalErrorException: null with precise count distinct

2019-05-14 Thread GitBox
TempleZhou opened a new pull request #641: KYLIN-3978 InternalErrorException: null with precise count distinct URL: https://github.com/apache/kylin/pull/641 This is an automated message from the Apache Git Service. To

[GitHub] [kylin] asfgit commented on issue #640: Add unit tests four

2019-05-14 Thread GitBox
asfgit commented on issue #640: Add unit tests four URL: https://github.com/apache/kylin/pull/640#issuecomment-492110321 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [kylin] asfgit commented on issue #641: KYLIN-3978 InternalErrorException: null with precise count distinct

2019-05-14 Thread GitBox
asfgit commented on issue #641: KYLIN-3978 InternalErrorException: null with precise count distinct URL: https://github.com/apache/kylin/pull/641#issuecomment-492110333 Can one of the admins verify this patch? This is an

[GitHub] [kylin] nichunen commented on issue #612: KYLIN-3961 Optimize TopNCounter's merge function to reduce TopNCounter's error size.

2019-05-14 Thread GitBox
nichunen commented on issue #612: KYLIN-3961 Optimize TopNCounter's merge function to reduce TopNCounter's error size. URL: https://github.com/apache/kylin/pull/612#issuecomment-492491490 Hi @zhaojintaozhao I agree that your pr will increase the accuracy of the counter number in

[GitHub] [kylin] nichunen merged pull request #641: KYLIN-3978 InternalErrorException: null with precise count distinct

2019-05-15 Thread GitBox
nichunen merged pull request #641: KYLIN-3978 InternalErrorException: null with precise count distinct URL: https://github.com/apache/kylin/pull/641 This is an automated message from the Apache Git Service. To respond to

[GitHub] [kylin] codecov-io edited a comment on issue #645: Add unit tests five

2019-05-18 Thread GitBox
codecov-io edited a comment on issue #645: Add unit tests five URL: https://github.com/apache/kylin/pull/645#issuecomment-493550575 # [Codecov](https://codecov.io/gh/apache/kylin/pull/645?src=pr=h1) Report > Merging [#645](https://codecov.io/gh/apache/kylin/pull/645?src=pr=desc) into

[GitHub] [kylin] coveralls commented on issue #645: Add unit tests five

2019-05-18 Thread GitBox
coveralls commented on issue #645: Add unit tests five URL: https://github.com/apache/kylin/pull/645#issuecomment-493675333 ## Pull Request Test Coverage Report for [Build 4510](https://coveralls.io/builds/23468162) * **0** of **0** changed or added relevant lines in **0** files

[GitHub] [kylin] coveralls edited a comment on issue #645: Add unit tests five

2019-05-18 Thread GitBox
coveralls edited a comment on issue #645: Add unit tests five URL: https://github.com/apache/kylin/pull/645#issuecomment-493675333 ## Pull Request Test Coverage Report for [Build 4511](https://coveralls.io/builds/23468323) * **0** of **0** changed or added relevant lines in **0**

[GitHub] [kylin] asfgit commented on issue #653: minor, switch to openjdk8 for travis

2019-05-22 Thread GitBox
asfgit commented on issue #653: minor, switch to openjdk8 for travis URL: https://github.com/apache/kylin/pull/653#issuecomment-494814406 Can one of the admins verify this patch? This is an automated message from the Apache

[GitHub] [kylin] shaofengshi opened a new pull request #653: minor, switch to openjdk8 for travis

2019-05-22 Thread GitBox
shaofengshi opened a new pull request #653: minor, switch to openjdk8 for travis URL: https://github.com/apache/kylin/pull/653 This is an automated message from the Apache Git Service. To respond to the message, please log

<    16   17   18   19   20   21   22   23   24   25   >