[jira] [Commented] (KYLIN-2971) Fix the wrong "Realization Names" in logQuery when hit cache
[
https://issues.apache.org/jira/browse/KYLIN-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185685#comment-17185685
]
ASF subversion and git services commented on KYLIN-2971:
Commit ff338de3d3fcd30508b8973bc740d0daf5da597d in kylin's branch
refs/heads/kylin-on-parquet-v2 from Zhichao Zhang
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=ff338de ]
KYLIN-2971 Fix the wrong "Realization Names" and missing "Cuboid Ids" in
logQuery when hit cache
Problems:
1. The value of "Realization Names" in logQuery is wrong when query two
different sqls within the same thread and second sql hits cache:
Example:
1). query Q1 hit project P1 and cube C1;
2). query Q2 hit project P2 and cube C2 in the same thread with Q1;
3). Q1 comes again and hits cache, it will show project P1 and cube C2.
However, it should be cube C1.
2. Missing "Cuboid Ids" in logQuery when hit cache in a new thread which does
not have OLAPContext;
Solutions:
1. Call 'OLAPContext.clearThreadLocalContexts()' before a query starts;
2. Get "Cuboid Ids" from SQLResponse when
"OLAPContext.getThreadLocalContexts()" is null;
(cherry picked from commit b8d55d08301779885dd6418651c979ccaaaf6165)
> Fix the wrong "Realization Names" in logQuery when hit cache
>
>
> Key: KYLIN-2971
> URL: https://issues.apache.org/jira/browse/KYLIN-2971
> Project: Kylin
> Issue Type: Bug
>Reporter: Zhong Yanghong
>Assignee: Zhichao Zhang
>Priority: Minor
> Fix For: v3.1.0
>
> Attachments: APACHE-KYLIN-2971.patch
>
>
> # The value of "Realization Names" in logQuery is wrong when query two
> different sqls within the same thread and second sql hits cache:
> Example:
> 1). query Q1 hit project P1 and cube C1;
> 2). query Q2 hit project P2 and cube C2 in the same thread with Q1;
> 3). Q1 comes again and hits cache, it will show project P1 and
> {color:#f79232}cube C2{color}. However, it should be {color:#f79232}cube
> C1{color}.
> # Missing "Cuboid Ids" in logQuery when hit cache in a new thread which does
> not have OLAPContext;
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (KYLIN-2971) Fix the wrong "Realization Names" in logQuery when hit cache
[
https://issues.apache.org/jira/browse/KYLIN-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114090#comment-17114090
]
ASF GitHub Bot commented on KYLIN-2971:
---
kyotoYaho commented on pull request #1215:
URL: https://github.com/apache/kylin/pull/1215#issuecomment-632721375
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix the wrong "Realization Names" in logQuery when hit cache
>
>
> Key: KYLIN-2971
> URL: https://issues.apache.org/jira/browse/KYLIN-2971
> Project: Kylin
> Issue Type: Bug
>Reporter: Zhong Yanghong
>Assignee: Zhichao Zhang
>Priority: Minor
> Fix For: v3.1.0
>
> Attachments: APACHE-KYLIN-2971.patch
>
>
> # The value of "Realization Names" in logQuery is wrong when query two
> different sqls within the same thread and second sql hits cache:
> Example:
> 1). query Q1 hit project P1 and cube C1;
> 2). query Q2 hit project P2 and cube C2 in the same thread with Q1;
> 3). Q1 comes again and hits cache, it will show project P1 and
> {color:#f79232}cube C2{color}. However, it should be {color:#f79232}cube
> C1{color}.
> # Missing "Cuboid Ids" in logQuery when hit cache in a new thread which does
> not have OLAPContext;
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (KYLIN-2971) Fix the wrong "Realization Names" in logQuery when hit cache
[
https://issues.apache.org/jira/browse/KYLIN-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114072#comment-17114072
]
ASF GitHub Bot commented on KYLIN-2971:
---
shaofengshi merged pull request #1215:
URL: https://github.com/apache/kylin/pull/1215
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix the wrong "Realization Names" in logQuery when hit cache
>
>
> Key: KYLIN-2971
> URL: https://issues.apache.org/jira/browse/KYLIN-2971
> Project: Kylin
> Issue Type: Bug
>Reporter: Zhong Yanghong
>Assignee: Zhichao Zhang
>Priority: Minor
> Fix For: v3.1.0
>
> Attachments: APACHE-KYLIN-2971.patch
>
>
> # The value of "Realization Names" in logQuery is wrong when query two
> different sqls within the same thread and second sql hits cache:
> Example:
> 1). query Q1 hit project P1 and cube C1;
> 2). query Q2 hit project P2 and cube C2 in the same thread with Q1;
> 3). Q1 comes again and hits cache, it will show project P1 and
> {color:#f79232}cube C2{color}. However, it should be {color:#f79232}cube
> C1{color}.
> # Missing "Cuboid Ids" in logQuery when hit cache in a new thread which does
> not have OLAPContext;
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (KYLIN-2971) Fix the wrong "Realization Names" in logQuery when hit cache
[
https://issues.apache.org/jira/browse/KYLIN-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114073#comment-17114073
]
ASF subversion and git services commented on KYLIN-2971:
Commit b8d55d08301779885dd6418651c979ccaaaf6165 in kylin's branch
refs/heads/master from Zhichao Zhang
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=b8d55d0 ]
KYLIN-2971 Fix the wrong "Realization Names" and missing "Cuboid Ids" in
logQuery when hit cache
Problems:
1. The value of "Realization Names" in logQuery is wrong when query two
different sqls within the same thread and second sql hits cache:
Example:
1). query Q1 hit project P1 and cube C1;
2). query Q2 hit project P2 and cube C2 in the same thread with Q1;
3). Q1 comes again and hits cache, it will show project P1 and cube C2.
However, it should be cube C1.
2. Missing "Cuboid Ids" in logQuery when hit cache in a new thread which does
not have OLAPContext;
Solutions:
1. Call 'OLAPContext.clearThreadLocalContexts()' before a query starts;
2. Get "Cuboid Ids" from SQLResponse when
"OLAPContext.getThreadLocalContexts()" is null;
> Fix the wrong "Realization Names" in logQuery when hit cache
>
>
> Key: KYLIN-2971
> URL: https://issues.apache.org/jira/browse/KYLIN-2971
> Project: Kylin
> Issue Type: Bug
>Reporter: Zhong Yanghong
>Assignee: Zhichao Zhang
>Priority: Minor
> Fix For: v3.1.0
>
> Attachments: APACHE-KYLIN-2971.patch
>
>
> # The value of "Realization Names" in logQuery is wrong when query two
> different sqls within the same thread and second sql hits cache:
> Example:
> 1). query Q1 hit project P1 and cube C1;
> 2). query Q2 hit project P2 and cube C2 in the same thread with Q1;
> 3). Q1 comes again and hits cache, it will show project P1 and
> {color:#f79232}cube C2{color}. However, it should be {color:#f79232}cube
> C1{color}.
> # Missing "Cuboid Ids" in logQuery when hit cache in a new thread which does
> not have OLAPContext;
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (KYLIN-2971) Fix the wrong "Realization Names" in logQuery when hit cache
[ https://issues.apache.org/jira/browse/KYLIN-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113313#comment-17113313 ] ASF GitHub Bot commented on KYLIN-2971: --- codecov-commenter edited a comment on pull request #1215: URL: https://github.com/apache/kylin/pull/1215#issuecomment-631180807 # [Codecov](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=h1) Report > Merging [#1215](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/7886a2498178ded085497d6204b4b367f56ce0c8=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1215 +/- ## - Coverage 24.85% 24.83% -0.03% + Complexity 6266 6263 -3 Files 1453 1453 Lines 8922589237 +12 Branches 1245612458 +2 - Hits 2218122165 -16 - Misses6486964892 +23 - Partials 2175 2180 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...va/org/apache/kylin/rest/service/QueryService.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9RdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0.00%> (-5.41%)` | `6.00% <0.00%> (-1.00%)` | | | [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `35.71% <0.00%> (-4.77%)` | `5.00% <0.00%> (-1.00%)` | | | [...che/kylin/stream/core/storage/CheckPointStore.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvQ2hlY2tQb2ludFN0b3JlLmphdmE=) | `63.63% <0.00%> (-3.04%)` | `21.00% <0.00%> (-1.00%)` | | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0.00%> (-2.31%)` | `0.00% <0.00%> (ø%)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.30% <0.00%> (-1.83%)` | `7.00% <0.00%> (ø%)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=footer). Last update [7886a24...2ef96ec](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix the wrong "Realization Names" in logQuery when hit cache > > > Key: KYLIN-2971 > URL: https://issues.apache.org/jira/browse/KYLIN-2971 > Project: Kylin > Issue Type: Bug >Reporter: Zhong Yanghong >Assignee: Zhichao Zhang >Priority: Minor > Fix For: v3.1.0 > > Attachments: APACHE-KYLIN-2971.patch > > > # The value of "Realization Names" in logQuery is wrong when query two > different sqls within the same thread and second sql hits cache: > Example: > 1). query Q1 hit project P1 and cube
[jira] [Commented] (KYLIN-2971) Fix the wrong "Realization Names" in logQuery when hit cache
[
https://issues.apache.org/jira/browse/KYLIN-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113307#comment-17113307
]
ASF GitHub Bot commented on KYLIN-2971:
---
coveralls edited a comment on pull request #1215:
URL: https://github.com/apache/kylin/pull/1215#issuecomment-631164387
## Pull Request Test Coverage Report for [Build
5929](https://coveralls.io/builds/30947782)
* **0** of **13** **(0.0%)** changed or added relevant lines in **1**
file are covered.
* **5** unchanged lines in **3** files lost coverage.
* Overall coverage decreased (**-0.009%**) to **27.285%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-|--||---: |
|
[server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java](https://coveralls.io/builds/30947782/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FQueryService.java#L338)
| 0 | 13 | 0.0%
| Files with Coverage Reduction | New Missed Lines | % |
| :-|--|--: |
|
[core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/30947782/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62)
| 1 | 81.08% |
|
[core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/30947782/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124)
| 2 | 68.46% |
|
[stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java](https://coveralls.io/builds/30947782/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2FCheckPointStore.java#L98)
| 2 | 73.74% |
| Totals | [](https://coveralls.io/builds/30947782)
|
| :-- | --: |
| Change from base [Build 5911](https://coveralls.io/builds/30861301): |
-0.009% |
| Covered Lines: | 24348 |
| Relevant Lines: | 89237 |
---
# - [Coveralls](https://coveralls.io)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix the wrong "Realization Names" in logQuery when hit cache
>
>
> Key: KYLIN-2971
> URL: https://issues.apache.org/jira/browse/KYLIN-2971
> Project: Kylin
> Issue Type: Bug
>Reporter: Zhong Yanghong
>Assignee: Zhichao Zhang
>Priority: Minor
> Fix For: v3.1.0
>
> Attachments: APACHE-KYLIN-2971.patch
>
>
> # The value of "Realization Names" in logQuery is wrong when query two
> different sqls within the same thread and second sql hits cache:
> Example:
> 1). query Q1 hit project P1 and cube C1;
> 2). query Q2 hit project P2 and cube C2 in the same thread with Q1;
> 3). Q1 comes again and hits cache, it will show project P1 and
> {color:#f79232}cube C2{color}. However, it should be {color:#f79232}cube
> C1{color}.
> # Missing "Cuboid Ids" in logQuery when hit cache in a new thread which does
> not have OLAPContext;
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (KYLIN-2971) Fix the wrong "Realization Names" in logQuery when hit cache
[
https://issues.apache.org/jira/browse/KYLIN-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113191#comment-17113191
]
ASF GitHub Bot commented on KYLIN-2971:
---
coveralls edited a comment on pull request #1215:
URL: https://github.com/apache/kylin/pull/1215#issuecomment-631164387
## Pull Request Test Coverage Report for [Build
5927](https://coveralls.io/builds/30944339)
* **0** of **13** **(0.0%)** changed or added relevant lines in **1**
file are covered.
* **5** unchanged lines in **2** files lost coverage.
* Overall coverage decreased (**-0.004%**) to **27.29%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-|--||---: |
|
[server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java](https://coveralls.io/builds/30944339/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FQueryService.java#L338)
| 0 | 13 | 0.0%
| Files with Coverage Reduction | New Missed Lines | % |
| :-|--|--: |
|
[stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java](https://coveralls.io/builds/30944339/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2FCheckPointStore.java#L98)
| 2 | 73.74% |
|
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/30944339/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449)
| 3 | 78.42% |
| Totals | [](https://coveralls.io/builds/30944339)
|
| :-- | --: |
| Change from base [Build 5911](https://coveralls.io/builds/30861301): |
-0.004% |
| Covered Lines: | 24353 |
| Relevant Lines: | 89237 |
---
# - [Coveralls](https://coveralls.io)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix the wrong "Realization Names" in logQuery when hit cache
>
>
> Key: KYLIN-2971
> URL: https://issues.apache.org/jira/browse/KYLIN-2971
> Project: Kylin
> Issue Type: Bug
>Reporter: Zhong Yanghong
>Assignee: Zhichao Zhang
>Priority: Minor
> Fix For: v3.1.0
>
> Attachments: APACHE-KYLIN-2971.patch
>
>
> # The value of "Realization Names" in logQuery is wrong when query two
> different sqls within the same thread and second sql hits cache:
> Example:
> 1). query Q1 hit project P1 and cube C1;
> 2). query Q2 hit project P2 and cube C2 in the same thread with Q1;
> 3). Q1 comes again and hits cache, it will show project P1 and
> {color:#f79232}cube C2{color}. However, it should be {color:#f79232}cube
> C1{color}.
> # Missing "Cuboid Ids" in logQuery when hit cache in a new thread which does
> not have OLAPContext;
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (KYLIN-2971) Fix the wrong "Realization Names" in logQuery when hit cache
[ https://issues.apache.org/jira/browse/KYLIN-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17111662#comment-17111662 ] ASF GitHub Bot commented on KYLIN-2971: --- codecov-commenter commented on pull request #1215: URL: https://github.com/apache/kylin/pull/1215#issuecomment-631180807 # [Codecov](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=h1) Report > Merging [#1215](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/7886a2498178ded085497d6204b4b367f56ce0c8=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1215 +/- ## - Coverage 24.85% 24.84% -0.02% + Complexity 6266 6263 -3 Files 1453 1453 Lines 8922589236 +11 Branches 1245612458 +2 - Hits 2217522168 -7 - Misses6487464888 +14 - Partials 2176 2180 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...va/org/apache/kylin/rest/service/QueryService.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9RdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0.00%> (-5.41%)` | `6.00% <0.00%> (-1.00%)` | | | [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `35.71% <0.00%> (-4.77%)` | `5.00% <0.00%> (-1.00%)` | | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0.00%> (-2.31%)` | `0.00% <0.00%> (ø%)` | | | [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `50.00% <0.00%> (-2.28%)` | `7.00% <0.00%> (-1.00%)` | | | [...ain/java/org/apache/kylin/dict/TrieDictionary.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L1RyaWVEaWN0aW9uYXJ5LmphdmE=) | `72.55% <0.00%> (-0.47%)` | `56.00% <0.00%> (-1.00%)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.60% <0.00%> (+0.30%)` | `7.00% <0.00%> (ø%)` | | | [...core/storage/columnar/GeneralColumnDataReader.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvR2VuZXJhbENvbHVtbkRhdGFSZWFkZXIuamF2YQ==) | `94.73% <0.00%> (+5.26%)` | `7.00% <0.00%> (+1.00%)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=footer). Last update [7886a24...87cd508](https://codecov.io/gh/apache/kylin/pull/1215?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix the wrong "Realization Names" in logQuery
[jira] [Commented] (KYLIN-2971) Fix the wrong "Realization Names" in logQuery when hit cache
[
https://issues.apache.org/jira/browse/KYLIN-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17111647#comment-17111647
]
ASF GitHub Bot commented on KYLIN-2971:
---
coveralls commented on pull request #1215:
URL: https://github.com/apache/kylin/pull/1215#issuecomment-631164387
## Pull Request Test Coverage Report for [Build
5915](https://coveralls.io/builds/30905195)
* **0** of **12** **(0.0%)** changed or added relevant lines in **1**
file are covered.
* **8** unchanged lines in **4** files lost coverage.
* Overall coverage decreased (**-0.006%**) to **27.288%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-|--||---: |
|
[server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java](https://coveralls.io/builds/30905195/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FQueryService.java#L337)
| 0 | 12 | 0.0%
| Files with Coverage Reduction | New Missed Lines | % |
| :-|--|--: |
|
[core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/30905195/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62)
| 1 | 81.08% |
|
[stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/30905195/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L146)
| 1 | 56.82% |
|
[core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/30905195/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124)
| 2 | 68.46% |
|
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/30905195/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449)
| 4 | 78.12% |
| Totals | [](https://coveralls.io/builds/30905195)
|
| :-- | --: |
| Change from base [Build 5911](https://coveralls.io/builds/30861301): |
-0.006% |
| Covered Lines: | 24351 |
| Relevant Lines: | 89236 |
---
# - [Coveralls](https://coveralls.io)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix the wrong "Realization Names" in logQuery when hit cache
>
>
> Key: KYLIN-2971
> URL: https://issues.apache.org/jira/browse/KYLIN-2971
> Project: Kylin
> Issue Type: Bug
>Reporter: Zhong Yanghong
>Assignee: Zhichao Zhang
>Priority: Minor
> Fix For: v3.1.0
>
> Attachments: APACHE-KYLIN-2971.patch
>
>
> # The value of "Realization Names" in logQuery is wrong when query two
> different sqls within the same thread and second sql hits cache:
> Example:
> 1). query Q1 hit project P1 and cube C1;
> 2). query Q2 hit project P2 and cube C2 in the same thread with Q1;
> 3). Q1 comes again and hits cache, it will show project P1 and
> {color:#f79232}cube C2{color}. However, it should be {color:#f79232}cube
> C1{color}.
> # Missing "Cuboid Ids" in logQuery when hit cache in a new thread which does
> not have OLAPContext;
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (KYLIN-2971) Fix the wrong "Realization Names" in logQuery when hit cache
[
https://issues.apache.org/jira/browse/KYLIN-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17111634#comment-17111634
]
ASF GitHub Bot commented on KYLIN-2971:
---
zzcclp opened a new pull request #1215:
URL: https://github.com/apache/kylin/pull/1215
**Problems:**
1. The value of "Realization Names" in logQuery is wrong when query two
different sqls within the same thread and second sql hits cache:
Example:
1). query Q1 hit project P1 and cube C1;
2). query Q2 hit project P2 and cube C2 in the same thread with Q1;
3). Q1 comes again and hits cache, it will show project P1 and cube C2.
However, it should be cube C1.
2. Missing "Cuboid Ids" in logQuery when hit cache in a new thread which
does not have OLAPContext;
**Solutions:**
1. Call 'OLAPContext.clearThreadLocalContexts()' before a query starts;
2. Get "Cuboid Ids" from SQLResponse when
"OLAPContext.getThreadLocalContexts()" is null;
## Proposed changes
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug or
resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to Kylin?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to ask.
We're here to help! This is simply a reminder of what we are going to look for
before merging your code._
- [ ] I have create an issue on [Kylin's
jira](https://issues.apache.org/jira/browse/KYLIN), and have described the
bug/feature there in detail
- [ ] Commit messages in my PR start with the related jira ID, like
"KYLIN- Make Kylin project open-source"
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature
works
- [ ] If this change need a document change, I will prepare another pr
against the `document` branch
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at
user@kylin or dev@kylin by explaining why you chose the solution you did and
what alternatives you considered, etc...
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix the wrong "Realization Names" in logQuery when hit cache
>
>
> Key: KYLIN-2971
> URL: https://issues.apache.org/jira/browse/KYLIN-2971
> Project: Kylin
> Issue Type: Bug
>Reporter: Zhong Yanghong
>Assignee: Zhichao Zhang
>Priority: Minor
> Fix For: v3.1.0
>
> Attachments: APACHE-KYLIN-2971.patch
>
>
> OLAPContext.clearThreadLocalContexts() should be called before a query
> starts. And we should consider query hit cache.
> Example,
> # query Q1 hit project P1 and cube C1;
> # then query Q2 hit project P2 and cube C2;
> # then Q1 comes again, it will show project P1 and {color:#f79232}cube
> C2{color}. However, it should be {color:#f79232}cube C1{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (KYLIN-2971) Fix the wrong "Realization Names" in logQuery when hit cache
[
https://issues.apache.org/jira/browse/KYLIN-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049826#comment-17049826
]
Zhong Yanghong commented on KYLIN-2971:
---
It seems this patch is overridden by other patches.
> Fix the wrong "Realization Names" in logQuery when hit cache
>
>
> Key: KYLIN-2971
> URL: https://issues.apache.org/jira/browse/KYLIN-2971
> Project: Kylin
> Issue Type: Bug
>Reporter: Zhong Yanghong
>Assignee: Zhong Yanghong
>Priority: Major
> Fix For: v2.3.0
>
> Attachments: APACHE-KYLIN-2971.patch
>
>
> OLAPContext.clearThreadLocalContexts() should be called before a query
> starts. And we should consider query hit cache.
> Example,
> # query Q1 hit project P1 and cube C1;
> # then query Q2 hit project P2 and cube C2;
> # then Q1 comes again, it will show project P1 and {color:#f79232}cube
> C2{color}. However, it should be {color:#f79232}cube C1{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
