[jira] [Commented] (KYLIN-2924) Utilize error-prone to discover common coding mistakes
[ https://issues.apache.org/jira/browse/KYLIN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728249#comment-16728249 ] Billy Liu commented on KYLIN-2924: -- [~yaho] I think [~Shaofengshi] has disabled this feature, to avoid too much log. > Utilize error-prone to discover common coding mistakes > -- > > Key: KYLIN-2924 > URL: https://issues.apache.org/jira/browse/KYLIN-2924 > Project: Kylin > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Billy Liu >Priority: Major > Fix For: v2.6.0 > > > http://errorprone.info/ is a tool which detects common coding mistakes. > We should incorporate into Kylin build. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2924) Utilize error-prone to discover common coding mistakes
[ https://issues.apache.org/jira/browse/KYLIN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728231#comment-16728231 ] Zhong Yanghong commented on KYLIN-2924: --- Hi [~yimingliu], what's the status of this? > Utilize error-prone to discover common coding mistakes > -- > > Key: KYLIN-2924 > URL: https://issues.apache.org/jira/browse/KYLIN-2924 > Project: Kylin > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Billy Liu >Priority: Major > Fix For: v2.6.0 > > > http://errorprone.info/ is a tool which detects common coding mistakes. > We should incorporate into Kylin build. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2924) Utilize error-prone to discover common coding mistakes
[
https://issues.apache.org/jira/browse/KYLIN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642696#comment-16642696
]
ASF GitHub Bot commented on KYLIN-2924:
---
shaofengshi closed pull request #281: KYLIN-2924 disable google error-prone for
travis-ci
URL: https://github.com/apache/kylin/pull/281
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/pom.xml b/pom.xml
index f35191f55b..c973d1abce 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1303,27 +1303,7 @@
true
1024m
2048m
- javac-with-errorprone
- true
-
- ${javaVersion}
- ${javaVersion}
-
--XepDisableWarningsInGeneratedCode
-
-
-
-org.codehaus.plexus
-plexus-compiler-javac-errorprone
-2.8.5
-
-
-com.google.errorprone
-error_prone_core
-2.3.1
-
-
@@ -1470,115 +1450,95 @@
true
1024m
2048m
- javac-with-errorprone
- true
-
- ${javaVersion}
- ${javaVersion}
-
--XepDisableWarningsInGeneratedCode
-
-
-
-org.codehaus.plexus
-plexus-compiler-javac-errorprone
-2.8.5
-
-
-com.google.errorprone
-error_prone_core
-2.3.1
-
-
-
-
-
-org.apache.maven.plugins
-maven-dependency-plugin
-
-
-copy-jamm
-
- copy
-
-generate-test-resources
-
-
-
- com.github.jbellis
- jamm
- ${project.build.testOutputDirectory}
-
- jamm.jar
-
-
-
-
-
-
-org.jacoco
-jacoco-maven-plugin
-
- true
-
-${sonar.jacoco.reportPaths}
-
-
-
-
-pre-test
-
- prepare-agent
-
-
- surefireArgLine
-
-
-
-post-test
-test
-
- report
-
-
-
-
-
-org.apache.maven.plugins
-maven-surefire-plugin
-2.21.0
-
- ${project.basedir}/../target/surefire-reports
-
-
-**/IT*.java
-
-
-
- buildCubeUsingProvidedData
- false
-
-
- log4j.configuration
-
-
file:${project.basedir}/../build/conf/kylin-tools-log4j.properties
-
-
-
- -javaagent:${project.build.testOutputDirectory}/jamm.jar
-${argLine} ${surefireArgLine}
-
-
-
-
-
-
-
-
+
+ org.apache.maven.plugins
+ maven-dependency-plugin
+
+
+ copy-jamm
+
+copy
+
+ generate-test-resources
+
+
+
+com.github.jbellis
+jamm
+${project.build.testOutputDirectory}
+
+jamm.jar
+
+
+
+
+
+
+
+
+ org.jacoco
+ jacoco-maven-plugin
+
+true
+
+ ${sonar.jacoco.reportPaths}
+
+
+
+
+ pre-test
+
+prepare-agent
+
+
+surefireArgLine
+
+
+
+ post-test
+ test
+
+report
+
+
+
+
+
+ org.apache.maven.plugins
+ maven-surefire-plugin
+ 2.21.0
+
+${project.basedir}/../target/surefire-reports
+
[jira] [Commented] (KYLIN-2924) Utilize error-prone to discover common coding mistakes
[ https://issues.apache.org/jira/browse/KYLIN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641548#comment-16641548 ] ASF GitHub Bot commented on KYLIN-2924: --- coveralls commented on issue #281: KYLIN-2924 disable google error-prone for travis-ci URL: https://github.com/apache/kylin/pull/281#issuecomment-427762555 ## Pull Request Test Coverage Report for [Build 3742](https://coveralls.io/builds/19399562) * **0** of **0** changed or added relevant lines in **0** files are covered. * **21** unchanged lines in **6** files lost coverage. * Overall coverage increased (+**0.01%**) to **23.306%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [atopcalcite/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java](https://coveralls.io/builds/19399562/source?filename=atopcalcite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcalcite%2Fsql%2Ftype%2FSqlTypeUtil.java#L844) | 1 | 0.0% | | [atopcalcite/src/main/java/org/apache/calcite/tools/Programs.java](https://coveralls.io/builds/19399562/source?filename=atopcalcite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcalcite%2Ftools%2FPrograms.java#L328) | 1 | 0.0% | | [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/19399562/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L64) | 1 | 81.08% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/19399562/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 4 | 78.12% | | [atopcalcite/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java](https://coveralls.io/builds/19399562/source?filename=atopcalcite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcalcite%2Fsql2rel%2FSqlToRelConverter.java#L1593) | 7 | 0.0% | | [atopcalcite/src/main/java/org/apache/calcite/prepare/CalcitePrepareImpl.java](https://coveralls.io/builds/19399562/source?filename=atopcalcite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcalcite%2Fprepare%2FCalcitePrepareImpl.java#L311) | 7 | 0.0% | | Totals | [](https://coveralls.io/builds/19399562) | | :-- | --: | | Change from base [Build 3738](https://coveralls.io/builds/19396624): | 0.01% | | Covered Lines: | 16295 | | Relevant Lines: | 69919 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Utilize error-prone to discover common coding mistakes > -- > > Key: KYLIN-2924 > URL: https://issues.apache.org/jira/browse/KYLIN-2924 > Project: Kylin > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Billy Liu >Priority: Major > Fix For: v2.6.0 > > > http://errorprone.info/ is a tool which detects common coding mistakes. > We should incorporate into Kylin build. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2924) Utilize error-prone to discover common coding mistakes
[ https://issues.apache.org/jira/browse/KYLIN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641546#comment-16641546 ] ASF GitHub Bot commented on KYLIN-2924: --- codecov-io commented on issue #281: KYLIN-2924 disable google error-prone for travis-ci URL: https://github.com/apache/kylin/pull/281#issuecomment-427762253 # [Codecov](https://codecov.io/gh/apache/kylin/pull/281?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@09c5668`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/kylin/pull/281?src=pr=tree) ```diff @@Coverage Diff@@ ## master #281 +/- ## = Coverage ? 21.29% Complexity? 4436 = Files ? 1087 Lines ?69919 Branches ?10101 = Hits ?14889 Misses?53626 Partials ? 1404 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/281?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/281?src=pr=footer). Last update [09c5668...7ea312f](https://codecov.io/gh/apache/kylin/pull/281?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Utilize error-prone to discover common coding mistakes > -- > > Key: KYLIN-2924 > URL: https://issues.apache.org/jira/browse/KYLIN-2924 > Project: Kylin > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Billy Liu >Priority: Major > Fix For: v2.6.0 > > > http://errorprone.info/ is a tool which detects common coding mistakes. > We should incorporate into Kylin build. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2924) Utilize error-prone to discover common coding mistakes
[ https://issues.apache.org/jira/browse/KYLIN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641513#comment-16641513 ] ASF GitHub Bot commented on KYLIN-2924: --- shaofengshi commented on issue #281: KYLIN-2924 disable google error-prone for travis-ci URL: https://github.com/apache/kylin/pull/281#issuecomment-427756893 Just try if it can make travis-ci happy This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Utilize error-prone to discover common coding mistakes > -- > > Key: KYLIN-2924 > URL: https://issues.apache.org/jira/browse/KYLIN-2924 > Project: Kylin > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Billy Liu >Priority: Major > Fix For: v2.6.0 > > > http://errorprone.info/ is a tool which detects common coding mistakes. > We should incorporate into Kylin build. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2924) Utilize error-prone to discover common coding mistakes
[ https://issues.apache.org/jira/browse/KYLIN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641511#comment-16641511 ] ASF GitHub Bot commented on KYLIN-2924: --- asfgit commented on issue #281: KYLIN-2924 disable google error-prone for travis-ci URL: https://github.com/apache/kylin/pull/281#issuecomment-427755080 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Utilize error-prone to discover common coding mistakes > -- > > Key: KYLIN-2924 > URL: https://issues.apache.org/jira/browse/KYLIN-2924 > Project: Kylin > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Billy Liu >Priority: Major > Fix For: v2.6.0 > > > http://errorprone.info/ is a tool which detects common coding mistakes. > We should incorporate into Kylin build. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2924) Utilize error-prone to discover common coding mistakes
[ https://issues.apache.org/jira/browse/KYLIN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641510#comment-16641510 ] ASF GitHub Bot commented on KYLIN-2924: --- shaofengshi opened a new pull request #281: KYLIN-2924 disable google error-prone for travis-ci URL: https://github.com/apache/kylin/pull/281 Travis-ci failed with message: " The job exceeded the maximum log length, and has been terminated." I try to disable errorprone check to reduce the log output. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Utilize error-prone to discover common coding mistakes > -- > > Key: KYLIN-2924 > URL: https://issues.apache.org/jira/browse/KYLIN-2924 > Project: Kylin > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Billy Liu >Priority: Major > Fix For: v2.6.0 > > > http://errorprone.info/ is a tool which detects common coding mistakes. > We should incorporate into Kylin build. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2924) Utilize error-prone to discover common coding mistakes
[ https://issues.apache.org/jira/browse/KYLIN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632934#comment-16632934 ] ASF GitHub Bot commented on KYLIN-2924: --- shaofengshi closed pull request #270: KYLIN-2924 enable google error-prone in compile phase URL: https://github.com/apache/kylin/pull/270 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Utilize error-prone to discover common coding mistakes > -- > > Key: KYLIN-2924 > URL: https://issues.apache.org/jira/browse/KYLIN-2924 > Project: Kylin > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Billy Liu >Priority: Major > Fix For: v2.6.0 > > > http://errorprone.info/ is a tool which detects common coding mistakes. > We should incorporate into Kylin build. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2924) Utilize error-prone to discover common coding mistakes
[ https://issues.apache.org/jira/browse/KYLIN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632935#comment-16632935 ] ASF subversion and git services commented on KYLIN-2924: Commit bd8961c884cdc8ec5a9903a1d5a317bb626a2dff in kylin's branch refs/heads/master from [~yimingliu] [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=bd8961c ] KYLIN-2924 enable google error-prone in compile phase > Utilize error-prone to discover common coding mistakes > -- > > Key: KYLIN-2924 > URL: https://issues.apache.org/jira/browse/KYLIN-2924 > Project: Kylin > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Billy Liu >Priority: Major > Fix For: v2.6.0 > > > http://errorprone.info/ is a tool which detects common coding mistakes. > We should incorporate into Kylin build. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2924) Utilize error-prone to discover common coding mistakes
[ https://issues.apache.org/jira/browse/KYLIN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632713#comment-16632713 ] ASF GitHub Bot commented on KYLIN-2924: --- yiming187 commented on issue #270: KYLIN-2924 enable google error-prone in compile phase URL: https://github.com/apache/kylin/pull/270#issuecomment-425606016 @shaofengshi yes. I saw it. I have fixed all "ERROR" level issues, but the "WARNING" issues generated too much logs. Trying to ignore the "WARNING" log to reduce the output size. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Utilize error-prone to discover common coding mistakes > -- > > Key: KYLIN-2924 > URL: https://issues.apache.org/jira/browse/KYLIN-2924 > Project: Kylin > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Billy Liu >Priority: Major > Fix For: v2.6.0 > > > http://errorprone.info/ is a tool which detects common coding mistakes. > We should incorporate into Kylin build. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2924) Utilize error-prone to discover common coding mistakes
[ https://issues.apache.org/jira/browse/KYLIN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632712#comment-16632712 ] ASF subversion and git services commented on KYLIN-2924: Commit a0941b333d88f122672bfdfd0863d7cdad4abaea in kylin's branch refs/heads/KYLIN-2924 from [~yimingliu] [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=a0941b3 ] KYLIN-2924 enable google error-prone in compile phase > Utilize error-prone to discover common coding mistakes > -- > > Key: KYLIN-2924 > URL: https://issues.apache.org/jira/browse/KYLIN-2924 > Project: Kylin > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Billy Liu >Priority: Major > Fix For: v2.6.0 > > > http://errorprone.info/ is a tool which detects common coding mistakes. > We should incorporate into Kylin build. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2924) Utilize error-prone to discover common coding mistakes
[ https://issues.apache.org/jira/browse/KYLIN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632675#comment-16632675 ] ASF GitHub Bot commented on KYLIN-2924: --- shaofengshi commented on issue #270: KYLIN-2924 enable google error-prone in compile phase URL: https://github.com/apache/kylin/pull/270#issuecomment-425600739 The travis-ci is failed with "The job exceeded the maximum log length, and has been terminated." This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Utilize error-prone to discover common coding mistakes > -- > > Key: KYLIN-2924 > URL: https://issues.apache.org/jira/browse/KYLIN-2924 > Project: Kylin > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Billy Liu >Priority: Major > Fix For: v2.6.0 > > > http://errorprone.info/ is a tool which detects common coding mistakes. > We should incorporate into Kylin build. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2924) Utilize error-prone to discover common coding mistakes
[ https://issues.apache.org/jira/browse/KYLIN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632037#comment-16632037 ] ASF GitHub Bot commented on KYLIN-2924: --- coveralls commented on issue #270: KYLIN-2924 enable google error-prone in compile phase URL: https://github.com/apache/kylin/pull/270#issuecomment-425479277 ## Pull Request Test Coverage Report for [Build 3705](https://coveralls.io/builds/19249459) * **1** of **12** **(8.33%)** changed or added relevant lines in **8** files are covered. * **79** unchanged lines in **26** files lost coverage. * Overall coverage decreased (**-0.02%**) to **23.152%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [core-common/src/main/java/org/apache/kylin/common/util/SparkEntry.java](https://coveralls.io/builds/19249459/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Futil%2FSparkEntry.java#L35) | 0 | 1 | 0.0% | [core-cube/src/main/java/org/apache/kylin/cube/model/DimensionDesc.java](https://coveralls.io/builds/19249459/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FDimensionDesc.java#L173) | 0 | 1 | 0.0% | [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/19249459/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L54) | 0 | 1 | 0.0% | [server-base/src/main/java/org/apache/kylin/rest/controller/ProjectController.java](https://coveralls.io/builds/19249459/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fcontroller%2FProjectController.java#L134) | 0 | 1 | 0.0% | [server-base/src/main/java/org/apache/kylin/rest/controller/ModelController.java](https://coveralls.io/builds/19249459/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fcontroller%2FModelController.java#L120) | 0 | 1 | 0.0% | [core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/InstantReservoir.java](https://coveralls.io/builds/19249459/source?filename=core-metrics%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetrics%2Flib%2Fimpl%2FInstantReservoir.java#L53) | 0 | 2 | 0.0% | [server-base/src/main/java/org/apache/kylin/rest/util/AclPermissionUtil.java](https://coveralls.io/builds/19249459/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Futil%2FAclPermissionUtil.java#L38) | 0 | 4 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [server-base/src/main/java/org/apache/kylin/rest/util/QueryRequestLimits.java](https://coveralls.io/builds/19249459/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Futil%2FQueryRequestLimits.java#L72) | 1 | 47.62% | | [server-base/src/main/java/org/apache/kylin/rest/util/AclPermissionUtil.java](https://coveralls.io/builds/19249459/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Futil%2FAclPermissionUtil.java#L43) | 1 | 0.0% | | [server-base/src/main/java/org/apache/kylin/rest/security/springacl/AclRecord.java](https://coveralls.io/builds/19249459/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fsecurity%2Fspringacl%2FAclRecord.java#L180) | 1 | 0.0% | | [storage-hbase/src/main/java/org/apache/kylin/storage/hbase/cube/v2/coprocessor/endpoint/CubeVisitService.java](https://coveralls.io/builds/19249459/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fcube%2Fv2%2Fcoprocessor%2Fendpoint%2FCubeVisitService.java#L367) | 1 | 0.0% | | [core-storage/src/main/java/org/apache/kylin/storage/gtrecord/GTCubeStorageQueryBase.java](https://coveralls.io/builds/19249459/source?filename=core-storage%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fgtrecord%2FGTCubeStorageQueryBase.java#L157) | 1 | 0.0% | | [core-metadata/src/main/java/org/apache/kylin/metadata/filter/CompareTupleFilter.java](https://coveralls.io/builds/19249459/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Ffilter%2FCompareTupleFilter.java#L308) | 1 | 34.0% | | [tool/src/main/java/org/apache/kylin/tool/MetadataCleanupJob.java](https://coveralls.io/builds/19249459/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2FMetadataCleanupJob.java#L61) | 1 | 0.0% | | [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/19249459/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L184) | 1 | 73.33% | |
[jira] [Commented] (KYLIN-2924) Utilize error-prone to discover common coding mistakes
[ https://issues.apache.org/jira/browse/KYLIN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631991#comment-16631991 ] ASF GitHub Bot commented on KYLIN-2924: --- asfgit commented on issue #270: KYLIN-2924 enable google error-prone in compile phase URL: https://github.com/apache/kylin/pull/270#issuecomment-425467595 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Utilize error-prone to discover common coding mistakes > -- > > Key: KYLIN-2924 > URL: https://issues.apache.org/jira/browse/KYLIN-2924 > Project: Kylin > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Billy Liu >Priority: Major > Fix For: v2.6.0 > > > http://errorprone.info/ is a tool which detects common coding mistakes. > We should incorporate into Kylin build. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2924) Utilize error-prone to discover common coding mistakes
[ https://issues.apache.org/jira/browse/KYLIN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631987#comment-16631987 ] ASF subversion and git services commented on KYLIN-2924: Commit 95e77a5af9a94ed0435024f1bc2467c9bb0edca1 in kylin's branch refs/heads/KYLIN-2924 from [~yimingliu] [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=95e77a5 ] KYLIN-2924 enable google error-prone in compile phase > Utilize error-prone to discover common coding mistakes > -- > > Key: KYLIN-2924 > URL: https://issues.apache.org/jira/browse/KYLIN-2924 > Project: Kylin > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Billy Liu >Priority: Major > Fix For: v2.6.0 > > > http://errorprone.info/ is a tool which detects common coding mistakes. > We should incorporate into Kylin build. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2924) Utilize error-prone to discover common coding mistakes
[ https://issues.apache.org/jira/browse/KYLIN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631990#comment-16631990 ] ASF GitHub Bot commented on KYLIN-2924: --- asfgit commented on issue #270: KYLIN-2924 enable google error-prone in compile phase URL: https://github.com/apache/kylin/pull/270#issuecomment-425467594 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Utilize error-prone to discover common coding mistakes > -- > > Key: KYLIN-2924 > URL: https://issues.apache.org/jira/browse/KYLIN-2924 > Project: Kylin > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Billy Liu >Priority: Major > Fix For: v2.6.0 > > > http://errorprone.info/ is a tool which detects common coding mistakes. > We should incorporate into Kylin build. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2924) Utilize error-prone to discover common coding mistakes
[ https://issues.apache.org/jira/browse/KYLIN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631989#comment-16631989 ] ASF GitHub Bot commented on KYLIN-2924: --- yiming187 opened a new pull request #270: KYLIN-2924 enable google error-prone in compile phase URL: https://github.com/apache/kylin/pull/270 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Utilize error-prone to discover common coding mistakes > -- > > Key: KYLIN-2924 > URL: https://issues.apache.org/jira/browse/KYLIN-2924 > Project: Kylin > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Billy Liu >Priority: Major > Fix For: v2.6.0 > > > http://errorprone.info/ is a tool which detects common coding mistakes. > We should incorporate into Kylin build. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
