[jira] [Updated] (LUCENE-9107) CommonsTermsQuery with huge no. of terms slower with top-k scoring

2019-12-23 Thread Tommaso Teofili (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tommaso Teofili updated LUCENE-9107: Description: In [1] a {{CommonTermsQuery}} is used in order to perform a query with lots

[jira] [Updated] (LUCENE-9107) CommonsTermsQuery with huge no. of terms slower with top-k scoring

2019-12-23 Thread Tommaso Teofili (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tommaso Teofili updated LUCENE-9107: Description: In [1] a {{CommonTermsQuery}} is used in order to perform a query with lots

[jira] [Updated] (SOLR-13808) Query DSL should let to cache filter

2019-12-23 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated SOLR-13808: Fix Version/s: 8.5 > Query DSL should let to cache filter >

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1106: LUCENE-9106: UniformSplit postings format allows extension of block/line serializers.

2019-12-23 Thread GitBox
dsmiley commented on a change in pull request #1106: LUCENE-9106: UniformSplit postings format allows extension of block/line serializers. URL: https://github.com/apache/lucene-solr/pull/1106#discussion_r361070689 ## File path:

[jira] [Commented] (SOLR-6613) TextField.analyzeMultiTerm should not throw exception when analyzer returns no term

2019-12-23 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-6613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002645#comment-17002645 ] David Smiley commented on SOLR-6613: +1 to the proposal > TextField.analyzeMultiTerm should not throw

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1105: LUCENE-9105: UniformSplit postings format detects corrupted index

2019-12-23 Thread GitBox
dsmiley commented on a change in pull request #1105: LUCENE-9105: UniformSplit postings format detects corrupted index URL: https://github.com/apache/lucene-solr/pull/1105#discussion_r361067076 ## File path:

[GitHub] [lucene-solr] dsmiley commented on issue #1109: More pervasive use of PackageLoader / PluginInfo

2019-12-23 Thread GitBox
dsmiley commented on issue #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#issuecomment-568654612 I think one of the most important next steps for Solr is that it support the vast majority of plugin abstractions, and that is the

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

2019-12-23 Thread GitBox
dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361064421 ## File path: solr/core/src/java/org/apache/solr/schema/IndexSchemaFactory.java ## @@ -62,7

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

2019-12-23 Thread GitBox
dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361064071 ## File path: solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java ## @@ -954,4

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

2019-12-23 Thread GitBox
dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361063486 ## File path: solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java ## @@ -529,6

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

2019-12-23 Thread GitBox
dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361063126 ## File path: solr/core/src/java/org/apache/solr/core/SolrCore.java ## @@ -890,7 +897,7 @@

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

2019-12-23 Thread GitBox
dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361062854 ## File path: solr/core/src/java/org/apache/solr/core/SolrCore.java ## @@ -810,28 +809,30 @@

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

2019-12-23 Thread GitBox
dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361062261 ## File path: solr/core/src/java/org/apache/solr/core/DirectoryFactory.java ## @@ -420,7 +420,7

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

2019-12-23 Thread GitBox
dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361062164 ## File path: solr/core/src/java/org/apache/solr/core/PluginBag.java ## @@ -140,11 +139,10 @@

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

2019-12-23 Thread GitBox
dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361062000 ## File path: solr/core/src/java/org/apache/solr/core/SolrCore.java ## @@ -810,28 +809,30 @@

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

2019-12-23 Thread GitBox
dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361061609 ## File path: solr/core/src/java/org/apache/solr/core/SolrCore.java ## @@ -810,28 +809,30 @@

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

2019-12-23 Thread GitBox
dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361061609 ## File path: solr/core/src/java/org/apache/solr/core/SolrCore.java ## @@ -810,28 +809,30 @@

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

2019-12-23 Thread GitBox
dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361061471 ## File path: solr/contrib/velocity/src/java/org/apache/solr/response/VelocityResponseWriter.java

[jira] [Updated] (LUCENE-9091) UnifiedHighlighter HTML escaping should only escape essentials

2019-12-23 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated LUCENE-9091: - Fix Version/s: 8.5 Resolution: Fixed Status: Resolved (was: Patch Available)

[GitHub] [lucene-solr] megancarey commented on a change in pull request #1117: SOLR-13101: ant precommit fixes

2019-12-23 Thread GitBox
megancarey commented on a change in pull request #1117: SOLR-13101: ant precommit fixes URL: https://github.com/apache/lucene-solr/pull/1117#discussion_r361037691 ## File path: solr/core/src/java/org/apache/solr/store/blob/client/LocalStorageClient.java ## @@ -97,7

[GitHub] [lucene-solr] megancarey opened a new pull request #1117: Jira/solr 13101 precommit fixes

2019-12-23 Thread GitBox
megancarey opened a new pull request #1117: Jira/solr 13101 precommit fixes URL: https://github.com/apache/lucene-solr/pull/1117 # Description This PR is just to fix precommit errors. # Solution Added licenses, updated code to remove forbidden method calls,

[jira] [Created] (SOLR-14144) add IP-based access control to securing solr page

2019-12-23 Thread Robert Muir (Jira)
Robert Muir created SOLR-14144: -- Summary: add IP-based access control to securing solr page Key: SOLR-14144 URL: https://issues.apache.org/jira/browse/SOLR-14144 Project: Solr Issue Type:

[jira] [Resolved] (SOLR-14136) add IP-based access control via environ vars

2019-12-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved SOLR-14136. Fix Version/s: 8.5 Assignee: Robert Muir Resolution: Fixed > add IP-based access

[jira] [Commented] (SOLR-14136) add IP-based access control via environ vars

2019-12-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002566#comment-17002566 ] ASF subversion and git services commented on SOLR-14136: Commit

[jira] [Commented] (SOLR-14136) add IP-based access control via environ vars

2019-12-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002565#comment-17002565 ] ASF subversion and git services commented on SOLR-14136: Commit

[jira] [Commented] (SOLR-14136) add IP-based access control via environ vars

2019-12-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002563#comment-17002563 ] ASF subversion and git services commented on SOLR-14136: Commit

[jira] [Commented] (SOLR-14136) add IP-based access control via environ vars

2019-12-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002564#comment-17002564 ] ASF subversion and git services commented on SOLR-14136: Commit

[GitHub] [lucene-solr] rmuir merged pull request #1111: SOLR-14136: ip whitelist/blacklist via env vars

2019-12-23 Thread GitBox
rmuir merged pull request #: SOLR-14136: ip whitelist/blacklist via env vars URL: https://github.com/apache/lucene-solr/pull/ This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Comment Edited] (LUCENE-9093) Unified highlighter with word separator never gives context to the left

2019-12-23 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-9093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002548#comment-17002548 ] Nándor Mátravölgyi edited comment on LUCENE-9093 at 12/24/19 12:04 AM:

[jira] [Commented] (LUCENE-9102) Add maxQueryLength option to DirectSpellchecker

2019-12-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002552#comment-17002552 ] ASF subversion and git services commented on LUCENE-9102: - Commit

[jira] [Commented] (SOLR-14138) Fix commented-out RequestLog in jetty.xml to use non-deprecated class

2019-12-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002551#comment-17002551 ] ASF subversion and git services commented on SOLR-14138: Commit

[jira] [Commented] (LUCENE-9102) Add maxQueryLength option to DirectSpellchecker

2019-12-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002550#comment-17002550 ] ASF subversion and git services commented on LUCENE-9102: - Commit

[jira] [Commented] (SOLR-14138) Fix commented-out RequestLog in jetty.xml to use non-deprecated class

2019-12-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002553#comment-17002553 ] ASF subversion and git services commented on SOLR-14138: Commit

[jira] [Commented] (LUCENE-9091) UnifiedHighlighter HTML escaping should only escape essentials

2019-12-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002554#comment-17002554 ] ASF subversion and git services commented on LUCENE-9091: - Commit

[jira] [Commented] (SOLR-14136) add IP-based access control via environ vars

2019-12-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002555#comment-17002555 ] ASF subversion and git services commented on SOLR-14136: Commit

[jira] [Commented] (LUCENE-8596) The replacement of comments is a bug, in "UserDictionary.java"

2019-12-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002549#comment-17002549 ] ASF subversion and git services commented on LUCENE-8596: - Commit

[jira] [Comment Edited] (LUCENE-9093) Unified highlighter with word separator never gives context to the left

2019-12-23 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-9093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002548#comment-17002548 ] Nándor Mátravölgyi edited comment on LUCENE-9093 at 12/24/19 12:02 AM:

[jira] [Commented] (LUCENE-9093) Unified highlighter with word separator never gives context to the left

2019-12-23 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-9093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002548#comment-17002548 ] Nándor Mátravölgyi commented on LUCENE-9093: I could look into making this a github PR

[jira] [Commented] (SOLR-14141) eliminate JKS keystore from solr SSL docs

2019-12-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002541#comment-17002541 ] Robert Muir commented on SOLR-14141: untested starter patch. just need to go thru all the steps on

[jira] [Updated] (SOLR-14095) Replace Java serialization with Javabin in Overseer operations

2019-12-23 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Eduardo Fernandez Lobbe updated SOLR-14095: - Summary: Replace Java serialization with Javabin in Overseer

[jira] [Updated] (SOLR-14141) eliminate JKS keystore from solr SSL docs

2019-12-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated SOLR-14141: --- Attachment: SOLR-14141.patch > eliminate JKS keystore from solr SSL docs >

[jira] [Resolved] (SOLR-14095) Remove serialization and/or support serialization filtering

2019-12-23 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Eduardo Fernandez Lobbe resolved SOLR-14095. -- Fix Version/s: 8.5 master (9.0)

[jira] [Commented] (SOLR-14120) Solr Admin UI breaks when using IE 11

2019-12-23 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002534#comment-17002534 ] Jan Høydahl commented on SOLR-14120: Can someone with Windows and IE11 please test this and merge for

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

2019-12-23 Thread GitBox
noblepaul commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361017640 ## File path: solr/contrib/velocity/src/java/org/apache/solr/response/VelocityResponseWriter.java

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

2019-12-23 Thread GitBox
noblepaul commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361021009 ## File path: solr/core/src/java/org/apache/solr/core/SolrCore.java ## @@ -810,28 +809,30 @@

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

2019-12-23 Thread GitBox
noblepaul commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361021437 ## File path: solr/core/src/java/org/apache/solr/core/SolrCore.java ## @@ -1408,7 +1415,7 @@

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

2019-12-23 Thread GitBox
noblepaul commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361021511 ## File path: solr/core/src/java/org/apache/solr/core/SolrCore.java ## @@ -2905,7 +2912,7 @@

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

2019-12-23 Thread GitBox
noblepaul commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361021936 ## File path: solr/core/src/java/org/apache/solr/core/TracerConfigurator.java ## @@ -43,8

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

2019-12-23 Thread GitBox
noblepaul commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361022038 ## File path: solr/core/src/java/org/apache/solr/metrics/MetricSuppliers.java ## @@ -283,7

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

2019-12-23 Thread GitBox
noblepaul commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361021700 ## File path: solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java ## @@ -529,6

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

2019-12-23 Thread GitBox
noblepaul commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361019528 ## File path: solr/core/src/java/org/apache/solr/core/PluginBag.java ## @@ -140,11 +139,10 @@

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

2019-12-23 Thread GitBox
noblepaul commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361021135 ## File path: solr/core/src/java/org/apache/solr/core/SolrCore.java ## @@ -810,28 +809,30 @@

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

2019-12-23 Thread GitBox
noblepaul commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361021908 ## File path: solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java ## @@ -954,4

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

2019-12-23 Thread GitBox
noblepaul commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361022358 ## File path: solr/core/src/java/org/apache/solr/schema/IndexSchemaFactory.java ## @@ -62,7

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

2019-12-23 Thread GitBox
noblepaul commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361020495 ## File path: solr/core/src/java/org/apache/solr/core/SolrCore.java ## @@ -519,7 +518,7 @@

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

2019-12-23 Thread GitBox
noblepaul commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361018813 ## File path: solr/core/src/java/org/apache/solr/core/DirectoryFactory.java ## @@ -420,7

[jira] [Commented] (SOLR-14095) Remove serialization and/or support serialization filtering

2019-12-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002528#comment-17002528 ] ASF subversion and git services commented on SOLR-14095: Commit

[jira] [Commented] (SOLR-14095) Remove serialization and/or support serialization filtering

2019-12-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002527#comment-17002527 ] ASF subversion and git services commented on SOLR-14095: Commit

[jira] [Commented] (LUCENE-9091) UnifiedHighlighter HTML escaping should only escape essentials

2019-12-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002519#comment-17002519 ] ASF subversion and git services commented on LUCENE-9091: - Commit

[jira] [Commented] (LUCENE-9091) UnifiedHighlighter HTML escaping should only escape essentials

2019-12-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002517#comment-17002517 ] ASF subversion and git services commented on LUCENE-9091: - Commit

[jira] [Commented] (SOLR-13101) Shared storage support in SolrCloud

2019-12-23 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002508#comment-17002508 ] Noble Paul commented on SOLR-13101: --- I would love to see a few more details   Is it a standard Solr

[jira] [Updated] (LUCENE-9093) Unified highlighter with word separator never gives context to the left

2019-12-23 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated LUCENE-9093: - Status: Patch Available (was: Open) > Unified highlighter with word separator never gives

[jira] [Commented] (LUCENE-9093) Unified highlighter with word separator never gives context to the left

2019-12-23 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002506#comment-17002506 ] David Smiley commented on LUCENE-9093: -- Sorry for the delay. Can you please post a PR as it's more

[GitHub] [lucene-solr] tflobbe opened a new pull request #1116: SOLR-14135: Utils.toJavabin returns a byte[] instead of InputStream

2019-12-23 Thread GitBox
tflobbe opened a new pull request #1116: SOLR-14135: Utils.toJavabin returns a byte[] instead of InputStream URL: https://github.com/apache/lucene-solr/pull/1116 I'm not too convinced about this PR honestly, I started thinking in doing this mostly because in the 8x branch we can't use

[GitHub] [lucene-solr] megancarey opened a new pull request #1115: SOLR-13101: Fix the gson version reference

2019-12-23 Thread GitBox
megancarey opened a new pull request #1115: SOLR-13101: Fix the gson version reference URL: https://github.com/apache/lucene-solr/pull/1115 # Description Please provide a short description of the changes you're making with this pull request. # Solution

[jira] [Commented] (SOLR-14141) eliminate JKS keystore from solr SSL docs

2019-12-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002493#comment-17002493 ] Robert Muir commented on SOLR-14141: Yes possible, but the defaults/compat change described here

[jira] [Commented] (SOLR-14141) eliminate JKS keystore from solr SSL docs

2019-12-23 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002492#comment-17002492 ] Uwe Schindler commented on SOLR-14141: -- FYI, it was always possible to run jetty with a p12

[jira] [Commented] (SOLR-14141) eliminate JKS keystore from solr SSL docs

2019-12-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002488#comment-17002488 ] Robert Muir commented on SOLR-14141: The funniest part about this is that this step 1 is really

[jira] [Comment Edited] (SOLR-13890) Add postfilter support to {!terms} queries

2019-12-23 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002424#comment-17002424 ] Joel Bernstein edited comment on SOLR-13890 at 12/23/19 8:24 PM: - The

[jira] [Comment Edited] (SOLR-13890) Add postfilter support to {!terms} queries

2019-12-23 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002424#comment-17002424 ] Joel Bernstein edited comment on SOLR-13890 at 12/23/19 8:23 PM: - The

[GitHub] [lucene-solr] andywebb1975 commented on a change in pull request #1113: SOLR-14131: adds maxQueryLength option

2019-12-23 Thread GitBox
andywebb1975 commented on a change in pull request #1113: SOLR-14131: adds maxQueryLength option URL: https://github.com/apache/lucene-solr/pull/1113#discussion_r360990276 ## File path: solr/core/src/test/org/apache/solr/spelling/DirectSolrSpellCheckerTest.java ## @@

[GitHub] [lucene-solr] andywebb1975 commented on a change in pull request #1113: SOLR-14131: adds maxQueryLength option

2019-12-23 Thread GitBox
andywebb1975 commented on a change in pull request #1113: SOLR-14131: adds maxQueryLength option URL: https://github.com/apache/lucene-solr/pull/1113#discussion_r360989706 ## File path: solr/core/src/test/org/apache/solr/spelling/DirectSolrSpellCheckerTest.java ## @@

[GitHub] [lucene-solr] andywebb1975 commented on a change in pull request #1113: SOLR-14131: adds maxQueryLength option

2019-12-23 Thread GitBox
andywebb1975 commented on a change in pull request #1113: SOLR-14131: adds maxQueryLength option URL: https://github.com/apache/lucene-solr/pull/1113#discussion_r360989610 ## File path: solr/core/src/test/org/apache/solr/spelling/DirectSolrSpellCheckerTest.java ## @@

[GitHub] [lucene-solr] andywebb1975 commented on issue #1113: SOLR-14131: adds maxQueryLength option

2019-12-23 Thread GitBox
andywebb1975 commented on issue #1113: SOLR-14131: adds maxQueryLength option URL: https://github.com/apache/lucene-solr/pull/1113#issuecomment-568568657 Thanks Bruno and Mike - I've submitted some updates, could you take another look please?

[GitHub] [lucene-solr] uschindler edited a comment on issue #1114: LUCENE-9109: Use stack walker to implement TestSecurityManager's detection of test JVM exit

2019-12-23 Thread GitBox
uschindler edited a comment on issue #1114: LUCENE-9109: Use stack walker to implement TestSecurityManager's detection of test JVM exit URL: https://github.com/apache/lucene-solr/pull/1114#issuecomment-568567830 You are right: > If there is a security manager, and this thread is not

[jira] [Commented] (SOLR-13817) Deprecate and remove legacy SolrCache implementations

2019-12-23 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002460#comment-17002460 ] David Smiley commented on SOLR-13817: - I'm looking at our {{_default}} configSet and I see class= all

[GitHub] [lucene-solr] uschindler commented on issue #1114: LUCENE-9109: Use stack walker to implement TestSecurityManager's detection of test JVM exit

2019-12-23 Thread GitBox
uschindler commented on issue #1114: LUCENE-9109: Use stack walker to implement TestSecurityManager's detection of test JVM exit URL: https://github.com/apache/lucene-solr/pull/1114#issuecomment-568567830 You are right: > If there is a security manager, and this thread is not the

[jira] [Commented] (SOLR-14143) Add request-logging to securing solr page

2019-12-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002448#comment-17002448 ] Robert Muir commented on SOLR-14143: Simple patch: since it isn't default, I really want to keep it

[jira] [Updated] (SOLR-14143) Add request-logging to securing solr page

2019-12-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated SOLR-14143: --- Attachment: SOLR-14143.patch > Add request-logging to securing solr page >

[jira] [Created] (SOLR-14143) Add request-logging to securing solr page

2019-12-23 Thread Robert Muir (Jira)
Robert Muir created SOLR-14143: -- Summary: Add request-logging to securing solr page Key: SOLR-14143 URL: https://issues.apache.org/jira/browse/SOLR-14143 Project: Solr Issue Type: Improvement

[jira] [Commented] (LUCENE-9109) Use Java 9+ StackWalker to implement TestSecurityManager's detection of JVM exit

2019-12-23 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002443#comment-17002443 ] Uwe Schindler commented on LUCENE-9109: --- We should look at other places calling

[jira] [Created] (LUCENE-9109) Use Java 9+ StackWalker to implement TestSecurityManager's detection of JVM exit

2019-12-23 Thread Uwe Schindler (Jira)
Uwe Schindler created LUCENE-9109: - Summary: Use Java 9+ StackWalker to implement TestSecurityManager's detection of JVM exit Key: LUCENE-9109 URL: https://issues.apache.org/jira/browse/LUCENE-9109

[GitHub] [lucene-solr] uschindler opened a new pull request #1114: LUCENE-9109: Use stack walker to implement TestSecurityManager's detection of test JVM exit

2019-12-23 Thread GitBox
uschindler opened a new pull request #1114: LUCENE-9109: Use stack walker to implement TestSecurityManager's detection of test JVM exit URL: https://github.com/apache/lucene-solr/pull/1114 This is just a small improvement in Lucene/Solr master (Java 11) to detect exit of JVM in our test

[jira] [Comment Edited] (SOLR-13890) Add postfilter support to {!terms} queries

2019-12-23 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002424#comment-17002424 ] Joel Bernstein edited comment on SOLR-13890 at 12/23/19 6:52 PM: - The

[jira] [Commented] (SOLR-14138) Fix commented-out RequestLog in jetty.xml to use non-deprecated class

2019-12-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002439#comment-17002439 ] ASF subversion and git services commented on SOLR-14138: Commit

[jira] [Commented] (SOLR-14138) Fix commented-out RequestLog in jetty.xml to use non-deprecated class

2019-12-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002438#comment-17002438 ] ASF subversion and git services commented on SOLR-14138: Commit

[jira] [Comment Edited] (SOLR-13890) Add postfilter support to {!terms} queries

2019-12-23 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002424#comment-17002424 ] Joel Bernstein edited comment on SOLR-13890 at 12/23/19 6:28 PM: - The

[jira] [Commented] (SOLR-13890) Add postfilter support to {!terms} queries

2019-12-23 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002424#comment-17002424 ] Joel Bernstein commented on SOLR-13890: --- The other really big aspect of this is caching. Even

[jira] [Comment Edited] (SOLR-13890) Add postfilter support to {!terms} queries

2019-12-23 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002424#comment-17002424 ] Joel Bernstein edited comment on SOLR-13890 at 12/23/19 6:27 PM: - The

[jira] [Comment Edited] (SOLR-13890) Add postfilter support to {!terms} queries

2019-12-23 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002416#comment-17002416 ] Joel Bernstein edited comment on SOLR-13890 at 12/23/19 6:18 PM: - I dug

[jira] [Comment Edited] (SOLR-13890) Add postfilter support to {!terms} queries

2019-12-23 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002416#comment-17002416 ] Joel Bernstein edited comment on SOLR-13890 at 12/23/19 6:15 PM: - I dug

[jira] [Commented] (SOLR-13890) Add postfilter support to {!terms} queries

2019-12-23 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002420#comment-17002420 ] Joel Bernstein commented on SOLR-13890: --- We have code somewhat similar to this patch deployed with

[jira] [Comment Edited] (SOLR-13890) Add postfilter support to {!terms} queries

2019-12-23 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002416#comment-17002416 ] Joel Bernstein edited comment on SOLR-13890 at 12/23/19 6:09 PM: - I dug

[jira] [Commented] (SOLR-13890) Add postfilter support to {!terms} queries

2019-12-23 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002416#comment-17002416 ] Joel Bernstein commented on SOLR-13890: --- I dug into this pretty deeply and I believe there is large

[jira] [Commented] (SOLR-13890) Add postfilter support to {!terms} queries

2019-12-23 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002388#comment-17002388 ] Jason Gerlowski commented on SOLR-13890: bq. I highly doubt the PostFilter abstraction somehow

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1113: SOLR-14131: adds maxQueryLength option

2019-12-23 Thread GitBox
bruno-roustant commented on a change in pull request #1113: SOLR-14131: adds maxQueryLength option URL: https://github.com/apache/lucene-solr/pull/1113#discussion_r360950592 ## File path: solr/core/src/test/org/apache/solr/spelling/DirectSolrSpellCheckerTest.java ## @@

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1113: SOLR-14131: adds maxQueryLength option

2019-12-23 Thread GitBox
bruno-roustant commented on a change in pull request #1113: SOLR-14131: adds maxQueryLength option URL: https://github.com/apache/lucene-solr/pull/1113#discussion_r360949433 ## File path: solr/core/src/test/org/apache/solr/spelling/DirectSolrSpellCheckerTest.java ## @@

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1113: SOLR-14131: adds maxQueryLength option

2019-12-23 Thread GitBox
bruno-roustant commented on a change in pull request #1113: SOLR-14131: adds maxQueryLength option URL: https://github.com/apache/lucene-solr/pull/1113#discussion_r360949198 ## File path: solr/core/src/test/org/apache/solr/spelling/DirectSolrSpellCheckerTest.java ## @@

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1113: SOLR-14131: adds maxQueryLength option

2019-12-23 Thread GitBox
bruno-roustant commented on a change in pull request #1113: SOLR-14131: adds maxQueryLength option URL: https://github.com/apache/lucene-solr/pull/1113#discussion_r360949962 ## File path: solr/core/src/test/org/apache/solr/spelling/DirectSolrSpellCheckerTest.java ## @@

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1113: SOLR-14131: adds maxQueryLength option

2019-12-23 Thread GitBox
bruno-roustant commented on a change in pull request #1113: SOLR-14131: adds maxQueryLength option URL: https://github.com/apache/lucene-solr/pull/1113#discussion_r360949352 ## File path: solr/core/src/test/org/apache/solr/spelling/DirectSolrSpellCheckerTest.java ## @@

  1   2   >