[jira] [Comment Edited] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2020-06-25 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145999#comment-17145999 ] Atri Sharma edited comment on SOLR-14588 at 6/26/20, 4:14 AM: --

[GitHub] [lucene-solr] CaoManhDat edited a comment on pull request #1470: SOLR-14354: Async or using threads in better way for HttpShardHandler

2020-06-25 Thread GitBox
CaoManhDat edited a comment on pull request #1470: URL: https://github.com/apache/lucene-solr/pull/1470#issuecomment-649949789 Note that this PR including changes for removing the ability to use HttpShardHandler with a custom HttpClient. My reasons for doing that is * In current code

[jira] [Comment Edited] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2020-06-25 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145999#comment-17145999 ] Atri Sharma edited comment on SOLR-14588 at 6/26/20, 4:14 AM: --

[GitHub] [lucene-solr] CaoManhDat edited a comment on pull request #1470: SOLR-14354: Async or using threads in better way for HttpShardHandler

2020-06-25 Thread GitBox
CaoManhDat edited a comment on pull request #1470: URL: https://github.com/apache/lucene-solr/pull/1470#issuecomment-649949789 Note that this PR including changes for removing the ability to use HttpShardHandler with a custom HttpClient. My reasons for doing that is * In current code,

[GitHub] [lucene-solr] CaoManhDat commented on pull request #1470: SOLR-14354: Async or using threads in better way for HttpShardHandler

2020-06-25 Thread GitBox
CaoManhDat commented on pull request #1470: URL: https://github.com/apache/lucene-solr/pull/1470#issuecomment-649949789 Note that this PR including changes for removing the ability to use HttpShardHandler with a custom HttpClient. My reasons for doing that is * In current code, we use

[GitHub] [lucene-solr] CaoManhDat commented on a change in pull request #1470: SOLR-14354: Async or using threads in better way for HttpShardHandler

2020-06-25 Thread GitBox
CaoManhDat commented on a change in pull request #1470: URL: https://github.com/apache/lucene-solr/pull/1470#discussion_r445955727 ## File path: solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java ## @@ -66,16 +66,20 @@ public static String

[GitHub] [lucene-solr] CaoManhDat commented on a change in pull request #1470: SOLR-14354: Async or using threads in better way for HttpShardHandler

2020-06-25 Thread GitBox
CaoManhDat commented on a change in pull request #1470: URL: https://github.com/apache/lucene-solr/pull/1470#discussion_r445955649 ## File path: solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java ## @@ -130,77 +134,64 @@ public void submit(final

[GitHub] [lucene-solr] CaoManhDat commented on a change in pull request #1470: SOLR-14354: Async or using threads in better way for HttpShardHandler

2020-06-25 Thread GitBox
CaoManhDat commented on a change in pull request #1470: URL: https://github.com/apache/lucene-solr/pull/1470#discussion_r445955598 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/util/OnComplete.java ## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (SOLR-14354) Async or using threads in better way for HttpShardHandler

2020-06-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146000#comment-17146000 ] ASF subversion and git services commented on SOLR-14354: Commit

[jira] [Commented] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2020-06-25 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145999#comment-17145999 ] Atri Sharma commented on SOLR-14588: [~erickerickson] Thank you for proactively fixing the test! Did

[jira] [Resolved] (LUCENE-9389) Enhance logging messages in Lucene's Luke module

2020-06-25 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved LUCENE-9389. Fix Version/s: 8.6 Resolution: Fixed Thanks Andras! > Enhance logging messages in

[jira] [Updated] (LUCENE-9389) Enhance logging messages in Lucene's Luke module

2020-06-25 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated LUCENE-9389: --- Status: Open (was: Patch Available) > Enhance logging messages in Lucene's Luke module >

[jira] [Commented] (LUCENE-9389) Enhance logging messages in Lucene's Luke module

2020-06-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145982#comment-17145982 ] ASF subversion and git services commented on LUCENE-9389: - Commit

[jira] [Commented] (LUCENE-9389) Enhance logging messages in Lucene's Luke module

2020-06-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145980#comment-17145980 ] ASF subversion and git services commented on LUCENE-9389: - Commit

[jira] [Updated] (LUCENE-9389) Enhance logging messages in Lucene's Luke module

2020-06-25 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated LUCENE-9389: --- Summary: Enhance logging messages in Lucene's Luke module (was: Enhance logging messages

[jira] [Updated] (LUCENE-9389) Enhance logging messages in Lucene

2020-06-25 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated LUCENE-9389: --- Summary: Enhance logging messages in Lucene (was: Enhance gradle logging calls validation:

[jira] [Commented] (SOLR-10229) See what it would take to shift many of our one-off schemas used for testing to managed schema and construct them as part of the tests

2020-06-25 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145962#comment-17145962 ] Alexandre Rafalovitch commented on SOLR-10229: -- I was more thinking something along

[jira] [Commented] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2020-06-25 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145920#comment-17145920 ] Erick Erickson commented on SOLR-14588: --- [~atris] This fixes the test by checking on the

[jira] [Commented] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2020-06-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145919#comment-17145919 ] ASF subversion and git services commented on SOLR-14588: Commit

[jira] [Commented] (SOLR-10229) See what it would take to shift many of our one-off schemas used for testing to managed schema and construct them as part of the tests

2020-06-25 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145918#comment-17145918 ] Erick Erickson commented on SOLR-10229: --- I don't think so. I'm looking at just the mechanics of the

[jira] [Updated] (SOLR-14595) json.facet subfacet 'sort:"index asc", refine:true' can return diff results using method:enum

2020-06-25 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-14595: -- Attachment: SOLR-14595.patch Status: Open (was: Open) Attaching a test patch

[jira] [Created] (SOLR-14595) json.facet subfacet 'sort:"index asc", refine:true' can return diff results using method:enum

2020-06-25 Thread Chris M. Hostetter (Jira)
Chris M. Hostetter created SOLR-14595: - Summary: json.facet subfacet 'sort:"index asc", refine:true' can return diff results using method:enum Key: SOLR-14595 URL:

[jira] [Commented] (SOLR-10229) See what it would take to shift many of our one-off schemas used for testing to managed schema and construct them as part of the tests

2020-06-25 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145910#comment-17145910 ] Alexandre Rafalovitch commented on SOLR-10229: -- I wonder if that's because we reached for a

[GitHub] [lucene-solr] tflobbe opened a new pull request #1616: SOLR-14590: Add RankQParserPlugin

2020-06-25 Thread GitBox
tflobbe opened a new pull request #1616: URL: https://github.com/apache/lucene-solr/pull/1616 This is still WIP, just the query parsing so far. Currently working on the indexing side of things. This is an automated

[jira] [Commented] (SOLR-10229) See what it would take to shift many of our one-off schemas used for testing to managed schema and construct them as part of the tests

2020-06-25 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145881#comment-17145881 ] Erick Erickson commented on SOLR-10229: --- I really don't see how to make forward progress on this.

[jira] [Resolved] (SOLR-14578) Confusing Name in the docs and Test of Auto Add Trigger

2020-06-25 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-14578. -- Fix Version/s: master (9.0) Assignee: Mike Drob Resolution: Fixed Thanks for the fix,

[jira] [Updated] (SOLR-14578) Confusing Name in the docs and Test of Auto Add Trigger

2020-06-25 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-14578: - Component/s: (was: AutoScaling) documentation > Confusing Name in the docs and Test

[jira] [Commented] (SOLR-14578) Confusing Name in the docs and Test of Auto Add Trigger

2020-06-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145876#comment-17145876 ] ASF subversion and git services commented on SOLR-14578: Commit

[jira] [Updated] (SOLR-14578) Confusing Name in the docs and Test of Auto Add Trigger

2020-06-25 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-14578: - Component/s: AutoScaling > Confusing Name in the docs and Test of Auto Add Trigger >

[GitHub] [lucene-solr] madrob merged pull request #1591: SOLR-14578: Update solrcloud-autoscaling-triggers.adoc and test

2020-06-25 Thread GitBox
madrob merged pull request #1591: URL: https://github.com/apache/lucene-solr/pull/1591 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2020-06-25 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145873#comment-17145873 ] Gus Heck commented on SOLR-14588: - [http://fucit.org/solr-jenkins-reports/failure-report.html] - failing

[jira] [Commented] (LUCENE-8962) Can we merge small segments during refresh, for faster searching?

2020-06-25 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145871#comment-17145871 ] Michael McCandless commented on LUCENE-8962: Ooh, found another failing test (after 341 full

[jira] [Updated] (LUCENE-8062) Never cache GlobalOrdinalQuery

2020-06-25 Thread Jim Ferenczi (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi updated LUCENE-8062: - Fix Version/s: (was: 8.3) (was: master (9.0)) 7.2

[jira] [Updated] (LUCENE-8062) Never cache GlobalOrdinalQuery

2020-06-25 Thread Jim Ferenczi (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi updated LUCENE-8062: - Fix Version/s: (was: 7.2) (was: 8.0) 8.3

[jira] [Resolved] (LUCENE-8148) Get precommit Lint warnings out of test code

2020-06-25 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved LUCENE-8148. Fix Version/s: 8.6 Resolution: Fixed The 9x Gradle builds build without warnings

[jira] [Resolved] (SOLR-10778) Address precommit WARNINGS

2020-06-25 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved SOLR-10778. --- Fix Version/s: 8.6 Resolution: Fixed All gone. To recap: * Added a LOT of

[jira] [Resolved] (SOLR-14574) Fix or suppress warnings in solr/core/src/test

2020-06-25 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved SOLR-14574. --- Resolution: Fixed Gosh it's easy to fix it when I mess up when [~hossman]  does all the

[jira] [Commented] (SOLR-14574) Fix or suppress warnings in solr/core/src/test

2020-06-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145836#comment-17145836 ] ASF subversion and git services commented on SOLR-14574: Commit

[jira] [Resolved] (SOLR-14541) Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-25 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved SOLR-14541. --- Fix Version/s: 8.6 Resolution: Fixed > Ensure classes that implement equals implement

[jira] [Commented] (SOLR-14541) Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145822#comment-17145822 ] ASF subversion and git services commented on SOLR-14541: Commit

[jira] [Commented] (SOLR-14541) Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145821#comment-17145821 ] ASF subversion and git services commented on SOLR-14541: Commit

[GitHub] [lucene-solr] atris commented on pull request #1615: SOLR-14588: Follow Up Fixes and Documentation

2020-06-25 Thread GitBox
atris commented on pull request #1615: URL: https://github.com/apache/lucene-solr/pull/1615#issuecomment-649796637 @ErickErickson This fixes the test failure. I ran the test around 20 times with and without the failing seed -- seems clean. @sigram Updated the documentation -- let me

[GitHub] [lucene-solr] atris opened a new pull request #1615: SOLR-14588: Follow Up Fixes and Documentation

2020-06-25 Thread GitBox
atris opened a new pull request #1615: URL: https://github.com/apache/lucene-solr/pull/1615 This commit is a follow up to the original commit and adds more documentation and adds timing information for circuit breaker check only if circuit breakers are enabled

[jira] [Resolved] (SOLR-14594) Bold title text in UI dashboard

2020-06-25 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cassandra Targett resolved SOLR-14594. -- Fix Version/s: 8.6 Resolution: Fixed > Bold title text in UI dashboard >

[jira] [Commented] (SOLR-14307) "user caches" don't support "enabled" attribute

2020-06-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145748#comment-17145748 ] ASF subversion and git services commented on SOLR-14307: Commit

[jira] [Commented] (SOLR-14237) Add authenticated user principal in Solr admin UI

2020-06-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145750#comment-17145750 ] ASF subversion and git services commented on SOLR-14237: Commit

[jira] [Commented] (SOLR-14594) Bold title text in UI dashboard

2020-06-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145749#comment-17145749 ] ASF subversion and git services commented on SOLR-14594: Commit

[jira] [Commented] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2020-06-25 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145747#comment-17145747 ] Erick Erickson commented on SOLR-14588: --- [~atris] I believe this is producing the following test

[jira] [Commented] (SOLR-14307) "user caches" don't support "enabled" attribute

2020-06-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145744#comment-17145744 ] ASF subversion and git services commented on SOLR-14307: Commit

[jira] [Commented] (SOLR-14594) Bold title text in UI dashboard

2020-06-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145745#comment-17145745 ] ASF subversion and git services commented on SOLR-14594: Commit

[jira] [Commented] (SOLR-14237) Add authenticated user principal in Solr admin UI

2020-06-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145746#comment-17145746 ] ASF subversion and git services commented on SOLR-14237: Commit

[jira] [Comment Edited] (SOLR-14574) Fix or suppress warnings in solr/core/src/test

2020-06-25 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145733#comment-17145733 ] Erick Erickson edited comment on SOLR-14574 at 6/25/20, 6:40 PM: -

[jira] [Commented] (LUCENE-8574) ExpressionFunctionValues should cache per-hit value

2020-06-25 Thread Haoyu Zhai (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145732#comment-17145732 ] Haoyu Zhai commented on LUCENE-8574: Made a PR([https://github.com/apache/lucene-solr/pull/1613])

[jira] [Commented] (SOLR-14574) Fix or suppress warnings in solr/core/src/test

2020-06-25 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145733#comment-17145733 ] Erick Erickson commented on SOLR-14574: --- [~hossman] I tried to stay away from any _intentional_

[jira] [Updated] (SOLR-14481) Add drill Streaming Expression

2020-06-25 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-14481: -- Description: This ticket will add the *drill* Streaming Expression. The drill Streaming

[jira] [Updated] (SOLR-14481) Add drill Streaming Expression

2020-06-25 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-14481: -- Attachment: SOLR-14481.patch > Add drill Streaming Expression > --

[jira] [Reopened] (SOLR-14574) Fix or suppress warnings in solr/core/src/test

2020-06-25 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter reopened SOLR-14574: --- git bisect has identified 102fc9d7e01966220927b90b13c72f3240890173 as the cause of

[jira] [Commented] (LUCENE-8962) Can we merge small segments during refresh, for faster searching?

2020-06-25 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145716#comment-17145716 ] Michael McCandless commented on LUCENE-8962: Beasting the branch (all Lucene core + module

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1610: LUCENE-9384: Backport for field sort optimization

2020-06-25 Thread GitBox
mayya-sharipova commented on a change in pull request #1610: URL: https://github.com/apache/lucene-solr/pull/1610#discussion_r445737021 ## File path: lucene/core/src/java/org/apache/lucene/search/SortField.java ## @@ -394,6 +399,21 @@ public String toString() { return

[jira] [Comment Edited] (SOLR-13688) Make the bin/solr export command to run one thread per shard

2020-06-25 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145689#comment-17145689 ] Joel Bernstein edited comment on SOLR-13688 at 6/25/20, 5:36 PM: - Maybe

[jira] [Comment Edited] (SOLR-13688) Make the bin/solr export command to run one thread per shard

2020-06-25 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145689#comment-17145689 ] Joel Bernstein edited comment on SOLR-13688 at 6/25/20, 5:36 PM: - Maybe

[jira] [Comment Edited] (SOLR-13688) Make the bin/solr export command to run one thread per shard

2020-06-25 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145689#comment-17145689 ] Joel Bernstein edited comment on SOLR-13688 at 6/25/20, 5:34 PM: - Maybe

[jira] [Comment Edited] (SOLR-13688) Make the bin/solr export command to run one thread per shard

2020-06-25 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145689#comment-17145689 ] Joel Bernstein edited comment on SOLR-13688 at 6/25/20, 5:34 PM: - Maybe

[jira] [Commented] (SOLR-13688) Make the bin/solr export command to run one thread per shard

2020-06-25 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145689#comment-17145689 ] Joel Bernstein commented on SOLR-13688: --- Maybe I'll add a simple command line tool for running

[jira] [Comment Edited] (SOLR-14329) Add support to choose field for expand component from multiple collapse groups

2020-06-25 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145509#comment-17145509 ] Cassandra Targett edited comment on SOLR-14329 at 6/25/20, 5:26 PM:

[jira] [Commented] (SOLR-14329) Add support to choose field for expand component from multiple collapse groups

2020-06-25 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145509#comment-17145509 ] Cassandra Targett commented on SOLR-14329: -- Ah, OK, my ignorance of {{fq}}'s is showing then.

[jira] [Commented] (SOLR-13688) Make the bin/solr export command to run one thread per shard

2020-06-25 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145132#comment-17145132 ] Joel Bernstein commented on SOLR-13688: --- This an interesting question. The streams that merge other

[jira] [Commented] (SOLR-10778) Address precommit WARNINGS

2020-06-25 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145117#comment-17145117 ] Erick Erickson commented on SOLR-10778: --- Well, the original intent was that multiple people were

[jira] [Commented] (SOLR-13749) Implement support for joining across collections with multiple shards ( XCJF )

2020-06-25 Thread Kevin Watters (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145104#comment-17145104 ] Kevin Watters commented on SOLR-13749: -- Awesome!  Thanks for taking care of the merge back to 8x

[jira] [Commented] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2020-06-25 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145099#comment-17145099 ] Atri Sharma commented on SOLR-14588: [~ab] Thanks for commenting. I will add documentation and update

[jira] [Commented] (SOLR-13749) Implement support for joining across collections with multiple shards ( XCJF )

2020-06-25 Thread Marcus Eagan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145101#comment-17145101 ] Marcus Eagan commented on SOLR-13749: -  > Implement support for joining across collections with

[jira] [Resolved] (SOLR-13749) Implement support for joining across collections with multiple shards ( XCJF )

2020-06-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-13749. - Resolution: Fixed Finally :-) > Implement support for joining across collections with multiple

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1574: SOLR-14566: Add request-ID to all distrib-search requests

2020-06-25 Thread GitBox
dsmiley commented on a change in pull request #1574: URL: https://github.com/apache/lucene-solr/pull/1574#discussion_r445702874 ## File path: solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java ## @@ -70,6 +73,11 @@ private static final Logger log =

[jira] [Commented] (SOLR-13749) Implement support for joining across collections with multiple shards ( XCJF )

2020-06-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145095#comment-17145095 ] ASF subversion and git services commented on SOLR-13749: Commit

[jira] [Commented] (SOLR-13132) Improve JSON "terms" facet performance when sorted by relatedness

2020-06-25 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145089#comment-17145089 ] Michael Gibney commented on SOLR-13132: --- Sorry for the delayed response; these changes and

[jira] [Commented] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2020-06-25 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145066#comment-17145066 ] Andrzej Bialecki commented on SOLR-14588: - [~atris] please see the comment above - the title of

[jira] [Commented] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2020-06-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145060#comment-17145060 ] ASF subversion and git services commented on SOLR-14588: Commit

[jira] [Commented] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2020-06-25 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145057#comment-17145057 ] Atri Sharma commented on SOLR-14588: [~mdrob] Yes, realised that post pushing. Pushing a fix now. >

[GitHub] [lucene-solr] gerlowskija commented on a change in pull request #1574: SOLR-14566: Add request-ID to all distrib-search requests

2020-06-25 Thread GitBox
gerlowskija commented on a change in pull request #1574: URL: https://github.com/apache/lucene-solr/pull/1574#discussion_r445668363 ## File path: solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java ## @@ -70,6 +73,11 @@ private static final Logger log

[jira] [Commented] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2020-06-25 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145051#comment-17145051 ] Andrzej Bialecki commented on SOLR-14588: - I must have missed the discussion about the design of

[jira] [Commented] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2020-06-25 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145039#comment-17145039 ] Mike Drob commented on SOLR-14588: -- [~atris] - needs a CHANGES entry too > Circuit Breakers

[GitHub] [lucene-solr] madrob commented on a change in pull request #1598: SOLR-14409: Existing violations allow bypassing policy rules when add…

2020-06-25 Thread GitBox
madrob commented on a change in pull request #1598: URL: https://github.com/apache/lucene-solr/pull/1598#discussion_r445653717 ## File path: solr/solrj/src/test/org/apache/solr/client/solrj/cloud/autoscaling/TestPolicy2.java ## @@ -516,6 +517,16 @@ public void

[jira] [Commented] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2020-06-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145030#comment-17145030 ] ASF subversion and git services commented on SOLR-14588: Commit

[jira] [Commented] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2020-06-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145029#comment-17145029 ] ASF subversion and git services commented on SOLR-14588: Commit

[GitHub] [lucene-solr] atris merged pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-25 Thread GitBox
atris merged pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (SOLR-10778) Address precommit WARNINGS

2020-06-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145028#comment-17145028 ] David Smiley commented on SOLR-10778: - I just want to mention that I think it was a bit heavyweight

[GitHub] [lucene-solr] atris commented on pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-25 Thread GitBox
atris commented on pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#issuecomment-649628396 @madrob @anshumg Thank you for the review! This is an automated message from the Apache Git Service. To

[GitHub] [lucene-solr] madrob commented on a change in pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-25 Thread GitBox
madrob commented on a change in pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r445647072 ## File path: solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java ## @@ -289,6 +295,23 @@ public void

[GitHub] [lucene-solr] atris commented on pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-25 Thread GitBox
atris commented on pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#issuecomment-649613385 @madrob I aim to close this PR out today if possible -- so happy to stay awake late tonight if you want me to iterate :)

[jira] [Closed] (SOLR-5387) Multi-Term analyser not working

2020-06-25 Thread Claire Chan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claire Chan closed SOLR-5387. - the resolution is verified. > Multi-Term analyser not working > --- > >

[jira] [Commented] (SOLR-14329) Add support to choose field for expand component from multiple collapse groups

2020-06-25 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144999#comment-17144999 ] Munendra S N commented on SOLR-14329: - [~ctargett] {{cost}} parameter is not specific to collapsing,

[jira] [Commented] (LUCENE-8962) Can we merge small segments during refresh, for faster searching?

2020-06-25 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144969#comment-17144969 ] Michael Sokolov commented on LUCENE-8962: - Yes, thanks Simon! I'll take a look too; hopefully I

[GitHub] [lucene-solr] ErickErickson commented on pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-25 Thread GitBox
ErickErickson commented on pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579#issuecomment-649582539 I'll merge this in a bit via another methodl This is an automated message from the Apache Git

[GitHub] [lucene-solr] ErickErickson closed pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-25 Thread GitBox
ErickErickson closed pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (SOLR-14022) Deprecate CDCR from Solr in 8.x

2020-06-25 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144963#comment-17144963 ] Timothy Potter commented on SOLR-14022: --- Check out Apache Pulsar's geo-replication capabilities as

[jira] [Updated] (LUCENE-9328) Sorting by DocValues while grouping is slower than old good FieldCache

2020-06-25 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated LUCENE-9328: - Summary: Sorting by DocValues while grouping is slower than old good FieldCache (was:

[jira] [Commented] (SOLR-13749) Implement support for joining across collections with multiple shards ( XCJF )

2020-06-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144951#comment-17144951 ] ASF subversion and git services commented on SOLR-13749: Commit

[jira] [Commented] (SOLR-14586) replace the second function parameter in Map#computeIfAbsent with static vars

2020-06-25 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144949#comment-17144949 ] Jason Gerlowski commented on SOLR-14586: bq. Now, do you expect a developer to run a perf

[GitHub] [lucene-solr] ErickErickson commented on a change in pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-25 Thread GitBox
ErickErickson commented on a change in pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r445578718 ## File path: solr/core/src/java/org/apache/solr/pkg/PackageAPI.java ## @@ -211,7 +211,7 @@ public boolean equals(Object obj) {

[GitHub] [lucene-solr] ErickErickson commented on a change in pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-25 Thread GitBox
ErickErickson commented on a change in pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r445576784 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/AutoScalingConfig.java ## @@ -587,11 +585,11 @@ public

  1   2   >