[jira] [Commented] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-02 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189847#comment-17189847 ] Dawid Weiss commented on LUCENE-9500: - bq. parameter off seems unused Oh, great catch! bq. will

[jira] [Commented] (SOLR-14819) SOLR has linear log operations that could trivially be linear

2020-09-02 Thread Thomas DuBuisson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189822#comment-17189822 ] Thomas DuBuisson commented on SOLR-14819: - [~broustant] yes there were other issues detected in

[GitHub] [lucene-solr] TomMD commented on a change in pull request #1818: SOLR-14819 Trivial fix to inefficient iterator pattern

2020-09-02 Thread GitBox
TomMD commented on a change in pull request #1818: URL: https://github.com/apache/lucene-solr/pull/1818#discussion_r482683688 ## File path: solr/solrj/src/java/org/apache/solr/common/util/JsonSchemaValidator.java ## @@ -48,13 +48,15 @@ public JsonSchemaValidator(String

[jira] [Created] (SOLR-14825) Wrap up async issues and tests.

2020-09-02 Thread Mark Robert Miller (Jira)
Mark Robert Miller created SOLR-14825: - Summary: Wrap up async issues and tests. Key: SOLR-14825 URL: https://issues.apache.org/jira/browse/SOLR-14825 Project: Solr Issue Type: Sub-task

[GitHub] [lucene-solr] vthacker commented on pull request #1816: LUCENE-9497: Integerate Error Prone ( Static Analysis Tool ) during compilation

2020-09-02 Thread GitBox
vthacker commented on pull request #1816: URL: https://github.com/apache/lucene-solr/pull/1816#issuecomment-68663 This is the set of warnings/errors for `solr/core` ``` ~/apache-work/lucene-solr (solr_core_errorprone) $ gradlew -p solr/core/ compileJava > Task

[GitHub] [lucene-solr] vthacker commented on pull request #1816: LUCENE-9497: Integerate Error Prone ( Static Analysis Tool ) during compilation

2020-09-02 Thread GitBox
vthacker commented on pull request #1816: URL: https://github.com/apache/lucene-solr/pull/1816#issuecomment-686220411 Here is the complete list of warnings/errors that this tool gives us for lucene-core ``` ~/apache-work/lucene-solr (solr_core_errorprone) $ gradlew -p

[GitHub] [lucene-solr] vthacker commented on pull request #1816: LUCENE-9497: Integerate Error Prone ( Static Analysis Tool ) during compilation

2020-09-02 Thread GitBox
vthacker commented on pull request #1816: URL: https://github.com/apache/lucene-solr/pull/1816#issuecomment-686220105 > Why is there this strange dependency? Listing it under plugins should be enough. Ah okay! Just getting starter with gradle so I'll be making some mistakes like

[GitHub] [lucene-solr] tflobbe opened a new pull request #1823: SOLR-14510: Remove deprecations added with BMW support

2020-09-02 Thread GitBox
tflobbe opened a new pull request #1823: URL: https://github.com/apache/lucene-solr/pull/1823 With BMW support, we added a new method to Text response writers to include in the response if the numFound is exact or not. This PR is to remove the previously existing and deprecated methods

[jira] [Commented] (SOLR-14645) Make FileListEntityProcessor streaming to prevent OOM

2020-09-02 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189774#comment-17189774 ] Ishan Chattopadhyaya commented on SOLR-14645: - Thanks [~mbolis], this was merged in the

[GitHub] [lucene-solr] murblanc commented on pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-02 Thread GitBox
murblanc commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686129516 @sigram @noblepaul I have removed the `PropertyValue` concept. Now once `PropertyKeys` are fetched, the value is accessed directly on the key (no more returned map). This

[jira] [Updated] (SOLR-14383) Fix indexing-nested-documents.adoc XML/JSON examples to be accurate, consistent, and clear

2020-09-02 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-14383: -- Fix Version/s: 8.7 master (9.0) Resolution: Fixed

[jira] [Comment Edited] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-02 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189741#comment-17189741 ] Uwe Schindler edited comment on LUCENE-9500 at 9/2/20, 10:16 PM: - Hi,

[jira] [Commented] (SOLR-14383) Fix indexing-nested-documents.adoc XML/JSON examples to be accurate, consistent, and clear

2020-09-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189739#comment-17189739 ] ASF subversion and git services commented on SOLR-14383: Commit

[jira] [Commented] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-02 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189741#comment-17189741 ] Uwe Schindler commented on LUCENE-9500: --- Hi, will report this one tomorrow morning after waking

[jira] [Commented] (SOLR-14383) Fix indexing-nested-documents.adoc XML/JSON examples to be accurate, consistent, and clear

2020-09-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189742#comment-17189742 ] ASF subversion and git services commented on SOLR-14383: Commit

[jira] [Commented] (SOLR-14383) Fix indexing-nested-documents.adoc XML/JSON examples to be accurate, consistent, and clear

2020-09-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189740#comment-17189740 ] ASF subversion and git services commented on SOLR-14383: Commit

[jira] [Commented] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-02 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189738#comment-17189738 ] Robert Muir commented on LUCENE-9500: - I think as a workaround we should arraycopy preset dictionary

[jira] [Commented] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-02 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189726#comment-17189726 ] Robert Muir commented on LUCENE-9500: - [~uschindler] this is a good one to report to the openjdk,

[jira] [Commented] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-02 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189723#comment-17189723 ] Robert Muir commented on LUCENE-9500: -

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-02 Thread GitBox
murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r482487876 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/PropertyValue.java ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-02 Thread GitBox
murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r482485955 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/plugins/SamplePluginMinimizeCores.java ## @@ -0,0 +1,132 @@ +/* + * Licensed to

[jira] [Commented] (SOLR-14383) Fix indexing-nested-documents.adoc XML/JSON examples to be accurate, consistent, and clear

2020-09-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189714#comment-17189714 ] ASF subversion and git services commented on SOLR-14383: Commit

[jira] [Commented] (SOLR-14383) Fix indexing-nested-documents.adoc XML/JSON examples to be accurate, consistent, and clear

2020-09-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189713#comment-17189713 ] ASF subversion and git services commented on SOLR-14383: Commit

[jira] [Commented] (SOLR-14383) Fix indexing-nested-documents.adoc XML/JSON examples to be accurate, consistent, and clear

2020-09-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189715#comment-17189715 ] ASF subversion and git services commented on SOLR-14383: Commit

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-02 Thread GitBox
murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r482478563 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/impl/PluginInteractionsImpl.java ## @@ -0,0 +1,190 @@ +/* Review comment:

[GitHub] [lucene-solr] rmuir commented on pull request #1822: Update french_stop.txt

2020-09-02 Thread GitBox
rmuir commented on pull request #1822: URL: https://github.com/apache/lucene-solr/pull/1822#issuecomment-686005054 Hi: this list is automatically generated from `snowball-website` by `gradle regenerate`. Would you mind submitting this PR to the upstream

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-02 Thread GitBox
murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r482477360 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/impl/PlacementPluginFactoryFacade.java ## @@ -0,0 +1,75 @@ +/* + * Licensed to

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-02 Thread GitBox
murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r482476548 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/SolrCollection.java ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-02 Thread GitBox
murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r482463350 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/PropertyKeyFactory.java ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-02 Thread GitBox
murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r482463350 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/PropertyKeyFactory.java ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache

[GitHub] [lucene-solr] quinzeromain opened a new pull request #1822: Update french_stop.txt

2020-09-02 Thread GitBox
quinzeromain opened a new pull request #1822: URL: https://github.com/apache/lucene-solr/pull/1822 Adding the term 'ça' corresponding to the shortened form of 'that' Adding the term 'où' corresponding to "where" because 'ou' corresponds to "or" Adding the term 'elles' corresponding

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-02 Thread GitBox
murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r482447666 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/Replica.java ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene-solr] jpountz commented on pull request #1817: Improve how Asserting* classes handle singleton doc values.

2020-09-02 Thread GitBox
jpountz commented on pull request #1817: URL: https://github.com/apache/lucene-solr/pull/1817#issuecomment-685989419 Good question. The test framework is used by our users so I think it makes sense to mention this change in the changelog.

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1789: LUCENE-9484: Allow sorting an index after the fact

2020-09-02 Thread GitBox
jpountz commented on a change in pull request #1789: URL: https://github.com/apache/lucene-solr/pull/1789#discussion_r482419163 ## File path: lucene/core/src/java/org/apache/lucene/index/NumericDocValuesWriter.java ## @@ -165,4 +166,62 @@ public long longValue() {

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1789: LUCENE-9484: Allow sorting an index after the fact

2020-09-02 Thread GitBox
jpountz commented on a change in pull request #1789: URL: https://github.com/apache/lucene-solr/pull/1789#discussion_r482434175 ## File path: lucene/core/src/java/org/apache/lucene/index/BinaryDocValuesWriter.java ## @@ -202,4 +203,63 @@ public BytesRef binaryValue() {

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1789: LUCENE-9484: Allow sorting an index after the fact

2020-09-02 Thread GitBox
jpountz commented on a change in pull request #1789: URL: https://github.com/apache/lucene-solr/pull/1789#discussion_r482418961 ## File path: lucene/core/src/java/org/apache/lucene/index/NumericDocValuesWriter.java ## @@ -165,4 +166,62 @@ public long longValue() {

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-02 Thread GitBox
murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r482438858 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/Replica.java ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-02 Thread GitBox
murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r482436534 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/PropertyValue.java ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-02 Thread GitBox
murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r482428206 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/PlacementPluginConfig.java ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache

[GitHub] [lucene-solr] jtibshirani commented on pull request #1817: Improve how Asserting* classes handle singleton doc values.

2020-09-02 Thread GitBox
jtibshirani commented on pull request #1817: URL: https://github.com/apache/lucene-solr/pull/1817#issuecomment-685981921 Thanks for the review. Let me know if I should add a changelog entry or issue number (I wasn't sure what to do for smaller test fixes like this).

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-02 Thread GitBox
murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r482424919 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/Cluster.java ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-02 Thread GitBox
murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r482422332 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/AddReplicasPlacementRequest.java ## @@ -0,0 +1,64 @@ +/* + * Licensed to the

[jira] [Commented] (LUCENE-9501) IndexSortSortedNumericDocValuesRangeQuery violates iterator invariant.

2020-09-02 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189693#comment-17189693 ] Julie Tibshirani commented on LUCENE-9501: -- Here's the first change around Asserting* wrapper

[GitHub] [lucene-solr] jtibshirani edited a comment on pull request #1817: Improve how Asserting* classes handle singleton doc values.

2020-09-02 Thread GitBox
jtibshirani edited a comment on pull request #1817: URL: https://github.com/apache/lucene-solr/pull/1817#issuecomment-685192326 I noticed this when debugging a bad bug in `IndexSortSortedNumericDocValuesRangeQuery` that wasn't caught by tests (LUCENE-9501). As a follow-up I plan to make

[GitHub] [lucene-solr] uschindler commented on pull request #1816: LUCENE-9497: Integerate Error Prone ( Static Analysis Tool ) during compilation

2020-09-02 Thread GitBox
uschindler commented on pull request #1816: URL: https://github.com/apache/lucene-solr/pull/1816#issuecomment-685972773 Why is there this strange dependency? Listing it under plugins should be enough. Especially, build tools should not be listed in versions.props and instead just

[jira] [Updated] (LUCENE-9501) IndexSortSortedNumericDocValuesRangeQuery violates iterator invariant.

2020-09-02 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julie Tibshirani updated LUCENE-9501: - Description: In LUCENE-7714 we added a new query to sandbox called

[jira] [Created] (LUCENE-9501) IndexSortSortedNumericDocValuesRangeQuery violates iterator invariant.

2020-09-02 Thread Julie Tibshirani (Jira)
Julie Tibshirani created LUCENE-9501: Summary: IndexSortSortedNumericDocValuesRangeQuery violates iterator invariant. Key: LUCENE-9501 URL: https://issues.apache.org/jira/browse/LUCENE-9501

[GitHub] [lucene-solr] dweiss commented on pull request #1816: LUCENE-9497: Integerate Error Prone ( Static Analysis Tool ) during compilation

2020-09-02 Thread GitBox
dweiss commented on pull request #1816: URL: https://github.com/apache/lucene-solr/pull/1816#issuecomment-685957523 I don't think so. That issue only added dependencies, it has nothing to do with running static analysis using that tool.

[jira] [Resolved] (LUCENE-9495) Ref Guide gradle buildSite ignores version parameter

2020-09-02 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cassandra Targett resolved LUCENE-9495. --- Resolution: Information Provided Closing this as the info I needed was provided and

[jira] [Created] (SOLR-14824) Simplify set of Ref Guide build parameters

2020-09-02 Thread Cassandra Targett (Jira)
Cassandra Targett created SOLR-14824: Summary: Simplify set of Ref Guide build parameters Key: SOLR-14824 URL: https://issues.apache.org/jira/browse/SOLR-14824 Project: Solr Issue Type:

[jira] [Resolved] (SOLR-14793) Clean up tests that log access permission violations.

2020-09-02 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved SOLR-14793. --- Resolution: Invalid Somehow I thought there were only a handful of these, in which fixing

[GitHub] [lucene-solr] vthacker commented on pull request #1816: LUCENE-9497: Integerate Error Prone ( Static Analysis Tool ) during compilation

2020-09-02 Thread GitBox
vthacker commented on pull request #1816: URL: https://github.com/apache/lucene-solr/pull/1816#issuecomment-685924654 Looks like this is duplicate of LUCENE-9411? This is an automated message from the Apache Git Service. To

[jira] [Comment Edited] (LUCENE-9444) Need an API to easily fetch facet labels for a field in a document

2020-09-02 Thread Ankur (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189618#comment-17189618 ] Ankur edited comment on LUCENE-9444 at 9/2/20, 6:35 PM: Here is a patch that

[jira] [Comment Edited] (LUCENE-9444) Need an API to easily fetch facet labels for a field in a document

2020-09-02 Thread Ankur (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189618#comment-17189618 ] Ankur edited comment on LUCENE-9444 at 9/2/20, 6:33 PM: Here is a patch that

[jira] [Comment Edited] (LUCENE-9444) Need an API to easily fetch facet labels for a field in a document

2020-09-02 Thread Ankur (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189618#comment-17189618 ] Ankur edited comment on LUCENE-9444 at 9/2/20, 6:28 PM: Here is a patch that

[jira] [Comment Edited] (LUCENE-9444) Need an API to easily fetch facet labels for a field in a document

2020-09-02 Thread Ankur (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189618#comment-17189618 ] Ankur edited comment on LUCENE-9444 at 9/2/20, 6:27 PM: Here is a patch that

[jira] [Commented] (LUCENE-9444) Need an API to easily fetch facet labels for a field in a document

2020-09-02 Thread Ankur (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189618#comment-17189618 ] Ankur commented on LUCENE-9444: --- Here is a patch that adds a new utility class - `TaxonomyFacetLabels`

[GitHub] [lucene-solr] sigram commented on a change in pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-02 Thread GitBox
sigram commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r482181180 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/Node.java ## @@ -0,0 +1,25 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (SOLR-14783) Remove DIH from 9.0

2020-09-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189587#comment-17189587 ] ASF subversion and git services commented on SOLR-14783: Commit

[jira] [Commented] (LUCENE-9215) replace checkJavaDocs.py with doclet

2020-09-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189588#comment-17189588 ] ASF subversion and git services commented on LUCENE-9215: - Commit

[jira] [Commented] (LUCENE-9317) Resolve package name conflicts for StandardAnalyzer to allow Java module system support

2020-09-02 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189575#comment-17189575 ] Uwe Schindler commented on LUCENE-9317: --- Hi, I am a bit busy with Gradle... give me a few days. >

[GitHub] [lucene-solr] TomMD commented on a change in pull request #1818: SOLR-14819 Trivial fix to inefficient iterator pattern

2020-09-02 Thread GitBox
TomMD commented on a change in pull request #1818: URL: https://github.com/apache/lucene-solr/pull/1818#discussion_r482245426 ## File path: solr/solrj/src/java/org/apache/solr/common/util/JsonSchemaValidator.java ## @@ -48,13 +48,15 @@ public JsonSchemaValidator(String

[jira] [Commented] (SOLR-14820) Create replica is broken

2020-09-02 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189564#comment-17189564 ] Christine Poerschke commented on SOLR-14820: Thanks [~thomas.woeckinger] for reporting this

[jira] [Commented] (SOLR-13681) make Lucene's index sorting directly configurable in Solr

2020-09-02 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189372#comment-17189372 ] Christine Poerschke commented on SOLR-13681: ticket cross-referencing: SOLR-12239 details how

[jira] [Commented] (SOLR-12239) Enabling index sorting causes "segment not sorted with indexSort=null"

2020-09-02 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189370#comment-17189370 ] Christine Poerschke commented on SOLR-12239: ticket cross-referencing: might LUCENE-9484

[jira] [Commented] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-02 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189356#comment-17189356 ] Dawid Weiss commented on LUCENE-9500: - No idea. Send a repro to core-libs-...@openjdk.java.net? >

[GitHub] [lucene-solr] dsmiley commented on pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-02 Thread GitBox
dsmiley commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-685841854 I think use of solr.xml for this is pragmatic/realistic with the Solr we have today. And it's flexible -- can go on the node or in ZK as you desire, and can hold

[jira] [Commented] (LUCENE-8319) A Time-limiting collector that works with CollectorManagers

2020-09-02 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189352#comment-17189352 ] Michael McCandless commented on LUCENE-8319: {quote}Timeout handling seems to be a frequent

[jira] [Commented] (LUCENE-9496) Replace (or accelerate) check-broken-links.gradle with a doclet pass

2020-09-02 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189349#comment-17189349 ] Dawid Weiss commented on LUCENE-9496: - There is definitely some effort in parsing those links

[jira] [Resolved] (SOLR-14782) QueryElevationComponent does not handle escaped query terms

2020-09-02 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant resolved SOLR-14782. --- Fix Version/s: 8.7 Resolution: Fixed No code change. Fixed by adding an example of

[jira] [Commented] (LUCENE-9495) Ref Guide gradle buildSite ignores version parameter

2020-09-02 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189340#comment-17189340 ] Dawid Weiss commented on LUCENE-9495: - Correct - -P is (one) of the ways to pass project properties

[jira] [Commented] (SOLR-14782) QueryElevationComponent does not handle escaped query terms

2020-09-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189337#comment-17189337 ] ASF subversion and git services commented on SOLR-14782: Commit

[jira] [Commented] (LUCENE-9215) replace checkJavaDocs.py with doclet

2020-09-02 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189334#comment-17189334 ] Dawid Weiss commented on LUCENE-9215: - Thanks for chipping at this, Robert. This is big lateral

[jira] [Commented] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-02 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189332#comment-17189332 ] Adrien Grand commented on LUCENE-9500: -- I just attached the test and test data I used that

[jira] [Updated] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-02 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-9500: - Attachment: test_data.txt Status: Open (was: Open) > Did we hit a DEFLATE bug? >

[jira] [Updated] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-02 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-9500: - Attachment: PresetDictTest.java Status: Open (was: Open) > Did we hit a DEFLATE bug? >

[jira] [Created] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-02 Thread Adrien Grand (Jira)
Adrien Grand created LUCENE-9500: Summary: Did we hit a DEFLATE bug? Key: LUCENE-9500 URL: https://issues.apache.org/jira/browse/LUCENE-9500 Project: Lucene - Core Issue Type: Bug

[GitHub] [lucene-solr] dsmiley commented on pull request #1687: SOLR-14658: Fix colstatus solrj interfaces to return one or all collections

2020-09-02 Thread GitBox
dsmiley commented on pull request #1687: URL: https://github.com/apache/lucene-solr/pull/1687#issuecomment-685826394 In addition to the minor expectThrows addition, @andyvuong can you also please add a CHANGES.txt entry for 8.7 in the bug section? Perhaps something like: *

[GitHub] [lucene-solr] bruno-roustant closed pull request #1819: SOLR-14782: Document how to unescape for the QueryElevationComponent.

2020-09-02 Thread GitBox
bruno-roustant closed pull request #1819: URL: https://github.com/apache/lucene-solr/pull/1819 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (SOLR-14782) QueryElevationComponent does not handle escaped query terms

2020-09-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189323#comment-17189323 ] ASF subversion and git services commented on SOLR-14782: Commit

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1687: SOLR-14658: Fix colstatus solrj interfaces to return one or all collections

2020-09-02 Thread GitBox
dsmiley commented on a change in pull request #1687: URL: https://github.com/apache/lucene-solr/pull/1687#discussion_r474312456 ## File path: solr/core/src/java/org/apache/solr/handler/admin/CollectionsHandler.java ## @@ -517,10 +517,7 @@ private static void

[GitHub] [lucene-solr] dsmiley merged pull request #1797: LUCENE ExitableReaderException public constructor

2020-09-02 Thread GitBox
dsmiley merged pull request #1797: URL: https://github.com/apache/lucene-solr/pull/1797 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (LUCENE-9317) Resolve package name conflicts for StandardAnalyzer to allow Java module system support

2020-09-02 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189318#comment-17189318 ] Tomoko Uchida commented on LUCENE-9317: --- [~uschindler] can I ask your thoughts on my design for

[jira] [Updated] (LUCENE-9499) Clean up package name conflicts between modules (split packages)

2020-09-02 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated LUCENE-9499: -- Description: We have lots of package name conflicts (shared package names) between modules

[jira] [Commented] (LUCENE-9215) replace checkJavaDocs.py with doclet

2020-09-02 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189307#comment-17189307 ] Uwe Schindler commented on LUCENE-9215: --- Thanks Robert Did you add a changes entry? > replace

[jira] [Commented] (LUCENE-9499) Clean up package name conflicts between modules (split packages)

2020-09-02 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189299#comment-17189299 ] Tomoko Uchida commented on LUCENE-9499: --- I will firstly (re)start [LUCENE-9317]. > Clean up

[jira] [Updated] (LUCENE-9499) Clean up package name conflicts between modules (split packages)

2020-09-02 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated LUCENE-9499: -- Description: We have lots of package name conflicts (shared package names) between modules

[jira] [Commented] (LUCENE-8985) SynonymGraphFilter cannot handle input stream with tokens filtered.

2020-09-02 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189288#comment-17189288 ] Michael McCandless commented on LUCENE-8985: Thank you [~nppoly] for the thorough PR – I

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1819: SOLR-14782: Document how to unescape for the QueryElevationComponent.

2020-09-02 Thread GitBox
bruno-roustant commented on a change in pull request #1819: URL: https://github.com/apache/lucene-solr/pull/1819#discussion_r482130641 ## File path: solr/solr-ref-guide/src/the-query-elevation-component.adoc ## @@ -61,7 +61,18 @@ Optionally, in the Query Elevation Component

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1819: SOLR-14782: Document how to unescape for the QueryElevationComponent.

2020-09-02 Thread GitBox
bruno-roustant commented on a change in pull request #1819: URL: https://github.com/apache/lucene-solr/pull/1819#discussion_r482123493 ## File path: solr/solr-ref-guide/src/the-query-elevation-component.adoc ## @@ -61,7 +61,18 @@ Optionally, in the Query Elevation Component

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1819: SOLR-14782: Document how to unescape for the QueryElevationComponent.

2020-09-02 Thread GitBox
bruno-roustant commented on a change in pull request #1819: URL: https://github.com/apache/lucene-solr/pull/1819#discussion_r482123493 ## File path: solr/solr-ref-guide/src/the-query-elevation-component.adoc ## @@ -61,7 +61,18 @@ Optionally, in the Query Elevation Component

[jira] [Updated] (LUCENE-9499) Clean up package name conflicts between modules (split packages)

2020-09-02 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated LUCENE-9499: -- Fix Version/s: master (9.0) > Clean up package name conflicts between modules (split

[jira] [Created] (LUCENE-9499) Clean up package name conflicts between modules (split packages)

2020-09-02 Thread Tomoko Uchida (Jira)
Tomoko Uchida created LUCENE-9499: - Summary: Clean up package name conflicts between modules (split packages) Key: LUCENE-9499 URL: https://issues.apache.org/jira/browse/LUCENE-9499 Project: Lucene -

[GitHub] [lucene-solr] TomMD commented on a change in pull request #1818: SOLR-14819 Trivial fix to inefficient iterator pattern

2020-09-02 Thread GitBox
TomMD commented on a change in pull request #1818: URL: https://github.com/apache/lucene-solr/pull/1818#discussion_r482121832 ## File path: .muse.toml ## @@ -0,0 +1 @@ +jdk11 = true Review comment: Woops, thanks for the catch that was for my own use.

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1819: SOLR-14782: Document how to unescape for the QueryElevationComponent.

2020-09-02 Thread GitBox
bruno-roustant commented on a change in pull request #1819: URL: https://github.com/apache/lucene-solr/pull/1819#discussion_r482119547 ## File path: solr/solr-ref-guide/src/the-query-elevation-component.adoc ## @@ -61,7 +61,18 @@ Optionally, in the Query Elevation Component

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1725: LUCENE-9449 Skip docs with _doc sort and "after"

2020-09-02 Thread GitBox
mayya-sharipova commented on a change in pull request #1725: URL: https://github.com/apache/lucene-solr/pull/1725#discussion_r482105620 ## File path: lucene/core/src/java/org/apache/lucene/search/comparators/DocComparator.java ## @@ -0,0 +1,183 @@ +/* + * Licensed to the

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1819: SOLR-14782: Document how to unescape for the QueryElevationComponent.

2020-09-02 Thread GitBox
bruno-roustant commented on a change in pull request #1819: URL: https://github.com/apache/lucene-solr/pull/1819#discussion_r482119547 ## File path: solr/solr-ref-guide/src/the-query-elevation-component.adoc ## @@ -61,7 +61,18 @@ Optionally, in the Query Elevation Component

[jira] [Assigned] (SOLR-14787) Inequality support in Payload Check query parser

2020-09-02 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gus Heck reassigned SOLR-14787: --- Assignee: Gus Heck > Inequality support in Payload Check query parser >

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1819: SOLR-14782: Document how to unescape for the QueryElevationComponent.

2020-09-02 Thread GitBox
bruno-roustant commented on a change in pull request #1819: URL: https://github.com/apache/lucene-solr/pull/1819#discussion_r482110458 ## File path: solr/solr-ref-guide/src/the-query-elevation-component.adoc ## @@ -61,7 +61,18 @@ Optionally, in the Query Elevation Component

[jira] [Commented] (SOLR-14422) Solr 8.5 Admin UI shows Angular placeholders on first load / refresh

2020-09-02 Thread Colvin Cowie (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189267#comment-17189267 ] Colvin Cowie commented on SOLR-14422: - No problem [~epugh], cheers > Solr 8.5 Admin UI shows Angular

  1   2   >