[jira] [Created] (SOLR-14842) Address Tolerant search feature and tests.

2020-09-07 Thread Mark Robert Miller (Jira)
Mark Robert Miller created SOLR-14842: - Summary: Address Tolerant search feature and tests. Key: SOLR-14842 URL: https://issues.apache.org/jira/browse/SOLR-14842 Project: Solr Issue

[jira] [Commented] (LUCENE-9497) Integerate Error Prone ( Static Analysis Tool ) during compilation

2020-09-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191925#comment-17191925 ] ASF subversion and git services commented on LUCENE-9497: - Commit

[jira] [Commented] (SOLR-14151) Make schema components load from packages

2020-09-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191923#comment-17191923 ] ASF subversion and git services commented on SOLR-14151: Commit

[jira] [Resolved] (SOLR-14151) Make schema components load from packages

2020-09-07 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul resolved SOLR-14151. --- Resolution: Fixed > Make schema components load from packages >

[jira] [Commented] (SOLR-14097) coreRootDirectory should be solr_home/cores

2020-09-07 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191900#comment-17191900 ] Alexandre Rafalovitch commented on SOLR-14097: -- Argh, it seems that this is because the code

[jira] [Updated] (SOLR-14097) coreRootDirectory should be solr_home/cores

2020-09-07 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Rafalovitch updated SOLR-14097: - Attachment: solr_yes_trace.log > coreRootDirectory should be solr_home/cores >

[jira] [Updated] (SOLR-14097) coreRootDirectory should be solr_home/cores

2020-09-07 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Rafalovitch updated SOLR-14097: - Attachment: solr_test_yes_dir.log > coreRootDirectory should be solr_home/cores

[jira] [Commented] (SOLR-14097) coreRootDirectory should be solr_home/cores

2020-09-07 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191891#comment-17191891 ] Alexandre Rafalovitch commented on SOLR-14097: -- This seems broken in 8.6.1. Attempts: #

[jira] [Commented] (SOLR-14613) Provide a clean API for pluggable replica assignment implementations

2020-09-07 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191890#comment-17191890 ] Noble Paul commented on SOLR-14613: --- I think we have addressed the API surface area issue. The only

[jira] [Updated] (SOLR-14097) coreRootDirectory should be solr_home/cores

2020-09-07 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Rafalovitch updated SOLR-14097: - Attachment: solr_test_no_dir.log > coreRootDirectory should be solr_home/cores >

[jira] [Commented] (SOLR-14151) Make schema components load from packages

2020-09-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191887#comment-17191887 ] ASF subversion and git services commented on SOLR-14151: Commit

[GitHub] [lucene-solr] noblepaul merged pull request #1815: SOLR-14151: Bug fixes

2020-09-07 Thread GitBox
noblepaul merged pull request #1815: URL: https://github.com/apache/lucene-solr/pull/1815 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene-solr] uschindler commented on pull request #1830: LUCENE-9506: Gradle: split validateSourcePatterns into per-project an…

2020-09-07 Thread GitBox
uschindler commented on pull request #1830: URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688524908 I refactored the config a bit (project-specific excludes moved to separate configure-blocks). I also added `*.md` to the list of scanned files. Looks ready now.

[GitHub] [lucene-solr] vthacker closed pull request #1828: LUCENE-9497: add google error prone checks

2020-09-07 Thread GitBox
vthacker closed pull request #1828: URL: https://github.com/apache/lucene-solr/pull/1828 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (LUCENE-9497) Integerate Error Prone ( Static Analysis Tool ) during compilation

2020-09-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191870#comment-17191870 ] ASF subversion and git services commented on LUCENE-9497: - Commit

[jira] [Commented] (LUCENE-9497) Integerate Error Prone ( Static Analysis Tool ) during compilation

2020-09-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191869#comment-17191869 ] ASF subversion and git services commented on LUCENE-9497: - Commit

[GitHub] [lucene-solr] vthacker merged pull request #1816: LUCENE-9497: Integerate Error Prone ( Static Analysis Tool ) during compilation

2020-09-07 Thread GitBox
vthacker merged pull request #1816: URL: https://github.com/apache/lucene-solr/pull/1816 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene-solr] uschindler commented on pull request #1830: LUCENE-9506: Gradle: split validateSourcePatterns into per-project an…

2020-09-07 Thread GitBox
uschindler commented on pull request #1830: URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688517196 The reason why the speed difference is so small may be related in the fact that "project configuration" (collecting those file trees, one for each project) take much

[GitHub] [lucene-solr] uschindler commented on pull request #1830: LUCENE-9506: Gradle: split validateSourcePatterns into per-project an…

2020-09-07 Thread GitBox
uschindler commented on pull request #1830: URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688516919 Hi, this now passes build, but speed is on my laptop (Windows 10) only sligthly faster: 32s before, 24s with this PR (including configuration and without gradle

[GitHub] [lucene-solr] uschindler edited a comment on pull request #1830: LUCENE-9506: Gradle: split validateSourcePatterns into per-project an…

2020-09-07 Thread GitBox
uschindler edited a comment on pull request #1830: URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688514787 Hi, I was able to prevent gradle from scanning duplicates: ```gradle // Don't go into subprojects (scanned separately). childProjects.keySet().each{

[GitHub] [lucene-solr] uschindler commented on pull request #1830: LUCENE-9506: Gradle: split validateSourcePatterns into per-project an…

2020-09-07 Thread GitBox
uschindler commented on pull request #1830: URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688514787 Hi, I was able to prevent gradle from scanning duplicates: ``` // Don't go into subprojects (scanned separately). childProjects.keySet().each{ exclude

[jira] [Commented] (SOLR-14815) Remove added Ignores to tests that still have them

2020-09-07 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191853#comment-17191853 ] Mark Robert Miller commented on SOLR-14815: --- I'm starting to actually work on this for real.

[GitHub] [lucene-solr] s1monw opened a new pull request #1839: LUCENE-9511: Include StoredFieldsWriter in DWPT accounting

2020-09-07 Thread GitBox
s1monw opened a new pull request #1839: URL: https://github.com/apache/lucene-solr/pull/1839 StoredFieldsWriter might consume some heap space memory that can have a significant impact on decisions made in the IW if writers should be stalled or DWPTs should be flushed if memory

[jira] [Created] (LUCENE-9511) Include StoredFieldsWriter in DWPT accounting

2020-09-07 Thread Simon Willnauer (Jira)
Simon Willnauer created LUCENE-9511: --- Summary: Include StoredFieldsWriter in DWPT accounting Key: LUCENE-9511 URL: https://issues.apache.org/jira/browse/LUCENE-9511 Project: Lucene - Core

[jira] [Commented] (SOLR-12963) change default for 'uninvertible' to 'false' (dependent on new schema 'version')

2020-09-07 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191849#comment-17191849 ] Alexandre Rafalovitch commented on SOLR-12963: -- Could we implement this for 9 (version bump

[GitHub] [lucene-solr] dweiss commented on pull request #1830: LUCENE-9506: Gradle: split validateSourcePatterns into per-project an…

2020-09-07 Thread GitBox
dweiss commented on pull request #1830: URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688492819 You're right, Uwe - the subproject scan inclusion sucks. I don't know how to avoid it in an elegant way. This could be done with worker API as well but it's not the same -

[jira] [Commented] (SOLR-14829) Default components are missing facet_module and terms in documentation

2020-09-07 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191847#comment-17191847 ] Cassandra Targett commented on SOLR-14829: -- The docs changes are fine from my POV, someone just

[jira] [Commented] (SOLR-14840) Convert Overseer Google doc to asciidoc for addition to Git repo

2020-09-07 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191841#comment-17191841 ] Cassandra Targett commented on SOLR-14840: -- Here is the branch:

[jira] [Assigned] (SOLR-14841) Update RefGuide with information in config files

2020-09-07 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Rafalovitch reassigned SOLR-14841: Assignee: Alexandre Rafalovitch > Update RefGuide with information in

[jira] [Created] (SOLR-14841) Update RefGuide with information in config files

2020-09-07 Thread Alexandre Rafalovitch (Jira)
Alexandre Rafalovitch created SOLR-14841: Summary: Update RefGuide with information in config files Key: SOLR-14841 URL: https://issues.apache.org/jira/browse/SOLR-14841 Project: Solr

[jira] [Created] (SOLR-14840) Convert Overseer Google doc to asciidoc for addition to Git repo

2020-09-07 Thread Cassandra Targett (Jira)
Cassandra Targett created SOLR-14840: Summary: Convert Overseer Google doc to asciidoc for addition to Git repo Key: SOLR-14840 URL: https://issues.apache.org/jira/browse/SOLR-14840 Project: Solr

[GitHub] [lucene-solr] sigram commented on a change in pull request #1758: SOLR-14749: Provide a clean API for cluster-level event processing, Initial draft.

2020-09-07 Thread GitBox
sigram commented on a change in pull request #1758: URL: https://github.com/apache/lucene-solr/pull/1758#discussion_r484517789 ## File path: solr/core/src/java/org/apache/solr/cluster/events/ScheduledEvent.java ## @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene-solr] sigram commented on pull request #1758: SOLR-14749: Provide a clean API for cluster-level event processing, Initial draft.

2020-09-07 Thread GitBox
sigram commented on pull request #1758: URL: https://github.com/apache/lucene-solr/pull/1758#issuecomment-688426745 FWIW, the scheduler part is now in PR 1831. This is an automated message from the Apache Git Service. To

[jira] [Commented] (SOLR-14834) Update all public-visible links from wiki.apache.org to RefGuide or cwiki

2020-09-07 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191774#comment-17191774 ] Alexandre Rafalovitch commented on SOLR-14834: -- I am marking this as a blocker for 9 that I

[jira] [Updated] (SOLR-14834) Update all public-visible links from wiki.apache.org to RefGuide or cwiki

2020-09-07 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Rafalovitch updated SOLR-14834: - Fix Version/s: master (9.0) > Update all public-visible links from

[jira] [Updated] (SOLR-14834) Update all public-visible links from wiki.apache.org to RefGuide or cwiki

2020-09-07 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Rafalovitch updated SOLR-14834: - Priority: Blocker (was: Major) > Update all public-visible links from

[jira] [Commented] (SOLR-14825) Wrap up async issues and tests.

2020-09-07 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191765#comment-17191765 ] Mark Robert Miller commented on SOLR-14825: --- I think I've gotten the majority of the pressing

[jira] [Created] (SOLR-14839) Address Alias impl.

2020-09-07 Thread Mark Robert Miller (Jira)
Mark Robert Miller created SOLR-14839: - Summary: Address Alias impl. Key: SOLR-14839 URL: https://issues.apache.org/jira/browse/SOLR-14839 Project: Solr Issue Type: Sub-task

[jira] [Commented] (LUCENE-9509) Refine lucene/BUILD.md (move Solr related contents to top-level README)

2020-09-07 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191749#comment-17191749 ] Uwe Schindler commented on LUCENE-9509: --- Thanks! > Refine lucene/BUILD.md (move Solr related

[jira] [Commented] (SOLR-14768) Error 500 on PDF extraction: java.lang.NoClassDefFoundError: org/eclipse/jetty/server/MultiParts

2020-09-07 Thread Joe Doupnik (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191714#comment-17191714 ] Joe Doupnik commented on SOLR-14768:     git is already installed and working. Thus one suspects the

[jira] [Created] (SOLR-14838) Atomic updates when the destination for a copyField has stored=true

2020-09-07 Thread Erick Erickson (Jira)
Erick Erickson created SOLR-14838: - Summary: Atomic updates when the destination for a copyField has stored=true Key: SOLR-14838 URL: https://issues.apache.org/jira/browse/SOLR-14838 Project: Solr

[jira] [Commented] (LUCENE-9509) Refine lucene/BUILD.md (move Solr related contents to top-level README)

2020-09-07 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191662#comment-17191662 ] Tomoko Uchida commented on LUCENE-9509: --- I changed the command to build documentation to

[jira] [Commented] (LUCENE-9509) Refine lucene/BUILD.md (move Solr related contents to top-level README)

2020-09-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191658#comment-17191658 ] ASF subversion and git services commented on LUCENE-9509: - Commit

[jira] [Updated] (LUCENE-9509) Refine lucene/BUILD.md (move Solr related contents to top-level README)

2020-09-07 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated LUCENE-9509: -- Attachment: LUCENE-9509-fix-gradle-command-documentation.patch > Refine lucene/BUILD.md (move

[jira] [Updated] (SOLR-14837) prometheus-exporter: different metrics ports publishes mixed metrics

2020-09-07 Thread Fadi Mohsen (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fadi Mohsen updated SOLR-14837: --- Affects Version/s: 8.6.2 > prometheus-exporter: different metrics ports publishes mixed metrics >

[jira] [Created] (SOLR-14837) prometheus-exporter: different metrics ports publishes mixed metrics

2020-09-07 Thread Fadi Mohsen (Jira)
Fadi Mohsen created SOLR-14837: -- Summary: prometheus-exporter: different metrics ports publishes mixed metrics Key: SOLR-14837 URL: https://issues.apache.org/jira/browse/SOLR-14837 Project: Solr

[jira] [Commented] (LUCENE-9507) Custom order for leaves in DirectoryReader, IndexWriter and searcher

2020-09-07 Thread Jim Ferenczi (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191638#comment-17191638 ] Jim Ferenczi commented on LUCENE-9507: -- Thanks for looking [~sokolov] , I was thinking that the

[jira] [Commented] (LUCENE-9509) Refine lucene/BUILD.md (move Solr related contents to top-level README)

2020-09-07 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191622#comment-17191622 ] Uwe Schindler commented on LUCENE-9509: --- The way how to build documentation looks strange. First

[jira] [Updated] (LUCENE-9509) Refine lucene/BUILD.md (move Solr related contents to top-level README)

2020-09-07 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated LUCENE-9509: -- Fix Version/s: master (9.0) > Refine lucene/BUILD.md (move Solr related contents to top-level

[jira] [Commented] (LUCENE-9509) Refine lucene/BUILD.md (move Solr related contents to top-level README)

2020-09-07 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191618#comment-17191618 ] Tomoko Uchida commented on LUCENE-9509: --- Thanks Erick for reviewing. I also think it would be nice

[jira] [Resolved] (LUCENE-9509) Refine lucene/BUILD.md (move Solr related contents to top-level README)

2020-09-07 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida resolved LUCENE-9509. --- Resolution: Fixed > Refine lucene/BUILD.md (move Solr related contents to top-level README)

[GitHub] [lucene-solr] mocobeta merged pull request #1835: LUCENE-9509: Refine lucene/BUILD.md and top-level README (for newdevs)

2020-09-07 Thread GitBox
mocobeta merged pull request #1835: URL: https://github.com/apache/lucene-solr/pull/1835 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (LUCENE-9509) Refine lucene/BUILD.md (move Solr related contents to top-level README)

2020-09-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191617#comment-17191617 ] ASF subversion and git services commented on LUCENE-9509: - Commit

[GitHub] [lucene-solr] dweiss commented on pull request #1830: LUCENE-9506: Gradle: split validateSourcePatterns into per-project an…

2020-09-07 Thread GitBox
dweiss commented on pull request #1830: URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688210409 I'll take a look, but not now - working. On Mon, Sep 7, 2020 at 11:38 AM Uwe Schindler wrote: > I committed my changes. You see the duplicate scanning now,

[GitHub] [lucene-solr] uschindler edited a comment on pull request #1830: LUCENE-9506: Gradle: split validateSourcePatterns into per-project an…

2020-09-07 Thread GitBox
uschindler edited a comment on pull request #1830: URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688203183 I committed my changes. You see the duplicate scanning now, because it reports hadoop errors in `:solr`, because the exclude does not work correctly. In fact

[GitHub] [lucene-solr] uschindler commented on pull request #1830: LUCENE-9506: Gradle: split validateSourcePatterns into per-project an…

2020-09-07 Thread GitBox
uschindler commented on pull request #1830: URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688203183 I committed my changes. You see the duplicate scanning now, because it reports hadoop errors in `:solr`, becaus ethe exclude does not work correctly. In fact `:solr`

[GitHub] [lucene-solr] dweiss commented on pull request #1830: LUCENE-9506: Gradle: split validateSourcePatterns into per-project an…

2020-09-07 Thread GitBox
dweiss commented on pull request #1830: URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688201937 bq. Actually the whole task does not scan any files Ah, so this would explain the speedup. :) Let me reiterate, sorry about the noise.

[GitHub] [lucene-solr] uschindler commented on pull request #1830: LUCENE-9506: Gradle: split validateSourcePatterns into per-project an…

2020-09-07 Thread GitBox
uschindler commented on pull request #1830: URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688200016 The other problem is that for ":solr" and ":lucene" it scans files twice, as the fileTree includes again the subprojects!

[GitHub] [lucene-solr] uschindler commented on pull request #1830: LUCENE-9506: Gradle: split validateSourcePatterns into per-project an…

2020-09-07 Thread GitBox
uschindler commented on pull request #1830: URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688199213 Actually for me the splitted tasks take much longer to complete: almost 30 seconds. Maybe it's caused by the progress meter.

[GitHub] [lucene-solr] uschindler edited a comment on pull request #1830: LUCENE-9506: Gradle: split validateSourcePatterns into per-project an…

2020-09-07 Thread GitBox
uschindler edited a comment on pull request #1830: URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688194137 Hi, I am reviewing: Actually the whole task does not scan any files, as the "extensions" are wrongly expanded. Should be `**/*.${it}`. I will commit a fix

[GitHub] [lucene-solr] uschindler commented on pull request #1830: LUCENE-9506: Gradle: split validateSourcePatterns into per-project an…

2020-09-07 Thread GitBox
uschindler commented on pull request #1830: URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688194137 Hi, I am reviewing: Actually the whole task does not scan any files, as the "extensions" are wrongly expanded. Should be `**/*.${it}`. I will commit a fix together with

[jira] [Commented] (LUCENE-9504) DocumentsWriterDeleteQueue.forceApplyGlobalSlice has needless locking

2020-09-07 Thread Simon Willnauer (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191579#comment-17191579 ] Simon Willnauer commented on LUCENE-9504: - there is no need for measuring impact. This is a

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1837: LUCENE-7882: First idea of using Java 15 hidden anonymous classes for Lucene expressions

2020-09-07 Thread GitBox
uschindler commented on a change in pull request #1837: URL: https://github.com/apache/lucene-solr/pull/1837#discussion_r484229443 ## File path: lucene/expressions/src/java/org/apache/lucene/expressions/js/JavascriptCompiler.java ## @@ -191,9 +220,21 @@ private Expression

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1837: LUCENE-7882: First idea of using Java 15 hidden anonymous classes for Lucene expressions

2020-09-07 Thread GitBox
dweiss commented on a change in pull request #1837: URL: https://github.com/apache/lucene-solr/pull/1837#discussion_r484223431 ## File path: lucene/expressions/src/test/org/apache/lucene/expressions/js/TestCustomFunctions.java ## @@ -263,7 +263,7 @@ public void

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1837: LUCENE-7882: First idea of using Java 15 hidden anonymous classes for Lucene expressions

2020-09-07 Thread GitBox
uschindler commented on a change in pull request #1837: URL: https://github.com/apache/lucene-solr/pull/1837#discussion_r484223373 ## File path: lucene/expressions/src/java/org/apache/lucene/expressions/js/JavascriptCompiler.java ## @@ -206,6 +247,12 @@ private Expression

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1837: LUCENE-7882: First idea of using Java 15 hidden anonymous classes for Lucene expressions

2020-09-07 Thread GitBox
uschindler commented on a change in pull request #1837: URL: https://github.com/apache/lucene-solr/pull/1837#discussion_r484222322 ## File path: lucene/expressions/src/test/org/apache/lucene/expressions/js/TestCustomFunctions.java ## @@ -263,7 +263,7 @@ public void