dweiss commented on pull request #1844:
URL: https://github.com/apache/lucene-solr/pull/1844#issuecomment-69581
Give me some time to digest it, @madrob I'll take a look at what the
distribution plugin does behind the scenes and how often it changes.
dweiss commented on pull request #1844:
URL: https://github.com/apache/lucene-solr/pull/1844#issuecomment-689996660
Perhaps I should clarify my reluctance to use the plugin - these plugins are
built-in and ship with gradle. It's a moving target when you upgrade the build
system - their
s1monw commented on pull request #1849:
URL: https://github.com/apache/lucene-solr/pull/1849#issuecomment-689995922
@uschindler why are you so grumpy, you have so much to add to this issue,
why don’t you do it in a positive way?
You could have reacted with something like „oh man
dweiss commented on pull request #1844:
URL: https://github.com/apache/lucene-solr/pull/1844#issuecomment-689994740
Could you please revert to using a task instead of the plugin? Including
that executable bits block Houston added.
dweiss commented on pull request #1844:
URL: https://github.com/apache/lucene-solr/pull/1844#issuecomment-689993901
I am not keen on using the plugin. I like knowing what's going on behind the
scenes - a bit of verboseness is good here, actually.
iverase commented on pull request #1849:
URL: https://github.com/apache/lucene-solr/pull/1849#issuecomment-689993395
Thanks for filing the JDK bug, looks great!
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/LUCENE-9517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193380#comment-17193380
]
Ignacio Vera commented on LUCENE-9517:
--
I tested locally and the error is gone with this change,
dsmiley commented on a change in pull request #1770:
URL: https://github.com/apache/lucene-solr/pull/1770#discussion_r486065813
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseCloudSolrClient.java
##
@@ -537,40 +541,100 @@ public void
[
https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193350#comment-17193350
]
Ankur commented on LUCENE-9444:
---
Thanks [~mikemccand]. I uploaded a new patch that incorporates the code
[
https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ankur updated LUCENE-9444:
--
Attachment: LUCENE-9444.v2.patch
> Need an API to easily fetch facet labels for a field in a document
>
[
https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193338#comment-17193338
]
Noble Paul commented on SOLR-14151:
---
I committed this after I beasted that a lot. I'm sure our core
madrob commented on pull request #1844:
URL: https://github.com/apache/lucene-solr/pull/1844#issuecomment-689925055
Most of the changes at this point are indentation, so the PR is much smaller
than it appears.
This is an
madrob commented on pull request #1844:
URL: https://github.com/apache/lucene-solr/pull/1844#issuecomment-689924800
@HoustonPutman since I don't have a windows machine, can you check the
behaviour of the the distribution plugin for me one more time? `./gradlew -p
solr/packaging distTar`
[
https://issues.apache.org/jira/browse/SOLR-14404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193266#comment-17193266
]
Noble Paul edited comment on SOLR-14404 at 9/10/20, 12:31 AM:
--
The failures
[
https://issues.apache.org/jira/browse/SOLR-14404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193266#comment-17193266
]
Noble Paul commented on SOLR-14404:
---
The errors are too infrequent . I have literally beasted this
noblepaul closed pull request #1813:
URL: https://github.com/apache/lucene-solr/pull/1813
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
noblepaul commented on pull request #1813:
URL: https://github.com/apache/lucene-solr/pull/1813#issuecomment-689885612
This was created as a PoC. It has outlived its purpose, closing
This is an automated message from the
HoustonPutman commented on pull request #1844:
URL: https://github.com/apache/lucene-solr/pull/1844#issuecomment-689853640
So it turns out that `fileMode` isn't an option for `FileCopyDetails`, so it
was applying it to the whole Copy operation instead. Changing it to `setMode`
fixed
madrob commented on pull request #1844:
URL: https://github.com/apache/lucene-solr/pull/1844#issuecomment-689842363
Doing more research on this, I suspect that we should be using the
https://docs.gradle.org/current/userguide/distribution_plugin.html built in
distribution plugin instead of
tflobbe commented on pull request #1823:
URL: https://github.com/apache/lucene-solr/pull/1823#issuecomment-689835989
Added a note to the upgrade section of the reference guide. Let me know what
you think
This is an
HoustonPutman commented on pull request #1844:
URL: https://github.com/apache/lucene-solr/pull/1844#issuecomment-689833826
> from(..., {
> filesMatching("**/*.sh", {
> fileMode 0755
> })
> })
Sorry, forgot to mention this before. I tried that initially and it resulted
in
[
https://issues.apache.org/jira/browse/SOLR-14404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193187#comment-17193187
]
Tomas Eduardo Fernandez Lobbe commented on SOLR-14404:
--
This Jira issue is marked as
[
https://issues.apache.org/jira/browse/SOLR-14849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193182#comment-17193182
]
ASF subversion and git services commented on SOLR-14849:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193181#comment-17193181
]
ASF subversion and git services commented on SOLR-14849:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193179#comment-17193179
]
Tomas Eduardo Fernandez Lobbe commented on SOLR-14151:
--
There are still a bunch of
Eugene Tenkaev created SOLR-14850:
-
Summary: ExactStatsCache NullPointerException when
shards.tolerant=true
Key: SOLR-14850
URL: https://issues.apache.org/jira/browse/SOLR-14850
Project: Solr
[
https://issues.apache.org/jira/browse/SOLR-14439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193151#comment-17193151
]
Tim Allison commented on SOLR-14439:
Thank you [~erickerickson]!
> Upgrade to Tika 1.24.1
>
[
https://issues.apache.org/jira/browse/SOLR-14439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193147#comment-17193147
]
Erick Erickson commented on SOLR-14439:
---
I don't think backporting to 8.6 is necessary. AFAIK,
dweiss commented on pull request #1844:
URL: https://github.com/apache/lucene-solr/pull/1844#issuecomment-689766430
from(..., {
filesMatching("**/*.sh", {
fileMode 0755
})
})
This is an automated
HoustonPutman commented on a change in pull request #1844:
URL: https://github.com/apache/lucene-solr/pull/1844#discussion_r485848370
##
File path: solr/packaging/build.gradle
##
@@ -109,6 +109,21 @@ task toDir(type: Sync) {
}
}
+task toTgz(type: Tar) {
Review comment:
[
https://issues.apache.org/jira/browse/LUCENE-9516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193115#comment-17193115
]
Dawid Weiss commented on LUCENE-9516:
-
Heh. It has always been my secret dream to have an
HoustonPutman commented on pull request #1844:
URL: https://github.com/apache/lucene-solr/pull/1844#issuecomment-689727987
I think I have addressed both of the issues I raised.
This is an automated message from the Apache
[
https://issues.apache.org/jira/browse/SOLR-14439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193095#comment-17193095
]
Tim Allison commented on SOLR-14439:
I'm currently working on this against the {{branch_8x}}. I'll
[
https://issues.apache.org/jira/browse/LUCENE-9517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-9517:
--
Summary: BugfixDeflater_JDK8252739 causes Java security issues in JDK 11
(was:
[
https://issues.apache.org/jira/browse/LUCENE-9517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193085#comment-17193085
]
Uwe Schindler commented on LUCENE-9517:
---
I opened this JDK bug:
[
https://issues.apache.org/jira/browse/LUCENE-9517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-9517:
--
Component/s: core/index
> BugfixDeflater_JDK8252739 causes Java security issues in JDK 11
>
[
https://issues.apache.org/jira/browse/LUCENE-9517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-9517:
--
Affects Version/s: master (9.0)
8.x
> BugfixDeflater_JDK8252739 causes
[
https://issues.apache.org/jira/browse/LUCENE-9517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193073#comment-17193073
]
Uwe Schindler edited comment on LUCENE-9517 at 9/9/20, 5:51 PM:
Here is
HoustonPutman commented on pull request #1844:
URL: https://github.com/apache/lucene-solr/pull/1844#issuecomment-689719861
Two issues I see currently.
- The package is named `solr-packaging-.tgz` not
`solr-.tgz`. This should be easily fixed by: `archiveBaseName = "solr"`
- The
[
https://issues.apache.org/jira/browse/LUCENE-9517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-9517:
--
Fix Version/s: master (9.0)
8.x
> BugfixDeflater_JDK8252739 causes Java
[
https://issues.apache.org/jira/browse/LUCENE-9517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-9517:
--
Comment: was deleted
(was: Sorry, this is bullshit.
Please don't do this. Fix your CI.)
>
[
https://issues.apache.org/jira/browse/LUCENE-9517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-9517:
--
Labels: Java10 Java11 (was: )
> BugfixDeflater_JDK8252739 causes Java security issues in JDK
uschindler commented on pull request #1849:
URL: https://github.com/apache/lucene-solr/pull/1849#issuecomment-689717960
FYI, here is the JDK bug: https://bugs.openjdk.java.net/browse/JDK-8252976
This is an automated message
[
https://issues.apache.org/jira/browse/LUCENE-9517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193074#comment-17193074
]
Uwe Schindler edited comment on LUCENE-9517 at 9/9/20, 5:23 PM:
[
https://issues.apache.org/jira/browse/LUCENE-9517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193074#comment-17193074
]
Uwe Schindler commented on LUCENE-9517:
---
[~ivera]: Do you think this is fine? To me this is not as
[
https://issues.apache.org/jira/browse/LUCENE-9517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193073#comment-17193073
]
Uwe Schindler commented on LUCENE-9517:
---
Here is a PR not trying to subclass Deflater, whcih was
[
https://issues.apache.org/jira/browse/SOLR-14723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193071#comment-17193071
]
Tomas Eduardo Fernandez Lobbe commented on SOLR-14723:
--
Yes, unfortunately branch 8x
uschindler commented on pull request #1842:
URL: https://github.com/apache/lucene-solr/pull/1842#issuecomment-689700778
I backported this also to 8.x, removing the Ant targets related to this.
Much cleaner now!
This is an
[
https://issues.apache.org/jira/browse/LUCENE-9512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-9512:
--
Description:
When porting to Gradle, the following task was missed to be ported to Gradle:
[
https://issues.apache.org/jira/browse/LUCENE-9512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler resolved LUCENE-9512.
---
Resolution: Fixed
This was merged into master and backported to 8.x. The Ant target in 8.x
[
https://issues.apache.org/jira/browse/LUCENE-9512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-9512:
--
Fix Version/s: master (9.0)
8.x
> Add test-lock-factory to Gradle build
>
[
https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-9379:
--
Fix Version/s: master (9.0)
8.x
> Directory based approach for index
[
https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-9379:
--
Fix Version/s: (was: 8.x)
(was: master (9.0))
> Directory based
[
https://issues.apache.org/jira/browse/LUCENE-9512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193043#comment-17193043
]
ASF subversion and git services commented on LUCENE-9512:
-
Commit
[
https://issues.apache.org/jira/browse/SOLR-14723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193034#comment-17193034
]
Shashank Shekhar commented on SOLR-14723:
-
Thanks [~tflobbe] for pointing this out. Just checked
sigram commented on a change in pull request #1831:
URL: https://github.com/apache/lucene-solr/pull/1831#discussion_r485761720
##
File path: solr/core/src/java/org/apache/solr/cloud/ClusterSingleton.java
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation
[
https://issues.apache.org/jira/browse/LUCENE-9512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193023#comment-17193023
]
ASF subversion and git services commented on LUCENE-9512:
-
Commit
uschindler merged pull request #1842:
URL: https://github.com/apache/lucene-solr/pull/1842
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
uschindler commented on pull request #1849:
URL: https://github.com/apache/lucene-solr/pull/1849#issuecomment-689672977
> It would be great if you can report it.
Will do later! I will post the link on the main issue. I will refer to your
name.
sigram commented on a change in pull request #1831:
URL: https://github.com/apache/lucene-solr/pull/1831#discussion_r485748887
##
File path: solr/core/src/java/org/apache/solr/cluster/scheduler/Schedulable.java
##
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software
sigram commented on pull request #1831:
URL: https://github.com/apache/lucene-solr/pull/1831#issuecomment-689671370
@noblepaul in this PR the Scheduler depends on ClusterSingleton, that's why
I imported it into this PR. Whatever the ClusterSingleton becomes it will be
the version from
uschindler closed pull request #1849:
URL: https://github.com/apache/lucene-solr/pull/1849
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
uschindler commented on pull request #1849:
URL: https://github.com/apache/lucene-solr/pull/1849#issuecomment-689670688
I have a better fix without hacks, just not subclassing Deflater!
See PR #1850. I will close this one.
uschindler opened a new pull request #1850:
URL: https://github.com/apache/lucene-solr/pull/1850
Bugfix for LUCENE-9517: Instead of subclassing Deflater like in LUCENE-9500,
we just provide a method reference (using a functional interface), so code can
call Deflater#setDictionary.
iverase commented on pull request #1849:
URL: https://github.com/apache/lucene-solr/pull/1849#issuecomment-689663895
Thanks Uwe for taking the time reviewing this issue.
>I have no idea how the stack trace looks like. And under which
circumstances you see this bug. Can you post a
Tomas Eduardo Fernandez Lobbe created SOLR-14849:
Summary: Investigate test failures in
TestReRankQParserPlugin.testMinExactCount
Key: SOLR-14849
URL:
dweiss commented on a change in pull request #1844:
URL: https://github.com/apache/lucene-solr/pull/1844#discussion_r485726236
##
File path: solr/packaging/build.gradle
##
@@ -109,6 +109,21 @@ task toDir(type: Sync) {
}
}
+task toTgz(type: Tar) {
Review comment:
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192974#comment-17192974
]
Ishan Chattopadhyaya commented on SOLR-14749:
-
I'd prefer if this were to be completely
[
https://issues.apache.org/jira/browse/SOLR-14846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob resolved SOLR-14846.
--
Fix Version/s: master (9.0)
Resolution: Fixed
> Avoid use of Optional.ofNullable.orElse in the
[
https://issues.apache.org/jira/browse/SOLR-14846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192970#comment-17192970
]
Mike Drob commented on SOLR-14846:
--
Individually calling ofNullable and calling orElse* on an Optional
uschindler commented on pull request #1842:
URL: https://github.com/apache/lucene-solr/pull/1842#issuecomment-689649444
@dweiss Are you fine with this? I would like to commit and backport this
soon.
Unless you have some minor comments about the cleanup process, as I had to
remove
[
https://issues.apache.org/jira/browse/LUCENE-9517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler reopened LUCENE-9517:
---
Maybe we should do a completely different fix for the original issue. I will
provide a PR
uschindler commented on pull request #1849:
URL: https://github.com/apache/lucene-solr/pull/1849#issuecomment-689648275
Maybe we should do another fix for the original bug: As only setDictionary
is affected, my proposal would be to not subclass `Deflater` at all and instead
just return an
uschindler commented on a change in pull request #1849:
URL: https://github.com/apache/lucene-solr/pull/1849#discussion_r485711771
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene87/BugfixDeflater_JDK8252739.java
##
@@ -40,7 +42,9 @@ public static Deflater
HoustonPutman commented on a change in pull request #1844:
URL: https://github.com/apache/lucene-solr/pull/1844#discussion_r485708813
##
File path: solr/packaging/build.gradle
##
@@ -109,6 +109,21 @@ task toDir(type: Sync) {
}
}
+task toTgz(type: Tar) {
Review comment:
uschindler edited a comment on pull request #1849:
URL: https://github.com/apache/lucene-solr/pull/1849#issuecomment-689635578
The problem with the fix here is:
- I have no idea how the stack trace looks like. And under which
circumstances you see this bug. Can you post a link to your
uschindler commented on pull request #1849:
URL: https://github.com/apache/lucene-solr/pull/1849#issuecomment-689636897
Does it help, because this code is only called from Deflater's ctor?
uschindler commented on pull request #1849:
URL: https://github.com/apache/lucene-solr/pull/1849#issuecomment-689635578
The problem with the fix here is:
- I have no idea how the stack trace looks like. And under which
circumstances you see this bug. Can you post a link to your CI, to
[
https://issues.apache.org/jira/browse/SOLR-14439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tim Allison updated SOLR-14439:
---
Status: Patch Available (was: Open)
> Upgrade to Tika 1.24.1
> --
>
>
[
https://issues.apache.org/jira/browse/SOLR-14701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192924#comment-17192924
]
Alexandre Rafalovitch commented on SOLR-14701:
--
Thanks Jan, these are good questions. To
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192921#comment-17192921
]
Andrzej Bialecki commented on SOLR-14749:
-
[~ichattopadhyaya] as I explained in the comments that
HoustonPutman commented on a change in pull request #1844:
URL: https://github.com/apache/lucene-solr/pull/1844#discussion_r485683230
##
File path: solr/packaging/build.gradle
##
@@ -109,6 +109,21 @@ task toDir(type: Sync) {
}
}
+task toTgz(type: Tar) {
Review comment:
[
https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192918#comment-17192918
]
Michael McCandless commented on LUCENE-9444:
Overall the patch looks good! Some small
sigram commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-689612257
Thanks @murblanc for taking the lead on this issue, and for your patience!
This is an automated message from
uschindler commented on pull request #1849:
URL: https://github.com/apache/lucene-solr/pull/1849#issuecomment-689611752
If this an issue at your CI, just use StackWalker and let this go through.
This is an automated message
uschindler commented on pull request #1849:
URL: https://github.com/apache/lucene-solr/pull/1849#issuecomment-689611169
Actually I remember that this same issue happened also at other places in
the JDK, luckily it was fixed on their side, because I complained on the
mailing list.
[
https://issues.apache.org/jira/browse/LUCENE-9513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless resolved LUCENE-9513.
Fix Version/s: 8.7
Resolution: Fixed
Thanks [~frankmanzhu]!
> Use seconds
[
https://issues.apache.org/jira/browse/LUCENE-9517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler resolved LUCENE-9517.
---
Assignee: Uwe Schindler
Resolution: Won't Fix
> BugfixDeflater_JDK8252739 causes Java
uschindler commented on pull request #1849:
URL: https://github.com/apache/lucene-solr/pull/1849#issuecomment-689606665
Actually the bug is in JDK and not in our code.
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/SOLR-14846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192908#comment-17192908
]
Erick Erickson commented on SOLR-14846:
---
[~mdrob] Is this something that should never be allowed?
uschindler commented on pull request #1849:
URL: https://github.com/apache/lucene-solr/pull/1849#issuecomment-689603748
Sorry, this is bullshit. Fix your CI and don't apply such stuff in Lucene.
This is an automated message
[
https://issues.apache.org/jira/browse/LUCENE-9517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192906#comment-17192906
]
Uwe Schindler commented on LUCENE-9517:
---
Sorry, this is bullshit.
Please don't do this. Fix your
[
https://issues.apache.org/jira/browse/LUCENE-9517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192905#comment-17192905
]
Uwe Schindler commented on LUCENE-9517:
---
This is more a bug in this jdk code. So please report it
[
https://issues.apache.org/jira/browse/LUCENE-9517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192902#comment-17192902
]
Uwe Schindler commented on LUCENE-9517:
---
Sorry, I don't understand the issue.
Lucene's code does
[
https://issues.apache.org/jira/browse/SOLR-14846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192899#comment-17192899
]
ASF subversion and git services commented on SOLR-14846:
Commit
mikemccand commented on a change in pull request #1846:
URL: https://github.com/apache/lucene-solr/pull/1846#discussion_r485650485
##
File path:
lucene/demo/src/java/org/apache/lucene/demo/facet/RangeFacetsExample.java
##
@@ -46,7 +46,7 @@
private final Directory
madrob merged pull request #1843:
URL: https://github.com/apache/lucene-solr/pull/1843
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/LUCENE-9513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192898#comment-17192898
]
Michael McCandless commented on LUCENE-9513:
Thanks [~frankmanzhu] – fix looks great; I'll
[
https://issues.apache.org/jira/browse/LUCENE-9516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192896#comment-17192896
]
Michael McCandless commented on LUCENE-9516:
+1
> Remove DocConsumer and IndexingChain from
mikemccand commented on a change in pull request #1848:
URL: https://github.com/apache/lucene-solr/pull/1848#discussion_r485644701
##
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##
@@ -272,7 +273,9 @@ static int getActualMaxDocs() {
* and a
1 - 100 of 161 matches
Mail list logo
