[
https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203694#comment-17203694
]
ASF subversion and git services commented on SOLR-14151:
Commit f
[
https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203693#comment-17203693
]
ASF subversion and git services commented on SOLR-14151:
Commit 5
[
https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203684#comment-17203684
]
ASF subversion and git services commented on SOLR-14151:
Commit 5
[
https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203685#comment-17203685
]
ASF subversion and git services commented on SOLR-14151:
Commit f
[
https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203677#comment-17203677
]
ASF subversion and git services commented on SOLR-14151:
Commit 5
[
https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203678#comment-17203678
]
ASF subversion and git services commented on SOLR-14151:
Commit f
[
https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203660#comment-17203660
]
ASF subversion and git services commented on SOLR-14151:
Commit a
[
https://issues.apache.org/jira/browse/SOLR-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203651#comment-17203651
]
ASF subversion and git services commented on SOLR-14901:
Commit 0
[
https://issues.apache.org/jira/browse/SOLR-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203652#comment-17203652
]
ASF subversion and git services commented on SOLR-14901:
Commit f
[
https://issues.apache.org/jira/browse/SOLR-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203649#comment-17203649
]
ASF subversion and git services commented on SOLR-14901:
Commit 0
[
https://issues.apache.org/jira/browse/SOLR-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203650#comment-17203650
]
ASF subversion and git services commented on SOLR-14901:
Commit f
[
https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203625#comment-17203625
]
Tomas Eduardo Fernandez Lobbe commented on SOLR-14151:
--
bq. How is i
dsmiley commented on a change in pull request #1921:
URL: https://github.com/apache/lucene-solr/pull/1921#discussion_r496366133
##
File path: solr/solr-ref-guide/src/common-query-parameters.adoc
##
@@ -307,11 +307,13 @@ The `echoParams` parameter controls what information
abou
dnhatn commented on a change in pull request #1925:
URL: https://github.com/apache/lucene-solr/pull/1925#discussion_r496348288
##
File path:
lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThread.java
##
@@ -284,7 +283,7 @@ FrozenBufferedUpdates prepareFlush() {
[
https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203575#comment-17203575
]
Noble Paul commented on SOLR-14151:
---
{quote}This change is not thread safe, looks like
[
https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203559#comment-17203559
]
Ankur edited comment on LUCENE-9444 at 9/29/20, 12:06 AM:
--
Than
[
https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203559#comment-17203559
]
Ankur edited comment on LUCENE-9444 at 9/29/20, 12:05 AM:
--
Than
[
https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ankur reopened LUCENE-9444:
---
Thanks [~mikemccand] for merging the
[PR-1893.|https://github.com/apache/lucene-solr/pull/1893/files]
I just r
goankur opened a new pull request #1928:
URL: https://github.com/apache/lucene-solr/pull/1928
# Description
This PR improves test coverage for `TaxonomyFacetLabels` ( added in [PR
1893](https://github.com/apache/lucene-solr/pull/1893/files) ) by exercising
the API - `Tax
muse-dev[bot] commented on a change in pull request #1571:
URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r496264303
##
File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/LTRRescorer.java
##
@@ -166,64 +186,77 @@ public void scoreFeatures(IndexSearcher in
alessandrobenedetti commented on a change in pull request #1571:
URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r496244191
##
File path:
solr/contrib/ltr/src/java/org/apache/solr/ltr/search/LTRQParserPlugin.java
##
@@ -146,93 +149,114 @@ public LTRQParser(Stri
dsmiley opened a new pull request #1927:
URL: https://github.com/apache/lucene-solr/pull/1927
…org.apache.solr.DEPRECATED
https://issues.apache.org/jira/browse/SOLR-12987
This is an automated message from the Apache Gi
[
https://issues.apache.org/jira/browse/SOLR-12987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203524#comment-17203524
]
David Smiley commented on SOLR-12987:
-
First, I want to say that I don't think we sho
alessandrobenedetti commented on a change in pull request #1571:
URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r496225246
##
File path:
solr/contrib/ltr/src/java/org/apache/solr/ltr/search/LTRQParserPlugin.java
##
@@ -146,93 +149,114 @@ public LTRQParser(Stri
[
https://issues.apache.org/jira/browse/SOLR-14850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203495#comment-17203495
]
Yevhen Tienkaiev edited comment on SOLR-14850 at 9/28/20, 8:12 PM:
[
https://issues.apache.org/jira/browse/SOLR-14850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203495#comment-17203495
]
Yevhen Tienkaiev commented on SOLR-14850:
-
[~ab] please adjust my full name to `Y
[
https://issues.apache.org/jira/browse/SOLR-14408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203486#comment-17203486
]
Alessandro Benedetti commented on SOLR-14408:
-
Hi [~Seidan], sorry for the ab
[
https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203454#comment-17203454
]
Tomas Eduardo Fernandez Lobbe commented on SOLR-14151:
--
Thanks for f
[
https://issues.apache.org/jira/browse/SOLR-14898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris M. Hostetter updated SOLR-14898:
--
Attachment: SOLR-14898.patch
Status: Open (was: Open)
writing a junit test pro
Chris M. Hostetter created SOLR-14903:
-
Summary: SolrCloud tests should use the jetty.xml that we ship with
Key: SOLR-14903
URL: https://issues.apache.org/jira/browse/SOLR-14903
Project: Solr
[
https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless resolved LUCENE-9444.
Resolution: Fixed
OK, fixed!
> Need an API to easily fetch facet labels for a fie
[
https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203405#comment-17203405
]
ASF subversion and git services commented on LUCENE-9444:
-
Commi
[
https://issues.apache.org/jira/browse/SOLR-14898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris M. Hostetter reassigned SOLR-14898:
-
Affects Version/s: 8.6.3
Assignee: Chris M. Hostetter
P
[
https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless reopened LUCENE-9444:
Woops, {{Set.of}} is only available in JDK 9+ ... I'll fix on our 8.x branch.
> Need
[
https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203367#comment-17203367
]
ASF subversion and git services commented on LUCENE-9444:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless updated LUCENE-9444:
---
Fix Version/s: 8.7
master (9.0)
Resolution: Fixed
[
https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203368#comment-17203368
]
ASF subversion and git services commented on LUCENE-9444:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203369#comment-17203369
]
ASF subversion and git services commented on LUCENE-9444:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203366#comment-17203366
]
ASF subversion and git services commented on LUCENE-9444:
-
Commi
[
https://issues.apache.org/jira/browse/SOLR-14897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris M. Hostetter updated SOLR-14897:
--
Fix Version/s: 8.6.3
Priority: Blocker (was: Major)
[~munendrasn] - +1 to com
[
https://issues.apache.org/jira/browse/SOLR-14788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203352#comment-17203352
]
Mark Robert Miller commented on SOLR-14788:
---
Shortly, I'll start publishing reg
[
https://issues.apache.org/jira/browse/SOLR-14850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203348#comment-17203348
]
ASF subversion and git services commented on SOLR-14850:
Commit 0
munendrasn commented on pull request #1775:
URL: https://github.com/apache/lucene-solr/pull/1775#issuecomment-700073981
I have included changes for TrieFields and modified to parse as Float for
Int fields. Probably, we could call toNativeType(val) from createField to avoid
duplication but
[
https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203282#comment-17203282
]
ASF subversion and git services commented on LUCENE-9444:
-
Commi
murblanc commented on a change in pull request #1758:
URL: https://github.com/apache/lucene-solr/pull/1758#discussion_r496005660
##
File path:
solr/core/src/java/org/apache/solr/cluster/events/impl/CollectionsRepairEventListener.java
##
@@ -0,0 +1,186 @@
+/*
+ * Licensed to th
mikemccand merged pull request #1893:
URL: https://github.com/apache/lucene-solr/pull/1893
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203281#comment-17203281
]
ASF subversion and git services commented on LUCENE-9444:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203271#comment-17203271
]
ASF subversion and git services commented on LUCENE-9317:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203261#comment-17203261
]
Michael McCandless commented on LUCENE-9004:
This is an exciting feature! I
[
https://issues.apache.org/jira/browse/LUCENE-9401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Munendra S N reassigned LUCENE-9401:
Assignee: Munendra S N
> ComplexPhraseQuery's toString method always omits field name
> -
[
https://issues.apache.org/jira/browse/LUCENE-9401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203251#comment-17203251
]
Munendra S N commented on LUCENE-9401:
--
[^LUCENE-9401.patch]
Minor formatting and
[
https://issues.apache.org/jira/browse/LUCENE-9401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Munendra S N updated LUCENE-9401:
-
Attachment: LUCENE-9401.patch
> ComplexPhraseQuery's toString method always omits field name
> -
[
https://issues.apache.org/jira/browse/SOLR-14898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203249#comment-17203249
]
Munendra S N commented on SOLR-14898:
-
When a request is received by any node, securi
[
https://issues.apache.org/jira/browse/SOLR-14897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203241#comment-17203241
]
Munendra S N commented on SOLR-14897:
-
[^SOLR-14897.patch]
This does forwardCount c
[
https://issues.apache.org/jira/browse/SOLR-14897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Munendra S N updated SOLR-14897:
Attachment: SOLR-14897.patch
> HttpSolrCall will forward a virtually unlimited number of times unti
[
https://issues.apache.org/jira/browse/SOLR-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203233#comment-17203233
]
Dawid Weiss commented on SOLR-14901:
These classes have been moved already (on master
[
https://issues.apache.org/jira/browse/SOLR-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203231#comment-17203231
]
Noble Paul edited comment on SOLR-14901 at 9/28/20, 1:27 PM:
-
[
https://issues.apache.org/jira/browse/SOLR-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203231#comment-17203231
]
Noble Paul commented on SOLR-14901:
---
[~dweiss] [~tomoko]
Can you just {{@Ignore}} this
[
https://issues.apache.org/jira/browse/SOLR-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul reassigned SOLR-14901:
-
Assignee: Noble Paul (was: Dawid Weiss)
> TestPackages uses binary precompiled classes to refer
jpountz commented on pull request #1912:
URL: https://github.com/apache/lucene-solr/pull/1912#issuecomment-67077
> We are talking about assigning DWPT to incoming indexing thread, right?
Right.
The thing that makes me hesitate is that it would probably make fetching a
DWPT
jpountz merged pull request #1919:
URL: https://github.com/apache/lucene-solr/pull/1919
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/SOLR-14902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203216#comment-17203216
]
David Smiley commented on SOLR-14902:
-
The SSL hack was added in SOLR-10783; I added
arafalov commented on pull request #1923:
URL: https://github.com/apache/lucene-solr/pull/1923#issuecomment-699988193
Thank you for the feedback. Was there a particular methodology you were
going to utilize for the upgrade yourself? I did visual and diff spot checks on
pages that seemed to
[
https://issues.apache.org/jira/browse/SOLR-10783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203204#comment-17203204
]
David Smiley commented on SOLR-10783:
-
I noticed this issue modified bin/solr to add
arafalov commented on a change in pull request #1923:
URL: https://github.com/apache/lucene-solr/pull/1923#discussion_r495913848
##
File path: solr/solr-ref-guide/src/_includes/head.html
##
@@ -11,6 +11,7 @@
+
David Smiley created SOLR-14902:
---
Summary: Merge Jetty and Solr classpath
Key: SOLR-14902
URL: https://issues.apache.org/jira/browse/SOLR-14902
Project: Solr
Issue Type: Improvement
Secur
[
https://issues.apache.org/jira/browse/LUCENE-9458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203188#comment-17203188
]
David Smiley commented on LUCENE-9458:
--
In the updated PR, I only changed WDGF, rev
[
https://issues.apache.org/jira/browse/SOLR-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203181#comment-17203181
]
Dawid Weiss commented on SOLR-14901:
I looked at fixing this test but I don't know ho
arafalov commented on a change in pull request #1923:
URL: https://github.com/apache/lucene-solr/pull/1923#discussion_r495891765
##
File path: solr/solr-ref-guide/src/_config.yml.template
##
@@ -91,6 +91,11 @@ asciidoctor:
<<: *solr-attributes-ref
attribute-missing: "
arafalov commented on a change in pull request #1923:
URL: https://github.com/apache/lucene-solr/pull/1923#discussion_r495890083
##
File path: solr/solr-ref-guide/build.gradle
##
@@ -90,14 +90,14 @@ dependencies {
depVer('org.apache.zookeeper:zookeeper')
// jekyll d
[
https://issues.apache.org/jira/browse/SOLR-14850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203177#comment-17203177
]
ASF subversion and git services commented on SOLR-14850:
Commit 3
ctargett commented on pull request #1923:
URL: https://github.com/apache/lucene-solr/pull/1923#issuecomment-699964182
The Jekyll 3 to 4 upgrade is a major one and has not been done to date
because it has caused failures in the past when attempted. I don't understand
from this so far what t
ctargett commented on a change in pull request #1923:
URL: https://github.com/apache/lucene-solr/pull/1923#discussion_r495884475
##
File path: solr/solr-ref-guide/src/_includes/head.html
##
@@ -11,6 +11,7 @@
+
ctargett commented on a change in pull request #1923:
URL: https://github.com/apache/lucene-solr/pull/1923#discussion_r495883947
##
File path: solr/solr-ref-guide/src/_config.yml.template
##
@@ -91,6 +91,11 @@ asciidoctor:
<<: *solr-attributes-ref
attribute-missing: "
ctargett commented on a change in pull request #1923:
URL: https://github.com/apache/lucene-solr/pull/1923#discussion_r495883260
##
File path: solr/solr-ref-guide/build.gradle
##
@@ -90,14 +90,14 @@ dependencies {
depVer('org.apache.zookeeper:zookeeper')
// jekyll d
[
https://issues.apache.org/jira/browse/SOLR-14397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203172#comment-17203172
]
Steven Chou edited comment on SOLR-14397 at 9/28/20, 11:53 AM:
[
https://issues.apache.org/jira/browse/SOLR-14397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203172#comment-17203172
]
Steven Chou edited comment on SOLR-14397 at 9/28/20, 11:50 AM:
[
https://issues.apache.org/jira/browse/SOLR-14397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203172#comment-17203172
]
RUEI-SING CHOU commented on SOLR-14397:
---
I would like to propose an new approach:
danmuzi commented on pull request #1926:
URL: https://github.com/apache/lucene-solr/pull/1926#issuecomment-699949157
Thanks, @dweiss ! 👍
This is an automated message from the Apache Git Service.
To respond to the message, pl
[
https://issues.apache.org/jira/browse/LUCENE-9544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203165#comment-17203165
]
ASF subversion and git services commented on LUCENE-9544:
-
Commi
danmuzi merged pull request #1926:
URL: https://github.com/apache/lucene-solr/pull/1926
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
danmuzi commented on pull request #1924:
URL: https://github.com/apache/lucene-solr/pull/1924#issuecomment-699900793
Thanks for reverting, @dweiss!
I reopened the pull request(#1926) for issue ID and CHANGES.txt.
This is a
danmuzi opened a new pull request #1926:
URL: https://github.com/apache/lucene-solr/pull/1926
It's almost the same as the #1924 (except CHANGES.txt).
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/SOLR-13528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203118#comment-17203118
]
ASF subversion and git services commented on SOLR-13528:
Commit 4
atris merged pull request #1906:
URL: https://github.com/apache/lucene-solr/pull/1906
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
Alan Woodward created LUCENE-9545:
-
Summary: Remove Analyzer.get/setVersion()
Key: LUCENE-9545
URL: https://issues.apache.org/jira/browse/LUCENE-9545
Project: Lucene - Core
Issue Type: Bug
dweiss commented on a change in pull request #1925:
URL: https://github.com/apache/lucene-solr/pull/1925#discussion_r495782001
##
File path:
lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThread.java
##
@@ -593,9 +568,61 @@ void unlock() {
}
/**
- * R
dweiss commented on a change in pull request #1925:
URL: https://github.com/apache/lucene-solr/pull/1925#discussion_r495780529
##
File path: lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java
##
@@ -2933,7 +2933,7 @@ public void testFlushLargestWriter() throws IO
s1monw commented on a change in pull request #1925:
URL: https://github.com/apache/lucene-solr/pull/1925#discussion_r495779250
##
File path: lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java
##
@@ -2933,7 +2933,7 @@ public void testFlushLargestWriter() throws IO
s1monw commented on a change in pull request #1925:
URL: https://github.com/apache/lucene-solr/pull/1925#discussion_r495778992
##
File path:
lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThread.java
##
@@ -593,9 +568,61 @@ void unlock() {
}
/**
- * R
dweiss commented on a change in pull request #1925:
URL: https://github.com/apache/lucene-solr/pull/1925#discussion_r495776845
##
File path: lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java
##
@@ -2933,7 +2933,7 @@ public void testFlushLargestWriter() throws IO
s1monw commented on pull request #1925:
URL: https://github.com/apache/lucene-solr/pull/1925#issuecomment-699864240
this is a followup from https://github.com/apache/lucene-solr/pull/1918
This is an automated message from the
s1monw commented on pull request #1925:
URL: https://github.com/apache/lucene-solr/pull/1925#issuecomment-699863956
@mikemccand can you take a look at this?
This is an automated message from the Apache Git Service.
To respond
s1monw opened a new pull request #1925:
URL: https://github.com/apache/lucene-solr/pull/1925
DWPT currently has no real notion of a state but it's lifecycle really
requires such a notion. We move DWPTs from active to flush pending to
flushing
and execute certain actions like RAM accou
mocobeta commented on pull request #1836:
URL: https://github.com/apache/lucene-solr/pull/1836#issuecomment-699844716
> I ran a full check, passes.
Thank you!
This is an automated message from the Apache Git Service.
T
dweiss commented on pull request #1836:
URL: https://github.com/apache/lucene-solr/pull/1836#issuecomment-699844397
I ran a full check, passes.
This is an automated message from the Apache Git Service.
To respond to the messa
mocobeta edited a comment on pull request #1836:
URL: https://github.com/apache/lucene-solr/pull/1836#issuecomment-699843865
I will keep open https://issues.apache.org/jira/browse/LUCENE-9317.
@uschindler if you notice that any follow-ups are needed, please give
comments there.
--
dweiss commented on pull request #1924:
URL: https://github.com/apache/lucene-solr/pull/1924#issuecomment-699843889
Reverted. You can also add CHANGES.txt entry while you're at it, thank you
and sorry for the noise!
This is
mocobeta commented on pull request #1836:
URL: https://github.com/apache/lucene-solr/pull/1836#issuecomment-699843865
I will keep open https://issues.apache.org/jira/browse/LUCENE-9317.
@uschindler if you notice any follow-ups are needed, please give comments
there.
--
dweiss commented on pull request #1924:
URL: https://github.com/apache/lucene-solr/pull/1924#issuecomment-699843163
Let me revert that commit and you please commit it in, ok? I rushed with
clicking the github merge button...
1 - 100 of 107 matches
Mail list logo
