[GitHub] [lucene] zacharymorn commented on pull request #180: LUCENE-9959: Add non thread local based API for term vector reader usage

2021-06-18 Thread GitBox
zacharymorn commented on pull request #180: URL: https://github.com/apache/lucene/pull/180#issuecomment-864358727 I have fixed a few more things and think this PR should be in good shape now. Please let me know if it looks ready. Note that I haven't added any new tests, as the

[GitHub] [lucene] zacharymorn commented on a change in pull request #180: LUCENE-9959: [WIP] Add non thread local based API for term vector reader usage

2021-06-18 Thread GitBox
zacharymorn commented on a change in pull request #180: URL: https://github.com/apache/lucene/pull/180#discussion_r654748459 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexReader.java ## @@ -307,8 +307,21 @@ public final int hashCode() { /** * Retrieve

[GitHub] [lucene] mayya-sharipova merged pull request #189: Sync CHANGES for 8.9.0

2021-06-18 Thread GitBox
mayya-sharipova merged pull request #189: URL: https://github.com/apache/lucene/pull/189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [lucene] madrob commented on a change in pull request #180: LUCENE-9959: [WIP] Add non thread local based API for term vector reader usage

2021-06-18 Thread GitBox
madrob commented on a change in pull request #180: URL: https://github.com/apache/lucene/pull/180#discussion_r654162699 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexReader.java ## @@ -307,8 +307,21 @@ public final int hashCode() { /** * Retrieve term

[GitHub] [lucene] mayya-sharipova opened a new pull request #189: Sync CHANGES for 8.9.0

2021-06-18 Thread GitBox
mayya-sharipova opened a new pull request #189: URL: https://github.com/apache/lucene/pull/189 Move changes that were released in 8.9.0 from 9.0.0 to 8.9.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [lucene] vigyasharma opened a new pull request #188: Lucene-10008: Respect ignoreCase flag in CommonGramsFilterFactory

2021-06-18 Thread GitBox
vigyasharma opened a new pull request #188: URL: https://github.com/apache/lucene/pull/188 ## Description `CommonGramsFilterFactory` should respect the ignoreCase flag passed in args even when the default stop word set is used. It currently ignores the flag if

[GitHub] [lucene] jpountz commented on a change in pull request #180: LUCENE-9959: [WIP] Add non thread local based API for term vector reader usage

2021-06-18 Thread GitBox
jpountz commented on a change in pull request #180: URL: https://github.com/apache/lucene/pull/180#discussion_r654536493 ## File path: lucene/core/src/java/org/apache/lucene/index/BaseCompositeReader.java ## @@ -112,10 +112,29 @@ protected BaseCompositeReader(R[] subReaders,

[GitHub] [lucene] rmuir commented on a change in pull request #180: LUCENE-9959: [WIP] Add non thread local based API for term vector reader usage

2021-06-18 Thread GitBox
rmuir commented on a change in pull request #180: URL: https://github.com/apache/lucene/pull/180#discussion_r654350144 ## File path: lucene/core/src/java/org/apache/lucene/index/TermVectors.java ## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [lucene] zacharymorn commented on pull request #180: LUCENE-9959: [WIP] Add non thread local based API for term vector reader usage

2021-06-18 Thread GitBox
zacharymorn commented on pull request #180: URL: https://github.com/apache/lucene/pull/180#issuecomment-863775298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[jira] [Updated] (LUCENE-9976) WANDScorer assertion error in ensureConsistent

2021-06-18 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayya Sharipova updated LUCENE-9976: Fix Version/s: 8.9 > WANDScorer assertion error in ensureConsistent >

[GitHub] [lucene] jpountz merged pull request #184: LUCENE-9996: Reduce RAM usage of DWPT for a single document.

2021-06-18 Thread GitBox
jpountz merged pull request #184: URL: https://github.com/apache/lucene/pull/184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Updated] (LUCENE-9991) Fix TestStringValueFacetCounts

2021-06-18 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayya Sharipova updated LUCENE-9991: Fix Version/s: 8.9 > Fix TestStringValueFacetCounts > -- > >

[jira] [Updated] (LUCENE-9953) FacetResult#value is inaccurate in LongValueFacetCounts for multi-value docs

2021-06-18 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayya Sharipova updated LUCENE-9953: Fix Version/s: 8.9 > FacetResult#value is inaccurate in LongValueFacetCounts for

[GitHub] [lucene] jtibshirani commented on a change in pull request #185: LUCENE-9999: CombinedFieldQuery can fail with an exception when document is missing fields

2021-06-18 Thread GitBox
jtibshirani commented on a change in pull request #185: URL: https://github.com/apache/lucene/pull/185#discussion_r654110030 ## File path: lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestCombinedFieldQuery.java ## @@ -85,7 +86,7 @@ public void testToString() {

[GitHub] [lucene] zhaih commented on pull request #163: LUCENE-9983: Stop sorting determinize powersets unnecessarily

2021-06-18 Thread GitBox
zhaih commented on pull request #163: URL: https://github.com/apache/lucene/pull/163#issuecomment-864214067 > Thanks @zhaih this looks great -- I think it's ready! Have you confirmed that `gradle check` passes? Thank you for reviewing it! Yeah `gradle check` passed. -- This is an

[jira] [Updated] (LUCENE-9687) Hunspell support improvements

2021-06-18 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayya Sharipova updated LUCENE-9687: Fix Version/s: 8.9 > Hunspell support improvements > - > >

[jira] [Updated] (LUCENE-9537) Add Indri Search Engine Functionality to Lucene

2021-06-18 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayya Sharipova updated LUCENE-9537: Fix Version/s: 8.9 Resolution: Fixed Status: Resolved (was: Patch

[GitHub] [lucene] zacharymorn commented on a change in pull request #180: LUCENE-9959: [WIP] Add non thread local based API for term vector reader usage

2021-06-18 Thread GitBox
zacharymorn commented on a change in pull request #180: URL: https://github.com/apache/lucene/pull/180#discussion_r654154850 ## File path: lucene/core/src/java/org/apache/lucene/index/TermVectors.java ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Resolved] (LUCENE-9680) Re-add IndexWriter.getFieldNames

2021-06-18 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayya Sharipova resolved LUCENE-9680. - Resolution: Fixed > Re-add IndexWriter.getFieldNames >

[jira] [Updated] (LUCENE-9680) Re-add IndexWriter.getFieldNames

2021-06-18 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayya Sharipova updated LUCENE-9680: Fix Version/s: 8.9 > Re-add IndexWriter.getFieldNames >

[jira] [Commented] (LUCENE-9098) Report problematic term value when fuzzy query is too complex

2021-06-18 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17365601#comment-17365601 ] Michael McCandless commented on LUCENE-9098: Hmm while backporting the fix for LUCENE-9981,

[jira] [Resolved] (LUCENE-10004) Delete unnecessary flush in Lucene90CompressingStoredFieldsWriter.copyChunks() to reduce dirty chunks

2021-06-18 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-10004. -- Resolution: Not A Problem We absolutely need to flush pending docs before we start copying

[jira] [Comment Edited] (LUCENE-10004) Delete unnecessary flush in Lucene90CompressingStoredFieldsWriter.copyChunks() to reduce dirty chunks

2021-06-18 Thread kkewwei (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17365411#comment-17365411 ] kkewwei edited comment on LUCENE-10004 at 6/18/21, 10:51 AM: - I read merge

[jira] [Comment Edited] (LUCENE-10004) Delete unnecessary flush in Lucene90CompressingStoredFieldsWriter.copyChunks() to reduce dirty chunks

2021-06-18 Thread kkewwei (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17365411#comment-17365411 ] kkewwei edited comment on LUCENE-10004 at 6/18/21, 9:48 AM: I read merge

[jira] [Comment Edited] (LUCENE-10004) Delete unnecessary flush in Lucene90CompressingStoredFieldsWriter.copyChunks() to reduce dirty chunks

2021-06-18 Thread kkewwei (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17365411#comment-17365411 ] kkewwei edited comment on LUCENE-10004 at 6/18/21, 9:47 AM: I read merge

[jira] [Commented] (LUCENE-10004) Delete unnecessary flush in Lucene90CompressingStoredFieldsWriter.copyChunks() to reduce dirty chunks

2021-06-18 Thread kkewwei (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17365411#comment-17365411 ] kkewwei commented on LUCENE-10004: -- I do read merge logic, including DocIdMerger. In the new segment,

[jira] [Resolved] (LUCENE-9996) Can we improve DWPT's initial memory footprint?

2021-06-18 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-9996. -- Fix Version/s: 8.10 Resolution: Fixed > Can we improve DWPT's initial memory

[jira] [Commented] (LUCENE-9996) Can we improve DWPT's initial memory footprint?

2021-06-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17365403#comment-17365403 ] ASF subversion and git services commented on LUCENE-9996: - Commit

[jira] [Commented] (LUCENE-10008) CommonGramsFilterFactory doesn't respect ignoreCase=true when default stopwords are used

2021-06-18 Thread Vigya Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17365324#comment-17365324 ] Vigya Sharma commented on LUCENE-10008: --- Ack, Chris. Will add the base class. >

[jira] [Commented] (LUCENE-9996) Can we improve DWPT's initial memory footprint?

2021-06-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17365283#comment-17365283 ] ASF subversion and git services commented on LUCENE-9996: - Commit