[GitHub] [lucene] glawson0 commented on pull request #157: LUCENE-9963 Fix issue with FlattenGraphFilter throwing exceptions from holes

2021-08-09 Thread GitBox
glawson0 commented on pull request #157: URL: https://github.com/apache/lucene/pull/157#issuecomment-895680595 Thanks for the merge! You are correct, there are no API changes and it should be safe to backport. -- This is an automated message from the Apache Git Service. To respond to

[jira] [Comment Edited] (LUCENE-9614) Implement KNN Query

2021-08-09 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17396283#comment-17396283 ] Michael Sokolov edited comment on LUCENE-9614 at 8/9/21, 9:07 PM: --

[jira] [Commented] (LUCENE-9614) Implement KNN Query

2021-08-09 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17396283#comment-17396283 ] Michael Sokolov commented on LUCENE-9614: - Thinking about how to make the scores be commensurate

[GitHub] [lucene-solr] ctargett commented on pull request #1971: SOLR-14900: 8.x changes to update Jekyll

2021-08-09 Thread GitBox
ctargett commented on pull request #1971: URL: https://github.com/apache/lucene-solr/pull/1971#issuecomment-895533661 We can't use Jekyll 4 due to problems with its dependencies on Windows machines (see also https://issues.apache.org/jira/browse/SOLR-15520). Closing this. -- This is an

[GitHub] [lucene-solr] ctargett closed pull request #1971: SOLR-14900: 8.x changes to update Jekyll

2021-08-09 Thread GitBox
ctargett closed pull request #1971: URL: https://github.com/apache/lucene-solr/pull/1971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene-solr] ctargett closed pull request #2467: SOLR-15230: Removed Fields and DynamicFields Section for FieldTypes in Schema-API Command

2021-08-09 Thread GitBox
ctargett closed pull request #2467: URL: https://github.com/apache/lucene-solr/pull/2467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene-solr] ctargett commented on pull request #2467: SOLR-15230: Removed Fields and DynamicFields Section for FieldTypes in Schema-API Command

2021-08-09 Thread GitBox
ctargett commented on pull request #2467: URL: https://github.com/apache/lucene-solr/pull/2467#issuecomment-895532506 I'm going to close this PR since it should now go against the `apache/solr` repo's `main` branch instead. However, I have made this change in a branch and I'll merge that

[jira] [Commented] (LUCENE-9963) Flatten graph filter has errors when there are holes at beginning or end of alternate paths

2021-08-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17396254#comment-17396254 ] ASF subversion and git services commented on LUCENE-9963: - Commit

[jira] [Commented] (LUCENE-9963) Flatten graph filter has errors when there are holes at beginning or end of alternate paths

2021-08-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17396253#comment-17396253 ] ASF subversion and git services commented on LUCENE-9963: - Commit

[GitHub] [lucene] mikemccand merged pull request #157: LUCENE-9963 Fix issue with FlattenGraphFilter throwing exceptions from holes

2021-08-09 Thread GitBox
mikemccand merged pull request #157: URL: https://github.com/apache/lucene/pull/157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (LUCENE-9620) Add Weight#count(LeafReaderContext)

2021-08-09 Thread Gautam Worah (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17396196#comment-17396196 ] Gautam Worah commented on LUCENE-9620: -- Hmm. Okay. Just so I get it right, this issue can be

[GitHub] [lucene] msokolov commented on a change in pull request #239: LUCENE-10040: Handle deletions in nearest vector search

2021-08-09 Thread GitBox
msokolov commented on a change in pull request #239: URL: https://github.com/apache/lucene/pull/239#discussion_r685374213 ## File path: lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraph.java ## @@ -109,13 +115,14 @@ public static NeighborQueue search( if

[GitHub] [lucene] jtibshirani commented on a change in pull request #239: LUCENE-10040: Handle deletions in nearest vector search

2021-08-09 Thread GitBox
jtibshirani commented on a change in pull request #239: URL: https://github.com/apache/lucene/pull/239#discussion_r685344896 ## File path: lucene/core/src/test/org/apache/lucene/codecs/lucene90/TestLucene90HnswVectorsFormat.java ## @@ -16,13 +16,79 @@ */ package

[GitHub] [lucene] mikemccand commented on pull request #157: LUCENE-9963 Fix issue with FlattenGraphFilter throwing exceptions from holes

2021-08-09 Thread GitBox
mikemccand commented on pull request #157: URL: https://github.com/apache/lucene/pull/157#issuecomment-895357881 +1, thanks @glawson0 -- I'll try to merge this soon. I think this is also safe to backport? No API breaks, and it is "just" fixing bugs in this hairy `TokenFilter`? --

[GitHub] [lucene] jtibshirani commented on a change in pull request #239: LUCENE-10040: Handle deletions in nearest vector search

2021-08-09 Thread GitBox
jtibshirani commented on a change in pull request #239: URL: https://github.com/apache/lucene/pull/239#discussion_r685315440 ## File path: lucene/core/src/test/org/apache/lucene/codecs/lucene90/TestLucene90HnswVectorsFormat.java ## @@ -16,13 +16,79 @@ */ package

[GitHub] [lucene] jtibshirani commented on a change in pull request #239: LUCENE-10040: Handle deletions in nearest vector search

2021-08-09 Thread GitBox
jtibshirani commented on a change in pull request #239: URL: https://github.com/apache/lucene/pull/239#discussion_r685309467 ## File path: lucene/core/src/test/org/apache/lucene/codecs/lucene90/TestLucene90HnswVectorsFormat.java ## @@ -16,13 +16,79 @@ */ package

[GitHub] [lucene] jtibshirani commented on a change in pull request #239: LUCENE-10040: Handle deletions in nearest vector search

2021-08-09 Thread GitBox
jtibshirani commented on a change in pull request #239: URL: https://github.com/apache/lucene/pull/239#discussion_r685299100 ## File path: lucene/core/src/java/org/apache/lucene/util/hnsw/NeighborQueue.java ## @@ -42,13 +42,6 @@ } } - NeighborQueue copy(boolean

[GitHub] [lucene] jtibshirani commented on a change in pull request #239: LUCENE-10040: Handle deletions in nearest vector search

2021-08-09 Thread GitBox
jtibshirani commented on a change in pull request #239: URL: https://github.com/apache/lucene/pull/239#discussion_r685297886 ## File path: lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraph.java ## @@ -109,13 +115,14 @@ public static NeighborQueue search( if

[GitHub] [lucene] jtibshirani commented on a change in pull request #239: LUCENE-10040: Handle deletions in nearest vector search

2021-08-09 Thread GitBox
jtibshirani commented on a change in pull request #239: URL: https://github.com/apache/lucene/pull/239#discussion_r685289606 ## File path: lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraph.java ## @@ -138,10 +145,14 @@ public static NeighborQueue search(

[GitHub] [lucene] msokolov commented on a change in pull request #239: LUCENE-10040: Handle deletions in nearest vector search

2021-08-09 Thread GitBox
msokolov commented on a change in pull request #239: URL: https://github.com/apache/lucene/pull/239#discussion_r685157613 ## File path: lucene/core/src/java/org/apache/lucene/util/hnsw/NeighborQueue.java ## @@ -42,13 +42,6 @@ } } - NeighborQueue copy(boolean

[jira] [Comment Edited] (LUCENE-9004) Approximate nearest vector search

2021-08-09 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17393292#comment-17393292 ] Julie Tibshirani edited comment on LUCENE-9004 at 8/9/21, 12:16 PM:

[jira] [Issue Comment Deleted] (LUCENE-10035) Simple text codec add multi level skip list data

2021-08-09 Thread wuda (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wuda updated LUCENE-10035: -- Comment: was deleted (was: Thanks! I have commited and add a new pull request.) > Simple text codec add

[GitHub] [lucene-solr] janhoy closed pull request #2550: Test github action - DO NOT MERGE

2021-08-09 Thread GitBox
janhoy closed pull request #2550: URL: https://github.com/apache/lucene-solr/pull/2550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #239: LUCENE-10040: Handle deletions in nearest vector search

2021-08-09 Thread GitBox
mayya-sharipova commented on a change in pull request #239: URL: https://github.com/apache/lucene/pull/239#discussion_r685117823 ## File path: lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraph.java ## @@ -138,10 +145,14 @@ public static NeighborQueue search(

[jira] [Updated] (LUCENE-10035) Simple text codec add multi level skip list data

2021-08-09 Thread wuda (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wuda updated LUCENE-10035: -- Description: Simple text codec add skip list data( include impact) to help understand index format,For

[jira] [Updated] (LUCENE-10035) Simple text codec add multi level skip list data

2021-08-09 Thread wuda (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wuda updated LUCENE-10035: -- Status: Patch Available (was: Open) > Simple text codec add multi level skip list data >

[jira] [Updated] (LUCENE-10035) Simple text codec add multi level skip list data

2021-08-09 Thread wuda (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wuda updated LUCENE-10035: -- Attachment: LUCENE-10035.patch Status: Open (was: Open) > Simple text codec add multi level skip

[jira] [Updated] (LUCENE-10035) Simple text codec add multi level skip list data

2021-08-09 Thread wuda (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wuda updated LUCENE-10035: -- Status: Open (was: Patch Available) > Simple text codec add multi level skip list data >

[jira] [Updated] (LUCENE-10035) Simple text codec add multi level skip list data

2021-08-09 Thread wuda (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wuda updated LUCENE-10035: -- Status: Patch Available (was: Open) > Simple text codec add multi level skip list data >

[jira] [Commented] (LUCENE-10040) Handle deletions in nearest vector search

2021-08-09 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17395937#comment-17395937 ] Julie Tibshirani commented on LUCENE-10040: --- I opened

[GitHub] [lucene] jtibshirani commented on a change in pull request #239: LUCENE-10040: Handle deletions in nearest vector search

2021-08-09 Thread GitBox
jtibshirani commented on a change in pull request #239: URL: https://github.com/apache/lucene/pull/239#discussion_r685036039 ## File path: lucene/core/src/test/org/apache/lucene/codecs/lucene90/TestLucene90HnswVectorsFormat.java ## @@ -16,13 +16,79 @@ */ package

[GitHub] [lucene] jtibshirani opened a new pull request #239: LUCENE-10040: Handle deletions in nearest vector search

2021-08-09 Thread GitBox
jtibshirani opened a new pull request #239: URL: https://github.com/apache/lucene/pull/239 This PR extends VectorReader#search to take a parameter specifying the live docs. LeafReader#searchNearestVectors then always returns the k nearest undeleted docs. To implement this, the

[jira] [Commented] (LUCENE-9620) Add Weight#count(LeafReaderContext)

2021-08-09 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17395870#comment-17395870 ] Adrien Grand commented on LUCENE-9620: -- Hi [~gworah]. Actually I was thinking of keeping