zhaih commented on a change in pull request #225:
URL: https://github.com/apache/lucene/pull/225#discussion_r726751739
##
File path: lucene/core/src/java/org/apache/lucene/search/AutomatonQuery.java
##
@@ -65,7 +66,20 @@
* @param automaton Automaton to run, terms that are
zhaih commented on a change in pull request #225:
URL: https://github.com/apache/lucene/pull/225#discussion_r726750180
##
File path: lucene/core/src/java/org/apache/lucene/search/AutomatonQuery.java
##
@@ -96,12 +110,36 @@ public AutomatonQuery(final Term term, Automaton
zhaih commented on a change in pull request #225:
URL: https://github.com/apache/lucene/pull/225#discussion_r726749819
##
File path:
lucene/core/src/java/org/apache/lucene/util/automaton/ByteRunnable.java
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation
zhaih commented on a change in pull request #225:
URL: https://github.com/apache/lucene/pull/225#discussion_r726749051
##
File path:
lucene/core/src/java/org/apache/lucene/util/automaton/ByteRunnable.java
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation
zhaih commented on a change in pull request #225:
URL: https://github.com/apache/lucene/pull/225#discussion_r726747416
##
File path:
lucene/codecs/src/java/org/apache/lucene/codecs/memory/DirectPostingsFormat.java
##
@@ -962,15 +964,22 @@ public ImpactsEnum impacts(int flags)
[
https://issues.apache.org/jira/browse/LUCENE-10160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427390#comment-17427390
]
ASF subversion and git services commented on LUCENE-10160:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427392#comment-17427392
]
ASF subversion and git services commented on LUCENE-10146:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427389#comment-17427389
]
ASF subversion and git services commented on LUCENE-10155:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427393#comment-17427393
]
ASF subversion and git services commented on LUCENE-10164:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427391#comment-17427391
]
ASF subversion and git services commented on LUCENE-10158:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427388#comment-17427388
]
ASF subversion and git services commented on LUCENE-10150:
--
Commit
madrob merged pull request #2579:
URL: https://github.com/apache/lucene-solr/pull/2579
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/LUCENE-10159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427352#comment-17427352
]
Robert Muir commented on LUCENE-10159:
--
Is there any chance to reproduce the original (presumably
[
https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427342#comment-17427342
]
Robert Muir commented on LUCENE-9997:
-
Some history: originally we had no smoketester.
Every
[
https://issues.apache.org/jira/browse/LUCENE-10163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-10163:
-
Description:
Some of them contain obsolete pointers and information (SYSTEM_REQUIREMENTS.md,
Dawid Weiss created LUCENE-10166:
Summary: Move relevant content of README.txt files from
subprojects into package javadocs
Key: LUCENE-10166
URL: https://issues.apache.org/jira/browse/LUCENE-10166
[
https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427321#comment-17427321
]
Dawid Weiss commented on LUCENE-9997:
-
Just for the record - I agree with Robert here that some of
[
https://issues.apache.org/jira/browse/LUCENE-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-10164:
-
Fix Version/s: main (9.0)
> lucene/replicator should only have jetty as a test dependency
>
[
https://issues.apache.org/jira/browse/LUCENE-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir resolved LUCENE-10164.
--
Resolution: Fixed
It was like this before with the ant build, so it was no regression with
[
https://issues.apache.org/jira/browse/LUCENE-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427284#comment-17427284
]
ASF subversion and git services commented on LUCENE-10164:
--
Commit
rmuir merged pull request #373:
URL: https://github.com/apache/lucene/pull/373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rmuir commented on pull request #373:
URL: https://github.com/apache/lucene/pull/373#issuecomment-940231838
for the record, it is just an improvement in the current build. i looked at
the ant build and it was never a "test-only" dependency there (not sure it
supported such things).
--
[
https://issues.apache.org/jira/browse/LUCENE-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427279#comment-17427279
]
Michael McCandless commented on LUCENE-10093:
-
OK I created a starter PR – still some
mikemccand opened a new pull request #375:
URL: https://github.com/apache/lucene/pull/375
# Description
First cut trying to resolve a consistent random corner-case failure in
`TestTieredMergePolicy.testForcedMergesUseLeastNumberOfMerges`. This is not
yet ready for
khitrin closed pull request #341:
URL: https://github.com/apache/lucene/pull/341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
khitrin commented on pull request #341:
URL: https://github.com/apache/lucene/pull/341#issuecomment-940218718
Superseded by #370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/LUCENE-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427245#comment-17427245
]
Michael McCandless commented on LUCENE-10093:
-
Also, I don't quite understand why
[
https://issues.apache.org/jira/browse/LUCENE-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427243#comment-17427243
]
Michael McCandless commented on LUCENE-10093:
-
{quote}If a user sets maxMergedSegmentMB to
[
https://issues.apache.org/jira/browse/LUCENE-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427239#comment-17427239
]
Michael McCandless commented on LUCENE-10093:
-
Yeah I agree with [~jpountz]'s explanation.
[
https://issues.apache.org/jira/browse/LUCENE-10159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427237#comment-17427237
]
Adrien Grand commented on LUCENE-10159:
---
I couldn't find an obvious issue by doing a quick review
[
https://issues.apache.org/jira/browse/LUCENE-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427230#comment-17427230
]
Nikolay Khitrin commented on LUCENE-10140:
--
Just amazing :)
> Minimizing intervals can give
[
https://issues.apache.org/jira/browse/LUCENE-10165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427221#comment-17427221
]
Adrien Grand commented on LUCENE-10165:
---
The linked PR improved doc values merge times by 11% on
jpountz opened a new pull request #374:
URL: https://github.com/apache/lucene/pull/374
This speeds up merging by returning doc values that perform faster when all
doc
IDs and values are consumed.
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/LUCENE-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julie Tibshirani resolved LUCENE-10146.
---
Fix Version/s: main (9.0)
Resolution: Fixed
> Add
[
https://issues.apache.org/jira/browse/LUCENE-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427216#comment-17427216
]
ASF subversion and git services commented on LUCENE-10146:
--
Commit
mayya-sharipova commented on a change in pull request #366:
URL: https://github.com/apache/lucene/pull/366#discussion_r726247466
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90FieldInfosFormat.java
##
@@ -99,11 +99,12 @@
*
[
https://issues.apache.org/jira/browse/LUCENE-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427215#comment-17427215
]
Alan Woodward commented on LUCENE-10140:
I've reworked things a bit so that we have a
dweiss commented on a change in pull request #372:
URL: https://github.com/apache/lucene/pull/372#discussion_r726245984
##
File path: lucene/distribution/build.gradle
##
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
mayya-sharipova commented on a change in pull request #366:
URL: https://github.com/apache/lucene/pull/366#discussion_r726246065
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90FieldInfosFormat.java
##
@@ -99,11 +99,12 @@
*
jtibshirani merged pull request #366:
URL: https://github.com/apache/lucene/pull/366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jtibshirani commented on pull request #366:
URL: https://github.com/apache/lucene/pull/366#issuecomment-940146857
Thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
janhoy commented on a change in pull request #372:
URL: https://github.com/apache/lucene/pull/372#discussion_r726233849
##
File path: lucene/distribution/build.gradle
##
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
jtibshirani commented on a change in pull request #366:
URL: https://github.com/apache/lucene/pull/366#discussion_r726227198
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90FieldInfosFormat.java
##
@@ -99,11 +99,12 @@
* PointDimensionCount,
dweiss commented on a change in pull request #372:
URL: https://github.com/apache/lucene/pull/372#discussion_r726219189
##
File path: lucene/distribution/build.gradle
##
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
Adrien Grand created LUCENE-10165:
-
Summary: Implement Lucene90DocValuesProducer#getMergeInstance
Key: LUCENE-10165
URL: https://issues.apache.org/jira/browse/LUCENE-10165
Project: Lucene - Core
mayya-sharipova commented on a change in pull request #366:
URL: https://github.com/apache/lucene/pull/366#discussion_r726206695
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90FieldInfosFormat.java
##
@@ -99,11 +99,12 @@
*
mayya-sharipova commented on a change in pull request #366:
URL: https://github.com/apache/lucene/pull/366#discussion_r726206695
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90FieldInfosFormat.java
##
@@ -99,11 +99,12 @@
*
mayya-sharipova commented on a change in pull request #366:
URL: https://github.com/apache/lucene/pull/366#discussion_r726206695
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90FieldInfosFormat.java
##
@@ -99,11 +99,12 @@
*
[
https://issues.apache.org/jira/browse/LUCENE-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427156#comment-17427156
]
Nikolay Khitrin commented on LUCENE-10140:
--
[~romseygeek], yes, core fix is the same and looks
iverase edited a comment on pull request #371:
URL: https://github.com/apache/lucene/pull/371#issuecomment-940021490
Another option is to mark the new abstraction as internal (much like
MutablePointValues) as it is only used during indexing. Then PointValues API
does not extend it so we
iverase edited a comment on pull request #371:
URL: https://github.com/apache/lucene/pull/371#issuecomment-940021490
Another option is to mark the new abstraction as internal (much like
MutablePointValues) as it is only used during indexing. Then PointValues API
does not extend it so we
iverase commented on pull request #371:
URL: https://github.com/apache/lucene/pull/371#issuecomment-940021490
Another option is to mark the new abstraction as internal (much like
MutablePointValues) as it is only used during indexing. Then PointValues API
does not extend it so we are not
[
https://issues.apache.org/jira/browse/LUCENE-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427117#comment-17427117
]
Robert Muir commented on LUCENE-10093:
--
I feel like the code is correct and the test is buggy
iverase edited a comment on pull request #371:
URL: https://github.com/apache/lucene/pull/371#issuecomment-939995941
>> can't MutablePointValues behave like a single-leaf PointValues instance?
There is some friction there.
First, in theory we should have the min/max point
iverase edited a comment on pull request #371:
URL: https://github.com/apache/lucene/pull/371#issuecomment-939995941
>> can't MutablePointValues behave like a single-leaf PointValues instance?
There is some friction there.
First, in theory we should have the min/max point
rmuir opened a new pull request #373:
URL: https://github.com/apache/lucene/pull/373
The main code only needs to compile against the servlet api, but should work
in any servlet.
Jetty is just the one used by the current tests.
--
This is an automated message from the Apache Git
Robert Muir created LUCENE-10164:
Summary: lucene/replicator should only have jetty as a test
dependency
Key: LUCENE-10164
URL: https://issues.apache.org/jira/browse/LUCENE-10164
Project: Lucene -
iverase edited a comment on pull request #371:
URL: https://github.com/apache/lucene/pull/371#issuecomment-939995941
>> can't MutablePointValues behave like a single-leaf PointValues instance?
The is some friction there.
First, in theory we should have the min/max point value
iverase edited a comment on pull request #371:
URL: https://github.com/apache/lucene/pull/371#issuecomment-939995941
>> can't MutablePointValues behave like a single-leaf PointValues instance?
The is some friction there.
First, in theory we should have the min/max point value
iverase commented on pull request #371:
URL: https://github.com/apache/lucene/pull/371#issuecomment-939995941
>> can't MutablePointValues behave like a single-leaf PointValues instance?
The is some friction there.
First, in theory we should have the min/max point value for
[
https://issues.apache.org/jira/browse/LUCENE-10160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless resolved LUCENE-10160.
-
Resolution: Duplicate
Dup of LUCENE-10093.
> TestTieredMergePolicy
[
https://issues.apache.org/jira/browse/LUCENE-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427101#comment-17427101
]
Michael McCandless commented on LUCENE-10093:
-
Thanks [~jpountz] – I'll try to dig on this
[
https://issues.apache.org/jira/browse/LUCENE-10160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427098#comment-17427098
]
Michael McCandless commented on LUCENE-10160:
-
Thanks [~rcmuir] – [~jpountz] dug a bit on
iverase commented on a change in pull request #7:
URL: https://github.com/apache/lucene/pull/7#discussion_r726066983
##
File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDDefaultReader.java
##
@@ -0,0 +1,923 @@
+/*
+ * Licensed to the Apache Software Foundation
iverase commented on pull request #7:
URL: https://github.com/apache/lucene/pull/7#issuecomment-939978962
>> I like the change, but I think it only really makes sense if we then move
PointValues to an API that is more like the BKDReader API.
Yes, that is the idea.That is the point
jpountz commented on pull request #371:
URL: https://github.com/apache/lucene/pull/371#issuecomment-939971085
While this patch reduces the number of lines of code, it does so at the cost
of an extra abstraction. It's unclear to me how it makes things simpler, can't
MutablePointValues
jpountz commented on a change in pull request #7:
URL: https://github.com/apache/lucene/pull/7#discussion_r725897371
##
File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDDefaultReader.java
##
@@ -0,0 +1,923 @@
+/*
+ * Licensed to the Apache Software Foundation
janhoy commented on a change in pull request #372:
URL: https://github.com/apache/lucene/pull/372#discussion_r726056433
##
File path: lucene/distribution/build.gradle
##
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
[
https://issues.apache.org/jira/browse/LUCENE-10127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-10127.
---
Fix Version/s: main (9.0)
Resolution: Fixed
> Minor enhancement to doc values
[
https://issues.apache.org/jira/browse/LUCENE-10152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427084#comment-17427084
]
Dawid Weiss commented on LUCENE-10152:
--
Rewritten as part of LUCENE-9488.
> Clean up artifact
[
https://issues.apache.org/jira/browse/LUCENE-10152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-10152.
--
Resolution: Duplicate
> Clean up artifact signing and publishing
>
dweiss commented on a change in pull request #372:
URL: https://github.com/apache/lucene/pull/372#discussion_r726046004
##
File path: lucene/distribution/build.gradle
##
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
[
https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427081#comment-17427081
]
Dawid Weiss commented on LUCENE-9488:
-
I filed a large PR with most of the packaging code rewritten
dweiss commented on pull request #372:
URL: https://github.com/apache/lucene/pull/372#issuecomment-939947185
This is the rewritten distribution assembly, guys. I would appreciate if you
could take a look, especially with regard to artifact signing (I don't use gpg
agent). I placed the
dweiss commented on pull request #359:
URL: https://github.com/apache/lucene/pull/359#issuecomment-939943176
I'm going to close this PR and just start a fresh one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
dweiss closed pull request #359:
URL: https://github.com/apache/lucene/pull/359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
janhoy commented on a change in pull request #355:
URL: https://github.com/apache/lucene/pull/355#discussion_r726029721
##
File path: dev-tools/scripts/smokeTestRelease.py
##
@@ -900,42 +701,19 @@ def testDemo(run_java, isSrc, version, jdk):
if
[
https://issues.apache.org/jira/browse/LUCENE-8739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427037#comment-17427037
]
Praveen Nishchal commented on LUCENE-8739:
--
Hi Mike
I see Adrien has used JNA based Zstd
[
https://issues.apache.org/jira/browse/LUCENE-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Ferenczi updated LUCENE-10110:
--
Fix Version/s: 8.10.1
> MultiCollector should conditionally wrap single leaf collector
>
[
https://issues.apache.org/jira/browse/LUCENE-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427022#comment-17427022
]
ASF subversion and git services commented on LUCENE-10110:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427017#comment-17427017
]
Robert Muir commented on LUCENE-10162:
--
+1
> Add IntField, LongField, FloatField and DoubleField
janhoy merged pull request #2589:
URL: https://github.com/apache/lucene-solr/pull/2589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
janhoy commented on a change in pull request #355:
URL: https://github.com/apache/lucene/pull/355#discussion_r725915416
##
File path: dev-tools/scripts/buildAndPushRelease.py
##
@@ -329,7 +329,11 @@ def main():
print('Next run the smoker tester:')
p =
janhoy commented on a change in pull request #355:
URL: https://github.com/apache/lucene/pull/355#discussion_r725914818
##
File path: dev-tools/scripts/smokeTestRelease.py
##
@@ -173,11 +173,15 @@ def checkJARMetaData(desc, jarFile, gitRevision, version):
if gitRevision
janhoy commented on a change in pull request #355:
URL: https://github.com/apache/lucene/pull/355#discussion_r725913472
##
File path: dev-tools/scripts/smokeTestRelease.py
##
@@ -1376,7 +1144,7 @@ def main():
c = parse_config()
scriptVersion =
janhoy opened a new pull request #2589:
URL: https://github.com/apache/lucene-solr/pull/2589
Backport from main repo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Dawid Weiss created LUCENE-10163:
Summary: Review top-level *.txt and *.md files
Key: LUCENE-10163
URL: https://issues.apache.org/jira/browse/LUCENE-10163
Project: Lucene - Core
Issue Type:
[
https://issues.apache.org/jira/browse/LUCENE-10159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17426983#comment-17426983
]
Adrien Grand commented on LUCENE-10159:
---
According to the stack trace, this happens on a field
Adrien Grand created LUCENE-10162:
-
Summary: Add IntField, LongField, FloatField and DoubleField
classes to index both points and doc values
Key: LUCENE-10162
URL:
iverase commented on pull request #7:
URL: https://github.com/apache/lucene/pull/7#issuecomment-939705693
I open https://github.com/apache/lucene/pull/371 which should simplify this
patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
90 matches
Mail list logo
